)]}'
{"config_tempest/services/services.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"da37957481a79c28560f20d5b230d41be61a3671","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :param name: Name of the service"},{"line_number":79,"context_line":"        :type name: string"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        versions \u003d [\u0027v2\u0027, \u0027v3\u0027]"},{"line_number":82,"context_line":"        services_lst \u003d []"},{"line_number":83,"context_line":"        s \u003d self.get_service(name)"},{"line_number":84,"context_line":"        for v in versions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_69a3ff01","line":81,"updated":"2018-05-17 12:59:44.000000000","message":"shouldn\u0027t \"versions\" be a parameter of this function as well?","commit_id":"e6351fb80690e7c2f22e1305d63035d4c2600647"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c5cb88adcf649abe520baada10aa5f6e4859479d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        :param name: Name of the service"},{"line_number":79,"context_line":"        :type name: string"},{"line_number":80,"context_line":"        \"\"\""},{"line_number":81,"context_line":"        versions \u003d [\u0027v2\u0027, \u0027v3\u0027]"},{"line_number":82,"context_line":"        services_lst \u003d []"},{"line_number":83,"context_line":"        s \u003d self.get_service(name)"},{"line_number":84,"context_line":"        for v in versions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_09504bd4","line":81,"in_reply_to":"5f7c97a3_69a3ff01","updated":"2018-05-17 13:12:41.000000000","message":"If those services is more, definitely .. ok, why don\u0027t do it right now.","commit_id":"e6351fb80690e7c2f22e1305d63035d4c2600647"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0f089867b2342ef48156fedae4d98afb7487b265","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            self._services.append(service)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":71,"context_line":"        versions \u003d C.SERVICE_VERSIONS[service_name][\u0027supported_versions\u0027]"},{"line_number":72,"context_line":"        self.merge_exts_multiversion_service(service_name, versions)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def merge_exts_multiversion_service(self, name, versions):"},{"line_number":75,"context_line":"        \"\"\"Merges extensions of a service given by its name"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e974ef00","line":72,"range":{"start_line":70,"start_character":7,"end_line":72,"end_character":68},"updated":"2018-05-17 13:26:04.000000000","message":"Is it possible to move this piece under volumes.py?","commit_id":"d66ac25965243a1d1afd0433ec6c20ccfb48e84c"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"393086a7f6648289b723856485617afd01253ebc","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            self._services.append(service)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":71,"context_line":"        versions \u003d C.SERVICE_VERSIONS[service_name][\u0027supported_versions\u0027]"},{"line_number":72,"context_line":"        self.merge_exts_multiversion_service(service_name, versions)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def merge_exts_multiversion_service(self, name, versions):"},{"line_number":75,"context_line":"        \"\"\"Merges extensions of a service given by its name"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0c69398a","line":72,"range":{"start_line":70,"start_character":7,"end_line":72,"end_character":68},"in_reply_to":"5f7c97a3_8970dbde","updated":"2018-05-17 13:50:16.000000000","message":"It is not possible to move this call there, but it is possible to generalize it (not in this review).\nAssuming that SERVICE_VERSIONS is moved to each service instance, there should be something like (very high level pseudocode):\n\nfor each service\n   if the list of supported versions contains more than 1 element\n      call merge_ext_multiversion_service","commit_id":"d66ac25965243a1d1afd0433ec6c20ccfb48e84c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"d7c258861dd595b09a5f3fa0c70409fcb53edb16","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            self._services.append(service)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        service_name \u003d \u0027volume\u0027"},{"line_number":71,"context_line":"        versions \u003d C.SERVICE_VERSIONS[service_name][\u0027supported_versions\u0027]"},{"line_number":72,"context_line":"        self.merge_exts_multiversion_service(service_name, versions)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def merge_exts_multiversion_service(self, name, versions):"},{"line_number":75,"context_line":"        \"\"\"Merges extensions of a service given by its name"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8970dbde","line":72,"range":{"start_line":70,"start_character":7,"end_line":72,"end_character":68},"in_reply_to":"5f7c97a3_e974ef00","updated":"2018-05-17 13:33:34.000000000","message":"I don\u0027t see how, there is no reference of Services class there, so we can\u0027t call merge_exts_multiversion_service from there. And I can\u0027t make the method static, because there are other methods from Services class needed.","commit_id":"d66ac25965243a1d1afd0433ec6c20ccfb48e84c"}]}