)]}'
{"config_tempest/constants.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1cc500851a8e754f371917874e37dc38c8b43979","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The dict holds the credentials, which are not supposed to be printed"},{"line_number":31,"context_line":"# to a tempest.conf when --test-accounts CLI parameter is used."},{"line_number":32,"context_line":"CREDENTIALS \u003d {"},{"line_number":33,"context_line":"    \"auth.admin_username\": [],"},{"line_number":34,"context_line":"    \"auth.admin_password\": [],"},{"line_number":35,"context_line":"    \"auth.admin_project_name\": [],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b8a8f177","line":32,"updated":"2018-05-29 09:11:20.000000000","message":"the name CREDENTIALS may be a bit generic but I don\u0027t have a good alternative (ALL_CREDENTIALS_KEYS ? Not sure)","commit_id":"d19b64b0d8806e8e26fc2a45b896ee4b26b91b54"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"19a5e7beee3d8f93ff1968b788c2cc94e3a43e32","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# The dict holds the credentials, which are not supposed to be printed"},{"line_number":31,"context_line":"# to a tempest.conf when --test-accounts CLI parameter is used."},{"line_number":32,"context_line":"CREDENTIALS \u003d {"},{"line_number":33,"context_line":"    \"auth.admin_username\": [],"},{"line_number":34,"context_line":"    \"auth.admin_password\": [],"},{"line_number":35,"context_line":"    \"auth.admin_project_name\": [],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_be50d9d6","line":32,"in_reply_to":"5f7c97a3_b8a8f177","updated":"2018-05-29 10:53:13.000000000","message":"It\u0027s generic, but I couldn\u0027t come up with anything better .. I can use your suggestion, it\u0027s more clear just from the name ... therefor I also added the comment above, explaining what it is.","commit_id":"d19b64b0d8806e8e26fc2a45b896ee4b26b91b54"}],"config_tempest/main.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1cc500851a8e754f371917874e37dc38c8b43979","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    credentials_off \u003d kwargs.get(\u0027test_accounts\u0027) is not None"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    conf \u003d tempest_conf.TempestConf(credentials_off\u003dcredentials_off)"},{"line_number":365,"context_line":"    set_options(conf, kwargs.get(\u0027deployer_input\u0027),"},{"line_number":366,"context_line":"                kwargs.get(\u0027non_admin\u0027, False),"},{"line_number":367,"context_line":"                kwargs.get(\u0027overrides\u0027, []), kwargs.get(\u0027test_accounts\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d8a5ada0","line":364,"updated":"2018-05-29 09:11:20.000000000","message":"or invert the logic and use write_credentials, False by default ?","commit_id":"d19b64b0d8806e8e26fc2a45b896ee4b26b91b54"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"19a5e7beee3d8f93ff1968b788c2cc94e3a43e32","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    credentials_off \u003d kwargs.get(\u0027test_accounts\u0027) is not None"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    conf \u003d tempest_conf.TempestConf(credentials_off\u003dcredentials_off)"},{"line_number":365,"context_line":"    set_options(conf, kwargs.get(\u0027deployer_input\u0027),"},{"line_number":366,"context_line":"                kwargs.get(\u0027non_admin\u0027, False),"},{"line_number":367,"context_line":"                kwargs.get(\u0027overrides\u0027, []), kwargs.get(\u0027test_accounts\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_fe73b17e","line":364,"in_reply_to":"5f7c97a3_d8a5ada0","updated":"2018-05-29 10:53:13.000000000","message":"write_credentials is better, I wasn\u0027t very creative when I was writing the patch :D\nFalse by default, yes, because usually we have credentials in tempest.conf. The credentials are not supposed to be there only in case, when --test-accounts is used.","commit_id":"d19b64b0d8806e8e26fc2a45b896ee4b26b91b54"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"3ec87cc7e9ec42895fedc7c27f53c61ef83bdd52","unresolved":false,"context_lines":[{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    credentials_off \u003d kwargs.get(\u0027test_accounts\u0027) is not None"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    conf \u003d tempest_conf.TempestConf(credentials_off\u003dcredentials_off)"},{"line_number":365,"context_line":"    set_options(conf, kwargs.get(\u0027deployer_input\u0027),"},{"line_number":366,"context_line":"                kwargs.get(\u0027non_admin\u0027, False),"},{"line_number":367,"context_line":"                kwargs.get(\u0027overrides\u0027, []), kwargs.get(\u0027test_accounts\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9272b111","line":364,"in_reply_to":"5f7c97a3_fe73b17e","updated":"2018-05-29 12:07:44.000000000","message":"oh, sorry, I meant True by default (which is the current behavior)","commit_id":"d19b64b0d8806e8e26fc2a45b896ee4b26b91b54"}],"releasenotes/notes/Do-not-expose-user-credentials-1ffba4d72798b5c9.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"e30c1abd94e14442dac8ea38883f365511a8e954","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When --test-accounts parameter (specifying a path to a accounts.yaml file)"},{"line_number":5,"context_line":"    is used, don\u0027t write any user credentials to tempest.conf."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_1258e187","line":2,"updated":"2018-05-29 12:08:34.000000000","message":"I think this is a new feature, not a fix - other opinions?","commit_id":"74d19e3d97798d0c968e869b99833de3e0cb1546"}]}