)]}'
{"config_tempest/main.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1454abcd4da3d3adaa9c08dcc05b439fce046eda","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        cloud_creds\u003dcloud_creds,"},{"line_number":418,"context_line":"        debug\u003dargs.debug,"},{"line_number":419,"context_line":"        deployer_input\u003dargs.deployer_input,"},{"line_number":420,"context_line":"        image_path\u003dargs.image,"},{"line_number":421,"context_line":"        image_disk_format\u003dargs.image_disk_format,"},{"line_number":422,"context_line":"        network_id\u003dargs.network_id,"},{"line_number":423,"context_line":"        non_admin\u003dargs.non_admin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b84471b9","line":420,"updated":"2018-05-29 09:16:59.000000000","message":"isn\u0027t this changing the API?","commit_id":"d359077836d64387b903468cff32eb2d21258853"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"72cf8d8682f4e99d6a7f9ea0ce41deddd026eee0","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        cloud_creds\u003dcloud_creds,"},{"line_number":418,"context_line":"        debug\u003dargs.debug,"},{"line_number":419,"context_line":"        deployer_input\u003dargs.deployer_input,"},{"line_number":420,"context_line":"        image_path\u003dargs.image,"},{"line_number":421,"context_line":"        image_disk_format\u003dargs.image_disk_format,"},{"line_number":422,"context_line":"        network_id\u003dargs.network_id,"},{"line_number":423,"context_line":"        non_admin\u003dargs.non_admin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d573337f","line":420,"in_reply_to":"5f7c97a3_52ddf911","updated":"2018-05-29 12:48:21.000000000","message":"Oh, right, the API is not used officially yet. I guess that Chandan may need to rebase his patch.","commit_id":"d359077836d64387b903468cff32eb2d21258853"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f33cdba2f57800976033cd73d6c8e07251e1b770","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        cloud_creds\u003dcloud_creds,"},{"line_number":418,"context_line":"        debug\u003dargs.debug,"},{"line_number":419,"context_line":"        deployer_input\u003dargs.deployer_input,"},{"line_number":420,"context_line":"        image_path\u003dargs.image,"},{"line_number":421,"context_line":"        image_disk_format\u003dargs.image_disk_format,"},{"line_number":422,"context_line":"        network_id\u003dargs.network_id,"},{"line_number":423,"context_line":"        non_admin\u003dargs.non_admin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_52ddf911","line":420,"in_reply_to":"5f7c97a3_b84471b9","updated":"2018-05-29 12:06:54.000000000","message":"From CLI point of view not, from refstack point of view, yes, but that part is still in progress. So if you agree that the new name is better, more descriptive, better do it know :)","commit_id":"d359077836d64387b903468cff32eb2d21258853"}],"config_tempest/services/image.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1454abcd4da3d3adaa9c08dcc05b439fce046eda","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.image_path \u003d image_path"},{"line_number":45,"context_line":"        self.disk_format \u003d disk_format"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def set_validation_section(self, conf):"},{"line_number":48,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":49,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":50,"context_line":"        # because we don\u0027t have to specify overrides."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f83e6927","line":47,"updated":"2018-05-29 09:16:59.000000000","message":"shouldn\u0027t this section use the newly defined set_default_tempest_options(self, conf)?","commit_id":"d359077836d64387b903468cff32eb2d21258853"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f33cdba2f57800976033cd73d6c8e07251e1b770","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self.image_path \u003d image_path"},{"line_number":45,"context_line":"        self.disk_format \u003d disk_format"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def set_validation_section(self, conf):"},{"line_number":48,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":49,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":50,"context_line":"        # because we don\u0027t have to specify overrides."}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_127f81df","line":47,"in_reply_to":"5f7c97a3_f83e6927","updated":"2018-05-29 12:06:54.000000000","message":"Yeah, it was already merged. I\u0027ll rebase. Good catch!","commit_id":"d359077836d64387b903468cff32eb2d21258853"}],"releasenotes/notes/image_ssh_user-option-in-validation-section-7cd0a6f44a8fdc1f.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c33d4672d7b44d4743cda282b00ba81c71c5fa28","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    in refstack. Therefor the value is set to cirros automatically from now"},{"line_number":6,"context_line":"    everytime when image used is cirros."},{"line_number":7,"context_line":"    The hardcoded value in default-overrides.conf is removed."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    By this change compute.image_ssh_user is removed from"},{"line_number":11,"context_line":"    default-overrides.conf too, because it was deprecated. All of the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_742be132","line":8,"updated":"2018-06-04 09:45:25.000000000","message":"Uhm, I\u0027m not sure that we need this section, because this is not a deprecation; the value was removed from tempest and we are just not setting it anymore.","commit_id":"f5ac2ef83c5174082b05fafa95a84069a8a80845"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4ad514044bdc0cf485242e5e7f7888b843bdf695","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    in refstack. Therefor the value is set to cirros automatically from now"},{"line_number":6,"context_line":"    everytime when image used is cirros."},{"line_number":7,"context_line":"    The hardcoded value in default-overrides.conf is removed."},{"line_number":8,"context_line":"deprecations:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    By this change compute.image_ssh_user is removed from"},{"line_number":11,"context_line":"    default-overrides.conf too, because it was deprecated. All of the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_94ba3dbe","line":8,"in_reply_to":"5f7c97a3_742be132","updated":"2018-06-04 09:52:13.000000000","message":"I just wanted to noted somewhere that we have stopped setting the option and the reason why as well, but I absolutely don\u0027t mind to delete the whole section.","commit_id":"f5ac2ef83c5174082b05fafa95a84069a8a80845"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c33d4672d7b44d4743cda282b00ba81c71c5fa28","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    image_ssh_user values from different sections were moved to validation"},{"line_number":13,"context_line":"    section by this change:"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    https://github.com/openstack/tempest/commit/244cf7cfb1632a5e1ae2332ad52fcdeff1ba97bd"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Since that change, there is only one image_ssh_user value and it\u0027s the one"},{"line_number":18,"context_line":"    under validation section."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_542a652c","line":15,"updated":"2018-06-04 09:45:25.000000000","message":"If we want to keep this section, please use the link to git.openstack.org or (imho better) the link to the review.","commit_id":"f5ac2ef83c5174082b05fafa95a84069a8a80845"}]}