)]}'
{"config_tempest/main.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"e3f0992e03ea459d2b58dd3a0ecb7d2d22e4bf2a","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    volume.check_volume_backup_service(conf, clients.volume_client,"},{"line_number":410,"context_line":"                                       services.is_service(\"volumev3\"))"},{"line_number":411,"context_line":"    ceilometer.check_ceilometer_service(conf, clients.service_client)"},{"line_number":412,"context_line":"    octavia.check_octavia_service(conf, clients.service_client)"},{"line_number":413,"context_line":"    boto.configure_boto(conf, s3_service\u003dservices.get_service(\"s3\"))"},{"line_number":414,"context_line":"    identity \u003d services.get_service(\u0027identity\u0027)"},{"line_number":415,"context_line":"    identity.configure_keystone_feature_flags(conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_767425d1","line":412,"updated":"2018-06-05 15:44:45.000000000","message":"see https://review.openstack.org/#/c/570876/","commit_id":"146023fda0c2b1263d64938d2d4b63e6bf02274d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"51cad1deca216655bf2791876d5fda89c84de99e","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    volume.check_volume_backup_service(conf, clients.volume_client,"},{"line_number":410,"context_line":"                                       services.is_service(\"volumev3\"))"},{"line_number":411,"context_line":"    ceilometer.check_ceilometer_service(conf, clients.service_client)"},{"line_number":412,"context_line":"    octavia.check_octavia_service(conf, clients.service_client)"},{"line_number":413,"context_line":"    boto.configure_boto(conf, s3_service\u003dservices.get_service(\"s3\"))"},{"line_number":414,"context_line":"    identity \u003d services.get_service(\u0027identity\u0027)"},{"line_number":415,"context_line":"    identity.configure_keystone_feature_flags(conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_b046ae20","line":412,"in_reply_to":"5f7c97a3_767425d1","updated":"2018-06-12 12:56:50.000000000","message":"Done","commit_id":"146023fda0c2b1263d64938d2d4b63e6bf02274d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"54b4655bd0068e629562e916b728725503586685","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    network \u003d services.get_service(\"network\")"},{"line_number":398,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":399,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":400,"context_line":"    octavia \u003d services.get_service(\"load-balancer\")"},{"line_number":401,"context_line":"    octavia.set_octavia_preferences("},{"line_number":402,"context_line":"        kwargs.get(\u0027enable_security_groups\u0027, True),"},{"line_number":403,"context_line":"        kwargs.get(\u0027member_role\u0027, C.OCTAVIA_MEMBER_ROLE),"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_906db233","line":400,"updated":"2018-06-12 13:04:54.000000000","message":"note for the other cores: we should make this pattern generic for all services (see also image.set_image_preferences above)","commit_id":"16a839f02601a699d3bcec7ec22b7afab9c6fffc"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"54b4655bd0068e629562e916b728725503586685","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    network \u003d services.get_service(\"network\")"},{"line_number":398,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":399,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":400,"context_line":"    octavia \u003d services.get_service(\"load-balancer\")"},{"line_number":401,"context_line":"    octavia.set_octavia_preferences("},{"line_number":402,"context_line":"        kwargs.get(\u0027enable_security_groups\u0027, True),"},{"line_number":403,"context_line":"        kwargs.get(\u0027member_role\u0027, C.OCTAVIA_MEMBER_ROLE),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d0424a68","line":400,"updated":"2018-06-12 13:04:54.000000000","message":"shouldn\u0027t this go to set_default_tempest_options() ?","commit_id":"810fed0958c635cba5e4c873e8d4133a8f1adf84"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"effbc0aa3e5a7c4e47619a129576ebacfaaee7f3","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    network \u003d services.get_service(\"network\")"},{"line_number":398,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":399,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":400,"context_line":"    octavia \u003d services.get_service(\"load-balancer\")"},{"line_number":401,"context_line":"    octavia.set_octavia_preferences("},{"line_number":402,"context_line":"        kwargs.get(\u0027enable_security_groups\u0027, True),"},{"line_number":403,"context_line":"        kwargs.get(\u0027member_role\u0027, C.OCTAVIA_MEMBER_ROLE),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_d3a1f4f8","line":400,"in_reply_to":"5f7c97a3_d0424a68","updated":"2018-06-12 13:16:31.000000000","message":"Done","commit_id":"810fed0958c635cba5e4c873e8d4133a8f1adf84"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"726d58248730227b5be3bf8cd6d3f2b2e5b09e85","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    network \u003d services.get_service(\"network\")"},{"line_number":398,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":399,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":400,"context_line":"    octavia \u003d services.get_service(\"load-balancer\")"},{"line_number":401,"context_line":"    octavia.set_default_tempest_options(conf)"},{"line_number":402,"context_line":"    services.set_service_availability()"},{"line_number":403,"context_line":"    services.set_supported_api_versions()"},{"line_number":404,"context_line":"    services.set_service_extensions()"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_702000b1","line":401,"range":{"start_line":400,"start_character":0,"end_line":401,"end_character":45},"updated":"2018-06-13 07:20:21.000000000","message":"This doesn\u0027t have to be here, if you check the discovery method in services.py, you\u0027ll see, there is the set_default_tempest_options method called automatically, when a service is discovered.\nIf you remove this and let the method to be called from discovery, it will solve your issue.","commit_id":"fe30ec201e83890ecd44f8b34bcd30ebf96d2855"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"94fed933dbf02fb3768d606afa7ea9dddd529dd5","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":399,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":400,"context_line":"    octavia \u003d services.get_service(\"load-balancer\")"},{"line_number":401,"context_line":"    octavia.set_default_tempest_options(conf)"},{"line_number":402,"context_line":"    services.set_service_availability()"},{"line_number":403,"context_line":"    services.set_supported_api_versions()"},{"line_number":404,"context_line":"    services.set_service_extensions()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_bda74cbc","line":401,"updated":"2018-06-13 09:30:12.000000000","message":"This is called automatically, don\u0027t need to do it here.","commit_id":"4b2d1b5db2c921d0069fe78d493f061551a984f1"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"876d4c17f5a656cca17eeeadf4f36e62dd53a463","unresolved":false,"context_lines":[{"line_number":398,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":399,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":400,"context_line":"    octavia \u003d services.get_service(\"load-balancer\")"},{"line_number":401,"context_line":"    octavia.set_default_tempest_options(conf)"},{"line_number":402,"context_line":"    services.set_service_availability()"},{"line_number":403,"context_line":"    services.set_supported_api_versions()"},{"line_number":404,"context_line":"    services.set_service_extensions()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_1dbc40b9","line":401,"in_reply_to":"5f7c97a3_bda74cbc","updated":"2018-06-13 09:33:46.000000000","message":"Done","commit_id":"4b2d1b5db2c921d0069fe78d493f061551a984f1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bf41629e2bc55bf7d96465b35da7a1feec2d23e8","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    network \u003d services.get_service(\"network\")"},{"line_number":396,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":397,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    services.set_service_availability()"},{"line_number":400,"context_line":"    services.set_supported_api_versions()"},{"line_number":401,"context_line":"    services.set_service_extensions()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_eca53949","side":"PARENT","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":0},"updated":"2018-06-24 15:15:24.000000000","message":"Is there any reason to delete the line or is it just an artifact from last changes?","commit_id":"686efa486043bfbdaedb9da9d9fc6db38a0f9617"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"416e2403deb813de839f57b12cf996445f4fae83","unresolved":false,"context_lines":[{"line_number":395,"context_line":"    network \u003d services.get_service(\"network\")"},{"line_number":396,"context_line":"    network.create_tempest_networks(has_neutron, conf,"},{"line_number":397,"context_line":"                                    kwargs.get(\u0027network_id\u0027))"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    services.set_service_availability()"},{"line_number":400,"context_line":"    services.set_supported_api_versions()"},{"line_number":401,"context_line":"    services.set_service_extensions()"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_23c49f91","side":"PARENT","line":398,"range":{"start_line":398,"start_character":0,"end_line":398,"end_character":0},"in_reply_to":"5f7c97a3_eca53949","updated":"2018-06-24 20:26:42.000000000","message":"Just a mistake.\nThank you for catching this. Fixed.","commit_id":"686efa486043bfbdaedb9da9d9fc6db38a0f9617"}],"config_tempest/services/octavia.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"412d311aabd5e485b314f725226651ed77b8e6a6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        services \u003d service_client.list_services(**params)"},{"line_number":29,"context_line":"    except exceptions.Forbidden:"},{"line_number":30,"context_line":"        C.LOG.warning(\"User has no permissions to list services - \""},{"line_number":31,"context_line":"                      \"metering service can\u0027t be discovered.\")"},{"line_number":32,"context_line":"        return"},{"line_number":33,"context_line":"    if services and len(services[\u0027services\u0027]):"},{"line_number":34,"context_line":"        load_balancer \u003d services[\u0027services\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_fb1c9e78","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":31},"updated":"2018-06-05 15:14:29.000000000","message":"load-balancer","commit_id":"74da8cf315640f009ce174ada9d1c4b53c19aa39"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"51cad1deca216655bf2791876d5fda89c84de99e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        services \u003d service_client.list_services(**params)"},{"line_number":29,"context_line":"    except exceptions.Forbidden:"},{"line_number":30,"context_line":"        C.LOG.warning(\"User has no permissions to list services - \""},{"line_number":31,"context_line":"                      \"metering service can\u0027t be discovered.\")"},{"line_number":32,"context_line":"        return"},{"line_number":33,"context_line":"    if services and len(services[\u0027services\u0027]):"},{"line_number":34,"context_line":"        load_balancer \u003d services[\u0027services\u0027][0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b5f381e7","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":31},"in_reply_to":"5f7c97a3_fb1c9e78","updated":"2018-06-12 12:56:50.000000000","message":"Yup, already fixed in the next patch set :)","commit_id":"74da8cf315640f009ce174ada9d1c4b53c19aa39"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"e3f0992e03ea459d2b58dd3a0ecb7d2d22e4bf2a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def check_octavia_service(conf, service_client):"},{"line_number":21,"context_line":"    \"\"\"If a load-balancer service is available, set it to conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    :type conf: TempestConf object"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_1666112b","line":20,"updated":"2018-06-05 15:44:45.000000000","message":"This file should contain a class derived from Service (config_tempest/services/base.py) or a derived class (like VersionedService).\n\nMost of the content of this method should go away, and it should not be called explicitly.\n\nSee also https://review.openstack.org/#/c/570876/ (please rebase on top of it, or at least consider the changes going on there).","commit_id":"146023fda0c2b1263d64938d2d4b63e6bf02274d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"51cad1deca216655bf2791876d5fda89c84de99e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def check_octavia_service(conf, service_client):"},{"line_number":21,"context_line":"    \"\"\"If a load-balancer service is available, set it to conf"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    :type conf: TempestConf object"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_f040a608","line":20,"in_reply_to":"5f7c97a3_1666112b","updated":"2018-06-12 12:56:50.000000000","message":"Done, Removed.","commit_id":"146023fda0c2b1263d64938d2d4b63e6bf02274d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"0bd0dff3041464be963554b082055b8dc35f1e79","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class LoadBalancerService(VersionedService):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":22,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_security_groups\u0027, \u0027True\u0027)"},{"line_number":23,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027, \u0027_member_\u0027)"},{"line_number":24,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027admin_role\u0027, \u0027admin\u0027)"},{"line_number":25,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027RBAC_test_type\u0027, \u0027owner_or_admin\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_78cc6269","line":25,"range":{"start_line":22,"start_character":8,"end_line":25,"end_character":69},"updated":"2018-06-13 10:17:04.000000000","message":"Thanks for the patch, It would be great if we add some code to check those values on system under test and set it.\nFor examples in terms of setting role:\nCan we first check whether those roles are available or not,\nif not then create it and then set it.","commit_id":"a777cf92e4ffd78155daf739dc0bd337f8bf174c"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"bf41629e2bc55bf7d96465b35da7a1feec2d23e8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class LoadBalancerService(VersionedService):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":22,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_security_groups\u0027, \u0027True\u0027)"},{"line_number":23,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027, \u0027_member_\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_ec7a19b9","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"updated":"2018-06-24 15:15:24.000000000","message":"Override, please, set_version method and set top_level to False. The default value of top_level is True and with this configuration do_get method inside set_version method loads unexpected data which leads to an error [1] in DNM testing patch [2]. \nI\u0027ve tested it manually in my local env and overriding top_level to False solved the issue. After that the wanted options inside load_balancer section and service_available.octavia \u003d True in tempest.conf were set as expected.\nHere is a diff of changes:\n\n class LoadBalancerService(VersionedService):\n \n+    def set_versions(self):\n+        super(LoadBalancerService, self).set_versions(top_level\u003dFalse)\n+\n     def set_default_tempest_options(self, conf):\n         conf.set(\u0027load_balancer\u0027, \u0027enable_security_groups\u0027, \u0027True\u0027)\n\n\n[1] http://logs.openstack.org/63/575063/8/check/python-tempestconf-tempest-devstack-admin/954e1a5/job-output.txt.gz#_2018-06-21_16_17_07_702360\n[2] https://review.openstack.org/#/c/575063/","commit_id":"e70d7b028e13e786630da53d45dc4b993a10b6e3"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"416e2403deb813de839f57b12cf996445f4fae83","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class LoadBalancerService(VersionedService):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":22,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_security_groups\u0027, \u0027True\u0027)"},{"line_number":23,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027, \u0027_member_\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f7c97a3_8359f3fd","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":0},"in_reply_to":"5f7c97a3_ec7a19b9","updated":"2018-06-24 20:26:42.000000000","message":"Done","commit_id":"e70d7b028e13e786630da53d45dc4b993a10b6e3"}],"config_tempest/services/services.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"412d311aabd5e485b314f725226651ed77b8e6a6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            # ceilometer is still transitioning from metering to telemetry"},{"line_number":200,"context_line":"            if service \u003d\u003d \u0027telemetry\u0027 and self.is_service(\u0027metering\u0027):"},{"line_number":201,"context_line":"                service \u003d \u0027metering\u0027"},{"line_number":202,"context_line":"            available \u003d str(self.is_service(service))"},{"line_number":203,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            # check if load-balancer service is enabled"},{"line_number":206,"context_line":"            if service \u003d\u003d \u0027load-balancer\u0027 and self.is_service(\u0027load-balancer\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_56456942","line":203,"range":{"start_line":202,"start_character":12,"end_line":203,"end_character":68},"updated":"2018-06-05 15:14:29.000000000","message":"delete these lines as they are in L208-209.","commit_id":"74da8cf315640f009ce174ada9d1c4b53c19aa39"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"51cad1deca216655bf2791876d5fda89c84de99e","unresolved":false,"context_lines":[{"line_number":199,"context_line":"            # ceilometer is still transitioning from metering to telemetry"},{"line_number":200,"context_line":"            if service \u003d\u003d \u0027telemetry\u0027 and self.is_service(\u0027metering\u0027):"},{"line_number":201,"context_line":"                service \u003d \u0027metering\u0027"},{"line_number":202,"context_line":"            available \u003d str(self.is_service(service))"},{"line_number":203,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            # check if load-balancer service is enabled"},{"line_number":206,"context_line":"            if service \u003d\u003d \u0027load-balancer\u0027 and self.is_service(\u0027load-balancer\u0027):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_70a496a3","line":203,"range":{"start_line":202,"start_character":12,"end_line":203,"end_character":68},"in_reply_to":"5f7c97a3_56456942","updated":"2018-06-12 12:56:50.000000000","message":"Done","commit_id":"74da8cf315640f009ce174ada9d1c4b53c19aa39"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"412d311aabd5e485b314f725226651ed77b8e6a6","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            # check if load-balancer service is enabled"},{"line_number":206,"context_line":"            if service \u003d\u003d \u0027load-balancer\u0027 and self.is_service(\u0027load-balancer\u0027):"},{"line_number":207,"context_line":"                service \u003d \u0027load-balancer\u0027"},{"line_number":208,"context_line":"            available \u003d str(self.is_service(service))"},{"line_number":209,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_763985d6","line":207,"range":{"start_line":206,"start_character":12,"end_line":207,"end_character":41},"updated":"2018-06-05 15:14:29.000000000","message":"This doesn\u0027t make sense? If service variable is already \u0027load-balancer\u0027, there\u0027s no need to redefine it to same value.","commit_id":"74da8cf315640f009ce174ada9d1c4b53c19aa39"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"51cad1deca216655bf2791876d5fda89c84de99e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            # check if load-balancer service is enabled"},{"line_number":206,"context_line":"            if service \u003d\u003d \u0027load-balancer\u0027 and self.is_service(\u0027load-balancer\u0027):"},{"line_number":207,"context_line":"                service \u003d \u0027load-balancer\u0027"},{"line_number":208,"context_line":"            available \u003d str(self.is_service(service))"},{"line_number":209,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b079ce2f","line":207,"range":{"start_line":206,"start_character":12,"end_line":207,"end_character":41},"in_reply_to":"5f7c97a3_763985d6","updated":"2018-06-12 12:56:50.000000000","message":"Correct. Fixed.","commit_id":"74da8cf315640f009ce174ada9d1c4b53c19aa39"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"54b4655bd0068e629562e916b728725503586685","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if service \u003d\u003d \u0027telemetry\u0027 and self.is_service(\u0027metering\u0027):"},{"line_number":226,"context_line":"                service \u003d \u0027metering\u0027"},{"line_number":227,"context_line":"            # check if load-balancer service is enabled"},{"line_number":228,"context_line":"            if self.is_service(\u0027load-balancer\u0027):"},{"line_number":229,"context_line":"                service \u003d \u0027load-balancer\u0027"},{"line_number":230,"context_line":"            available \u003d str(self.is_service(service))"},{"line_number":231,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_b05b0e52","line":228,"updated":"2018-06-12 13:04:54.000000000","message":"I don\u0027t think that these lines are needed","commit_id":"810fed0958c635cba5e4c873e8d4133a8f1adf84"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"effbc0aa3e5a7c4e47619a129576ebacfaaee7f3","unresolved":false,"context_lines":[{"line_number":225,"context_line":"            if service \u003d\u003d \u0027telemetry\u0027 and self.is_service(\u0027metering\u0027):"},{"line_number":226,"context_line":"                service \u003d \u0027metering\u0027"},{"line_number":227,"context_line":"            # check if load-balancer service is enabled"},{"line_number":228,"context_line":"            if self.is_service(\u0027load-balancer\u0027):"},{"line_number":229,"context_line":"                service \u003d \u0027load-balancer\u0027"},{"line_number":230,"context_line":"            available \u003d str(self.is_service(service))"},{"line_number":231,"context_line":"            self._conf.set(\u0027service_available\u0027, codename, available)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_3388686f","line":228,"in_reply_to":"5f7c97a3_b05b0e52","updated":"2018-06-12 13:16:31.000000000","message":"Done","commit_id":"810fed0958c635cba5e4c873e8d4133a8f1adf84"}],"etc/default-overrides.conf":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"1cc5a81d0d64be52011362a96e07374525c4cfe2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"[network-feature-enabled]"},{"line_number":126,"context_line":"# Added in juno"},{"line_number":127,"context_line":"ipv6_subnet_attributes\u003dtrue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"[load_balancer]"},{"line_number":130,"context_line":"enable_security_groups \u003d True"},{"line_number":131,"context_line":"member_role \u003d _member_"},{"line_number":132,"context_line":"admin_role \u003d admin"},{"line_number":133,"context_line":"RBAC_test_type \u003d owner_or_admin"}],"source_content_type":"text/plain","patch_set":4,"id":"5f7c97a3_766ae51b","line":133,"range":{"start_line":128,"start_character":0,"end_line":133,"end_character":31},"updated":"2018-06-05 15:39:53.000000000","message":"This file will get removed, create a OctaviaService class and add it on set_default_tempest_options function there","commit_id":"146023fda0c2b1263d64938d2d4b63e6bf02274d"},{"author":{"_account_id":6579,"name":"Nir Magnezi","email":"nmagnezi@redhat.com","username":"nmagnezi"},"change_message_id":"51cad1deca216655bf2791876d5fda89c84de99e","unresolved":false,"context_lines":[{"line_number":125,"context_line":"[network-feature-enabled]"},{"line_number":126,"context_line":"# Added in juno"},{"line_number":127,"context_line":"ipv6_subnet_attributes\u003dtrue"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"[load_balancer]"},{"line_number":130,"context_line":"enable_security_groups \u003d True"},{"line_number":131,"context_line":"member_role \u003d _member_"},{"line_number":132,"context_line":"admin_role \u003d admin"},{"line_number":133,"context_line":"RBAC_test_type \u003d owner_or_admin"}],"source_content_type":"text/plain","patch_set":4,"id":"5f7c97a3_f05986fc","line":133,"range":{"start_line":128,"start_character":0,"end_line":133,"end_character":31},"in_reply_to":"5f7c97a3_766ae51b","updated":"2018-06-12 12:56:50.000000000","message":"Done, Removed.","commit_id":"146023fda0c2b1263d64938d2d4b63e6bf02274d"}]}