)]}'
{"config_tempest/services/object_storage.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"42f64801e7e9147388343f83c9c1232675abb5de","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            LOG.info(\"Roles can\u0027t be listed - the user needs permissions.\")"},{"line_number":40,"context_line":"            return"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        options \u003d [{\"key\": \"operator_role\", \"value\": \"SwiftOperator\"},"},{"line_number":43,"context_line":"                   {\"key\": \"reseller_admin\", \"value\": \"ResellerAdmin\"}]"},{"line_number":44,"context_line":"        for role in options:"},{"line_number":45,"context_line":"            if role[\u0027value\u0027] not in [r[\u0027name\u0027] for r in roles]:"},{"line_number":46,"context_line":"                LOG.info(\"Creating %s role\", role[\u0027value\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3e6a28ed","line":43,"range":{"start_line":42,"start_character":7,"end_line":43,"end_character":71},"updated":"2018-06-04 08:40:26.000000000","message":"Thanks martin for the patch, I think we can first look for default role from conf instead of storing the role value in dict then create/set the defaulted conf role.","commit_id":"56e35e96427a1172ae0f11ff6f011d254feeab7f"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"6ed859e37a785aa24a2dbe9e9aa5c4a22a685eee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            key_value \u003d conf.get_defaulted(\"object-storage\", section_key)"},{"line_number":44,"context_line":"            if key_value not in [r[\u0027name\u0027] for r in roles]:"},{"line_number":45,"context_line":"                LOG.info(\"Creating %s role\", key_value)"},{"line_number":46,"context_line":"                client.create_role(name\u003dkey_value)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"            conf.set(\"object-storage\", section_key, key_value)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_2da998dc","line":46,"range":{"start_line":46,"start_character":16,"end_line":46,"end_character":50},"updated":"2018-06-04 12:14:17.000000000","message":"Can we add one more step to add that role to that user?","commit_id":"0f0bfb1b62dfdce8704efffa39acdf13c913d739"}]}