)]}'
{".zuul.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bf315e79ec3c83795f6a9d152f9068045e0f4024","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    vars:"},{"line_number":27,"context_line":"      tox_envlist: cover"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job: python-tempestconf"},{"line_number":30,"context_line":"    name: python-tempestconf"},{"line_number":31,"context_line":"    parent: devstack"},{"line_number":32,"context_line":"    description: Base job for python-tempestconf on a devstack environment"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_14d58447","line":29,"updated":"2018-06-19 09:23:12.000000000","message":"uhm, job name here?","commit_id":"2b95cf91de739fd9934959cfe1490701ef55a903"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bf315e79ec3c83795f6a9d152f9068045e0f4024","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      tox_envlist: cover"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job: python-tempestconf"},{"line_number":30,"context_line":"    name: python-tempestconf"},{"line_number":31,"context_line":"    parent: devstack"},{"line_number":32,"context_line":"    description: Base job for python-tempestconf on a devstack environment"},{"line_number":33,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_f447a81d","line":30,"updated":"2018-06-19 09:23:12.000000000","message":"python-tempestconf-devstack-base","commit_id":"2b95cf91de739fd9934959cfe1490701ef55a903"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bf315e79ec3c83795f6a9d152f9068045e0f4024","unresolved":false,"context_lines":[{"line_number":70,"context_line":"      cloud_user: devstack"},{"line_number":71,"context_line":"      test_demo: True"},{"line_number":72,"context_line":"      cloud_admin: devstack-admin"},{"line_number":73,"context_line":"      zuul_copy_output:"},{"line_number":74,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/tempest.conf\u0027: \u0027logs\u0027"},{"line_number":75,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/accounts.yaml\u0027: \u0027logs\u0027"},{"line_number":76,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/tempest.log\u0027: \u0027logs\u0027    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_34f0c0fd","line":73,"updated":"2018-06-19 09:23:12.000000000","message":"why is zuul_copy_output defined again, if the job inherits from python-tempestconf?","commit_id":"2b95cf91de739fd9934959cfe1490701ef55a903"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bf315e79ec3c83795f6a9d152f9068045e0f4024","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      zuul_copy_output:"},{"line_number":74,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/tempest.conf\u0027: \u0027logs\u0027"},{"line_number":75,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/accounts.yaml\u0027: \u0027logs\u0027"},{"line_number":76,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/tempest.log\u0027: \u0027logs\u0027    irrelevant-files:"},{"line_number":77,"context_line":"      - config_tempest/tests/.*$"},{"line_number":78,"context_line":"      - ^doc/.*$"},{"line_number":79,"context_line":"      - ^releasenotes/.*$"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_14434413","line":76,"updated":"2018-06-19 09:23:12.000000000","message":"this irrelevant-files in the same line is not exactly working","commit_id":"2b95cf91de739fd9934959cfe1490701ef55a903"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bf315e79ec3c83795f6a9d152f9068045e0f4024","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    vars:"},{"line_number":100,"context_line":"      scenario: scenario000"},{"line_number":101,"context_line":"      user: admin"},{"line_number":102,"context_line":"      zuul_copy_output:"},{"line_number":103,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/tempest.conf\u0027: \u0027logs\u0027"},{"line_number":104,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/accounts.yaml\u0027: \u0027logs\u0027"},{"line_number":105,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/tempest.log\u0027: \u0027logs\u0027    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_9460b4a6","line":102,"updated":"2018-06-19 09:23:12.000000000","message":"no shared job for packstack too?","commit_id":"2b95cf91de739fd9934959cfe1490701ef55a903"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bf315e79ec3c83795f6a9d152f9068045e0f4024","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      user: demo"},{"line_number":131,"context_line":"      test_demo: True"},{"line_number":132,"context_line":"      cloud_admin: packstack-admin"},{"line_number":133,"context_line":"      zuul_copy_output:"},{"line_number":134,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/tempest.conf\u0027: \u0027logs\u0027"},{"line_number":135,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/etc/accounts.yaml\u0027: \u0027logs\u0027"},{"line_number":136,"context_line":"        \u0027{{ devstack_base_dir }}/tempest/tempest.log\u0027: \u0027logs\u0027    irrelevant-files:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_d465ccb0","line":133,"updated":"2018-06-19 09:23:12.000000000","message":"see above","commit_id":"2b95cf91de739fd9934959cfe1490701ef55a903"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      tox_envlist: cover"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: python-tempestconf-packstack"},{"line_number":31,"context_line":"    parent: packstack-allinone"},{"line_number":32,"context_line":"    description: Base job for python-tempestconf on packstack environment"},{"line_number":33,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5f7c97a3_870b7b20","line":30,"updated":"2018-07-03 09:30:13.000000000","message":"Can you please define this after python-tempestconf-devstack?\n\n(just to follow the same order).\n\nWould it be worth to call those jobs\npython-tempestconf-packstack-base\npython-tempestconf-devstack-base\n?","commit_id":"f4c6808210546bbaad92268ee3549c7a9820fe71"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    vars:"},{"line_number":27,"context_line":"      tox_envlist: cover"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: python-tempestconf-packstack"},{"line_number":31,"context_line":"    parent: packstack-allinone"},{"line_number":32,"context_line":"    description: Base job for python-tempestconf on packstack environment"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_b5a6ee0c","line":29,"updated":"2018-07-03 09:30:13.000000000","message":"If the base jobs can\u0027t be used as they are, without inheriting, maybe we could add a -base suffix in their name.","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      tox_envlist: cover"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- job:"},{"line_number":30,"context_line":"    name: python-tempestconf-packstack"},{"line_number":31,"context_line":"    parent: packstack-allinone"},{"line_number":32,"context_line":"    description: Base job for python-tempestconf on packstack environment"},{"line_number":33,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_159802ca","line":30,"updated":"2018-07-03 09:30:13.000000000","message":"this is a nit of mine, but: can you please order the jobs, so that it\u0027s either\nall devstack\nall packstack\n\nor \ndevstack base\npackstack base\nall real devstack\nall real packstack\n\nRight now is\npackstack base\ndevstack base\nall real devstack\nall real packstack","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      - openstack/python-tempestconf"},{"line_number":36,"context_line":"      - openstack/tempest"},{"line_number":37,"context_line":"      - openstack-dev/devstack"},{"line_number":38,"context_line":"    timeout: 5400"},{"line_number":39,"context_line":"    post-run: playbooks/upload-logs.yaml"},{"line_number":40,"context_line":"    roles:"},{"line_number":41,"context_line":"      - zuul: openstack/packstack"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_7542963d","line":38,"updated":"2018-07-03 09:30:13.000000000","message":"the default timeout for packstack-allinone is 7200, is this reduction really wanted?","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"}],"/COMMIT_MSG":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch collect the tempest.conf, accounts.yaml and the"},{"line_number":10,"context_line":"tempest.log files. In order to make it work here\u0027s what had to"},{"line_number":11,"context_line":"be changed:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Devstack jobs, inherit from devstack, and these files are on logs/"},{"line_number":14,"context_line":"  since it\u0027s the only place we can specify files to be according"},{"line_number":15,"context_line":"  zuul documentation. You could add a tempest directory in logs but"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"5f7c97a3_55199a77","line":12,"updated":"2018-07-03 09:30:13.000000000","message":"(you may want to mention the general refactor of the jobs)","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"tempest.log files. In order to make it work here\u0027s what had to"},{"line_number":11,"context_line":"be changed:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Devstack jobs, inherit from devstack, and these files are on logs/"},{"line_number":14,"context_line":"  since it\u0027s the only place we can specify files to be according"},{"line_number":15,"context_line":"  zuul documentation. You could add a tempest directory in logs but"},{"line_number":16,"context_line":"  we would have to overwrite a lot of code just for it, since we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"5f7c97a3_35289e83","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":24},"updated":"2018-07-03 09:30:13.000000000","message":"(in the nit category, only if you change anything else: inherited)","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  zuul documentation. You could add a tempest directory in logs but"},{"line_number":16,"context_line":"  we would have to overwrite a lot of code just for it, since we"},{"line_number":17,"context_line":"  are inherit the tempest run playbook from tempest project."},{"line_number":18,"context_line":"* Packstack jobs are inherit from packstack, and they have a different"},{"line_number":19,"context_line":"  way to upload logs, and they don\u0027t run tempest, so we had to"},{"line_number":20,"context_line":"  implement our own upload logs and overwrite the packstack one."},{"line_number":21,"context_line":"  Basically a copy and paste, plus the generation of tempest directory"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"5f7c97a3_752db68d","line":18,"updated":"2018-07-03 09:30:13.000000000","message":"(see above)","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"}],"playbooks/python-tempestconf-tempest-packstack.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        name: run-tempest"},{"line_number":70,"context_line":"      vars:"},{"line_number":71,"context_line":"        tempest_concurrency: 2"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_758a96bc","line":72,"updated":"2018-07-03 09:30:13.000000000","message":"no change here, but I would not block the patch for this","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"}],"playbooks/upload-logs.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b19bf942193e9425a287c29807efe9e33142c5d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"        state: directory"},{"line_number":7,"context_line":"      become: True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    - command: \"sudo cp {{ item }} /tmp/logs/tempest\""},{"line_number":10,"context_line":"      with_items:"},{"line_number":11,"context_line":"        - /opt/stack/tempest/etc/tempest.conf"},{"line_number":12,"context_line":"        - /opt/stack/tempest/tempest.log"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"5f7c97a3_558f5acc","line":9,"updated":"2018-07-03 09:30:13.000000000","message":"Can you please add the link to the bug in a comment before this line?","commit_id":"ede95daab05c2e86e6ad8a1e1644c915df81c726"}]}