)]}'
{"config_tempest/services/image.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"164c30830c3e63d48df5885b10169063724adb13","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                except IOError:"},{"line_number":129,"context_line":"                    # let\u0027s try if this is the case when a user uses already"},{"line_number":130,"context_line":"                    # existing image in glance wihch is not uploaded as *_alt"},{"line_number":131,"context_line":"                    image \u003d self._find_image(None, image_name[:-4])"},{"line_number":132,"context_line":"                    if image:"},{"line_number":133,"context_line":"                        path \u003d os.path.abspath(image_dest)"},{"line_number":134,"context_line":"                        if not os.path.isfile(path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_6ad5dae5","line":131,"updated":"2018-07-26 09:32:41.000000000","message":"what is this :-4 used for exactly? Remove _alt? \n\n(typo: wihch)","commit_id":"8116930c985fefd4e1abdf73b0a4031f40acfbbf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a81d0fba53fa0c9ea665c76b47a892f2e9efdf3f","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                except IOError:"},{"line_number":129,"context_line":"                    # let\u0027s try if this is the case when a user uses already"},{"line_number":130,"context_line":"                    # existing image in glance wihch is not uploaded as *_alt"},{"line_number":131,"context_line":"                    image \u003d self._find_image(None, image_name[:-4])"},{"line_number":132,"context_line":"                    if image:"},{"line_number":133,"context_line":"                        path \u003d os.path.abspath(image_dest)"},{"line_number":134,"context_line":"                        if not os.path.isfile(path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aa1f726f","line":131,"in_reply_to":"5f7c97a3_6ad5dae5","updated":"2018-07-26 09:44:32.000000000","message":"yes, removing _alt .. I can add a more explicit comment there","commit_id":"8116930c985fefd4e1abdf73b0a4031f40acfbbf"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ae319d10c69819e6519e7a48015a8dd65b29a2a5","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                except IOError:"},{"line_number":129,"context_line":"                    # let\u0027s try if this is the case when a user uses already"},{"line_number":130,"context_line":"                    # existing image in glance wihch is not uploaded as *_alt"},{"line_number":131,"context_line":"                    image \u003d self._find_image(None, image_name[:-4])"},{"line_number":132,"context_line":"                    if image:"},{"line_number":133,"context_line":"                        path \u003d os.path.abspath(image_dest)"},{"line_number":134,"context_line":"                        if not os.path.isfile(path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ed1ca467","line":131,"in_reply_to":"5f7c97a3_aa1f726f","updated":"2018-07-26 09:48:48.000000000","message":"But if you know that this is exactly about _alt, can\u0027t you check if this the last part of the string is really _alt?","commit_id":"8116930c985fefd4e1abdf73b0a4031f40acfbbf"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"41d0b14adbdd6da32cc03d17caefd225b1d8708d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                except IOError:"},{"line_number":129,"context_line":"                    # let\u0027s try if this is the case when a user uses already"},{"line_number":130,"context_line":"                    # existing image in glance wihch is not uploaded as *_alt"},{"line_number":131,"context_line":"                    image \u003d self._find_image(None, image_name[:-4])"},{"line_number":132,"context_line":"                    if image:"},{"line_number":133,"context_line":"                        path \u003d os.path.abspath(image_dest)"},{"line_number":134,"context_line":"                        if not os.path.isfile(path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4dd03853","line":131,"in_reply_to":"5f7c97a3_cd3688e0","updated":"2018-07-26 09:53:38.000000000","message":"This codepath is always trying to remove the last 4 characters from image_name, not just when those last 4 characters are _alt. Can this be change so that the  \u0027_alt\u0027 suffix is removed from image_name only when the last 4 characters are really \u0027_alt\u0027 and not something else?","commit_id":"8116930c985fefd4e1abdf73b0a4031f40acfbbf"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"cb31bf82db3ad2c398c9b7ea4aea96b5f4f03205","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                except IOError:"},{"line_number":129,"context_line":"                    # let\u0027s try if this is the case when a user uses already"},{"line_number":130,"context_line":"                    # existing image in glance wihch is not uploaded as *_alt"},{"line_number":131,"context_line":"                    image \u003d self._find_image(None, image_name[:-4])"},{"line_number":132,"context_line":"                    if image:"},{"line_number":133,"context_line":"                        path \u003d os.path.abspath(image_dest)"},{"line_number":134,"context_line":"                        if not os.path.isfile(path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cd3688e0","line":131,"in_reply_to":"5f7c97a3_ed1ca467","updated":"2018-07-26 09:51:14.000000000","message":"But I don\u0027t know what is before _alt .. this except should deal with only one situation as the comment above describes.","commit_id":"8116930c985fefd4e1abdf73b0a4031f40acfbbf"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b9e7f0caf8426a1711d71dbfdce71f12f970ca1d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    # existing image in glance which is not uploaded as *_alt"},{"line_number":131,"context_line":"                    if image_name[-4:] \u003d\u003d \"_alt\":"},{"line_number":132,"context_line":"                        image_name \u003d image_name[:-4]"},{"line_number":133,"context_line":"                    image \u003d self._find_image(None, image_name)"},{"line_number":134,"context_line":"                    if image:"},{"line_number":135,"context_line":"                        path \u003d os.path.abspath(image_dest)"},{"line_number":136,"context_line":"                        if not os.path.isfile(path):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2dce1c8f","line":133,"updated":"2018-07-26 10:03:18.000000000","message":"shouldn\u0027t this executed inside the if image_name[-4:0] \u003d\u003d \u0027_alt\u0027: \n?\nThe previous logic was:\nfind an image with the same name but the last 4 characters.\n\nNow the logic is:\nfind an image with the same name, or without _alt if the name ends with _alt.\n\nShouldn\u0027t the logic be:\nfind an image with the same name but the last 4 characters if it ends with _alt.\n\nUnless I missed the original purpose.","commit_id":"cea6ee2bf0b723271cf940d7480cdcad74d31569"}]}