)]}'
{"config_tempest/services/base.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1d5d846346f0eff840579a18aa83b53aa139445e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def set_extensions(self):"},{"line_number":68,"context_line":"        self.extensions \u003d []"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def set_versions(self):"},{"line_number":71,"context_line":"        self.versions \u003d []"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_extensions(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ba48a989","line":70,"updated":"2018-08-01 13:20:26.000000000","message":"I was wondering: what is the reason of having set_versions and get_versions here, for Service objects which are not VersionedServices?\n\nI\u0027m asking this because I\u0027m a bit confused between get_versions and get_supported_versions.\n\nThose functions could benefit from a bit of docstring.","commit_id":"56d9a3bd341ab65a6adbd26d178d3185c3cb6d90"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1d5d846346f0eff840579a18aa83b53aa139445e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def get_supported_versions(self):"},{"line_number":108,"context_line":"        return []"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def get_catalog(self):"},{"line_number":111,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_da4b2583","line":110,"updated":"2018-08-01 13:20:26.000000000","message":"This is introduced but never used. It should probably be defined for all services, or at least have a default value.","commit_id":"56d9a3bd341ab65a6adbd26d178d3185c3cb6d90"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"753d40d0d7dc8d9c4d499b12369e2bd29b078f42","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return self.name"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_feature_name(self):"},{"line_number":105,"context_line":"        \"\"\"Return the $service used in $service-feature-enabled."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        Some services have the -feature-enabled option in tempest, that"},{"line_number":108,"context_line":"        diverges from the service name. The main example is object-store"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_99a9e97c","line":105,"range":{"start_line":105,"start_character":22,"end_line":105,"end_character":40},"updated":"2018-08-07 14:47:23.000000000","message":"Why are dollars here? Maybe it\u0027s correct, but I don\u0027t get it.","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"75896ce7465eff8dca623d87dadbef012fb7c3f4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return self.name"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_feature_name(self):"},{"line_number":105,"context_line":"        \"\"\"Return the $service used in $service-feature-enabled."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        Some services have the -feature-enabled option in tempest, that"},{"line_number":108,"context_line":"        diverges from the service name. The main example is object-store"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_24274cb6","line":105,"range":{"start_line":105,"start_character":22,"end_line":105,"end_character":40},"in_reply_to":"3f79a3b5_79596d58","updated":"2018-08-07 14:56:37.000000000","message":"but why variable? there is no $service or $service-feature-enabled variable","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f443556be588815e5b06bf5e8cb6aff822440439","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        return self.name"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_feature_name(self):"},{"line_number":105,"context_line":"        \"\"\"Return the $service used in $service-feature-enabled."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        Some services have the -feature-enabled option in tempest, that"},{"line_number":108,"context_line":"        diverges from the service name. The main example is object-store"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_79596d58","line":105,"range":{"start_line":105,"start_character":22,"end_line":105,"end_character":40},"in_reply_to":"3f79a3b5_99a9e97c","updated":"2018-08-07 14:53:35.000000000","message":"$VAR like a variable","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"753d40d0d7dc8d9c4d499b12369e2bd29b078f42","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def get_unversioned_service_name(self):"},{"line_number":114,"context_line":"        \"\"\"Return name of service without versions."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        Some versions are versioned like volumev2 and volumev3, we try to"},{"line_number":117,"context_line":"        discover these services checking the supported versions, so we need"},{"line_number":118,"context_line":"        to know the unversioned service name for this."},{"line_number":119,"context_line":"        The default value is the name of the service."}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_99748937","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":21},"updated":"2018-08-07 14:47:23.000000000","message":"Probably \"services\" not \"versions\"","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f443556be588815e5b06bf5e8cb6aff822440439","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def get_unversioned_service_name(self):"},{"line_number":114,"context_line":"        \"\"\"Return name of service without versions."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        Some versions are versioned like volumev2 and volumev3, we try to"},{"line_number":117,"context_line":"        discover these services checking the supported versions, so we need"},{"line_number":118,"context_line":"        to know the unversioned service name for this."},{"line_number":119,"context_line":"        The default value is the name of the service."}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_5936f105","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":21},"in_reply_to":"3f79a3b5_99748937","updated":"2018-08-07 14:53:35.000000000","message":"Done","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"}],"config_tempest/services/services.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1d5d846346f0eff840579a18aa83b53aa139445e","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                supported_versions \u003d []"},{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                supported_versions \u003d service_object.get_versions()"},{"line_number":242,"context_line":"            # FIXME: object-store config param object-storage needs to be"},{"line_number":243,"context_line":"            # handled here In future this should be removed from Services class"},{"line_number":244,"context_line":"            if service \u003d\u003d \u0027object-store\u0027:"},{"line_number":245,"context_line":"                service \u003d \u0027object-storage\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_dac6c515","side":"PARENT","line":242,"updated":"2018-08-01 13:20:26.000000000","message":"this case is not handled anymore, and there are no methods inservices/object_storage.py  which exports this information","commit_id":"37b5e60948cb6cb07f022b293b29d4437e3aef9e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1637aea216400990fbd756d8e70cd3f56593c358","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        if keystone_v3_support:"},{"line_number":262,"context_line":"            self.get_service(\u0027identity\u0027).set_identity_v3_extensions()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        # TODO(arxcruz): We already have a service.feature_name so we don\u0027t"},{"line_number":265,"context_line":"        # need this special case in object-store"},{"line_number":266,"context_line":"        for service, ext_key in C.SERVICE_EXTENSION_KEY.iteritems():"},{"line_number":267,"context_line":"            if not self.is_service(service):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e0bd1067","line":264,"updated":"2018-08-01 14:29:17.000000000","message":"I guess that this TODO will be addressed with task 22730 ?","commit_id":"2593933e08b6dd5e800ab9a02495dd9e6e49a70e"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"257f23c1ee089538d123350ada23a8da90195816","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        if keystone_v3_support:"},{"line_number":262,"context_line":"            self.get_service(\u0027identity\u0027).set_identity_v3_extensions()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        # TODO(arxcruz): We already have a service.feature_name so we don\u0027t"},{"line_number":265,"context_line":"        # need this special case in object-store"},{"line_number":266,"context_line":"        for service, ext_key in C.SERVICE_EXTENSION_KEY.iteritems():"},{"line_number":267,"context_line":"            if not self.is_service(service):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_cb97d59b","line":264,"in_reply_to":"5f7c97a3_e0bd1067","updated":"2018-08-01 14:35:45.000000000","message":"Yes","commit_id":"2593933e08b6dd5e800ab9a02495dd9e6e49a70e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"753d40d0d7dc8d9c4d499b12369e2bd29b078f42","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        Looking for extensions from all versions of the service"},{"line_number":81,"context_line":"        defined by name and merges them to that provided service."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param name: Name of the service"},{"line_number":84,"context_line":"        :type name: string"},{"line_number":85,"context_line":"        :param versions: Supported versions"},{"line_number":86,"context_line":"        :type versions: list"},{"line_number":87,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_b97dc51d","line":84,"range":{"start_line":83,"start_character":7,"end_line":84,"end_character":26},"updated":"2018-08-07 14:47:23.000000000","message":"This needs to be changed too, it\u0027s not a string anymore, it\u0027s an object and the name of the parameter got changed too.","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f443556be588815e5b06bf5e8cb6aff822440439","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        Looking for extensions from all versions of the service"},{"line_number":81,"context_line":"        defined by name and merges them to that provided service."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param name: Name of the service"},{"line_number":84,"context_line":"        :type name: string"},{"line_number":85,"context_line":"        :param versions: Supported versions"},{"line_number":86,"context_line":"        :type versions: list"},{"line_number":87,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_19407956","line":84,"range":{"start_line":83,"start_character":7,"end_line":84,"end_character":26},"in_reply_to":"3f79a3b5_b97dc51d","updated":"2018-08-07 14:53:35.000000000","message":"Done","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"753d40d0d7dc8d9c4d499b12369e2bd29b078f42","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param name: Name of the service"},{"line_number":84,"context_line":"        :type name: string"},{"line_number":85,"context_line":"        :param versions: Supported versions"},{"line_number":86,"context_line":"        :type versions: list"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        versions \u003d service.get_supported_versions()"},{"line_number":89,"context_line":"        service_name \u003d service.get_unversioned_service_name()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_f9aa5d83","line":86,"range":{"start_line":85,"start_character":7,"end_line":86,"end_character":28},"updated":"2018-08-07 14:47:23.000000000","message":"This should be removed now","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f443556be588815e5b06bf5e8cb6aff822440439","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        :param name: Name of the service"},{"line_number":84,"context_line":"        :type name: string"},{"line_number":85,"context_line":"        :param versions: Supported versions"},{"line_number":86,"context_line":"        :type versions: list"},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        versions \u003d service.get_supported_versions()"},{"line_number":89,"context_line":"        service_name \u003d service.get_unversioned_service_name()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_b924e5c7","line":86,"range":{"start_line":85,"start_character":7,"end_line":86,"end_character":28},"in_reply_to":"3f79a3b5_f9aa5d83","updated":"2018-08-07 14:53:35.000000000","message":"Done","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"}],"config_tempest/services/volume.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"753d40d0d7dc8d9c4d499b12369e2bd29b078f42","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return [\u0027v2\u0027, \u0027v3\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_catalog(self):"},{"line_number":40,"context_line":"        return \u0027volumev3\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_feature_name(self):"},{"line_number":43,"context_line":"        return \u0027volume\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_79764d09","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":25},"updated":"2018-08-07 14:47:23.000000000","message":"In the doc string of get_catalog method is mentioned, that we have volume, volumev2 and volumev3 .. so why is this statically set to volumev3? If volume service can have more names, this should return a value of an variable which is set dynamically .. or I\u0027m missing something.","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"f443556be588815e5b06bf5e8cb6aff822440439","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return [\u0027v2\u0027, \u0027v3\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_catalog(self):"},{"line_number":40,"context_line":"        return \u0027volumev3\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_feature_name(self):"},{"line_number":43,"context_line":"        return \u0027volume\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_d90a0125","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":25},"in_reply_to":"3f79a3b5_79764d09","updated":"2018-08-07 14:53:35.000000000","message":"You are missing something. From what I saw, you have in the catalog both volume and volumev3, however, the one working properly is volumev3 that inherit from VolumeService, volume is inherit from Service, that is a dummy service right now when we don\u0027t find the proper class. With this i\u0027m ensuring that the proper catalog is being returned for volume","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"75896ce7465eff8dca623d87dadbef012fb7c3f4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        return [\u0027v2\u0027, \u0027v3\u0027]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def get_catalog(self):"},{"line_number":40,"context_line":"        return \u0027volumev3\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def get_feature_name(self):"},{"line_number":43,"context_line":"        return \u0027volume\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f79a3b5_a4603cd0","line":40,"range":{"start_line":40,"start_character":15,"end_line":40,"end_character":25},"in_reply_to":"3f79a3b5_d90a0125","updated":"2018-08-07 14:56:37.000000000","message":"ok, makes sense","commit_id":"a17e212a6904fbac2169b2379064829f9d4cdfda"}]}