)]}'
{"config_tempest/services/services.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fc21e5113cafa99a00392840cd7f30edb9a48e4b","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                extensions \u003d \u0027,\u0027.join(service_object.get_extensions())"},{"line_number":270,"context_line":"            # FIXME: object-store config param object-storage needs to be"},{"line_number":271,"context_line":"            # handled here In future this should be removed from Services class"},{"line_number":272,"context_line":"            if service \u003d\u003d \u0027object-store\u0027:"},{"line_number":273,"context_line":"                service \u003d \u0027object-storage\u0027"},{"line_number":274,"context_line":"            service_name \u003d service_object.get_unversioned_service_name()"},{"line_number":275,"context_line":"            self._conf.set(service_name + postfix, ext_key, extensions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5c680a20","side":"PARENT","line":272,"updated":"2018-08-08 10:36:37.000000000","message":"Do I understand it correctly that this \"if\" could have been removed in the previous change and the usage of service_object.get_unversioned_service_name makes it useless?","commit_id":"b0b8a9a6bb4347be83addb0059c93a370225c307"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"70008c43a6aab6762caf2f153fe96df0ec4ced5f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                extensions \u003d \u0027,\u0027.join(service_object.get_extensions())"},{"line_number":270,"context_line":"            # FIXME: object-store config param object-storage needs to be"},{"line_number":271,"context_line":"            # handled here In future this should be removed from Services class"},{"line_number":272,"context_line":"            if service \u003d\u003d \u0027object-store\u0027:"},{"line_number":273,"context_line":"                service \u003d \u0027object-storage\u0027"},{"line_number":274,"context_line":"            service_name \u003d service_object.get_unversioned_service_name()"},{"line_number":275,"context_line":"            self._conf.set(service_name + postfix, ext_key, extensions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c8d3f437","side":"PARENT","line":272,"in_reply_to":"3f79a3b5_5c680a20","updated":"2018-08-08 13:08:26.000000000","message":"Yes, but i didn\u0027t wanted to touch here because I had the plan to remove it on this patch. Also, it was my mistake I use get_unversioned_service_name here, should be get_feature_name","commit_id":"b0b8a9a6bb4347be83addb0059c93a370225c307"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fc21e5113cafa99a00392840cd7f30edb9a48e4b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return extensions"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def set_service_extensions(self):"},{"line_number":253,"context_line":"        postfix \u003d \"-feature-enabled\""},{"line_number":254,"context_line":"        try:"},{"line_number":255,"context_line":"            keystone_v3_support \u003d self._conf.getboolean(\u0027identity\u0027 + postfix,"},{"line_number":256,"context_line":"                                                        \u0027api_v3\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_7c8386cd","line":253,"updated":"2018-08-08 10:36:37.000000000","message":"(unrelated to this change, just as reminder: shouldn\u0027t this code move to IdentityService.get_extensions() ?)","commit_id":"3cc109c93038fb89e7505cd9e3273b970a863094"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"70008c43a6aab6762caf2f153fe96df0ec4ced5f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        return extensions"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def set_service_extensions(self):"},{"line_number":253,"context_line":"        postfix \u003d \"-feature-enabled\""},{"line_number":254,"context_line":"        try:"},{"line_number":255,"context_line":"            keystone_v3_support \u003d self._conf.getboolean(\u0027identity\u0027 + postfix,"},{"line_number":256,"context_line":"                                                        \u0027api_v3\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a85d58ea","line":253,"in_reply_to":"3f79a3b5_7c8386cd","updated":"2018-08-08 13:08:26.000000000","message":"Done","commit_id":"3cc109c93038fb89e7505cd9e3273b970a863094"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fc21e5113cafa99a00392840cd7f30edb9a48e4b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            extensions \u003d \u0027,\u0027.join(service.get_extensions())"},{"line_number":264,"context_line":"            service_name \u003d service.get_feature_name()"},{"line_number":265,"context_line":"            ext_key \u003d service.get_service_extension_key()"},{"line_number":266,"context_line":"            if ext_key:"},{"line_number":267,"context_line":"                self._conf.set(service_name + postfix, ext_key, extensions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bcf03e69","line":266,"updated":"2018-08-08 10:36:37.000000000","message":"can\u0027t we check first service.get_service_extension_key and continue the loop only if defined?\n\nSomething like:\nfor service in self._services:\n    ext_key \u003d service.get_service_extension_key()\n    if not ext_key:\n       continue\n    extensions \u003d \u0027,\u0027.join(service.get_extensions())\n    service_name \u003d service.get_feature_name()\n    self._conf.set(service_name + postfix, ext_key, extensions)    \n\n(or the other way, if ext_key: extensions \u003d ....)","commit_id":"3cc109c93038fb89e7505cd9e3273b970a863094"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"70008c43a6aab6762caf2f153fe96df0ec4ced5f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            extensions \u003d \u0027,\u0027.join(service.get_extensions())"},{"line_number":264,"context_line":"            service_name \u003d service.get_feature_name()"},{"line_number":265,"context_line":"            ext_key \u003d service.get_service_extension_key()"},{"line_number":266,"context_line":"            if ext_key:"},{"line_number":267,"context_line":"                self._conf.set(service_name + postfix, ext_key, extensions)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a8e0f8fb","line":266,"in_reply_to":"3f79a3b5_bcf03e69","updated":"2018-08-08 13:08:26.000000000","message":"Better indeed.","commit_id":"3cc109c93038fb89e7505cd9e3273b970a863094"}]}