)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"62ee233c5a15305bd0e48eeb5d411b6c94e98108","unresolved":false,"context_lines":[{"line_number":17,"context_line":"service\u0027s versions into account when setting service"},{"line_number":18,"context_line":"availability."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Story: 2003550"},{"line_number":21,"context_line":"Task: 29596"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ica42fe6ae57eaef6bffd28b557f6b178a2ed8fb9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9fdfeff1_3f6058a5","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":11},"updated":"2019-02-26 12:48:32.000000000","message":"Story: 2002787\nTask: 29632","commit_id":"5bfed53c9f93d110575522223215ffd28ec5de0c"}],"config_tempest/constants.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"34dba4e3ae9eafe22c6aec5c82bc7b0449daf087","unresolved":false,"context_lines":[{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# services and their codenames"},{"line_number":47,"context_line":"SERVICE_NAMES \u003d {"},{"line_number":48,"context_line":"    \u0027baremetal\u0027: \u0027ironic\u0027,"},{"line_number":49,"context_line":"    \u0027compute\u0027: \u0027nova\u0027,"},{"line_number":50,"context_line":"    \u0027database\u0027: \u0027trove\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_a4d3e100","side":"PARENT","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":13},"updated":"2019-02-26 12:18:22.000000000","message":"if the services are removed, they will not be set to False under [service_available] section if they are not present in the system ... but that shouldn\u0027t be a problem.","commit_id":"be87a3a5cb8f51baa18d30b19f9ea5e2eef83d57"}],"config_tempest/services/base.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"aff4fee3c8b173145c8b5fd88c5ca0a782acb5fc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.versions \u003d []"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @staticmethod"},{"line_number":74,"context_line":"    def set_availability(conf, available):"},{"line_number":75,"context_line":"        \"\"\"Sets service\u0027s availability."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        By implementing this method service\u0027s codename will be set to"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_3711cab0","line":74,"updated":"2019-03-05 13:51:26.000000000","message":"Why do we need a method that needs to be redefined?\n\nDo you think that there could be implementations different from \n\nconf.set(\u0027service_available\u0027, somename, str(available))\n\n?","commit_id":"7aec6af04d78d31c94200addac200381039b840e"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fc125e79021ce622daa5a09e4e3ccd687dd35501","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.versions \u003d []"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @staticmethod"},{"line_number":74,"context_line":"    def set_availability(conf, available):"},{"line_number":75,"context_line":"        \"\"\"Sets service\u0027s availability."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        By implementing this method service\u0027s codename will be set to"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_527b3cf3","line":74,"in_reply_to":"9fdfeff1_175e0676","updated":"2019-03-05 14:44:15.000000000","message":"oh, I\u0027ve rewritten it multiple times, so I missed this.","commit_id":"7aec6af04d78d31c94200addac200381039b840e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"41c04a8a494435d79f5d9d820a70cf051533bacc","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.versions \u003d []"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @staticmethod"},{"line_number":74,"context_line":"    def set_availability(conf, available):"},{"line_number":75,"context_line":"        \"\"\"Sets service\u0027s availability."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        By implementing this method service\u0027s codename will be set to"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_175e0676","line":74,"in_reply_to":"9fdfeff1_3711cab0","updated":"2019-03-05 13:55:25.000000000","message":"I see the aodh case. But even with that in mind:\n- the default implementation should work, and it should be overwritten only in specific cases;\n- it is possible to write a generic implementation that considers also that case\n(loop through the output of get_service_names, set the requested value).","commit_id":"7aec6af04d78d31c94200addac200381039b840e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"cb87b70c02b0f829d89f8f3f9fa43b1119188910","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        [service_available] section in tempest.conf during the services"},{"line_number":78,"context_line":"        discovery process."},{"line_number":79,"context_line":"        \"\"\""},{"line_number":80,"context_line":"        name \u003d self.get_service_name()[0]"},{"line_number":81,"context_line":"        conf.set(\u0027service_available\u0027, name, str(available))"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def get_extensions(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fdfeff1_d2072c1d","line":80,"updated":"2019-03-05 14:56:08.000000000","message":"I see that the get_service_name is not the best choice (as the list of service names in the service catalog does not match the name set there).\n\nI also noticed that get_catalog is not used at all; the value does not match the value that we need, but maybe it can be re-purposed for this? Or maybe another, new method?","commit_id":"1f0a5d07309bf7c3369df476e89324651e695c94"}]}