)]}'
{"config_tempest/services/alarming.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee5160f7bea799eb7c3128506bdbd7b072c4050b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class AlarmingService(Service):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def set_availability(self, conf, available):"},{"line_number":22,"context_line":"        # TODO(arxcruz): Remove this once/if we get the following reviews"},{"line_number":23,"context_line":"        # merged in all branches supported by tempestconf, or once/if"},{"line_number":24,"context_line":"        # tempestconf do not support anymore the OpenStack release where"},{"line_number":25,"context_line":"        # those patches are not available."},{"line_number":26,"context_line":"        # https://review.openstack.org/#/c/492526/"},{"line_number":27,"context_line":"        # https://review.openstack.org/#/c/492525/"},{"line_number":28,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh\u0027, str(available))"},{"line_number":29,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh_plugin\u0027, str(available))"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_f1e352d7","line":27,"range":{"start_line":22,"start_character":7,"end_line":27,"end_character":50},"updated":"2019-03-05 12:06:16.000000000","message":"@arx @mkopec, can we remove these stuff as telemetry-tempest-plugin-0.2.0 is available till queens, so I think we donot need to carry it.","commit_id":"239758eca410190557d522f69c7cd95d314a142d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"ee5160f7bea799eb7c3128506bdbd7b072c4050b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # https://review.openstack.org/#/c/492526/"},{"line_number":27,"context_line":"        # https://review.openstack.org/#/c/492525/"},{"line_number":28,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh\u0027, str(available))"},{"line_number":29,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh_plugin\u0027, str(available))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def get_service_name():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_11e936b6","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":68},"updated":"2019-03-05 12:06:16.000000000","message":"Same as above.","commit_id":"239758eca410190557d522f69c7cd95d314a142d"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"98ebe24d99d8c33b4221aa74cf2d2d54232e2e6d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # https://review.openstack.org/#/c/492526/"},{"line_number":27,"context_line":"        # https://review.openstack.org/#/c/492525/"},{"line_number":28,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh\u0027, str(available))"},{"line_number":29,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh_plugin\u0027, str(available))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def get_service_name():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b1d70ac1","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":68},"in_reply_to":"9fdfeff1_1137f64f","updated":"2019-03-05 12:21:08.000000000","message":"it is available in telemetry-tempest-plugin 0.2.0 https://github.com/openstack/telemetry-tempest-plugin/blob/0.2.0/telemetry_tempest_plugin/config.py#L31 and in rdoinfo:\nhttps://github.com/redhat-openstack/rdoinfo/blob/master/tags/queens.yml#L1042\n\nI am fine with separate patch.","commit_id":"239758eca410190557d522f69c7cd95d314a142d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fa801146ff5b993e7ba39bd4208279048a71628","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # https://review.openstack.org/#/c/492526/"},{"line_number":27,"context_line":"        # https://review.openstack.org/#/c/492525/"},{"line_number":28,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh\u0027, str(available))"},{"line_number":29,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh_plugin\u0027, str(available))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def get_service_name():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_1137f64f","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":68},"in_reply_to":"9fdfeff1_11e936b6","updated":"2019-03-05 12:13:39.000000000","message":"We can, but if so, it will be in a different review - in case we want to backport this review to queens.\n\nI see, the option is deprecated now:\nhttps://github.com/openstack/telemetry-tempest-plugin/blob/7f0e315a78df17d981ed86ebddf87759cd97eedf/telemetry_tempest_plugin/config.py#L31\n\nDo you know which version of the package has the option deprecated? Is telemetry-tempest-plugin-0.2.0 the last version which supported aodh_plugin option? I don\u0027t know how to verify it.","commit_id":"239758eca410190557d522f69c7cd95d314a142d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"79c7310e1ed312acd124efdbf32c9c6f260afec0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # https://review.openstack.org/#/c/492526/"},{"line_number":27,"context_line":"        # https://review.openstack.org/#/c/492525/"},{"line_number":28,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh\u0027, str(available))"},{"line_number":29,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh_plugin\u0027, str(available))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def get_service_name():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b10aaa24","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":68},"in_reply_to":"9fdfeff1_b1738ae8","updated":"2019-03-05 12:31:53.000000000","message":"https://review.openstack.org/#/c/640998/","commit_id":"239758eca410190557d522f69c7cd95d314a142d"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"5cda90ac73ddb2cd1d653cbb7fd5660b6f3f216f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        # https://review.openstack.org/#/c/492526/"},{"line_number":27,"context_line":"        # https://review.openstack.org/#/c/492525/"},{"line_number":28,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh\u0027, str(available))"},{"line_number":29,"context_line":"        conf.set(\u0027service_available\u0027, \u0027aodh_plugin\u0027, str(available))"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @staticmethod"},{"line_number":32,"context_line":"    def get_service_name():"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_b1738ae8","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":68},"in_reply_to":"9fdfeff1_b1d70ac1","updated":"2019-03-05 12:26:13.000000000","message":"oh, so it\u0027s deprecated even in queens, good, but I\u0027d still rather create a new review.","commit_id":"239758eca410190557d522f69c7cd95d314a142d"}]}