)]}'
{"config_tempest/flavors.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b5cf5c38ee5e78b8b692f74e916b1ab76127afd2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                               no_rng\u003dpref[\u0027no_rng\u0027])"},{"line_number":71,"context_line":"                self._conf.set(\u0027compute\u0027, pref[\u0027key\u0027], flavor_id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if conf.has_option(\u0027service_available\u0027, \u0027heat\u0027):"},{"line_number":74,"context_line":"            if conf.get_bool_value(conf.get(\u0027service_available\u0027, \u0027heat\u0027)):"},{"line_number":75,"context_line":"                conf.set(\u0027heat_plugin\u0027, \u0027minimal_instance_type\u0027,"},{"line_number":76,"context_line":"                         conf.get(\u0027compute\u0027, \u0027flavor_ref\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_2157b103","line":73,"updated":"2019-04-09 22:05:51.000000000","message":"isn\u0027t it possible to move this code inside config_tempest/services/orchestration.py somehow? A new hook?","commit_id":"0e7a18c58fb35f0e741c6dbf6c9b788051f13707"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f16d848a3700f371517567ba7eecf370fb1c168e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                                               no_rng\u003dpref[\u0027no_rng\u0027])"},{"line_number":71,"context_line":"                self._conf.set(\u0027compute\u0027, pref[\u0027key\u0027], flavor_id)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if conf.has_option(\u0027service_available\u0027, \u0027heat\u0027):"},{"line_number":74,"context_line":"            if conf.get_bool_value(conf.get(\u0027service_available\u0027, \u0027heat\u0027)):"},{"line_number":75,"context_line":"                conf.set(\u0027heat_plugin\u0027, \u0027minimal_instance_type\u0027,"},{"line_number":76,"context_line":"                         conf.get(\u0027compute\u0027, \u0027flavor_ref\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_010b957c","line":73,"in_reply_to":"5fc1f717_2157b103","updated":"2019-04-09 22:34:52.000000000","message":"I was thinking about it, but the new code requires to have already compute.flavor_ref set, so the code can be executed only after this line [1].\nWe already have a code which has similar problem (needs to be executed almost at the end) and it\u0027s located here [2][3]\nSo what we could do is to move this new code to flavors.py file and call it from set_service_availability method - in that case we could rename the method to something more clear like, post_configuration_services or something like that.\nWhat do you think?\n\n[1] https://github.com/openstack/python-tempestconf/blob/fa359b84c33abf76df39d5918d16e0b20daf9149/config_tempest/main.py#L532\n\n[2] https://github.com/openstack/python-tempestconf/blob/fa359b84c33abf76df39d5918d16e0b20daf9149/config_tempest/main.py#L539\n\n[3] https://github.com/openstack/python-tempestconf/blob/fa359b84c33abf76df39d5918d16e0b20daf9149/config_tempest/services/services.py#L224","commit_id":"0e7a18c58fb35f0e741c6dbf6c9b788051f13707"}],"config_tempest/services/image.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"b5cf5c38ee5e78b8b692f74e916b1ab76127afd2","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        conf.set(\u0027compute\u0027, \u0027image_ref\u0027, image_id)"},{"line_number":114,"context_line":"        conf.set(\u0027compute\u0027, \u0027image_ref_alt\u0027, alt_image_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if conf.has_option(\u0027service_available\u0027, \u0027heat\u0027):"},{"line_number":117,"context_line":"            if conf.get_bool_value(conf.get(\u0027service_available\u0027, \u0027heat\u0027)):"},{"line_number":118,"context_line":"                conf.set(\u0027heat_plugin\u0027, \u0027minimal_image_ref\u0027, image_id)"},{"line_number":119,"context_line":"                conf.set(\u0027heat_plugin\u0027, \u0027image_ref\u0027, alt_image_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_e13c49c0","line":116,"updated":"2019-04-09 22:05:51.000000000","message":"see above","commit_id":"0e7a18c58fb35f0e741c6dbf6c9b788051f13707"}]}