)]}'
{"config_tempest/flavors.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"35cdc954044bf8732b281f3290f146b415bf9d48","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                flavor_id \u003d self.create_flavor(pref[\u0027name\u0027], ram\u003dpref[\u0027ram\u0027])"},{"line_number":69,"context_line":"                self._conf.set(\u0027compute\u0027, pref[\u0027key\u0027], flavor_id)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def create_flavor(self, flavor_name, ram\u003d64, vcpus\u003d1):"},{"line_number":72,"context_line":"        \"\"\"Create flavors or try to discover two smallest ones available."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        :param flavor_name: flavor name to be created (usually m1.nano or"}],"source_content_type":"text/x-python","patch_set":5,"id":"5fc1f717_8df0fdfe","line":71,"updated":"2019-03-28 09:08:08.000000000","message":"what is the purpose of keeping the \u0027ram\u0027 parameters? I\u0027d say: leave the parameter also for the disk, so that this method  takes all external parameters - or change it to use all internal ones (from self), otherwise it\u0027s difficult to follow which parameter comes from where.","commit_id":"8dbaac19ee72478338c487fe6c14c9773a1a4746"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"09618d4af54835d4e6b0c38ead0233d8de505c9b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            C.LOG.info(\"Creating flavor \u0027%s\u0027\", flavor_name)"},{"line_number":88,"context_line":"            resp \u003d self.client.create_flavor(name\u003dflavor_name,"},{"line_number":89,"context_line":"                                             ram\u003dram, vcpus\u003dvcpus,"},{"line_number":90,"context_line":"                                             disk\u003dself.min_disk, id\u003dNone)"},{"line_number":91,"context_line":"            return resp[\u0027flavor\u0027][\u0027id\u0027]"},{"line_number":92,"context_line":"        else:"},{"line_number":93,"context_line":"            if len(self.flavor_list) \u003c 2:"}],"source_content_type":"text/x-python","patch_set":7,"id":"5fc1f717_36e835e0","line":90,"range":{"start_line":90,"start_character":50,"end_line":90,"end_character":55},"updated":"2019-03-28 15:23:23.000000000","message":"self is not supposed to be here\n\nbased on the current design, create_flavor is called in a loop and the only parameter which changes is the ram one - that\u0027s why it needs to be there - to have it unified, let\u0027s keep all values needed for creating a flavor as arguments .. so, I\u0027m gonna remove \"self.\" from line 90, will it be ok then?","commit_id":"ed27bfdf1aa4d06330cf1c9f3ef86e72c5a7976d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8c7e3b65e0e7229a6ce330410a25e217b23efba7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self._conf \u003d conf"},{"line_number":33,"context_line":"        self.no_rng \u003d no_rng"},{"line_number":34,"context_line":"        self.flavor_list \u003d self.client.list_flavors()[\u0027flavors\u0027]"},{"line_number":35,"context_line":"        self.min_memory \u003d min_memory"},{"line_number":36,"context_line":"        if min_memory \u003d\u003d C.DEFAULT_FLAVOR_RAM:"},{"line_number":37,"context_line":"            self.min_memory_alt \u003d C.DEFAULT_FLAVOR_RAM_ALT"},{"line_number":38,"context_line":"            self.name \u003d \u0027m1.nano\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_ff683021","line":35,"updated":"2019-03-29 09:31:39.000000000","message":"now that you have save all those values inside self.prefs, do you still need to set self.min_memory, self.min_memory_alt, self.name, self.name_alt, self.min_disk? You can refer to prefs values. You can also store the disk value.","commit_id":"80f377ab8affe5dd792d0f341e6f4a3593721e5f"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8c7e3b65e0e7229a6ce330410a25e217b23efba7","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        If \u0027flavor_ref\u0027 and \u0027flavor_ref_alt\u0027 are specified in conf, it will"},{"line_number":56,"context_line":"        try to find them, if not found, it raises an Exception."},{"line_number":57,"context_line":"        Otherwise it will try finding or creating self.name and self.name_alt"},{"line_number":58,"context_line":"        flavors and set their ids in conf."},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        for pref in self.prefs:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_7f668053","line":57,"updated":"2019-03-29 09:31:39.000000000","message":"see above - I\u0027d change this to \"the required base flavors (m1.name and m1.micro by default) and...\"","commit_id":"80f377ab8affe5dd792d0f341e6f4a3593721e5f"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8c7e3b65e0e7229a6ce330410a25e217b23efba7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            else:"},{"line_number":69,"context_line":"                flavor_id \u003d self.create_flavor(pref[\u0027name\u0027], pref[\u0027ram\u0027],"},{"line_number":70,"context_line":"                                               C.DEFAULT_FLAVOR_VCPUS,"},{"line_number":71,"context_line":"                                               self.min_disk,"},{"line_number":72,"context_line":"                                               no_rng\u003dself.no_rng)"},{"line_number":73,"context_line":"                self._conf.set(\u0027compute\u0027, pref[\u0027key\u0027], flavor_id)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5fc1f717_3f5c787b","line":71,"updated":"2019-03-29 09:31:39.000000000","message":"just use pref[\u0027disk\u0027] after storing it inside prefs.","commit_id":"80f377ab8affe5dd792d0f341e6f4a3593721e5f"}]}