)]}'
{"id":"openinfra%2Fpython-tempestconf~660606","triplet_id":"openinfra%2Fpython-tempestconf~master~I97d821c3f141da7d21fc1a4b7f4e1af0c957f9f8","project":"openinfra/python-tempestconf","branch":"master","topic":"fix_stuff","hashtags":[],"change_id":"I97d821c3f141da7d21fc1a4b7f4e1af0c957f9f8","subject":"Donot remove auth.tempest_roles section","status":"ABANDONED","created":"2019-05-22 08:38:29.000000000","updated":"2019-05-23 07:22:55.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f6803665f293cd3287679957c4625aa5ae82963a","_number":660606,"virtual_id_number":660606,"owner":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"date":"2019-05-22 08:43:30.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":1,"date":"2019-05-22 10:24:25.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2019-05-22 10:59:21.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"all":[{"value":-1,"date":"2019-05-22 09:57:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-22 08:43:30.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2019-05-22 09:57:35.000000000","updated_by":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"reviewer":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"state":"REVIEWER"},{"updated":"2019-05-22 10:24:25.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-05-22 10:59:21.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8a429696c7ce19f0a3c75a5bae27d89208d95df6","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2019-05-22 08:38:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f74806fc3385809f278eb4f28f0474e0e88db55b","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-05-22 08:43:30.000000000","message":"Patch Set 1:\n\nShouldn\u0027t the issue be caught by a unit test?","accounts_in_message":[],"_revision_number":1},{"id":"6b02c6e6753728c1b68b23eaf5eb0fac5bcb161d","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2019-05-22 09:42:13.000000000","message":"Patch Set 1:\n\nAlso according the comment in the code, the role is removed only when it doesn\u0027t exist in the system. Are you sure, the role which was set by user (the failing job) exists in the environment?","accounts_in_message":[],"_revision_number":1},{"id":"817ef4a32f40fff405bfdf5684efec822b1e68fd","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2019-05-22 09:55:27.000000000","message":"Patch Set 1:\n\nThen I don\u0027t think this change will resolve this [1] issue. If you check the error occurred in the beginning of the if statement, so removing code inside the if statement can\u0027t help.\n\n[1] https://logs.rdoproject.org/32/20832/5/check/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset030-queens/e11e2cd/logs/undercloud/home/zuul/tempest.log.txt.gz#_2019-05-22_07_38_27","accounts_in_message":[],"_revision_number":1},{"id":"418bcdca2f4aa7d2cc4c35693ee6d22ca451d7b2","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2019-05-22 09:57:35.000000000","message":"Patch Set 1: Code-Review-1\n\nbased on the above comments and missing bug I\u0027m giving -1 for now","accounts_in_message":[],"_revision_number":1},{"id":"0a9face7ac622503a61a3fb5f4a6ab7530aa6180","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-22 10:24:25.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/06/660606/1/check/openstack-tox-cover/5cef137/cover/ : SUCCESS in 4m 35s\n- openstack-tox-pep8 http://logs.openstack.org/06/660606/1/check/openstack-tox-pep8/600f8c2/ : SUCCESS in 5m 27s\n- openstack-tox-py27 http://logs.openstack.org/06/660606/1/check/openstack-tox-py27/bc4fa99/ : SUCCESS in 5m 34s\n- openstack-tox-py35 http://logs.openstack.org/06/660606/1/check/openstack-tox-py35/5778f31/ : SUCCESS in 9m 27s\n- openstack-tox-py36 http://logs.openstack.org/06/660606/1/check/openstack-tox-py36/c16ddd0/ : SUCCESS in 5m 24s\n- openstack-tox-py37 http://logs.openstack.org/06/660606/1/check/openstack-tox-py37/ad9f14a/ : SUCCESS in 6m 33s\n- openstack-tox-docs http://logs.openstack.org/06/660606/1/check/openstack-tox-docs/f2210e2/html/ : SUCCESS in 3m 57s\n- python-tempestconf-tempest-devstack-admin http://logs.openstack.org/06/660606/1/check/python-tempestconf-tempest-devstack-admin/c3c3dd5/ : SUCCESS in 33m 46s\n- python-tempestconf-tempest-devstack-admin-py3 http://logs.openstack.org/06/660606/1/check/python-tempestconf-tempest-devstack-admin-py3/a3ce09a/ : SUCCESS in 38m 53s\n- python-tempestconf-tempest-devstack-demo http://logs.openstack.org/06/660606/1/check/python-tempestconf-tempest-devstack-demo/8873b66/ : SUCCESS in 48m 23s\n- python-tempestconf-tempest-devstack-demo-py3 http://logs.openstack.org/06/660606/1/check/python-tempestconf-tempest-devstack-demo-py3/865bf58/ : SUCCESS in 37m 25s\n- python-tempestconf-tempest-packstack-admin http://logs.openstack.org/06/660606/1/check/python-tempestconf-tempest-packstack-admin/2c7321f/ : SUCCESS in 1h 24m 49s\n- python-tempestconf-tempest-packstack-demo http://logs.openstack.org/06/660606/1/check/python-tempestconf-tempest-packstack-demo/799f781/ : SUCCESS in 1h 34m 42s\n- tripleo-ci-centos-7-scenario002-standalone http://logs.openstack.org/06/660606/1/check/tripleo-ci-centos-7-scenario002-standalone/0fa0653/ : SUCCESS in 1h 40m 49s\n- tripleo-ci-centos-7-standalone-os-tempest http://logs.openstack.org/06/660606/1/check/tripleo-ci-centos-7-standalone-os-tempest/ebd0515/ : SUCCESS in 1h 12m 20s\n- refstack-client-devstack-tempestconf http://logs.openstack.org/06/660606/1/check/refstack-client-devstack-tempestconf/c9a358f/ : SUCCESS in 48m 11s","accounts_in_message":[],"_revision_number":1},{"id":"2c1985d074d0418b508bc3b87bfaea81e8a3fc51","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-05-22 10:59:21.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/06/660606/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/70a0d96/ : FAILURE in 2h 19m 50s","accounts_in_message":[],"_revision_number":1},{"id":"3a74756dfe62e1233442fdae082f4e1ad19e5f04","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2019-05-22 15:16:17.000000000","message":"Patch Set 1:\n\nI believe the root cause will be fixed by https://review.opendev.org/#/c/660748/, see story https://storyboard.openstack.org/#!/story/2005758","accounts_in_message":[],"_revision_number":1},{"id":"e8b061ceebafa3ab89b6e41b5631604027c8d7ea","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2019-05-23 07:22:55.000000000","message":"Abandoned\n\nnot needed","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"553d754f1ce9658c797d389ffcbeaa518d318001","revisions":{"553d754f1ce9658c797d389ffcbeaa518d318001":{"kind":"REWORK","_number":1,"created":"2019-05-22 08:38:29.000000000","uploader":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"ref":"refs/changes/06/660606/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openinfra/python-tempestconf","ref":"refs/changes/06/660606/1","commands":{"Checkout":"git fetch https://review.opendev.org/openinfra/python-tempestconf refs/changes/06/660606/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openinfra/python-tempestconf refs/changes/06/660606/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openinfra/python-tempestconf refs/changes/06/660606/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openinfra/python-tempestconf refs/changes/06/660606/1"}}},"commit":{"parents":[{"commit":"e0d5dd6725f9a21090cae69a12bf087004a17e13","subject":"Merge \"Fix no _member_ role found\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openinfra/python-tempestconf/commit/e0d5dd6725f9a21090cae69a12bf087004a17e13"}]}],"author":{"name":"Chandan Kumar (raukadah)","email":"chkumar@redhat.com","date":"2019-05-22 08:34:46.000000000","tz":330},"committer":{"name":"Chandan Kumar (raukadah)","email":"chkumar@redhat.com","date":"2019-05-22 08:38:25.000000000","tz":330},"subject":"Donot remove auth.tempest_roles section","message":"Donot remove auth.tempest_roles section\n\nCurrently python-tempestconf looks for member role, then sets\nthe value of auth.tempest_roles if tempest_roles is not found\nit removes the section from tempest.conf which leads to\nNoOptionError failure while generating tempest.conf.\n\nSince in tempest/config.py, auth.tempest_roles is a empty list\nit does not make any sense to remove it as it is empty.\n\nRemoving the same piece of code fixes the issue.\n\nChange-Id: I97d821c3f141da7d21fc1a4b7f4e1af0c957f9f8\nSigned-off-by: Chandan Kumar (raukadah) \u003cchkumar@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openinfra/python-tempestconf/commit/553d754f1ce9658c797d389ffcbeaa518d318001"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openinfra/python-tempestconf/commit/553d754f1ce9658c797d389ffcbeaa518d318001"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}