)]}'
{"config_tempest/tests/test_users.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"bc6ea4781d887b612fa87a48681c2fa369f7b9d8","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            username\u003dself.username,"},{"line_number":302,"context_line":"            role_name\u003dself.role_name)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _check_user_roles(self, user_roles, system_roles):"},{"line_number":305,"context_line":"        self.Service._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, user_roles)"},{"line_number":306,"context_line":"        return self.Service.check_user_roles(system_roles)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_58f8e247","line":304,"updated":"2019-05-24 16:39:10.000000000","message":"It looks to me like no one of the new tests checks what happens when there are more roles (but maybe it\u0027s not needed) or a smaller edge case (\u0027Member\u0027 but no \u0027member\u0027) - do I read the code correctly?","commit_id":"f30365f109fbcab7eaa9cb49fb061c86f4fefbcd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"aade7fae12578f277991ff35db16953c1f0c03e4","unresolved":false,"context_lines":[{"line_number":301,"context_line":"            username\u003dself.username,"},{"line_number":302,"context_line":"            role_name\u003dself.role_name)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _check_user_roles(self, user_roles, system_roles):"},{"line_number":305,"context_line":"        self.Service._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, user_roles)"},{"line_number":306,"context_line":"        return self.Service.check_user_roles(system_roles)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bfb3d3c7_f9a19147","line":304,"in_reply_to":"bfb3d3c7_58f8e247","updated":"2019-05-26 16:47:56.000000000","message":"Yes, you\u0027re right.","commit_id":"f30365f109fbcab7eaa9cb49fb061c86f4fefbcd"}],"config_tempest/users.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"475ee6fbd02ec0ba62eaf053d1415ac5c362b7a7","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        if len(available_roles) \u003d\u003d 0:"},{"line_number":112,"context_line":"            # try \u0027member\u0027, usually it\u0027s present in a system"},{"line_number":113,"context_line":"            if \u0027member\u0027 in roles_names:"},{"line_number":114,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \u0027member\u0027)"},{"line_number":115,"context_line":"            else:"},{"line_number":116,"context_line":"                # the default role/role given by user or \u0027member\u0027 role are not"},{"line_number":117,"context_line":"                # present in the system, remove the option completely"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_5d5fa271","line":114,"range":{"start_line":113,"start_character":12,"end_line":114,"end_character":65},"updated":"2019-05-22 16:02:59.000000000","message":"I would look for both member and Member roles.","commit_id":"e9ca16bf6edfe06061dd22260e4b9c5e75bea852"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2d898ac0b5d8f7cfc98f199d76b4c4d2a0e43cb0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :rtype: list"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        roles_names \u003d [r[\u0027name\u0027] for r in roles[\u0027roles\u0027]]"},{"line_number":100,"context_line":"        user_roles \u003d self._conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)"},{"line_number":101,"context_line":"        available_roles \u003d []"},{"line_number":102,"context_line":"        for r in user_roles:"},{"line_number":103,"context_line":"            if r in roles_names:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_96608d03","line":100,"updated":"2019-05-23 07:22:35.000000000","message":"i was confused by \u0027user_roles\u0027 really its more like \u0027system_roles\u0027","commit_id":"f78e343f3c7e259986de2e60d74a10a9a102b8e1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"4e76f9d80df3f1ff4780b4aa821c3b3a275a6f87","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        :rtype: list"},{"line_number":98,"context_line":"        \"\"\""},{"line_number":99,"context_line":"        roles_names \u003d [r[\u0027name\u0027] for r in roles[\u0027roles\u0027]]"},{"line_number":100,"context_line":"        user_roles \u003d self._conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)"},{"line_number":101,"context_line":"        available_roles \u003d []"},{"line_number":102,"context_line":"        for r in user_roles:"},{"line_number":103,"context_line":"            if r in roles_names:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_49927aa0","line":100,"in_reply_to":"bfb3d3c7_96608d03","updated":"2019-05-23 07:33:51.000000000","message":"yeah, i could have named it better. On the other side, these roles are obtained from the config file, which is set by a user (or it contains the default values). In this scope \u0027roles\u0027 represents system roles.","commit_id":"f78e343f3c7e259986de2e60d74a10a9a102b8e1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"a22a603acc8c82ebfdf9f048af4db0dabca4d516","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                # present in the system, remove the option completely"},{"line_number":117,"context_line":"                LOG.debug(\"Removing auth.tempest_roles because non of the \""},{"line_number":118,"context_line":"                          \"provided roles exists.\")"},{"line_number":119,"context_line":"                self._conf.remove_option(\u0027auth\u0027, \u0027tempest_roles\u0027)"},{"line_number":120,"context_line":"        return available_roles"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def create_user_with_project(self, username, password, project_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb3d3c7_8956325c","line":119,"range":{"start_line":119,"start_character":16,"end_line":119,"end_character":65},"updated":"2019-05-23 08:01:49.000000000","message":"What about instead of removing it just set to empty list []. and as tempest tries to retrive auth.tempest_roles from tempest.conf if not found, it might screw other tests.","commit_id":"f78e343f3c7e259986de2e60d74a10a9a102b8e1"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"555d5bd7b9e41c7f2dcd11a4520aeaf48f6d4c3d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                # present in the system, remove the option completely"},{"line_number":117,"context_line":"                LOG.debug(\"Setting auth.tempest_roles to empty list  because \""},{"line_number":118,"context_line":"                          \"non of the provided roles exists.\")"},{"line_number":119,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \"\")"},{"line_number":120,"context_line":"        return available_roles"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def create_user_with_project(self, username, password, project_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_7eb28b96","line":119,"range":{"start_line":119,"start_character":56,"end_line":119,"end_character":59},"updated":"2019-05-23 13:08:04.000000000","message":"It should be []","commit_id":"164793ec208a089b8d7a5dc52cf0fcb1bae94e40"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a08029292e5c7751a4231c856b5f25e38071c6c2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                # present in the system, remove the option completely"},{"line_number":117,"context_line":"                LOG.debug(\"Setting auth.tempest_roles to empty list  because \""},{"line_number":118,"context_line":"                          \"non of the provided roles exists.\")"},{"line_number":119,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \"\")"},{"line_number":120,"context_line":"        return available_roles"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def create_user_with_project(self, username, password, project_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_c1a7080b","line":119,"range":{"start_line":119,"start_character":56,"end_line":119,"end_character":59},"in_reply_to":"bfb3d3c7_7eb28b96","updated":"2019-05-24 09:00:31.000000000","message":"I looked on other cases when python-tempestconf sets a value to tempest.conf and it always sets strings.","commit_id":"164793ec208a089b8d7a5dc52cf0fcb1bae94e40"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"4b9d5f6511603ba2dc4cb688bf734d0c4a4e9e8f","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            elif \u0027Member\u0027 in roles_names:"},{"line_number":113,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \u0027Member\u0027)"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # the default role/role given by user or \u0027member\u0027 role are not"},{"line_number":116,"context_line":"                # present in the system, remove the option completely"},{"line_number":117,"context_line":"                LOG.debug(\"Setting auth.tempest_roles to empty list because \""},{"line_number":118,"context_line":"                          \"none of the provided roles exists.\")"},{"line_number":119,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \"\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_4786b368","line":116,"range":{"start_line":115,"start_character":18,"end_line":116,"end_character":69},"updated":"2019-05-27 06:50:39.000000000","message":"It needs to be improved, we are not removing the roles, we are setting to empty string.","commit_id":"b713331e6d277cb44ec7cf88d73989a9227e7398"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ce5a10b54ef5acc04d55330b34204fe5db30d3b4","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            elif \u0027Member\u0027 in roles_names:"},{"line_number":113,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \u0027Member\u0027)"},{"line_number":114,"context_line":"            else:"},{"line_number":115,"context_line":"                # the default role/role given by user or \u0027member\u0027 role are not"},{"line_number":116,"context_line":"                # present in the system, remove the option completely"},{"line_number":117,"context_line":"                LOG.debug(\"Setting auth.tempest_roles to empty list because \""},{"line_number":118,"context_line":"                          \"none of the provided roles exists.\")"},{"line_number":119,"context_line":"                self._conf.set(\u0027auth\u0027, \u0027tempest_roles\u0027, \"\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_e7db2779","line":116,"range":{"start_line":115,"start_character":18,"end_line":116,"end_character":69},"in_reply_to":"bfb3d3c7_4786b368","updated":"2019-05-27 06:54:16.000000000","message":"oh, i forgot about the comment, i changed only the log message","commit_id":"b713331e6d277cb44ec7cf88d73989a9227e7398"}]}