)]}'
{"config_tempest/services/volume.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"8056acf5c0d696d79cc9629a7dc9b993dcbb1219","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        return [\u0027cinderv2\u0027, \u0027cinderv3\u0027]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":63,"context_line":"        if self.name \u003d\u003d \u0027volumev2\u0027:"},{"line_number":64,"context_line":"            # in volumev2 backup service is implemented within volume service."},{"line_number":65,"context_line":"            # post_configuration method is called with every volume (v2, v3)"},{"line_number":66,"context_line":"            # service, therefore set the value with priority so it can\u0027t be"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_f2835a55","line":63,"range":{"start_line":63,"start_character":25,"end_line":63,"end_character":33},"updated":"2019-06-04 04:05:51.000000000","message":"There is no volume2 service type in tripleo side, it is volume.","commit_id":"103cdf7c3ad80ae0c6883ba858243170165ba017"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"cff80ce5f264eb5ca7fe5169c4eda5f0073b65a4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        if self.name \u003d\u003d \u0027volume\u0027 or self.name \u003d\u003d \u0027volumev2\u0027:"},{"line_number":64,"context_line":"            # in volume/volumev2 backup service is implemented within"},{"line_number":65,"context_line":"            # the volume service."},{"line_number":66,"context_line":"            # post_configuration method is called with every volume (v2, v3)"},{"line_number":67,"context_line":"            # service, therefore set the value with priority so it can\u0027t be"},{"line_number":68,"context_line":"            # overrided by this method called from other instance of volume"},{"line_number":69,"context_line":"            conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027True\u0027, priority\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_7db17b8f","line":66,"range":{"start_line":66,"start_character":14,"end_line":66,"end_character":76},"updated":"2019-06-04 17:23:01.000000000","message":"post configuration method is called with every volume(v2, v3)and (v, v3)? What about this?","commit_id":"bfbcbf71df2359a13bc4dfd2a8a455de91723b27"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"43e2c685157368bc1ac49f8face0d9e02ce04815","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":63,"context_line":"        if self.name \u003d\u003d \u0027volume\u0027 or self.name \u003d\u003d \u0027volumev2\u0027:"},{"line_number":64,"context_line":"            # in volume/volumev2 backup service is implemented within"},{"line_number":65,"context_line":"            # the volume service."},{"line_number":66,"context_line":"            # post_configuration method is called with every volume (v2, v3)"},{"line_number":67,"context_line":"            # service, therefore set the value with priority so it can\u0027t be"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_404ccbc6","line":64,"updated":"2019-06-04 11:48:43.000000000","message":"-1: no, this is not true. cinder-backup separate regardless of whether cinder is running its v1 (volume), v2 (volume2) or v3 (volume3) service.","commit_id":"b95b1dd8e0e3b875974ab19a43bc2e52cede3d62"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"43e2c685157368bc1ac49f8face0d9e02ce04815","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        if self.name \u003d\u003d \u0027volumev3\u0027:"},{"line_number":71,"context_line":"            # since volumev3 backup service is a standalone service called"},{"line_number":72,"context_line":"            # cinder-backup"},{"line_number":73,"context_line":"            if not is_service(\"volumev3\"):"},{"line_number":74,"context_line":"                C.LOG.info(\"No volumev3 service found, backup service might \""},{"line_number":75,"context_line":"                           \"not be running.\")"},{"line_number":76,"context_line":"                conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_40e12b9a","line":73,"updated":"2019-06-04 11:48:43.000000000","message":"What if we eliminate L63 through L72, and do something like this:\n\n    if not is_service(self.name):\n\nThat should work regardless of which version of the service is running.","commit_id":"b95b1dd8e0e3b875974ab19a43bc2e52cede3d62"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"1b2d7ef0d147c8f2ff1f857c2ed1a3990d46da6a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        if self.name \u003d\u003d \u0027volumev3\u0027:"},{"line_number":71,"context_line":"            # since volumev3 backup service is a standalone service called"},{"line_number":72,"context_line":"            # cinder-backup"},{"line_number":73,"context_line":"            if not is_service(\"volumev3\"):"},{"line_number":74,"context_line":"                C.LOG.info(\"No volumev3 service found, backup service might \""},{"line_number":75,"context_line":"                           \"not be running.\")"},{"line_number":76,"context_line":"                conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)"},{"line_number":77,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_38c5513d","line":74,"range":{"start_line":73,"start_character":13,"end_line":74,"end_character":22},"updated":"2019-06-04 07:25:14.000000000","message":"so is this like the case of the \u0027fake v3\u0027 when we had the endpoint but not the service? i.e. that is what this if /check is for?","commit_id":"b95b1dd8e0e3b875974ab19a43bc2e52cede3d62"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"43e2c685157368bc1ac49f8face0d9e02ce04815","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            except exceptions.Forbidden:"},{"line_number":82,"context_line":"                C.LOG.warning(\"User has no permissions to list services - \""},{"line_number":83,"context_line":"                              \"cinder-backup service can\u0027t be discovered.\")"},{"line_number":84,"context_line":"                return"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"            if is_backup:"},{"line_number":87,"context_line":"                # We only set backup to false if the service isn\u0027t running"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_009a5313","line":84,"updated":"2019-06-04 11:48:43.000000000","message":"If the user doesn\u0027t have permission to list the services, then would it make sense to set [volume-feature-enabled]backup \u003d False to be safe? Remember that cinder-backup is often an optional service, and in many distros (certainly Tripleo) it is not enabled by default. So unless we disable testing it here, the user will likely encounter failures when tempest runs the backup tests.","commit_id":"b95b1dd8e0e3b875974ab19a43bc2e52cede3d62"}]}