)]}'
{"id":"openinfra%2Fpython-tempestconf~663061","triplet_id":"openinfra%2Fpython-tempestconf~master~Ifdeaa2b854dfa2dcfda1491b522e4e67b822fc4f","project":"openinfra/python-tempestconf","branch":"master","topic":"ref","hashtags":[],"change_id":"Ifdeaa2b854dfa2dcfda1491b522e4e67b822fc4f","subject":"Clear the difference between service type and name","status":"MERGED","created":"2019-06-04 15:14:52.000000000","updated":"2019-06-05 16:53:34.000000000","submitted":"2019-06-05 16:53:34.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"663061-1559753614643-589de8e3","meta_rev_id":"dccc9bfeccde1977abee18fb67899d769fdd36c7","_number":663061,"virtual_id_number":663061,"owner":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"date":"2019-06-04 21:04:13.000000000","_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"date":"2019-06-04 15:53:17.000000000","_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":2,"date":"2019-06-05 16:53:34.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-06-04 17:54:14.000000000","_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":0,"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"recommended":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"all":[{"value":1,"date":"2019-06-05 06:19:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":2,"date":"2019-06-05 06:07:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":2,"date":"2019-06-05 15:10:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"all":[{"value":0,"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"value":0,"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"value":0,"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"value":0,"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},{"value":1,"date":"2019-06-05 15:10:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-06-04 15:53:17.000000000","updated_by":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"reviewer":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"state":"REVIEWER"},{"updated":"2019-06-04 17:54:14.000000000","updated_by":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"reviewer":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-06-05 06:07:41.000000000","updated_by":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"reviewer":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"state":"REVIEWER"},{"updated":"2019-06-05 06:19:17.000000000","updated_by":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"reviewer":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"state":"REVIEWER"},{"updated":"2019-06-05 15:10:55.000000000","updated_by":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"reviewer":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"state":"REVIEWER"},{"updated":"2019-06-05 16:53:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b00791b8235ccfd9fc5c1a5d4a167aec5a101cdc","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2019-06-04 15:14:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9d5e4467bd91e889c0b137e1fb40bf5e7d0478c6","author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"date":"2019-06-04 15:53:17.000000000","message":"Patch Set 1:\n\nI know that the reason is good, but isn\u0027t this changing a public interface?","accounts_in_message":[],"_revision_number":1},{"id":"8e789aeb788577cbe2e76573e52fed53cbd8d763","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-04 16:52:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover http://logs.openstack.org/61/663061/1/check/openstack-tox-cover/9da3838/cover/ : SUCCESS in 4m 56s\n- openstack-tox-pep8 http://logs.openstack.org/61/663061/1/check/openstack-tox-pep8/dfc8ed0/ : SUCCESS in 4m 11s\n- openstack-tox-py27 http://logs.openstack.org/61/663061/1/check/openstack-tox-py27/ae3e919/ : SUCCESS in 3m 42s\n- openstack-tox-py35 http://logs.openstack.org/61/663061/1/check/openstack-tox-py35/9cef06e/ : SUCCESS in 4m 35s\n- openstack-tox-py36 http://logs.openstack.org/61/663061/1/check/openstack-tox-py36/fd646da/ : SUCCESS in 4m 10s\n- openstack-tox-py37 http://logs.openstack.org/61/663061/1/check/openstack-tox-py37/b537a93/ : SUCCESS in 4m 47s\n- openstack-tox-docs http://logs.openstack.org/61/663061/1/check/openstack-tox-docs/0660118/html/ : SUCCESS in 4m 04s\n- python-tempestconf-tempest-devstack-admin http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-devstack-admin/e2126be/ : SUCCESS in 43m 42s\n- python-tempestconf-tempest-devstack-admin-py3 http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-devstack-admin-py3/c4625e5/ : SUCCESS in 46m 54s\n- python-tempestconf-tempest-devstack-demo http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-devstack-demo/d480e43/ : SUCCESS in 43m 08s\n- python-tempestconf-tempest-devstack-demo-py3 http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-devstack-demo-py3/cc700fd/ : SUCCESS in 38m 23s\n- python-tempestconf-tempest-packstack-admin http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-packstack-admin/8e59b22/ : SUCCESS in 1h 12m 48s\n- python-tempestconf-tempest-packstack-demo http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-packstack-demo/c9384c6/ : SUCCESS in 1h 13m 21s\n- python-tempestconf-tempest-devstack-admin-plugins http://logs.openstack.org/61/663061/1/check/python-tempestconf-tempest-devstack-admin-plugins/a198657/ : SUCCESS in 42m 55s\n- tripleo-ci-centos-7-scenario002-standalone http://logs.openstack.org/61/663061/1/check/tripleo-ci-centos-7-scenario002-standalone/6f8abd0/ : SUCCESS in 1h 30m 58s\n- tripleo-ci-centos-7-standalone-os-tempest http://logs.openstack.org/61/663061/1/check/tripleo-ci-centos-7-standalone-os-tempest/a914067/ : SUCCESS in 1h 03m 16s\n- refstack-client-devstack-tempestconf http://logs.openstack.org/61/663061/1/check/refstack-client-devstack-tempestconf/715d145/ : SUCCESS in 52m 15s","accounts_in_message":[],"_revision_number":1},{"id":"5a46beb4ab6e7917f84280ff97e26aee11ff3470","author":{"_account_id":23181,"name":"RDO Third Party CI","email":"dmsimard+rdothirdparty@redhat.com","username":"rdothirdparty","tags":["SERVICE_USER"]},"date":"2019-06-04 17:54:14.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001 http://logs.rdoproject.org/61/663061/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/0530248/ : SUCCESS in 2h 34m 21s","accounts_in_message":[],"_revision_number":1},{"id":"6bea357fa03e3a02b26913e3f403e59cec6cf21a","author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"date":"2019-06-04 21:04:13.000000000","message":"Patch Set 1:\n\n\u003e I know that the reason is good, but isn\u0027t this changing a public\n \u003e interface?\n\nIt shouldn\u0027t, the patch changes only a name of one method and number of arguments required for instantiating Service class and AFAIK both of them should be used only internally.","accounts_in_message":[],"_revision_number":1},{"id":"a64d8a5674f78192ec29f109fdc64fe848f0d248","author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"date":"2019-06-05 06:07:41.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2d221d6e63c3c5385460b3abd0ff4ea13ebbe97e","author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"date":"2019-06-05 06:19:17.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"83f4fb9b1284554f7369c63dcec84092c4c651dc","author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"date":"2019-06-05 15:10:55.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nBased on the fact that we have a blocker, and the is_service is used only internally, I am okay with this, and talking with Martin on IRC he will submit a new patch with a documentation regarding how to create a new service module, and the use of the is_service there.","accounts_in_message":[],"_revision_number":1},{"id":"6bd9b964c98b2292db03d24624acf980d48c92df","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 15:11:07.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"9fe4e8a2a67777642932b6824e933665c1fd206d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 16:53:34.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/61/663061/1/gate/openstack-tox-pep8/f2120d1/ : SUCCESS in 5m 36s\n- openstack-tox-py27 http://logs.openstack.org/61/663061/1/gate/openstack-tox-py27/d0c477e/ : SUCCESS in 4m 31s\n- openstack-tox-py35 http://logs.openstack.org/61/663061/1/gate/openstack-tox-py35/6c6f39d/ : SUCCESS in 5m 59s\n- openstack-tox-py36 http://logs.openstack.org/61/663061/1/gate/openstack-tox-py36/9f8eed4/ : SUCCESS in 6m 14s\n- openstack-tox-py37 http://logs.openstack.org/61/663061/1/gate/openstack-tox-py37/b0b52a6/ : SUCCESS in 5m 44s\n- openstack-tox-docs http://logs.openstack.org/61/663061/1/gate/openstack-tox-docs/dd49a7c/html/ : SUCCESS in 4m 55s\n- python-tempestconf-tempest-devstack-admin http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-devstack-admin/48efc88/ : SUCCESS in 48m 05s\n- python-tempestconf-tempest-devstack-admin-py3 http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-devstack-admin-py3/e9f0d48/ : SUCCESS in 51m 42s\n- python-tempestconf-tempest-devstack-demo http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-devstack-demo/47c7e6d/ : SUCCESS in 1h 00m 53s\n- python-tempestconf-tempest-devstack-demo-py3 http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-devstack-demo-py3/c06541f/ : SUCCESS in 40m 11s\n- python-tempestconf-tempest-packstack-admin http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-packstack-admin/474530a/ : SUCCESS in 1h 15m 31s\n- python-tempestconf-tempest-packstack-demo http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-packstack-demo/8226ebf/ : SUCCESS in 1h 13m 47s\n- python-tempestconf-tempest-devstack-admin-plugins http://logs.openstack.org/61/663061/1/gate/python-tempestconf-tempest-devstack-admin-plugins/88c56cd/ : SUCCESS in 47m 56s\n- tripleo-ci-centos-7-scenario002-standalone http://logs.openstack.org/61/663061/1/gate/tripleo-ci-centos-7-scenario002-standalone/a92f999/ : SUCCESS in 1h 36m 18s\n- tripleo-ci-centos-7-standalone-os-tempest http://logs.openstack.org/61/663061/1/gate/tripleo-ci-centos-7-standalone-os-tempest/e4407b0/ : SUCCESS in 1h 10m 45s\n- refstack-client-devstack-tempestconf http://logs.openstack.org/61/663061/1/gate/refstack-client-devstack-tempestconf/cd265fd/ : SUCCESS in 1h 05m 37s","accounts_in_message":[],"_revision_number":1},{"id":"e3c80bafd9ba7d0a47365b3857a3e3ec5db1b0b1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-06-05 16:53:34.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3abb0ae5c518639e467934d6ee5fa0de312b6333","revisions":{"3abb0ae5c518639e467934d6ee5fa0de312b6333":{"kind":"REWORK","_number":1,"created":"2019-06-04 15:14:52.000000000","uploader":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"ref":"refs/changes/61/663061/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openinfra/python-tempestconf","ref":"refs/changes/61/663061/1","commands":{"Checkout":"git fetch https://review.opendev.org/openinfra/python-tempestconf refs/changes/61/663061/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openinfra/python-tempestconf refs/changes/61/663061/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openinfra/python-tempestconf refs/changes/61/663061/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openinfra/python-tempestconf refs/changes/61/663061/1"}}},"commit":{"parents":[{"commit":"5dda24d4067aa9a99c287940971400c7704331a8","subject":"Merge \"Edit doc regarding override values\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openinfra/python-tempestconf/commit/5dda24d4067aa9a99c287940971400c7704331a8"}]}],"author":{"name":"Martin Kopec","email":"mkopec@redhat.com","date":"2019-06-04 15:05:46.000000000","tz":0},"committer":{"name":"Martin Kopec","email":"mkopec@redhat.com","date":"2019-06-04 15:06:50.000000000","tz":0},"subject":"Clear the difference between service type and name","message":"Clear the difference between service type and name\n\nThe current code mixes service type and service name based on\nthe context. Service type should be service type allways. The\nsame applies on service name. The patch clears the difference\nbetween these two different variables.\n\nStory: 2005820\nTask: 33577\n\nChange-Id: Ifdeaa2b854dfa2dcfda1491b522e4e67b822fc4f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openinfra/python-tempestconf/commit/3abb0ae5c518639e467934d6ee5fa0de312b6333"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openinfra/python-tempestconf/commit/3abb0ae5c518639e467934d6ee5fa0de312b6333"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}