)]}'
{".zuul.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"eda2072f7e958be2ae7d11f4455c3d5c44c1c857","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    run: playbooks/python-tempestconf-tempest-devstack.yaml"},{"line_number":133,"context_line":"    vars:"},{"line_number":134,"context_line":"      # creator role is required for Barbican tests"},{"line_number":135,"context_line":"      additional_tempestconf_params: \"auth.tempest_roles creator\""},{"line_number":136,"context_line":"      test_regex:"},{"line_number":137,"context_line":"        - \u0027heat_tempest_plugin\u0027"},{"line_number":138,"context_line":"        - \u0027designate_tempest_plugin\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_3d7ff115","line":135,"range":{"start_line":135,"start_character":6,"end_line":135,"end_character":65},"updated":"2020-03-05 14:33:16.000000000","message":"Or should this be added automatically by tempestconf ?","commit_id":"52f7bc2b4f38f182cdd589ec0d8d9937986cb937"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"c5f7f30957243664d9a1a9ccf178b9acd7775169","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    run: playbooks/python-tempestconf-tempest-devstack.yaml"},{"line_number":133,"context_line":"    vars:"},{"line_number":134,"context_line":"      # creator role is required for Barbican tests"},{"line_number":135,"context_line":"      additional_tempestconf_params: \"auth.tempest_roles creator\""},{"line_number":136,"context_line":"      test_regex:"},{"line_number":137,"context_line":"        - \u0027heat_tempest_plugin\u0027"},{"line_number":138,"context_line":"        - \u0027designate_tempest_plugin\u0027"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_be00b702","line":135,"range":{"start_line":135,"start_character":6,"end_line":135,"end_character":65},"in_reply_to":"1fa4df85_3d7ff115","updated":"2020-03-05 16:24:28.000000000","message":"this is correct way for adding additional parameters, you can check the tempest.conf that it contains the creator role now:\nhttps://d3f2acf47bc8c9aee528-cf4df5e5ffe136c56cf2c9d8dbb6eb03.ssl.cf2.rackcdn.com/706646/3/check/python-tempestconf-tempest-devstack-admin-plugins/fc07480/controller/logs/tempest_conf.txt","commit_id":"52f7bc2b4f38f182cdd589ec0d8d9937986cb937"}],"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8717879bd7adf2c2812a989cd0d6da5eeffed7e0","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Barbican service."},{"line_number":11,"context_line":"Note that barbican is disabled in queens job due to barbican issue"},{"line_number":12,"context_line":"on py3 in queens."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2023df6ce212bd9c455fa04a43419c6760e22267"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a773380_8e53f809","line":13,"updated":"2021-01-04 13:21:38.000000000","message":"Story: 2005757\nTask: 33460","commit_id":"6a717246267cd7ff80fae422bb0430b12e681a06"}],"playbooks/python-tempestconf-tempest-packstack.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9da5845bd96f4bbdd2e810fc9e798ce0f3d8ed9e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      include_role:"},{"line_number":53,"context_line":"        name: generate-tempestconf-file"},{"line_number":54,"context_line":"      vars:"},{"line_number":55,"context_line":"        additional_tempestconf_params: \"object-storage.operator_role Member\""},{"line_number":56,"context_line":"        output_path: \"/etc/openstack/tempest_admin.conf\""},{"line_number":57,"context_line":"        source_credentials_commands: \"source {{ ansible_user_dir }}/keystonerc_admin\""},{"line_number":58,"context_line":"        test_demo_user: False"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_01fcaf3c","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":37},"updated":"2020-03-12 10:42:43.000000000","message":"well, i know it\u0027s a typo, but it needs to be \"aditional_\" .. we noticed that later and now there is a circular dependency with refstack, so we cannot just change that\n\nif you wanna fix that typo, it\u0027s ok, but it has to be in a different patch, it will require marking refstack job as non-voting, then fix it in refstack-client and then mark it as voting again :)","commit_id":"3f7e3af6c205c9befe9b716b4918f5e360397782"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"30cdf96615007538c90aae34447d26437e68d221","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      include_role:"},{"line_number":53,"context_line":"        name: generate-tempestconf-file"},{"line_number":54,"context_line":"      vars:"},{"line_number":55,"context_line":"        additional_tempestconf_params: \"object-storage.operator_role Member\""},{"line_number":56,"context_line":"        output_path: \"/etc/openstack/tempest_admin.conf\""},{"line_number":57,"context_line":"        source_credentials_commands: \"source {{ ansible_user_dir }}/keystonerc_admin\""},{"line_number":58,"context_line":"        test_demo_user: False"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_94a8dbdb","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":37},"in_reply_to":"1fa4df85_01fcaf3c","updated":"2020-03-12 11:04:03.000000000","message":"Thanks. Now I understood the situation.\n\nI removed the change related to this typo fixing from the patch at the moment.","commit_id":"3f7e3af6c205c9befe9b716b4918f5e360397782"}],"roles/generate-tempestconf-file/tasks/main.yaml":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"939dbed151c199ef662882abd32b7232d2750291","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        cp  {{ tempestconf_src_relative_path }}/etc/tempest.conf {{ output_path }}"},{"line_number":85,"context_line":"    when: output_path is defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  # We need cirros image is located under etc to run barbican tests"},{"line_number":88,"context_line":"  - name: Copy cirros image to the tempest directory"},{"line_number":89,"context_line":"    become: yes"},{"line_number":90,"context_line":"    shell: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"946203ae_8d52250e","line":87,"updated":"2021-01-22 09:03:36.000000000","message":"Are you sure this is the case? I think I\u0027ve seen those tests being executed without copying this.","commit_id":"f4c45c098e826902ae0a20bfcd04e4c7392e756c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ab41c42991a29894ea961980341e77326edb693d","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        cp  {{ tempestconf_src_relative_path }}/etc/tempest.conf {{ output_path }}"},{"line_number":85,"context_line":"    when: output_path is defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  # We need cirros image is located under etc to run barbican tests"},{"line_number":88,"context_line":"  - name: Copy cirros image to the tempest directory"},{"line_number":89,"context_line":"    become: yes"},{"line_number":90,"context_line":"    shell: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9defb443_5018c617","line":87,"in_reply_to":"361cc051_0de466a8","updated":"2021-01-22 12:32:06.000000000","message":"Please check the following failure logs. We need to copy the cirros image to fix that error. It might be a misbehavior of test code itself.\n\nhttps://zuul.opendev.org/t/openstack/build/d88c608820fd48e486b3bb25e6cf1dc6/log/job-output.txt#40377-40414","commit_id":"f4c45c098e826902ae0a20bfcd04e4c7392e756c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f9c855e46f5f3ae2b0feacef342d3d85dce1ed34","unresolved":true,"context_lines":[{"line_number":84,"context_line":"        cp  {{ tempestconf_src_relative_path }}/etc/tempest.conf {{ output_path }}"},{"line_number":85,"context_line":"    when: output_path is defined"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  # We need cirros image is located under etc to run barbican tests"},{"line_number":88,"context_line":"  - name: Copy cirros image to the tempest directory"},{"line_number":89,"context_line":"    become: yes"},{"line_number":90,"context_line":"    shell: |"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"361cc051_0de466a8","line":87,"in_reply_to":"946203ae_8d52250e","updated":"2021-01-22 09:08:10.000000000","message":"IIUC this we required since some of barbican tests use cirros images from this location... but let me recheck this.\n\nI submitted a subsequent DNM patch which have this block removed. If the commit passes the CI then I\u0027ll remove this block.","commit_id":"f4c45c098e826902ae0a20bfcd04e4c7392e756c"}]}