)]}'
{"config_tempest/services/octavia.py":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"4037be13f807fb92930b7a87a4db159320be221b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5790eb4e","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"updated":"2020-03-27 11:44:15.000000000","message":"Wouldn\u0027t this still set \"_member_\"? See https://opendev.org/openstack/python-tempestconf/src/branch/master/config_tempest/main.py#L98","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"65225ec32c71f70a2ee67bdf8e7d4ed772556d55","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_4d105802","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"in_reply_to":"df33271e_3239f540","updated":"2020-03-27 13:11:23.000000000","message":"It will be set to _member_ only if that role is present in the system .. _member_ has been a default since long ago and I\u0027m not sure if changing the default would be easy as python-tempestconf keeps support for osp 13 and higher ..\n\nanyway, python-tempestconf checks if the roles present in auth.tempest_roles exist [1]. The ones which doesn\u0027t are filtered out. In case no given role exists python-tempestconf tries member and Member roles in order to not end up with no roles set in auth.tempest_roles. \n\nI know that the check process is not very intelligent but it does work in reality. Also python-tempestconf is no AI, it just tries to do the best to make user\u0027s life easier.\n\n\n[1] https://opendev.org/openstack/python-tempestconf/src/branch/master/config_tempest/users.py#L83-L109","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a95658962bf5ca8f0970c8ebc1c4c028b2efae90","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_8d7ee016","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"in_reply_to":"df33271e_4d105802","updated":"2020-03-27 13:16:20.000000000","message":"Right, the underlying problems is that in a perfect world the deployment tool would spit out a working tempest.conf which matches the deployment. But that\u0027s a different story and a discusion for another day.","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"d2afb83d26a747ddfed9eb97783725eb9d0de35c","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_d2ad2989","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"in_reply_to":"df33271e_52cd99b6","updated":"2020-03-27 12:32:29.000000000","message":"How is it detected? What makes tempest_role\u003dmember and not tempest_role\u003d_member_?","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"448c0c3c648f47edda14e2f9f2cf6b823ef067e0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_d7e07bcf","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"in_reply_to":"df33271e_5790eb4e","updated":"2020-03-27 11:48:51.000000000","message":"Just to clarify, I understand that users of python-tempestconf (e.g. TripleO) can override the defaults like in https://opendev.org/openstack/puppet-openstack-integration/src/branch/master/manifests/tempest.pp#L217\n\nButif _member_ is deprecated, python-tempestconf should redefine its default values.","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"74cb3ff41daec47a3b173e6544ab327d12bf054d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_52cd99b6","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"in_reply_to":"df33271e_5790eb4e","updated":"2020-03-27 12:17:01.000000000","message":"No, that\u0027s the default. It is detected:\nhttps://920f07a834efdebe4841-2fe81f106a8b79afa5f859bb7636b32b.ssl.cf5.rackcdn.com/715372/1/check/python-tempestconf-tempest-devstack-admin/5b32f92/controller/logs/tempest_conf.txt\n\ntempest_roles \u003d member","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"08eaa83661b0bd1af778686f17fec5fcf78f83fd","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_3239f540","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":50},"in_reply_to":"df33271e_d2ad2989","updated":"2020-03-27 12:36:49.000000000","message":"See the other comments.","commit_id":"32b60cc83342695cf7f653cd26c8a0cbe9453ca1"}]}