)]}'
{".zuul.yaml":[{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"492f80f4c5b0eecd8a38feb1280aa2eb32551850","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - tripleo-ci-centos-8-scenario002-standalone"},{"line_number":21,"context_line":"        - tripleo-ci-centos-8-standalone"},{"line_number":22,"context_line":"        - refstack-client-devstack-tempestconf"},{"line_number":23,"context_line":"        - tripleo-ci-centos-8-scenario010-standalone"},{"line_number":24,"context_line":"    gate:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf51134e_4d26366a","line":23,"updated":"2020-07-14 09:18:19.000000000","message":"This is a voting job. It must be added to the gate list too.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3b641a6fb07b35d7553d20ff527d2213aeea10ce","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - tripleo-ci-centos-8-scenario002-standalone"},{"line_number":21,"context_line":"        - tripleo-ci-centos-8-standalone"},{"line_number":22,"context_line":"        - refstack-client-devstack-tempestconf"},{"line_number":23,"context_line":"        - tripleo-ci-centos-8-scenario010-standalone"},{"line_number":24,"context_line":"    gate:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf51134e_90c7c196","line":23,"in_reply_to":"bf51134e_4d26366a","updated":"2020-07-14 12:01:03.000000000","message":"You\u0027ve not addressed this comment.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"95ca1a4b7725f70efb6d5e908946844a0bbe0328","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - tripleo-ci-centos-8-scenario002-standalone"},{"line_number":21,"context_line":"        - tripleo-ci-centos-8-standalone"},{"line_number":22,"context_line":"        - refstack-client-devstack-tempestconf"},{"line_number":23,"context_line":"        - tripleo-ci-centos-8-scenario010-standalone"},{"line_number":24,"context_line":"    gate:"},{"line_number":25,"context_line":"      jobs:"},{"line_number":26,"context_line":"        - openstack-tox-pep8"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"bf51134e_66a9978e","line":23,"in_reply_to":"bf51134e_90c7c196","updated":"2020-07-14 12:42:55.000000000","message":"Sorry, i missed this comment. I\u0027ll add this job to gate list.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"}],"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d7d66295b5cb1444361766daa1f2651ef920a4d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amol Kahat \u003camolkahat@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-08 13:32:58 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added octavia tempest plugin support configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To run octavia tempest plugin some configuration need to"},{"line_number":10,"context_line":"set in tempestconf file. If octavia service is enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"bf51134e_6869bdbc","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2020-07-08 08:44:12.000000000","message":"The plugin was already supported - at least some configuration was set by tempestconf automatically .. I\u0027d rephrase this to something like \"Improve octavia tempest plugin configuration\"","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d7d66295b5cb1444361766daa1f2651ef920a4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To run octavia tempest plugin some configuration need to"},{"line_number":10,"context_line":"set in tempestconf file. If octavia service is enabled"},{"line_number":11,"context_line":"then this configuration will set automatically."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added tripleo-ci-centos-8-scenario010-standalone job."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"bf51134e_48a959db","line":11,"updated":"2020-07-08 08:44:12.000000000","message":"Could you add here that the patch makes tempestconf set region and list and set enabled_provider_drivers?","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d7d66295b5cb1444361766daa1f2651ef920a4d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Added tripleo-ci-centos-8-scenario010-standalone job."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Added tests for list_drivers and post_configuration."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: https://review.opendev.org/#/c/736527/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ic719f83f4fb9a330fc64ef46144e0b0b39c3a7d5"},{"line_number":20,"context_line":"Signed-off-by: Amol Kahat \u003camolkahat@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"bf51134e_68125d5a","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":50},"updated":"2020-07-08 08:44:12.000000000","message":"this is no longer needed","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"}],"config_tempest/services/octavia.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fb4e4474b476f24fc07be1e853b372963cfba45b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027provider\u0027, \u0027ovn\u0027)"},{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_with_ipv6\u0027, \u0027false\u0027)"},{"line_number":42,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_reuse_connection\u0027, \u0027false\u0027)"},{"line_number":43,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027load_balancing_algorithm\u0027, \u0027SOURCE_IP_PORT\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0d3ae196","line":40,"updated":"2020-05-28 11:31:28.000000000","message":"Why? This depends on the specific deployment. It can\u0027t be set here. Same question for all the other parameters.","commit_id":"2c7159d0f92acd3e130aae00af8a57e77675f691"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fb4e4474b476f24fc07be1e853b372963cfba45b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_reuse_connection\u0027, \u0027false\u0027)"},{"line_number":43,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027load_balancing_algorithm\u0027, \u0027SOURCE_IP_PORT\u0027)"},{"line_number":44,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_flavors\u0027, \u0027false\u0027)"},{"line_number":45,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027health_monitor_enabled\u0027, \u0027false\u0027)"},{"line_number":46,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027pool_algorithms_enabled\u0027, \u0027false\u0027)"},{"line_number":47,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l7_protocol_enabled\u0027, \u0027false\u0027)"},{"line_number":48,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l4_protocol\u0027, \u0027TCP\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_2d37e5b2","line":45,"updated":"2020-05-28 11:31:28.000000000","message":"if this must be set to false, why is it set to true by octavia-tempest-plugin?","commit_id":"2c7159d0f92acd3e130aae00af8a57e77675f691"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"fb4e4474b476f24fc07be1e853b372963cfba45b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027health_monitor_enabled\u0027, \u0027false\u0027)"},{"line_number":46,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027pool_algorithms_enabled\u0027, \u0027false\u0027)"},{"line_number":47,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l7_protocol_enabled\u0027, \u0027false\u0027)"},{"line_number":48,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l4_protocol\u0027, \u0027TCP\u0027)"},{"line_number":49,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027session_persistence_enabled\u0027, \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_6d41dd0b","line":48,"updated":"2020-05-28 11:31:28.000000000","message":"This is the default value, for example","commit_id":"2c7159d0f92acd3e130aae00af8a57e77675f691"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"784045d79d27c9601b713b1c7b87725777143113","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027provider\u0027, \u0027ovn\u0027)"},{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_with_ipv6\u0027, \u0027false\u0027)"},{"line_number":42,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_reuse_connection\u0027, \u0027false\u0027)"},{"line_number":43,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027load_balancing_algorithm\u0027, \u0027SOURCE_IP_PORT\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_8c1b7e19","line":40,"updated":"2020-05-29 12:39:33.000000000","message":"All these settings are *if* one wants to test against the OVN Octavia provider driver.","commit_id":"5cae90a999957ab2dccc56103cb575b8135d3bc6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fc2157fa4585d6deea59a0a3084740ebf694877","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_reuse_connection\u0027, \u0027false\u0027)"},{"line_number":43,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027load_balancing_algorithm\u0027, \u0027SOURCE_IP_PORT\u0027)"},{"line_number":44,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_flavors\u0027, \u0027false\u0027)"},{"line_number":45,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027health_monitor_enabled\u0027, \u0027false\u0027)"},{"line_number":46,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027pool_algorithms_enabled\u0027, \u0027false\u0027)"},{"line_number":47,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l7_protocol_enabled\u0027, \u0027false\u0027)"},{"line_number":48,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l4_protocol\u0027, \u0027TCP\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_852405c8","line":45,"updated":"2020-05-28 14:05:24.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"5cae90a999957ab2dccc56103cb575b8135d3bc6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fc2157fa4585d6deea59a0a3084740ebf694877","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027load_balancing_algorithm\u0027, \u0027SOURCE_IP_PORT\u0027)"},{"line_number":44,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_flavors\u0027, \u0027false\u0027)"},{"line_number":45,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027health_monitor_enabled\u0027, \u0027false\u0027)"},{"line_number":46,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027pool_algorithms_enabled\u0027, \u0027false\u0027)"},{"line_number":47,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l7_protocol_enabled\u0027, \u0027false\u0027)"},{"line_number":48,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l4_protocol\u0027, \u0027TCP\u0027)"},{"line_number":49,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027session_persistence_enabled\u0027, \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_651f3170","line":46,"updated":"2020-05-28 14:05:24.000000000","message":"pep8: E501 line too long (84 \u003e 79 characters)","commit_id":"5cae90a999957ab2dccc56103cb575b8135d3bc6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fc2157fa4585d6deea59a0a3084740ebf694877","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027test_flavors\u0027, \u0027false\u0027)"},{"line_number":45,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027health_monitor_enabled\u0027, \u0027false\u0027)"},{"line_number":46,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027pool_algorithms_enabled\u0027, \u0027false\u0027)"},{"line_number":47,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l7_protocol_enabled\u0027, \u0027false\u0027)"},{"line_number":48,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l4_protocol\u0027, \u0027TCP\u0027)"},{"line_number":49,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027session_persistence_enabled\u0027, \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_c52efda3","line":47,"updated":"2020-05-28 14:05:24.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"5cae90a999957ab2dccc56103cb575b8135d3bc6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5fc2157fa4585d6deea59a0a3084740ebf694877","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027pool_algorithms_enabled\u0027, \u0027false\u0027)"},{"line_number":47,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l7_protocol_enabled\u0027, \u0027false\u0027)"},{"line_number":48,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027l4_protocol\u0027, \u0027TCP\u0027)"},{"line_number":49,"context_line":"        conf.set(\u0027loadbalancer-feature-enabled\u0027, \u0027session_persistence_enabled\u0027, \u0027false\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_a529499c","line":49,"updated":"2020-05-28 14:05:24.000000000","message":"pep8: E501 line too long (88 \u003e 79 characters)","commit_id":"5cae90a999957ab2dccc56103cb575b8135d3bc6"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f220ff3c68e99805472391d5250990b9820c7d32","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":42,"context_line":"                 \u0027\"amphora:The Octavia Amphora driver.,\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_47cf7f7e","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":65},"updated":"2020-05-29 13:47:04.000000000","message":"This one returns defaults to _member_ role, it need to be fixed if Member or member role is present something like this we have handled previously https://opendev.org/openstack/python-tempestconf/src/branch/master/config_tempest/users.py#L99","commit_id":"5230d32c3ecf4a4ae3a0d509354ddcb476e88878"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"88beb21ba6972b6c8da9741303bd4b66efc15cc8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":42,"context_line":"                 \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":43,"context_line":"                 \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                 \u0027ovn:Octavia ovn driver.\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a7781b8f","line":44,"updated":"2020-05-29 13:22:46.000000000","message":"OVN is only available on OVN ML2 environments. Having it enabled on other ML2 backends will result in Octavia tempest test failures.","commit_id":"5230d32c3ecf4a4ae3a0d509354ddcb476e88878"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"89c8bbda6f286d0f52d96e1675acc63e6bc94684","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":42,"context_line":"                 \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":43,"context_line":"                 \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                 \u0027ovn:Octavia ovn driver.\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_c7042fc9","line":44,"in_reply_to":"ff570b3c_075aa7f1","updated":"2020-05-29 13:35:55.000000000","message":"Lists all enabled provider drivers via Octavia API: https://docs.openstack.org/api-ref/load-balancer/v2/?expanded\u003dlist-providers-detail#list-providers","commit_id":"5230d32c3ecf4a4ae3a0d509354ddcb476e88878"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c608ab4ec48ffaf0744fafde1955565093ed58f7","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":42,"context_line":"                 \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":43,"context_line":"                 \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                 \u0027ovn:Octavia ovn driver.\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_075aa7f1","line":44,"in_reply_to":"ff570b3c_87bfd7f9","updated":"2020-05-29 13:33:01.000000000","message":"if it\u0027s specific to ovn job, python-tempestconf is not the place, unless you can find a way to get the list of enabled providers dynamically.\n\nSo again, if there is no way to get those details from the system, please drop this change.","commit_id":"5230d32c3ecf4a4ae3a0d509354ddcb476e88878"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"bd383781609fb9d55465341b8391093e8ed6f401","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":42,"context_line":"                 \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":43,"context_line":"                 \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                 \u0027ovn:Octavia ovn driver.\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_87bfd7f9","line":44,"in_reply_to":"ff570b3c_a7781b8f","updated":"2020-05-29 13:30:43.000000000","message":"You got the point. I think i should make it more specific to ovn related jobs.","commit_id":"5230d32c3ecf4a4ae3a0d509354ddcb476e88878"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"f220ff3c68e99805472391d5250990b9820c7d32","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":42,"context_line":"                 \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":43,"context_line":"                 \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                 \u0027ovn:Octavia ovn driver.\"\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_a7be5bd1","line":44,"in_reply_to":"ff570b3c_c7042fc9","updated":"2020-05-29 13:47:04.000000000","message":"If we pass a list of supported provides here does it will not work?","commit_id":"5230d32c3ecf4a4ae3a0d509354ddcb476e88878"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"c1d98fa995b73bce18356f73e954519dd340f648","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":41,"context_line":"        if conf.get(\u0027load_balancer\u0027, \u0027provider\u0027) \u003d\u003d \u0027ovn\u0027:"},{"line_number":42,"context_line":"            conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":43,"context_line":"                     \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                     \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_d137c3af","line":41,"updated":"2020-05-30 15:02:57.000000000","message":"This looks backward: isn\u0027t enable_provider_drivers more general than provider?","commit_id":"9267cb81274c8b4137e41f21b7ef8b6c6cee04f0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"0f5f3fbd0efc86dc3dab1c44fb5581d325ee7587","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":41,"context_line":"        if conf.get(\u0027load_balancer\u0027, \u0027provider\u0027) \u003d\u003d \u0027ovn\u0027:"},{"line_number":42,"context_line":"            conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":43,"context_line":"                     \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                     \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_69a13147","line":41,"in_reply_to":"ff570b3c_1c7e4ee3","updated":"2020-06-08 10:51:08.000000000","message":"Maybe a better approach would be to construct the \u0027enabled_provider_drivers\u0027 in tempestconf based on the enabled provider drivers that you can get via Octavia API\n\nhttps://docs.openstack.org/api-ref/load-balancer/v2/?expanded\u003dlist-providers-detail#list-providers","commit_id":"9267cb81274c8b4137e41f21b7ef8b6c6cee04f0"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"2c412af3ef80ea4119331495fd9cd20369cb2fd7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":41,"context_line":"        if conf.get(\u0027load_balancer\u0027, \u0027provider\u0027) \u003d\u003d \u0027ovn\u0027:"},{"line_number":42,"context_line":"            conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":43,"context_line":"                     \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                     \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_1c7e4ee3","line":41,"in_reply_to":"ff570b3c_20b5ea32","updated":"2020-06-02 15:34:39.000000000","message":"I\u0027m talking about those options which are specific to the octavia-tempest-plugin.","commit_id":"9267cb81274c8b4137e41f21b7ef8b6c6cee04f0"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"51d8697638eef59fa5b4c3df32d768c2ec8c2509","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":41,"context_line":"        if conf.get(\u0027load_balancer\u0027, \u0027provider\u0027) \u003d\u003d \u0027ovn\u0027:"},{"line_number":42,"context_line":"            conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":43,"context_line":"                     \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                     \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_20b5ea32","line":41,"in_reply_to":"ff570b3c_d137c3af","updated":"2020-06-02 09:48:46.000000000","message":"Where exactly it is defined? I\u0027m not able to find it in python-tempestconf repo.","commit_id":"9267cb81274c8b4137e41f21b7ef8b6c6cee04f0"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"0f5f3fbd0efc86dc3dab1c44fb5581d325ee7587","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":40,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":41,"context_line":"        if conf.get(\u0027load_balancer\u0027, \u0027provider\u0027) \u003d\u003d \u0027ovn\u0027:"},{"line_number":42,"context_line":"            conf.set(\u0027load_balancer\u0027, \u0027enable_provider_drivers\u0027,"},{"line_number":43,"context_line":"                     \u0027\"amphora:The Octavia Amphora driver.,\u0027"},{"line_number":44,"context_line":"                     \u0027octavia:Deprecated alias of the Octavia Amphora driver.,\u0027"},{"line_number":45,"context_line":"                     \u0027ovn:Octavia ovn driver.\"\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_09fb5547","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":62},"updated":"2020-06-08 10:51:08.000000000","message":"typo: enabled_provider_drivers","commit_id":"9267cb81274c8b4137e41f21b7ef8b6c6cee04f0"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"30ed05897f519c33c8ce9cf1abd762856a9bfdfd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def list_drivers(self):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        List lbaas drivers"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        conn \u003d sdk.connet()"},{"line_number":43,"context_line":"        providers \u003d list(conn.load_balancer.providers())"},{"line_number":44,"context_line":"        names \u003d [i.name for i in providers]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_b02c3e48","line":41,"updated":"2020-06-15 16:16:51.000000000","message":"pep8: H404  multi line docstring should start without a leading new line","commit_id":"251cdb77ee07e36990b8ac044d4c25436470949a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"30ed05897f519c33c8ce9cf1abd762856a9bfdfd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def list_drivers(self):"},{"line_number":39,"context_line":"        \"\"\""},{"line_number":40,"context_line":"        List lbaas drivers"},{"line_number":41,"context_line":"        \"\"\""},{"line_number":42,"context_line":"        conn \u003d sdk.connet()"},{"line_number":43,"context_line":"        providers \u003d list(conn.load_balancer.providers())"},{"line_number":44,"context_line":"        names \u003d [i.name for i in providers]"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_1021aa4e","line":41,"updated":"2020-06-15 16:16:51.000000000","message":"pep8: H405  multi line docstring summary not separated with an empty line","commit_id":"251cdb77ee07e36990b8ac044d4c25436470949a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"30ed05897f519c33c8ce9cf1abd762856a9bfdfd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":49,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":50,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":51,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enabled_provider_drivers\u0027, \",\".join(self.list_drivers()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_f01d1610","line":51,"updated":"2020-06-15 16:16:51.000000000","message":"pep8: E501 line too long (92 \u003e 79 characters)","commit_id":"251cdb77ee07e36990b8ac044d4c25436470949a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"40371a5b47494365561cc0b14bf228f2283ebc87","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list_drivers(self):"},{"line_number":39,"context_line":"        \"\"\"List lbaas drivers"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        conn \u003d sdk.connet()"},{"line_number":42,"context_line":"        providers \u003d list(conn.load_balancer.providers())"},{"line_number":43,"context_line":"        names \u003d [i.name for i in providers]"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_19fa7541","line":40,"updated":"2020-06-15 19:18:35.000000000","message":"pep8: H405  multi line docstring summary not separated with an empty line","commit_id":"2e328bf7b55b801e898686928e98dba6d9688ce3"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b3656297350fe0c60bdd378806609df8ad6eb34c","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list_drivers(self):"},{"line_number":39,"context_line":"        \"\"\"List lbaas drivers"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        conn \u003d sdk.connet()"},{"line_number":42,"context_line":"        providers \u003d list(conn.load_balancer.providers())"},{"line_number":43,"context_line":"        names \u003d [i.name for i in providers]"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_90ae33e5","line":40,"updated":"2020-06-17 11:41:22.000000000","message":"pep8: H405  multi line docstring summary not separated with an empty line","commit_id":"747f042498d7f2cc1f9ebdad89ad8b8410a1c488"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"05465cf1151f474d6a624a39605421ea8b65be5a","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":48,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":49,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":50,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enabled_provider_drivers\u0027,"},{"line_number":51,"context_line":"                 \",\".join(self.list_drivers()))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_00f5b857","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"updated":"2020-06-17 09:49:56.000000000","message":"this one sets _member_ role but we need Member role, can we fix that one also in same patch?","commit_id":"747f042498d7f2cc1f9ebdad89ad8b8410a1c488"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4a04c688292bc716b0236879aee185d10abbeb5c","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":48,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":49,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":50,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enabled_provider_drivers\u0027,"},{"line_number":51,"context_line":"                 \",\".join(self.list_drivers()))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_800a6823","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"in_reply_to":"bf51134e_00f5b857","updated":"2020-06-17 09:57:35.000000000","message":"I think we don\u0027t use Member anymore.","commit_id":"747f042498d7f2cc1f9ebdad89ad8b8410a1c488"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"bf462f5be032e50c7eea2f73f384364953e329e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":48,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":49,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":50,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enabled_provider_drivers\u0027,"},{"line_number":51,"context_line":"                 \",\".join(self.list_drivers()))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_7bc26587","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"in_reply_to":"bf51134e_00f5b857","updated":"2020-06-17 10:20:36.000000000","message":"Yes, we can do that.","commit_id":"747f042498d7f2cc1f9ebdad89ad8b8410a1c488"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"bf462f5be032e50c7eea2f73f384364953e329e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027,"},{"line_number":48,"context_line":"                 conf.get(\u0027auth\u0027, \u0027tempest_roles\u0027).split(\u0027,\u0027)[0])"},{"line_number":49,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":50,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enabled_provider_drivers\u0027,"},{"line_number":51,"context_line":"                 \",\".join(self.list_drivers()))"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf51134e_fb93154e","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":65},"in_reply_to":"bf51134e_800a6823","updated":"2020-06-17 10:20:36.000000000","message":"Luigi is right. It is changed to member.","commit_id":"747f042498d7f2cc1f9ebdad89ad8b8410a1c488"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"0c22987310c1623f9b6961bcd1cf94edbc8cab84","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def list_drivers(self):"},{"line_number":39,"context_line":"        \"\"\"List lbaas drivers"},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        conn \u003d sdk.connet()"},{"line_number":42,"context_line":"        providers \u003d list(conn.load_balancer.providers())"},{"line_number":43,"context_line":"        names \u003d [i.name for i in providers]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bf51134e_9cc64c67","line":40,"updated":"2020-06-17 14:23:17.000000000","message":"pep8: H405  multi line docstring summary not separated with an empty line","commit_id":"bf8c7091920fb012233e684eb8d630755163dd06"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"606984c33e2783c74086cd106b646f695458fb17","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        return names"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":48,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027member_role\u0027, \u0027member\u0027)"},{"line_number":49,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027region\u0027, conf.get(\u0027identity\u0027, \u0027region\u0027))"},{"line_number":50,"context_line":"        conf.set(\u0027load_balancer\u0027, \u0027enabled_provider_drivers\u0027,"},{"line_number":51,"context_line":"                 \",\".join(self.list_drivers()))"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf51134e_5f9f6302","line":48,"range":{"start_line":48,"start_character":50,"end_line":48,"end_character":56},"updated":"2020-07-07 09:18:57.000000000","message":"why do we need to set this specifically to \u0027member\u0027? what was wrong with the original approach where we chose the first role from auth.tempest_roles?","commit_id":"dceff7b91e8ef53ae755a57395d9ce1ba5c75de5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d7d66295b5cb1444361766daa1f2651ef920a4d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        return \"octavia\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_drivers(self):"},{"line_number":38,"context_line":"        \"\"\"List lbaas drivers"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        \"\"\""},{"line_number":41,"context_line":"        body \u003d self.do_get(self.service_url + \"/v2/lbaas/providers\")"},{"line_number":42,"context_line":"        body \u003d json.loads(body)"},{"line_number":43,"context_line":"        names \u003d ["}],"source_content_type":"text/x-python","patch_set":20,"id":"bf51134e_68409d36","line":40,"range":{"start_line":38,"start_character":8,"end_line":40,"end_character":11},"updated":"2020-07-08 08:44:12.000000000","message":"\"\"\"List lbaas drivers\"\"\"","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9d7d66295b5cb1444361766daa1f2651ef920a4d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return names"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":49,"context_line":"        conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        conf.set(\"load_balancer\", \"region\", conf.get(\"identity\", \"region\"))"},{"line_number":51,"context_line":"        conf.set("},{"line_number":52,"context_line":"            \"load_balancer\","}],"source_content_type":"text/x-python","patch_set":20,"id":"bf51134e_483679e9","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":57},"updated":"2020-07-08 08:44:12.000000000","message":"I don\u0027t like setting an exact value here, I would leave it as it was before unless there is a strong reason why not to","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"1ef23660b6ee44848508b4c213a31bc419d48af4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return names"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":49,"context_line":"        conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        conf.set(\"load_balancer\", \"region\", conf.get(\"identity\", \"region\"))"},{"line_number":51,"context_line":"        conf.set("},{"line_number":52,"context_line":"            \"load_balancer\","}],"source_content_type":"text/x-python","patch_set":20,"id":"bf51134e_c5841d61","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":57},"in_reply_to":"bf51134e_35c0b97c","updated":"2020-07-09 05:48:41.000000000","message":"I agree with Luigi, please look for \u0027member\u0027 role in auth.tempest_roles and if exists then use it, if not then use item from auth.tempest_roles.","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"981f4638149111592a618bcd1658fcbb04ade6a4","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return names"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":49,"context_line":"        conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        conf.set(\"load_balancer\", \"region\", conf.get(\"identity\", \"region\"))"},{"line_number":51,"context_line":"        conf.set("},{"line_number":52,"context_line":"            \"load_balancer\","}],"source_content_type":"text/x-python","patch_set":20,"id":"bf51134e_a3abf61a","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":57},"in_reply_to":"bf51134e_483679e9","updated":"2020-07-08 10:23:47.000000000","message":"Value is getting set to \"Member\" because it is got override here: https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/general_config/featureset062.yml#L60\n\n\nAfter this i\u0027ll remove it from tripleo-quickstart.","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"a3afdaf5036ba61a18ad1630ee08a21cb0655eef","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return names"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":49,"context_line":"        conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        conf.set(\"load_balancer\", \"region\", conf.get(\"identity\", \"region\"))"},{"line_number":51,"context_line":"        conf.set("},{"line_number":52,"context_line":"            \"load_balancer\","}],"source_content_type":"text/x-python","patch_set":20,"id":"bf51134e_35c0b97c","line":49,"range":{"start_line":49,"start_character":49,"end_line":49,"end_character":57},"in_reply_to":"bf51134e_a3abf61a","updated":"2020-07-08 10:48:56.000000000","message":"But again, does the old code work? If it does (picking an element from auth.tempest_roles) then no need to set a specific element here.\n\nYou may want to add a bit more logic then, like: if \u0027member\u0027 is in auth.tempest_roles, use it; otherwise use the first item from auth.tempest_roles (if the other cores agree).","commit_id":"3c957eef48b585dd7d16e49bbb0aa253164d990a"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"492f80f4c5b0eecd8a38feb1280aa2eb32551850","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        if not conf.has_option(\"auth\", \"tempest_roles\") \\"},{"line_number":48,"context_line":"                or conf.get(\"auth\", \"tempest_roles\") not in [\"\", None]:"},{"line_number":49,"context_line":"            conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            conf.set(\"load_balancer\", \"member_role\","}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_2d01426b","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":71},"updated":"2020-07-14 09:18:19.000000000","message":"I\u0027m not sure this is the intended behavior, because if I am understanding it right it is overriding the value explicitly set by the user to \"member\".","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"f913020a1b550987d3b5949ecaa3ff7299f56986","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        if not conf.has_option(\"auth\", \"tempest_roles\") \\"},{"line_number":48,"context_line":"                or conf.get(\"auth\", \"tempest_roles\") not in [\"\", None]:"},{"line_number":49,"context_line":"            conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            conf.set(\"load_balancer\", \"member_role\","}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_ed50ea34","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":71},"in_reply_to":"bf51134e_2d01426b","updated":"2020-07-14 09:34:46.000000000","message":"It\u0027s not overriding the value. If it is not set then we are setting it to the \"member\". Else we are using value which is already set to \"member_role\".","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"},{"author":{"_account_id":30750,"name":"amolkahat","display_name":"Amol Kahat","email":"amolkahat@gmail.com","username":"amolkahat"},"change_message_id":"95ca1a4b7725f70efb6d5e908946844a0bbe0328","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        if not conf.has_option(\"auth\", \"tempest_roles\") \\"},{"line_number":48,"context_line":"                or conf.get(\"auth\", \"tempest_roles\") not in [\"\", None]:"},{"line_number":49,"context_line":"            conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            conf.set(\"load_balancer\", \"member_role\","}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_26a31fb4","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":71},"in_reply_to":"bf51134e_50ca49a0","updated":"2020-07-14 12:42:55.000000000","message":"I updated it in patch set 29. Now \"not\" isn\u0027t there so it make seance.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"3b641a6fb07b35d7553d20ff527d2213aeea10ce","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def post_configuration(self, conf, is_service):"},{"line_number":47,"context_line":"        if not conf.has_option(\"auth\", \"tempest_roles\") \\"},{"line_number":48,"context_line":"                or conf.get(\"auth\", \"tempest_roles\") not in [\"\", None]:"},{"line_number":49,"context_line":"            conf.set(\"load_balancer\", \"member_role\", \"member\")"},{"line_number":50,"context_line":"        else:"},{"line_number":51,"context_line":"            conf.set(\"load_balancer\", \"member_role\","}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_50ca49a0","line":48,"range":{"start_line":48,"start_character":16,"end_line":48,"end_character":71},"in_reply_to":"bf51134e_ed50ea34","updated":"2020-07-14 12:01:03.000000000","message":"That is the first part of the conditional. The second one is not negated.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"5ff1d0cec472916614aa65a2fb3434954e49f1f6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        super(LoadBalancerService, self).set_versions(top_level\u003dFalse)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def set_default_tempest_options(self, conf):"},{"line_number":25,"context_line":"        conf.set(\"load_balancer\", \"enable_security_groups\", \"True\")"},{"line_number":26,"context_line":"        conf.set(\"load_balancer\", \"admin_role\", \"admin\")"},{"line_number":27,"context_line":"        conf.set(\"load_balancer\", \"RBAC_test_type\", \"owner_or_admin\")"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"bf51134e_bd18ced2","line":25,"updated":"2020-07-15 08:47:24.000000000","message":"I\u0027m generally fine with this change, but I don\u0027t like this forced change of formatting from \u0027 to \" for no reason. Not that I prefer one to another, but looking at the other files we use the single tick \u0027 .\nAdding new code to an existing code means following the same convention. I would revert the usage of \" to \u0027 here.\n\nGiven the fact I haven\u0027t checked it before and this request comes late in the cycle, I\u0027m not going to -1 but I\u0027m not going to approve it either.","commit_id":"a26b522f97f0b670a08b9a8dc93e55c7c1895946"}],"config_tempest/tests/base.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5a6900c717c504f165ab0f18c0766c3c8e5b542e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    FAKE_PROVIDERS \u003d ("},{"line_number":214,"context_line":"        {"},{"line_number":215,"context_line":"            \"providers\": [{"},{"line_number":216,"context_line":"                    \"name\": \"amphora\","},{"line_number":217,"context_line":"                    \"description\": \"The Octavia Amphora driver.\""},{"line_number":218,"context_line":"                }, {"},{"line_number":219,"context_line":"                    \"name\": \"octavia\","}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_e862f4ac","line":216,"updated":"2020-07-07 21:16:38.000000000","message":"pep8: E126 continuation line over-indented for hanging indent","commit_id":"07dc31b1a8e1efa5d300761f3102312106a22be6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5a6900c717c504f165ab0f18c0766c3c8e5b542e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            \"providers\": [{"},{"line_number":216,"context_line":"                    \"name\": \"amphora\","},{"line_number":217,"context_line":"                    \"description\": \"The Octavia Amphora driver.\""},{"line_number":218,"context_line":"                }, {"},{"line_number":219,"context_line":"                    \"name\": \"octavia\","},{"line_number":220,"context_line":"                    \"description\": \"Deprecated alias of the Octavia driver.\""},{"line_number":221,"context_line":"                }]"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_485a00f3","line":218,"updated":"2020-07-07 21:16:38.000000000","message":"pep8: E121 continuation line under-indented for hanging indent","commit_id":"07dc31b1a8e1efa5d300761f3102312106a22be6"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"492f80f4c5b0eecd8a38feb1280aa2eb32551850","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            }"},{"line_number":209,"context_line":"        }"},{"line_number":210,"context_line":"    )"},{"line_number":211,"context_line":"    FAKE_PROVIDERS \u003d ("},{"line_number":212,"context_line":"        {"},{"line_number":213,"context_line":"            \"providers\": [{"},{"line_number":214,"context_line":"                \"name\": \"amphora\","}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_0dbefed3","line":211,"range":{"start_line":211,"start_character":4,"end_line":211,"end_character":18},"updated":"2020-07-14 09:18:19.000000000","message":"This constant name is too loose in scope. It should be narrowed to the load balancing service.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"}],"config_tempest/tests/services/test_octavia.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from fixtures import MonkeyPatch"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_9d059c7d","line":16,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F401 \u0027unittest.mock\u0027 imported but unused","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from fixtures import MonkeyPatch"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from config_tempest.services.identity import IdentityService"},{"line_number":21,"context_line":"from config_tempest.services.octavia import LoadBalancerService"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_7d088890","line":18,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F401 \u0027fixtures.MonkeyPatch\u0027 imported but unused","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from fixtures import MonkeyPatch"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from config_tempest.services.identity import IdentityService"},{"line_number":21,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":22,"context_line":"from config_tempest.tempest_conf import TempestConf"},{"line_number":23,"context_line":"from config_tempest.tests.base import BaseServiceTest"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_ddff1465","line":20,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F401 \u0027config_tempest.services.identity.IdentityService\u0027 imported but unused","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                    \"ServiceType\","},{"line_number":39,"context_line":"                                    self.FAKE_URL + \"v2.0/\","},{"line_number":40,"context_line":"                                    self.FAKE_TOKEN,"},{"line_number":41,"context_line":"                                    disable_ssl_valication\u003dFalse).list_drivers()"},{"line_number":42,"context_line":"        name \u003d [i.split(\":\")[0] for i in lbaas]"},{"line_number":43,"context_line":"        assert \u0027octavia\u0027 in names"},{"line_number":44,"context_line":"        assert \u0027amphora\u0027 in names"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_bd02206e","line":41,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                    self.FAKE_URL + \"v2.0/\","},{"line_number":40,"context_line":"                                    self.FAKE_TOKEN,"},{"line_number":41,"context_line":"                                    disable_ssl_valication\u003dFalse).list_drivers()"},{"line_number":42,"context_line":"        name \u003d [i.split(\":\")[0] for i in lbaas]"},{"line_number":43,"context_line":"        assert \u0027octavia\u0027 in names"},{"line_number":44,"context_line":"        assert \u0027amphora\u0027 in names"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_1df98c7f","line":42,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F841 local variable \u0027name\u0027 is assigned to but never used","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                                    self.FAKE_TOKEN,"},{"line_number":41,"context_line":"                                    disable_ssl_valication\u003dFalse).list_drivers()"},{"line_number":42,"context_line":"        name \u003d [i.split(\":\")[0] for i in lbaas]"},{"line_number":43,"context_line":"        assert \u0027octavia\u0027 in names"},{"line_number":44,"context_line":"        assert \u0027amphora\u0027 in names"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_octavia_service_post_conf(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_fdf3f89d","line":43,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F821 undefined name \u0027names\u0027","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                                    disable_ssl_valication\u003dFalse).list_drivers()"},{"line_number":42,"context_line":"        name \u003d [i.split(\":\")[0] for i in lbaas]"},{"line_number":43,"context_line":"        assert \u0027octavia\u0027 in names"},{"line_number":44,"context_line":"        assert \u0027amphora\u0027 in names"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_octavia_service_post_conf(self):"},{"line_number":47,"context_line":"        client_service_mock \u003d self.FakeServiceClient(services\u003d{"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_5df3049f","line":44,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F821 undefined name \u0027names\u0027","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027services\u0027: [{\"name\": \"octavia\", \"enabled\": True}]})"},{"line_number":49,"context_line":"        self.Service.client \u003d client_service_mock"},{"line_number":50,"context_line":"        self.Service.post_configuration(self.conf, client_service_mock)"},{"line_number":51,"context_line":"        self._assert_conf_get_not_raises(configparser.NoSectionError, \"service_available\","},{"line_number":52,"context_line":"                                         \"octavia\")"},{"line_number":53,"context_line":"        client_service_mock \u003d self.FakeServiceClient(services\u003d{"},{"line_number":54,"context_line":"            \u0027services\u0027: [{\"name\": \"octavia\", \"enabled\": True}]})"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_9d2abce4","line":51,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: E501 line too long (90 \u003e 79 characters)","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"de9d2398f57c74c4b91e567c95b6dfc3fc812fed","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027services\u0027: [{\"name\": \"octavia\", \"enabled\": True}]})"},{"line_number":49,"context_line":"        self.Service.client \u003d client_service_mock"},{"line_number":50,"context_line":"        self.Service.post_configuration(self.conf, client_service_mock)"},{"line_number":51,"context_line":"        self._assert_conf_get_not_raises(configparser.NoSectionError, \"service_available\","},{"line_number":52,"context_line":"                                         \"octavia\")"},{"line_number":53,"context_line":"        client_service_mock \u003d self.FakeServiceClient(services\u003d{"},{"line_number":54,"context_line":"            \u0027services\u0027: [{\"name\": \"octavia\", \"enabled\": True}]})"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_3dee10b4","line":51,"updated":"2020-07-06 07:06:11.000000000","message":"pep8: F821 undefined name \u0027configparser\u0027","commit_id":"9ee1b5f34778c9a2b6a0f63888d5ab4634e7d70a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"606984c33e2783c74086cd106b646f695458fb17","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        assert \u0027amphora\u0027 in names"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @mock.patch(\"config_tempest.services.services.Services.is_service\")"},{"line_number":46,"context_line":"    @mock.patch(\"config_tempest.services.services.Services.post_configuration\")"},{"line_number":47,"context_line":"    def test_octavia_service_post_conf(self, mock_is_service,"},{"line_number":48,"context_line":"                                       mock_post_configuration):"},{"line_number":49,"context_line":"        client_service_mock \u003d self.FakeServiceClient(services\u003d{"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf51134e_1ff04b67","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":79},"updated":"2020-07-07 09:18:57.000000000","message":"why do you mock the method this test is supposed to test?","commit_id":"dceff7b91e8ef53ae755a57395d9ce1ba5c75de5"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"606984c33e2783c74086cd106b646f695458fb17","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        client_service_mock \u003d self.FakeServiceClient(services\u003d{"},{"line_number":56,"context_line":"            \u0027services\u0027: [{\"name\": \"octavia\", \"enabled\": True}]})"},{"line_number":57,"context_line":"        self.Service.client \u003d client_service_mock"},{"line_number":58,"context_line":"        self.Service.post_configuration(self.conf, client_service_mock)"},{"line_number":59,"context_line":"        self.Service.post_configuration(self.conf, mock_is_service)"},{"line_number":60,"context_line":"        self.Service.post_configuration(self.conf, mock_post_configuration)"},{"line_number":61,"context_line":"        self.assertEqual(self.conf.get(\u0027service_available\u0027, \u0027octavia\u0027),"},{"line_number":62,"context_line":"                         \u0027True\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"bf51134e_9f03bb42","line":60,"range":{"start_line":58,"start_character":0,"end_line":60,"end_character":75},"updated":"2020-07-07 09:18:57.000000000","message":"why do you call post_configuration 3 times? based on the arguments the method is accepting only the call on line 59 is correct","commit_id":"dceff7b91e8ef53ae755a57395d9ce1ba5c75de5"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5a6900c717c504f165ab0f18c0766c3c8e5b542e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"# under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from six.moves import configparser"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from config_tempest.services.identity import IdentityService"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_a84f5c32","line":16,"updated":"2020-07-07 21:16:38.000000000","message":"pep8: F401 \u0027six.moves.configparser\u0027 imported but unused","commit_id":"07dc31b1a8e1efa5d300761f3102312106a22be6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"5a6900c717c504f165ab0f18c0766c3c8e5b542e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from six.moves import configparser"},{"line_number":17,"context_line":"from unittest import mock"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from config_tempest.services.identity import IdentityService"},{"line_number":20,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":21,"context_line":"from config_tempest.tempest_conf import TempestConf"},{"line_number":22,"context_line":"from config_tempest.tests.base import BaseServiceTest"}],"source_content_type":"text/x-python","patch_set":18,"id":"bf51134e_086008a5","line":19,"updated":"2020-07-07 21:16:38.000000000","message":"pep8: F401 \u0027config_tempest.services.identity.IdentityService\u0027 imported but unused","commit_id":"07dc31b1a8e1efa5d300761f3102312106a22be6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ea8d85d1ff84f5a8af253b57cb14b891e8777f53","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from config_tempest.services.identity import IdentityService"},{"line_number":19,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":20,"context_line":"from config_tempest.tempest_conf import TempestConf"},{"line_number":21,"context_line":"from config_tempest.tests.base import BaseServiceTest"}],"source_content_type":"text/x-python","patch_set":19,"id":"bf51134e_8202300a","line":18,"updated":"2020-07-08 07:27:49.000000000","message":"pep8: F401 \u0027config_tempest.services.identity.IdentityService\u0027 imported but unused","commit_id":"94b12a51c0272236427a9ffd3a5cb16ea9e241d6"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"66a5211f299575f87640b23194bb6313be3227a4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":19,"context_line":"from config_tempest.services.services import Services"},{"line_number":20,"context_line":"from config_tempest.tempest_conf import TempestConf"},{"line_number":21,"context_line":"from config_tempest.tests.base import (BaseServiceTest as bst,"},{"line_number":22,"context_line":"                                       BaseConfigTempestTest)"}],"source_content_type":"text/x-python","patch_set":25,"id":"bf51134e_1670db07","line":19,"updated":"2020-07-13 14:09:12.000000000","message":"pep8: F401 \u0027config_tempest.services.services.Services\u0027 imported but unused","commit_id":"39e8193da46860472c8ae3dee86e7a7ec2ac8a51"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"66a5211f299575f87640b23194bb6313be3227a4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":19,"context_line":"from config_tempest.services.services import Services"},{"line_number":20,"context_line":"from config_tempest.tempest_conf import TempestConf"},{"line_number":21,"context_line":"from config_tempest.tests.base import (BaseServiceTest as bst,"},{"line_number":22,"context_line":"                                       BaseConfigTempestTest)"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"bf51134e_7662f73f","line":20,"updated":"2020-07-13 14:09:12.000000000","message":"pep8: F401 \u0027config_tempest.tempest_conf.TempestConf\u0027 imported but unused","commit_id":"39e8193da46860472c8ae3dee86e7a7ec2ac8a51"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"66a5211f299575f87640b23194bb6313be3227a4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":19,"context_line":"from config_tempest.services.services import Services"},{"line_number":20,"context_line":"from config_tempest.tempest_conf import TempestConf"},{"line_number":21,"context_line":"from config_tempest.tests.base import (BaseServiceTest as bst,"},{"line_number":22,"context_line":"                                       BaseConfigTempestTest)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"bf51134e_5667f34d","line":21,"updated":"2020-07-13 14:09:12.000000000","message":"pep8: H301  one import per line","commit_id":"39e8193da46860472c8ae3dee86e7a7ec2ac8a51"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e83e2dc3950552c947c76c5695fc920f4779e137","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from config_tempest.services.octavia import LoadBalancerService"},{"line_number":19,"context_line":"from config_tempest.tests.base import BaseServiceTest as bst"},{"line_number":20,"context_line":"from config_tempest.tests.base import BaseConfigTempestTest"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestOctaviaService(BaseConfigTempestTest):"}],"source_content_type":"text/x-python","patch_set":26,"id":"bf51134e_c7850faf","line":20,"updated":"2020-07-13 16:40:26.000000000","message":"pep8: H306  imports not in alphabetical order (config_tempest.tests.base.baseservicetest, config_tempest.tests.base.baseconfigtempesttest)","commit_id":"9b835a98d5a2876663cc8426499277df673e440e"},{"author":{"_account_id":6469,"name":"Carlos Gonçalves","display_name":"Carlos Goncalves","email":"cgoncalves@redhat.com","username":"cgoncalves"},"change_message_id":"492f80f4c5b0eecd8a38feb1280aa2eb32551850","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            \"octavia:Deprecated alias of the Octavia driver.\","},{"line_number":43,"context_line":"        ]"},{"line_number":44,"context_line":"        providers \u003d self.Service.list_drivers()"},{"line_number":45,"context_line":"        self.assertItemsEqual(providers, expected_resp)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    @mock.patch(\"config_tempest.services.services.Services.is_service\")"},{"line_number":48,"context_line":"    def test_octavia_service_post_configuration(self, mock_is_service):"}],"source_content_type":"text/x-python","patch_set":27,"id":"bf51134e_8dcdee67","line":45,"range":{"start_line":45,"start_character":13,"end_line":45,"end_character":29},"updated":"2020-07-14 09:18:19.000000000","message":"In Python 3, this method is named assertCountEqual.","commit_id":"f31b4323b7a325c30e372f3c3e4224c3463ae0c9"}]}