)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fc52e755b38f7f2f3e1a4c6591ccbc8a10b265ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Soniya Vyas \u003csvyas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-29 17:16:00 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Need to update Python-tempestconf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to update python-tempestconf for populating the"},{"line_number":10,"context_line":"tempestconf when multistore_image enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f75fc5c_039965a6","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2021-11-29 13:08:53.000000000","message":"better to avoid this, gerrit has a nice feature (I\u0027m trying to use it myself too) when you can mark a patch as WIP by -w param \"git review -w\". In that case the WIP in the commit message is redundant - also the downside of having WIP within the commit message is that in order to remove that the check gates need to be triggered again","commit_id":"fae16bec4942d2ba8714911dda512d94702d1051"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fc52e755b38f7f2f3e1a4c6591ccbc8a10b265ff","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Soniya Vyas \u003csvyas@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-29 17:16:00 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Need to update Python-tempestconf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to update python-tempestconf for populating the"},{"line_number":10,"context_line":"tempestconf when multistore_image enabled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"72bfadf9_9f43c5d1","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":39},"updated":"2021-11-29 13:08:53.000000000","message":"let\u0027s be more descriptive here, f.e.: setting XY opt to True","commit_id":"fae16bec4942d2ba8714911dda512d94702d1051"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fc52e755b38f7f2f3e1a4c6591ccbc8a10b265ff","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Need to update Python-tempestconf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Need to update python-tempestconf for populating the"},{"line_number":10,"context_line":"tempestconf when multistore_image enabled"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Soniya Vyas \u003csvyas@redhat.com\u003e"},{"line_number":13,"context_line":"Change-Id: I2623af02434a262c2108454bce4432d032d8b7cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"45b3e37e_9c0bda50","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":41},"updated":"2021-11-29 13:08:53.000000000","message":"same here, let\u0027s mention the following: why, where this change is needed, what it will solve, etc","commit_id":"fae16bec4942d2ba8714911dda512d94702d1051"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6b90bac97ea3b62861f18c535a107f08703e55d4","unresolved":true,"context_lines":[{"line_number":11,"context_line":"missing in cs9."},{"line_number":12,"context_line":"Parameter \u0027Image-feature-enabled.import_image\u0027"},{"line_number":13,"context_line":"covers all the above missing parameter we need to"},{"line_number":14,"context_line":"enable in cs9. Hence, this is an attemmpt to address"},{"line_number":15,"context_line":"this issue."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Signed-off-by: Soniya Vyas \u003csvyas@redhat.com\u003e"},{"line_number":18,"context_line":"Change-Id: I2623af02434a262c2108454bce4432d032d8b7cb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d21302e3_db065bc0","line":15,"range":{"start_line":14,"start_character":15,"end_line":15,"end_character":11},"updated":"2021-11-30 12:04:20.000000000","message":"Attempt you mean, you\u0027re not sure if this will fix the problem for Centos 9? Do we have a testproject testing it on Centos 7, 8 and 9? We can\u0027t fix it for Centos 9 and break for the other previous versions.","commit_id":"1152704e2f97f81af06fa4983ef4393f5bcc339d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"ac8a627339e8ccfef11753cc89d0e8d109b576fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d5336110_044a1cc5","updated":"2021-11-01 15:01:02.000000000","message":"I wonder why not all check jobs were triggered, weird .. yeah, the syntax of the conf.set call is not correct, it should be like conf.set(\u003csection within tempest.conf\u003e, \u003coption\u003e, \u003cvalue\u003e)","commit_id":"01c4c958cc70f0ea8bc196a0e849477ec14f5dc3"},{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"99f065b90a4c4c19d0de88b6ed8a09e709e3d37f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82b56b11_e31d743f","updated":"2021-10-29 10:57:45.000000000","message":"Please have a look at the syntax, we also need some unit test and testproject to validate it","commit_id":"01c4c958cc70f0ea8bc196a0e849477ec14f5dc3"},{"author":{"_account_id":30742,"name":"Soniya Murlidhar Vyas","email":"svyas@redhat.com","username":"svyas"},"change_message_id":"f7c76ddc6df512273b87f208c36a8f7cc6f57d7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c02d4b4a_27112cbd","in_reply_to":"82b56b11_e31d743f","updated":"2021-10-29 13:03:01.000000000","message":"okay..i would update with unit test and test-project","commit_id":"01c4c958cc70f0ea8bc196a0e849477ec14f5dc3"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"66c810267833643fdaf921ea256dc8bab512451e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cb401b3e_580ecaf9","updated":"2021-11-29 12:07:02.000000000","message":"Does it mean the option is enabled by default in all OSP version supported, regardless of the way they were installed? \nI see this is enabled since victoria - does it mean we need to stop supporting ussuri? That would need at least a release note. For sure the change needs a reference to the change where this option is always enabled . Can the property be dynamically discovered?\n\nAlso, please fix the commit message when you remove the WIP - the first line should explain what\u0027s going on at a glance, see for example:\nhttps://review.opendev.org/c/openinfra/python-tempestconf/+/775195\nhttps://review.opendev.org/c/openinfra/python-tempestconf/+/720093\n\n","commit_id":"fae16bec4942d2ba8714911dda512d94702d1051"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"5d232451ad5dce92378dfa075c30ce67e1c1dc71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44631f36_52df704d","updated":"2021-11-30 12:07:12.000000000","message":"If this affect only centos-9 on tripleo, we can add it on the job definition there is the tempest_tempestconf_profile_overrides variable.\nSee an example in https://opendev.org/openstack/tripleo-quickstart/src/branch/master/config/general_config/featureset062.yml#L82","commit_id":"1152704e2f97f81af06fa4983ef4393f5bcc339d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7653a35dc406bc8415ead140f0570105c97a1fbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2a6eaa28_6d82585d","updated":"2021-11-30 11:46:43.000000000","message":"Please change the first line as I explained before.\n\nMoreover, the need for something in c9 is not a reason for this change. If the parameter is missing in some specific deployment, then it should be added to that deployment, unless it can be detected.\n\nIf you think this is the new default and should be changed for this reason, please explain why.","commit_id":"1152704e2f97f81af06fa4983ef4393f5bcc339d"}],"config_tempest/services/image.py":[{"author":{"_account_id":12393,"name":"chandan kumar","display_name":"Chandan Kumar","email":"chkumar@redhat.com","username":"chkumar246"},"change_message_id":"99f065b90a4c4c19d0de88b6ed8a09e709e3d37f","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":60,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":61,"context_line":"        # because we don\u0027t have to specify overrides."},{"line_number":62,"context_line":"        conf.set(\u0027image-feature-enabled.import_image\u0027,"},{"line_number":63,"context_line":"                 \u0027console_output\u0027, \u0027True\u0027)"},{"line_number":64,"context_line":"        if \u0027cirros\u0027 in conf.get_defaulted(\u0027image\u0027,"},{"line_number":65,"context_line":"                                          \u0027image_path\u0027).rsplit(\u0027/\u0027)[-1]:"},{"line_number":66,"context_line":"            conf.set(\u0027validation\u0027, \u0027image_ssh_user\u0027, \u0027cirros\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6249009_71f5635b","line":63,"range":{"start_line":62,"start_character":8,"end_line":63,"end_character":42},"updated":"2021-10-29 10:57:45.000000000","message":"I think the syntex would be\n        conf.set(\u0027image-feature-enabled.import_image\u0027,\u0027True\u0027)","commit_id":"01c4c958cc70f0ea8bc196a0e849477ec14f5dc3"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fc52e755b38f7f2f3e1a4c6591ccbc8a10b265ff","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":60,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":61,"context_line":"        # because we don\u0027t have to specify overrides."},{"line_number":62,"context_line":"        conf.set(\u0027image-feature-enabled.import_image\u0027, \u0027True\u0027)"},{"line_number":63,"context_line":"        if \u0027cirros\u0027 in conf.get_defaulted(\u0027image\u0027,"},{"line_number":64,"context_line":"                                          \u0027image_path\u0027).rsplit(\u0027/\u0027)[-1]:"},{"line_number":65,"context_line":"            conf.set(\u0027validation\u0027, \u0027image_ssh_user\u0027, \u0027cirros\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"704ad2bb_6f6dc2f6","line":62,"range":{"start_line":62,"start_character":17,"end_line":62,"end_character":53},"updated":"2021-11-29 13:08:53.000000000","message":"let\u0027s at least fix this so that we can see how the gate jobs will behave with this change.\n\nit should be:\nconf.set(\u0027image-feature-enabled\u0027, \u0027import_image\u0027, \u0027True\u0027)","commit_id":"fae16bec4942d2ba8714911dda512d94702d1051"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"6b90bac97ea3b62861f18c535a107f08703e55d4","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        # When cirros is the image, set validation.image_ssh_user to cirros."},{"line_number":60,"context_line":"        # The option is heavily used in CI and it\u0027s also usefull for refstack,"},{"line_number":61,"context_line":"        # because we don\u0027t have to specify overrides."},{"line_number":62,"context_line":"        conf.set(\u0027image-feature-enabled\u0027, \u0027import_image\u0027, \u0027True\u0027)"},{"line_number":63,"context_line":"        if \u0027cirros\u0027 in conf.get_defaulted(\u0027image\u0027,"},{"line_number":64,"context_line":"                                          \u0027image_path\u0027).rsplit(\u0027/\u0027)[-1]:"},{"line_number":65,"context_line":"            conf.set(\u0027validation\u0027, \u0027image_ssh_user\u0027, \u0027cirros\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"849ad97f_2788e277","line":62,"updated":"2021-11-30 12:04:20.000000000","message":"Please move this up and add proper comments. The comment above is for the line below, make it confuse for people in the future","commit_id":"1152704e2f97f81af06fa4983ef4393f5bcc339d"}],"config_tempest/tests/services/test_image.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fc52e755b38f7f2f3e1a4c6591ccbc8a10b265ff","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.conf \u003d TempestConf()"},{"line_number":49,"context_line":"        self.conf.set(\"image\", \"image_path\", \"my_image.qcow2\")"},{"line_number":50,"context_line":"        self.conf.set(\"image\", \"http_image\", \"http_image.qcow2\")"},{"line_number":51,"context_line":"        self.conf.set(\u0027image-feature-enabled.import_image\u0027, \u0027True\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @mock.patch(\u0027config_tempest.services.image.ImageService._find_image\u0027)"},{"line_number":54,"context_line":"    @mock.patch(\u0027config_tempest.services.image.ImageService\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9793fd57_24b333c2","line":51,"range":{"start_line":51,"start_character":8,"end_line":51,"end_character":67},"updated":"2021-11-29 13:08:53.000000000","message":"ditto","commit_id":"fae16bec4942d2ba8714911dda512d94702d1051"}]}