)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"77462a6a21997a55b6a3829cef099ef6d4ccd058","unresolved":true,"context_lines":[{"line_number":15,"context_line":"of the backend. So the values of the backend names will be"},{"line_number":16,"context_line":"different as bellow:"},{"line_number":17,"context_line":"Native \u003d\u003e backend_names\u003dcephfsnative"},{"line_number":18,"context_line":"Ganesha \u003d\u003e backend_names\u003dcephfs"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ife21f28de60a2dc052e2c76a1e2fe6b1090e32ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3607a812_afce3acc","line":18,"updated":"2022-04-27 10:09:31.000000000","message":"NIT backend_names\u003dcephfsnfs","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b30213f16598531fb07fc551d43f79a90d13e9e5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"of the backend. So the values of the backend names will be"},{"line_number":16,"context_line":"different as bellow:"},{"line_number":17,"context_line":"Native \u003d\u003e backend_names\u003dcephfsnative"},{"line_number":18,"context_line":"Ganesha \u003d\u003e backend_names\u003dcephfs"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ife21f28de60a2dc052e2c76a1e2fe6b1090e32ee"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a366d60e_8ff938fc","line":18,"in_reply_to":"3607a812_afce3acc","updated":"2022-04-28 06:07:22.000000000","message":"Done","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"77462a6a21997a55b6a3829cef099ef6d4ccd058","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50feaadd_4cf1544c","updated":"2022-04-27 10:09:31.000000000","message":"Better to be more explicit IMHO, thanks Liron!","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6fda1a4e325f0104a52776cc4e8f3c71d51c24e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70d2719d_349509e2","updated":"2022-04-27 10:28:06.000000000","message":"I\u0027m not sure I follow.\nDoesn\u0027t backend_names reflect the names of the backend as it is defined in manila.\nWhy should it be changed by tempestconf? How do you find the original backend if you set it here to a a name which doesn\u0027t exist?\n\nIf you have multiple backends, shouldn\u0027t they be differentiated by their name and/or ID? ","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"fe50f20bd03e39d2db2a7cd20ea39d2ae2667b32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2b8fe17_25428777","in_reply_to":"208abdff_750fb663","updated":"2022-04-28 09:25:46.000000000","message":"You\u0027re right.\nThe fix should be in the template.\nI noticed that the backend names are same in both yaml files:\n[stack@undercloud-0 ~]$ cat /usr/share/openstack-tripleo-heat-templates/environments/manila-cephfsganesha-config.yaml | grep ManilaCephFSBackendName\n  ManilaCephFSBackendName: cephfs\n\n\n[stack@undercloud-0 ~]$ cat /usr/share/openstack-tripleo-heat-templates/environments/manila-cephfsnative-config.yaml | grep ManilaCephFSBackendName\n  ManilaCephFSBackendName: cephfs\n\nSo we need to override this parameter.","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1bd011cd84a0717350d9708a8a7a36e9877189b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4e8a53ef_ba401c68","in_reply_to":"26395971_f4abfa4b","updated":"2022-04-28 10:16:55.000000000","message":"I mean, even if the default values are the same, if you deploy just one template it\u0027s not really a problem, right?\n \nAnd when a person deploys a system with two backends, I guess they will set appropriate different names for the two backends? But I haven\u0027t checked how you set those in tripleo.\n\nIn the end, unless tripleo keeps the default name when you deploy two backends, and depending on their instructions, there may be no real bug.","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b83d37f1c1e4cf11c99b79c9d135630fc5708d93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70f33318_ab026d95","in_reply_to":"4e8a53ef_ba401c68","updated":"2022-04-28 11:16:00.000000000","message":"Yes\u0027 it\u0027s not really a bug.","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"64915d1a9ef4f4c14ea219443a4fa04bfef6102a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"208abdff_750fb663","in_reply_to":"704cf3cb_f046a2cf","updated":"2022-04-28 08:38:11.000000000","message":"You override them, but they match what is configured in manila, if I read the code correctly.\n\nFor example, in the manila-tempest-plugin-cephfs-native job definition\nhttps://opendev.org/openstack/manila-tempest-plugin/src/branch/master/zuul.d/manila-tempest-jobs.yaml#L292\nyou set both\ndevstack_localrc.MANILA_ENABLED_BACKENDS: cephfsnative (so the backend will be cephfsnative)\nand then \n    devstack_local_conf\n        test-config:\n          $TEMPEST_CONFIG:\n            share:\n              backend_names: CEPHFSNATIVE\n\nSame for the manila-tempest-plugin-cephfs-nfs job (where the values are cephfsnative/CEPHFSNATIVE)\n\nDoesn\u0027t this means the values configured in tempest.conf must match what the service return?","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b30213f16598531fb07fc551d43f79a90d13e9e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"704cf3cb_f046a2cf","in_reply_to":"70d2719d_349509e2","updated":"2022-04-28 06:07:22.000000000","message":"As I mentioned, in the case of Native and Ganesha, the backend names are exactly the same, but we can distinguish between them according to the storage protocol.\nThere is no unique name or ID for backend.\nIn the upstream we are overriding this parameter. Here we are doing it by python-tempestconf.","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"4ca1b47375c25a6c5879d7ccfac7d8e32a339ed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26395971_f4abfa4b","in_reply_to":"a2b8fe17_25428777","updated":"2022-04-28 09:43:28.000000000","message":"There are two options:\n1. Override \"ManilaCephFSBackendName\" parameter by infrared.\n2. Update the template itself.\n\nWhat is the preferred option ?","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"}],"config_tempest/services/share.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"77462a6a21997a55b6a3829cef099ef6d4ccd058","unresolved":true,"context_lines":[{"line_number":59,"context_line":"                pool_capabilities \u003d pool[\u0027capabilities\u0027]"},{"line_number":60,"context_line":"                protocol \u003d pool_capabilities[\u0027storage_protocol\u0027].lower()"},{"line_number":61,"context_line":"                backends.add(pool[\u0027backend\u0027] + \u0027{}\u0027.format("},{"line_number":62,"context_line":"                    \u0027native\u0027 if protocol \u003d\u003d \u0027cephfs\u0027 else \u0027\u0027))"},{"line_number":63,"context_line":"                enable_protocols.update(protocol.split(\u0027_\u0027))"},{"line_number":64,"context_line":"                dhss.add(pool_capabilities[\u0027driver_handles_share_servers\u0027])"},{"line_number":65,"context_line":"                capability_snapshot_support.add("}],"source_content_type":"text/x-python","patch_set":1,"id":"52b1bbab_e65958d1","line":62,"updated":"2022-04-27 10:09:31.000000000","message":"NIT else \u0027nfs\u0027","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"b30213f16598531fb07fc551d43f79a90d13e9e5","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                pool_capabilities \u003d pool[\u0027capabilities\u0027]"},{"line_number":60,"context_line":"                protocol \u003d pool_capabilities[\u0027storage_protocol\u0027].lower()"},{"line_number":61,"context_line":"                backends.add(pool[\u0027backend\u0027] + \u0027{}\u0027.format("},{"line_number":62,"context_line":"                    \u0027native\u0027 if protocol \u003d\u003d \u0027cephfs\u0027 else \u0027\u0027))"},{"line_number":63,"context_line":"                enable_protocols.update(protocol.split(\u0027_\u0027))"},{"line_number":64,"context_line":"                dhss.add(pool_capabilities[\u0027driver_handles_share_servers\u0027])"},{"line_number":65,"context_line":"                capability_snapshot_support.add("}],"source_content_type":"text/x-python","patch_set":1,"id":"d2f72368_f4bbd134","line":62,"in_reply_to":"52b1bbab_e65958d1","updated":"2022-04-28 06:07:22.000000000","message":"Done!\nSorry for the ugly condition, I don\u0027t want it to affect other backends.","commit_id":"472a29c97164841320470623fef7cd2cd6b0fd88"}]}