)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"ba86abd1e3ce31e72b03bdcaa83e4a625c5a9e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"87015d42_9976e2dc","updated":"2022-07-08 15:27:45.000000000","message":"LGTM","commit_id":"f6fd3431e46f89af9c6960ee80d2b7725ddb2d4e"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d6bf93a2e81919d5a800eedd86be5366b56dfdef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d7e5f21b_913fdbc3","updated":"2022-08-31 18:01:44.000000000","message":"Looks good to me!\n\n(I checked zuul. Looks like the tripleo-ci-centos-9-standalone passed)","commit_id":"b9d8d4a43064527092fc63f3f7955672242b043e"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f8a5113a31d318d5f7d8e3cb010d243220a6410c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e98ebcc_808c3159","updated":"2022-08-17 12:08:45.000000000","message":"recheck","commit_id":"b9d8d4a43064527092fc63f3f7955672242b043e"},{"author":{"_account_id":33080,"name":"Mikolaj Ciecierski","display_name":"Mikolaj Ciecierski","email":"mciecier@redhat.com","username":"mciecierski"},"change_message_id":"a99702f2966818c8738884672db4146628797df8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ebfb319_935af350","updated":"2022-08-03 13:01:05.000000000","message":"recheck","commit_id":"b9d8d4a43064527092fc63f3f7955672242b043e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"01ca480c9cb2c92e0b93b2590ed7d98eb3c8b2d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"296e5102_e3c21772","updated":"2022-08-31 15:13:43.000000000","message":"recheck\n\nArx suggested a recheck to ensure it\u0027s not a transient issue with packaging","commit_id":"b9d8d4a43064527092fc63f3f7955672242b043e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ba0a44730179203d1974f37a35cb1a382db8d14c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7631dca0_23e999ed","updated":"2022-08-31 12:27:38.000000000","message":"recheck\n\nwe had more fixes","commit_id":"b9d8d4a43064527092fc63f3f7955672242b043e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"8315d3b9a6dce44cace84e0adc6793a6f99cc8eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83b8da11_e6cf517b","updated":"2022-08-31 14:40:31.000000000","message":"tripleo-citripleo-ci-centos-9-standalone (https://zuul.opendev.org/t/openstack/build/2fd23051f44949b58b09220ea252b11e) failed with an error which seems related to this change, but I\u0027m not sure why the unit tests don\u0027t find the issue:\n\nDEBUG: config_tempest.tests.services.test_volume.TestVolumeService.test_post_configuration_no_volume\nDEBUG: ---------------------------------------------------------------------------------------------\nDEBUG: Captured traceback:\nDEBUG: ~~~~~~~~~~~~~~~~~~~\nDEBUG:     Traceback (most recent call last):\nDEBUG:       File \"/usr/lib64/python3.9/configparser.py\", line 789, in get\nDEBUG:     value \u003d d[option]\nDEBUG:       File \"/usr/lib64/python3.9/collections/__init__.py\", line 941, in __getitem__\nDEBUG:     return self.__missing__(key)            # support subclasses that define __missing__\nDEBUG:       File \"/usr/lib64/python3.9/collections/__init__.py\", line 933, in __missing__\nDEBUG:     raise KeyError(key)\nDEBUG:     KeyError: \u0027backup\u0027\nDEBUG:     \nDEBUG: During handling of the above exception, another exception occurred:\nDEBUG:     Traceback (most recent call last):\nDEBUG:       File \"/usr/lib64/python3.9/unittest/mock.py\", line 1336, in patched\nDEBUG:     return func(*newargs, **newkeywargs)\nDEBUG:       File \"/builddir/build/BUILD/python-tempestconf-3.3.1.dev8/config_tempest/tests/services/test_volume.py\", line 45, in test_post_configuration_no_volume\nDEBUG:     self.Service.post_configuration(self.conf, mock_is_service)\nDEBUG:       File \"/builddir/build/BUILD/python-tempestconf-3.3.1.dev8/config_tempest/services/volume.py\", line 85, in post_configuration\nDEBUG:     conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)\nDEBUG:       File \"/builddir/build/BUILD/python-tempestconf-3.3.1.dev8/config_tempest/tempest_conf.py\", line 99, in set\nDEBUG:     self.get(section, key), value)\nDEBUG:       File \"/usr/lib64/python3.9/configparser.py\", line 792, in get\nDEBUG:     raise NoOptionError(option, section)\nDEBUG:     configparser.NoOptionError: No option \u0027backup\u0027 in section: \u0027volume-feature-enabled\u0027","commit_id":"b9d8d4a43064527092fc63f3f7955672242b043e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"685809fdd8a4beca689e9618d3075c809a1863a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"686ad388_d05a9b06","updated":"2022-09-01 14:07:43.000000000","message":"Thanks!\nJesse, Lukas, Mikolaj, Sofer, is the change still fine with you?","commit_id":"ea78088ecb256f6ad6b97512cc0e7fb5c0090f1d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f44d92e1c1ceb4e642fd7ac1e75b98394a1268bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0075942d_20421d39","updated":"2022-09-07 09:59:34.000000000","message":"recheck","commit_id":"ea78088ecb256f6ad6b97512cc0e7fb5c0090f1d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"65e7360e7925e1e9fe630255ba7feeac90321bc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d041e01a_d101ee67","updated":"2022-09-01 15:39:30.000000000","message":"recheck","commit_id":"ea78088ecb256f6ad6b97512cc0e7fb5c0090f1d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"846ab04348c34bc2e75cb11c54222f1f8b00abc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1a38339a_ec03af10","updated":"2022-09-02 16:49:45.000000000","message":"recheck\n\nThere was also an issue fixed by https://review.opendev.org/c/openstack/tripleo-quickstart/+/855587","commit_id":"ea78088ecb256f6ad6b97512cc0e7fb5c0090f1d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"94acc3618c21aa3f780db97399b8d1b4b06a31f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"01682ce9_a9a5660e","updated":"2022-09-05 15:01:48.000000000","message":"recheck\n\njust in case...","commit_id":"ea78088ecb256f6ad6b97512cc0e7fb5c0090f1d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"adb0d10440f76422f518972b3f2dd0cc7b89778d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cf43c5cb_4b084446","updated":"2022-09-01 20:26:32.000000000","message":"recheck\n\ntripleo-ci-centos-9-content-provider failed with the same error reported before","commit_id":"ea78088ecb256f6ad6b97512cc0e7fb5c0090f1d"}],"config_tempest/services/volume.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"abe2ad5a2bbc90061cada973750da174eea04bc9","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            if not service or service[0][\u0027state\u0027] \u003d\u003d \u0027down\u0027:"},{"line_number":99,"context_line":"                conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)"},{"line_number":100,"context_line":"            else:"},{"line_number":101,"context_line":"                # post_configuration method is called with every volume (v2,"},{"line_number":102,"context_line":"                # v3) service, therefore set the value with priority so that it"},{"line_number":103,"context_line":"                # can\u0027t be overrided by this method called from other instance"},{"line_number":104,"context_line":"                # of volume service"}],"source_content_type":"text/x-python","patch_set":3,"id":"f26cb4ef_9362f712","side":"PARENT","line":101,"updated":"2022-08-31 21:05:13.000000000","message":"Is there a reason to remove this comment? It looks still relevant","commit_id":"a8aaad54f6df863617d0f0333fb61e81dbdbec75"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"4c90dd35dbb6c0fbe89c244c8624f829793ff221","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            if not service or service[0][\u0027state\u0027] \u003d\u003d \u0027down\u0027:"},{"line_number":99,"context_line":"                conf.set(\u0027volume-feature-enabled\u0027, \u0027backup\u0027, \u0027False\u0027)"},{"line_number":100,"context_line":"            else:"},{"line_number":101,"context_line":"                # post_configuration method is called with every volume (v2,"},{"line_number":102,"context_line":"                # v3) service, therefore set the value with priority so that it"},{"line_number":103,"context_line":"                # can\u0027t be overrided by this method called from other instance"},{"line_number":104,"context_line":"                # of volume service"}],"source_content_type":"text/x-python","patch_set":3,"id":"8626a901_97c6b77a","side":"PARENT","line":101,"in_reply_to":"f26cb4ef_9362f712","updated":"2022-09-01 13:56:02.000000000","message":"fixed.","commit_id":"a8aaad54f6df863617d0f0333fb61e81dbdbec75"}]}
