)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5856ead1f178e63df0b02a2c3f387eff94fcc367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00fe15d1_df662662","updated":"2022-08-10 13:22:28.000000000","message":"Hi Liron, this isn\u0027t used; what tests are relying on this parameter?","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0a308abc84f7c6804654568393973e35c8dae7fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4138d2b_44c2153c","updated":"2022-08-17 07:05:03.000000000","message":"Thanks Goutham!\nJust to update you, I have ran netapp job when thin provisioning is enabled\nand all tests passed.\nI plan to enable it permanently. ","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"3a8f2f9e20b8427ab27f71734a63a567d57705fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"af7aa78f_13aa4055","in_reply_to":"00fe15d1_df662662","updated":"2022-08-10 14:19:27.000000000","message":"Actually, there is only one test and it resides in tempest_storage_plugin.\nThe test should migrate to manila-tempest-plugin and I\u0027m going to upload a patch for this.\nSo this is the reason I uploaded this patch.","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"9e8975ae71e71c70de1108307a97bc0128a1883b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"544b8c72_b8479183","in_reply_to":"13f404ec_c5d95190","updated":"2022-08-11 07:23:26.000000000","message":"I just noticed that we cover thin provisioning in manila-tempest-plugin.\nThis parameter is already exists:\nhttps://github.com/openstack/manila-tempest-plugin/blob/master/manila_tempest_tests/config.py#L143\n\nSo all we need is to enable this flag in tempest.conf\nBy the way why is \"thin_provisioning\" parameter returned as a list and not as string or boolean, like snapshot_support ?","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7128e12af5c28e842e1b9577e31c68d55e87c2e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"42eb3e58_763753bb","in_reply_to":"544b8c72_b8479183","updated":"2022-08-16 19:53:21.000000000","message":"Great! yes, \"thin_provisioning\", \"dedupe\", \"compression\" are reported as lists - so a backend pool can support an \"on\" and \"off\" mode for these capabilities; the right way to determine if the backend supports thin provisioning is to see if \"True\" is in the list it reports","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"32d8b2158057c66ca54c552440895a29258de08e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"13f404ec_c5d95190","in_reply_to":"af7aa78f_13aa4055","updated":"2022-08-10 21:01:35.000000000","message":"I see; so we should create a config option (\"capability_thin_provisioning\") on manila-tempest-plugin then for this to be effective","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4d37f0cf3c66fd496cf6b249ea9a1bb2a7af0f65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1984978f_b12bfc7b","updated":"2022-08-25 23:09:18.000000000","message":"We\u0027re using the LVM driver in the test jobs here; it doesn\u0027t report the capability... ","commit_id":"9406b9a564e735c31ef8826f5211abfd444c9318"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0a834507877e5dc8406b0246ce9a69789276cd1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d1fe7254_2859d170","updated":"2022-08-29 23:04:17.000000000","message":"LGTM, thank you Liron!","commit_id":"684db64bf1bb532912151147f9f44f32295cf5f8"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"ba2b6d956e57ca770a24c2063bca51c2824b7c08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bb0ca2b0_455b018c","updated":"2022-08-30 10:17:22.000000000","message":"Thanks, looks good.","commit_id":"684db64bf1bb532912151147f9f44f32295cf5f8"}],"config_tempest/services/share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5856ead1f178e63df0b02a2c3f387eff94fcc367","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                    pool_capabilities[\u0027snapshot_support\u0027])"},{"line_number":67,"context_line":"                capability_create_share_from_snapshot_support.add("},{"line_number":68,"context_line":"                    pool_capabilities[\u0027create_share_from_snapshot_support\u0027])"},{"line_number":69,"context_line":"                capability_thin_provisioning.add("},{"line_number":70,"context_line":"                    pool_capabilities[\u0027thin_provisioning\u0027][0])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            conf.set(\u0027share\u0027, \u0027backend_names\u0027, \u0027,\u0027.join(backends))"},{"line_number":73,"context_line":"            conf.set(\u0027share\u0027, \u0027enable_protocols\u0027, \u0027,\u0027.join(enable_protocols))"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c3d549e_50f2d249","line":70,"range":{"start_line":69,"start_character":16,"end_line":70,"end_character":62},"updated":"2022-08-10 13:22:28.000000000","message":"this isn\u0027t being used..","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7128e12af5c28e842e1b9577e31c68d55e87c2e3","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                    pool_capabilities[\u0027snapshot_support\u0027])"},{"line_number":67,"context_line":"                capability_create_share_from_snapshot_support.add("},{"line_number":68,"context_line":"                    pool_capabilities[\u0027create_share_from_snapshot_support\u0027])"},{"line_number":69,"context_line":"                capability_thin_provisioning.add("},{"line_number":70,"context_line":"                    pool_capabilities[\u0027thin_provisioning\u0027][0])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            conf.set(\u0027share\u0027, \u0027backend_names\u0027, \u0027,\u0027.join(backends))"},{"line_number":73,"context_line":"            conf.set(\u0027share\u0027, \u0027enable_protocols\u0027, \u0027,\u0027.join(enable_protocols))"}],"source_content_type":"text/x-python","patch_set":1,"id":"c5172a04_eefb6277","line":70,"range":{"start_line":69,"start_character":16,"end_line":70,"end_character":62},"in_reply_to":"6c3d549e_50f2d249","updated":"2022-08-16 19:53:21.000000000","message":"Instead of getting \n\n \"pool_capabilities[\u0027thin_provisioning\u0027][0]\", \n\nget\n \n  any(pool_capabilities[\u0027thin_provisioning\u0027])\n  \n  \nThis would let you know whether the backend supports thin provisioning at all; since backends can report one of:\n\n [\u0027True\u0027], [\u0027True\u0027, \u0027False\u0027], [\u0027False\u0027]","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0a308abc84f7c6804654568393973e35c8dae7fa","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                    pool_capabilities[\u0027snapshot_support\u0027])"},{"line_number":67,"context_line":"                capability_create_share_from_snapshot_support.add("},{"line_number":68,"context_line":"                    pool_capabilities[\u0027create_share_from_snapshot_support\u0027])"},{"line_number":69,"context_line":"                capability_thin_provisioning.add("},{"line_number":70,"context_line":"                    pool_capabilities[\u0027thin_provisioning\u0027][0])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            conf.set(\u0027share\u0027, \u0027backend_names\u0027, \u0027,\u0027.join(backends))"},{"line_number":73,"context_line":"            conf.set(\u0027share\u0027, \u0027enable_protocols\u0027, \u0027,\u0027.join(enable_protocols))"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5108d29_49abb225","line":70,"range":{"start_line":69,"start_character":16,"end_line":70,"end_character":62},"in_reply_to":"c5172a04_eefb6277","updated":"2022-08-17 07:05:03.000000000","message":"Got you, thanks!","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7128e12af5c28e842e1b9577e31c68d55e87c2e3","unresolved":true,"context_lines":[{"line_number":85,"context_line":"                     str(any(capability_snapshot_support)))"},{"line_number":86,"context_line":"            conf.set(\u0027share\u0027, \u0027capability_create_share_from_snapshot_support\u0027,"},{"line_number":87,"context_line":"                     str(any(capability_create_share_from_snapshot_support)))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            if len(backends) \u003e 1:"},{"line_number":90,"context_line":"                conf.set(\u0027share\u0027, \u0027multi_backend\u0027, \u0027True\u0027)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"66f9d5aa_1703c80c","line":88,"updated":"2022-08-16 19:53:21.000000000","message":"need to add:\n\n conf.set(\u0027share\u0027, \u0027capability_thin_provisioned\u0027, \n          str(any(capability_thin_provisioning\u0027))","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"0a308abc84f7c6804654568393973e35c8dae7fa","unresolved":true,"context_lines":[{"line_number":85,"context_line":"                     str(any(capability_snapshot_support)))"},{"line_number":86,"context_line":"            conf.set(\u0027share\u0027, \u0027capability_create_share_from_snapshot_support\u0027,"},{"line_number":87,"context_line":"                     str(any(capability_create_share_from_snapshot_support)))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            if len(backends) \u003e 1:"},{"line_number":90,"context_line":"                conf.set(\u0027share\u0027, \u0027multi_backend\u0027, \u0027True\u0027)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"234d40d9_a2a494eb","line":88,"in_reply_to":"66f9d5aa_1703c80c","updated":"2022-08-17 07:05:03.000000000","message":"Sure thanks!","commit_id":"99720ca89d27dfac38ed45a858c4ec502a567f63"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4d37f0cf3c66fd496cf6b249ea9a1bb2a7af0f65","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                capability_create_share_from_snapshot_support.add("},{"line_number":68,"context_line":"                    pool_capabilities[\u0027create_share_from_snapshot_support\u0027])"},{"line_number":69,"context_line":"                capability_thin_provisioning.add("},{"line_number":70,"context_line":"                    any(pool_capabilities[\u0027thin_provisioning\u0027]))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            conf.set(\u0027share\u0027, \u0027backend_names\u0027, \u0027,\u0027.join(backends))"},{"line_number":73,"context_line":"            conf.set(\u0027share\u0027, \u0027enable_protocols\u0027, \u0027,\u0027.join(enable_protocols))"}],"source_content_type":"text/x-python","patch_set":3,"id":"31cf9266_8e2a2ca3","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":62},"updated":"2022-08-25 23:09:18.000000000","message":"This is causing a failure in the test jobs against this repository. test jobs here use the LVM driver which doesn\u0027t report this at all (meaning, it doesn\u0027t support thin_provisioning). Moreover, many drivers in manila are reporting non-list values as well. So perhaps we need to sanitize this like the way manila\u0027s scheduler does:\n\n  # drivers can report a list, or a single value or nothing at all \n  thin_provisioning \u003d pool_capabilities.get(\u0027thin_provisioning\u0027)\n  thin_provisioning \u003d ([thin_provisioning] \n                     if not isinstance(thin_provisioning, list)\n                     else thin_provisioning)\n  capability_thin_provisioning.add(any(thin_provisioning)","commit_id":"9406b9a564e735c31ef8826f5211abfd444c9318"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"98bfcb7011c711d95b6f42b2b895703af8aeca2f","unresolved":true,"context_lines":[{"line_number":67,"context_line":"                capability_create_share_from_snapshot_support.add("},{"line_number":68,"context_line":"                    pool_capabilities[\u0027create_share_from_snapshot_support\u0027])"},{"line_number":69,"context_line":"                capability_thin_provisioning.add("},{"line_number":70,"context_line":"                    any(pool_capabilities[\u0027thin_provisioning\u0027]))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            conf.set(\u0027share\u0027, \u0027backend_names\u0027, \u0027,\u0027.join(backends))"},{"line_number":73,"context_line":"            conf.set(\u0027share\u0027, \u0027enable_protocols\u0027, \u0027,\u0027.join(enable_protocols))"}],"source_content_type":"text/x-python","patch_set":3,"id":"f4e94672_3fc4f950","line":70,"range":{"start_line":70,"start_character":24,"end_line":70,"end_character":62},"in_reply_to":"31cf9266_8e2a2ca3","updated":"2022-08-28 10:31:07.000000000","message":"Thanks Goutham!","commit_id":"9406b9a564e735c31ef8826f5211abfd444c9318"}]}