)]}'
{".zuul.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"989cb0b5566304f30e0c7f9c1ecc727952374925","unresolved":true,"context_lines":[{"line_number":8,"context_line":"        - openstack-tox-py39"},{"line_number":9,"context_line":"        - python-tempestconf-tempest-devstack-admin"},{"line_number":10,"context_line":"        - python-tempestconf-tempest-devstack-admin-yoga"},{"line_number":11,"context_line":"        # temporarily marked to n-v, there is a bug"},{"line_number":12,"context_line":"        # https://storyboard.openstack.org/#!/story/2010573"},{"line_number":13,"context_line":"        - python-tempestconf-tempest-devstack-admin-zed"},{"line_number":14,"context_line":"        - python-tempestconf-tempest-devstack-demo"},{"line_number":15,"context_line":"        - python-tempestconf-tempest-devstack-admin-plugins"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ea3afd21_74829bd9","line":12,"range":{"start_line":11,"start_character":7,"end_line":12,"end_character":59},"updated":"2023-04-26 11:38:39.000000000","message":"this can be deleted now","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"776dcad48c9ed29940815ae1c4c4610881a31d56","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        - openstack-tox-py39"},{"line_number":9,"context_line":"        - python-tempestconf-tempest-devstack-admin"},{"line_number":10,"context_line":"        - python-tempestconf-tempest-devstack-admin-yoga"},{"line_number":11,"context_line":"        # temporarily marked to n-v, there is a bug"},{"line_number":12,"context_line":"        # https://storyboard.openstack.org/#!/story/2010573"},{"line_number":13,"context_line":"        - python-tempestconf-tempest-devstack-admin-zed"},{"line_number":14,"context_line":"        - python-tempestconf-tempest-devstack-demo"},{"line_number":15,"context_line":"        - python-tempestconf-tempest-devstack-admin-plugins"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1b9036a4_660cbeec","line":12,"range":{"start_line":11,"start_character":7,"end_line":12,"end_character":59},"in_reply_to":"ea3afd21_74829bd9","updated":"2023-04-26 14:23:31.000000000","message":"Done","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"989cb0b5566304f30e0c7f9c1ecc727952374925","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        - openstack-tox-py39"},{"line_number":64,"context_line":"        - python-tempestconf-tempest-devstack-admin"},{"line_number":65,"context_line":"        - python-tempestconf-tempest-devstack-admin-yoga"},{"line_number":66,"context_line":"        # - python-tempestconf-tempest-devstack-admin-zed"},{"line_number":67,"context_line":"        - python-tempestconf-tempest-devstack-demo"},{"line_number":68,"context_line":"        - python-tempestconf-tempest-devstack-admin-plugins"},{"line_number":69,"context_line":"        - refstack-client-devstack-master:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"381b7261_3f1adb3b","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":57},"updated":"2023-04-26 11:38:39.000000000","message":"let\u0027s also uncomment this","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"776dcad48c9ed29940815ae1c4c4610881a31d56","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        - openstack-tox-py39"},{"line_number":64,"context_line":"        - python-tempestconf-tempest-devstack-admin"},{"line_number":65,"context_line":"        - python-tempestconf-tempest-devstack-admin-yoga"},{"line_number":66,"context_line":"        # - python-tempestconf-tempest-devstack-admin-zed"},{"line_number":67,"context_line":"        - python-tempestconf-tempest-devstack-demo"},{"line_number":68,"context_line":"        - python-tempestconf-tempest-devstack-admin-plugins"},{"line_number":69,"context_line":"        - refstack-client-devstack-master:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f29732ef_0b2d3309","line":66,"range":{"start_line":66,"start_character":8,"end_line":66,"end_character":57},"in_reply_to":"381b7261_3f1adb3b","updated":"2023-04-26 14:23:31.000000000","message":"Done","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"989cb0b5566304f30e0c7f9c1ecc727952374925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e7315f8_87d395f3","updated":"2023-04-26 11:38:39.000000000","message":"small -1, pep8 failed https://zuul.opendev.org/t/openstack/build/983c49300049496cad724abb5865ea63 .. seems like something\u0027s changed and the newer flake8 is more sensitive and it suddenly finds one line as too long (although it didn\u0027t before), let\u0027s fix that in this patch .. plus I found a few small things that need to be improved, see the comments below\n\nBut first, let\u0027s wait until the gates finish, to see if everything else is working","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"776dcad48c9ed29940815ae1c4c4610881a31d56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0d4f5ded_ce69ae8d","in_reply_to":"7e7315f8_87d395f3","updated":"2023-04-26 14:23:31.000000000","message":"Done","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"7db04cb1fb0c2a0b24669791f37baf810b5bde8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9409d681_7d3a4745","updated":"2023-05-09 14:43:29.000000000","message":"recheck to see the failure is still consistent","commit_id":"943dba4b971db1dff974379df6a211b6ab1b9ba6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"a9f4aab102d16457b52befaa87e7dfbdb8c15454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"268c0502_abf88906","updated":"2023-05-24 11:10:11.000000000","message":"The jobs fail due to a bug in tempest -\u003e https://bugs.launchpad.net/tempest/+bug/2020659","commit_id":"ffbfafe9c90d7e2af576728c1cf6204f172df5c1"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"99f2827df2c15d972a46695080c2470b6fcba6b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1d2da7d3_edba7c20","updated":"2023-05-23 18:59:30.000000000","message":"recheck\n\nunrelated failure","commit_id":"ffbfafe9c90d7e2af576728c1cf6204f172df5c1"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"f825a61ac839d4e44a60e675966d0e09780e43d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fa69fc03_5b7e9e31","updated":"2023-05-24 07:53:34.000000000","message":"recheck the failure seems unrelated","commit_id":"ffbfafe9c90d7e2af576728c1cf6204f172df5c1"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"90bb00c351460438875afded1c31bb159a5f695c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"113eb7ea_dce2704d","updated":"2023-06-28 14:43:35.000000000","message":"Thanks for the explanation (and sorry, now this needs a rebase)","commit_id":"126b4c011e72cfafbde7795e0fd9b974fe8a7fd6"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"fd35d624594ab9d00b761b8af0c438abddc9f39b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fce621e7_8f315e54","updated":"2023-07-12 11:16:06.000000000","message":"lgtm, thanks Roman!","commit_id":"9ff70dd6bc8bbddaed80e909084641f3ce941456"}],"config_tempest/main.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4949536fd69b9e5fddc389581858a6f9f5ca30f6","unresolved":true,"context_lines":[{"line_number":306,"context_line":"                        help\u003d\"\"\"Convert images to raw format before uploading"},{"line_number":307,"context_line":"                                to glance.\"\"\")"},{"line_number":308,"context_line":"    parser.add_argument(\u0027--network-id\u0027,"},{"line_number":309,"context_line":"                        help\u003d\"\"\"Specify which network with external"},{"line_number":310,"context_line":"                        connectivity should be used by the tests.\"\"\")"},{"line_number":311,"context_line":"    parser.add_argument(\u0027--append\u0027, action\u003d\u0027append\u0027, default\u003d[],"},{"line_number":312,"context_line":"                        metavar\u003d\"SECTION.KEY\u003dVALUE[,VALUE]\","}],"source_content_type":"text/x-python","patch_set":5,"id":"7440d263_c2377513","line":309,"updated":"2023-05-29 16:16:05.000000000","message":"is this a pep8 error that was problematic with the older combination of tox and pep8?","commit_id":"96ba08311b79a3b44c6e4631d338890a7c7970df"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"96ce8a4200ab7a56600c3dfe7e0ab5b4f21f66e8","unresolved":true,"context_lines":[{"line_number":306,"context_line":"                        help\u003d\"\"\"Convert images to raw format before uploading"},{"line_number":307,"context_line":"                                to glance.\"\"\")"},{"line_number":308,"context_line":"    parser.add_argument(\u0027--network-id\u0027,"},{"line_number":309,"context_line":"                        help\u003d\"\"\"Specify which network with external"},{"line_number":310,"context_line":"                        connectivity should be used by the tests.\"\"\")"},{"line_number":311,"context_line":"    parser.add_argument(\u0027--append\u0027, action\u003d\u0027append\u0027, default\u003d[],"},{"line_number":312,"context_line":"                        metavar\u003d\"SECTION.KEY\u003dVALUE[,VALUE]\","}],"source_content_type":"text/x-python","patch_set":5,"id":"39819eab_f54c6ec4","line":309,"in_reply_to":"7440d263_c2377513","updated":"2023-05-29 16:23:06.000000000","message":"yes, the error can be seen in this patch (Jakub will need to rebase on top of this patch):\nhttps://review.opendev.org/c/openinfra/python-tempestconf/+/883257\nhttps://zuul.opendev.org/t/openstack/build/94e288289f1a40e69cfa63e6ad8038df","commit_id":"96ba08311b79a3b44c6e4631d338890a7c7970df"}],"playbooks/python-tempestconf-tempest-devstack.yaml":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"989cb0b5566304f30e0c7f9c1ecc727952374925","unresolved":true,"context_lines":[{"line_number":28,"context_line":"      include_role:"},{"line_number":29,"context_line":"        name: setup-tempest-data-dir"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # NOTE: devstack jobs are failing on Run Tempest task"},{"line_number":32,"context_line":"    # it is because tox command is not found. Adding \u0027ensure-tox\u0027"},{"line_number":33,"context_line":"    # role here to make sure that tox is installed and it"},{"line_number":34,"context_line":"    # will not break the tempest tests."},{"line_number":35,"context_line":"    - name: Ensure tox is installed"},{"line_number":36,"context_line":"      include_role:"},{"line_number":37,"context_line":"        name: ensure-tox"},{"line_number":38,"context_line":"      vars:"},{"line_number":39,"context_line":"        ensure_global_symlinks: True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: ACL devstack files"},{"line_number":42,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"14c03621_8506c344","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":36},"updated":"2023-04-26 11:38:39.000000000","message":"I think we can also get rid of this","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"776dcad48c9ed29940815ae1c4c4610881a31d56","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      include_role:"},{"line_number":29,"context_line":"        name: setup-tempest-data-dir"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    # NOTE: devstack jobs are failing on Run Tempest task"},{"line_number":32,"context_line":"    # it is because tox command is not found. Adding \u0027ensure-tox\u0027"},{"line_number":33,"context_line":"    # role here to make sure that tox is installed and it"},{"line_number":34,"context_line":"    # will not break the tempest tests."},{"line_number":35,"context_line":"    - name: Ensure tox is installed"},{"line_number":36,"context_line":"      include_role:"},{"line_number":37,"context_line":"        name: ensure-tox"},{"line_number":38,"context_line":"      vars:"},{"line_number":39,"context_line":"        ensure_global_symlinks: True"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    - name: ACL devstack files"},{"line_number":42,"context_line":"      include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f345b8d2_755c18af","line":39,"range":{"start_line":31,"start_character":0,"end_line":39,"end_character":36},"in_reply_to":"14c03621_8506c344","updated":"2023-04-26 14:23:31.000000000","message":"Done","commit_id":"8ab9d32c4f94c6cdbfd0c89a57d62da33e622dbd"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4949536fd69b9e5fddc389581858a6f9f5ca30f6","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    # the role is inherited from openstack/devstack project"},{"line_number":4,"context_line":"    - run-devstack"},{"line_number":5,"context_line":"  tasks:"},{"line_number":6,"context_line":"    - name: Ensure tox (system-wide)"},{"line_number":7,"context_line":"      shell: |"},{"line_number":8,"context_line":"        python3 -m pip install \"tox{{ ensure_tox_version }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bfdcb6eb_919024d9","line":5,"updated":"2023-05-29 16:16:05.000000000","message":"so does it means that the ensure-tox role can\u0027t be used at all?","commit_id":"96ba08311b79a3b44c6e4631d338890a7c7970df"},{"author":{"_account_id":33732,"name":"Roman Popelka","email":"rpopelka@redhat.com","username":"rpopelka"},"change_message_id":"92e8fa2494d8fa8e4c7814cfebeeec4df1c830fb","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    # the role is inherited from openstack/devstack project"},{"line_number":4,"context_line":"    - run-devstack"},{"line_number":5,"context_line":"  tasks:"},{"line_number":6,"context_line":"    - name: Ensure tox (system-wide)"},{"line_number":7,"context_line":"      shell: |"},{"line_number":8,"context_line":"        python3 -m pip install \"tox{{ ensure_tox_version }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"80be34ba_bfd4b7a4","line":5,"in_reply_to":"7ecb4078_40c9fe60","updated":"2023-06-28 14:29:21.000000000","message":"The role could also be used with this task. Unfortunately, the ensure-tox role only ensures the role is installed (and doesn\u0027t check if the version in ensure_tox_version variable is correct if there is tox installed)[1]. \n\nFor other devstack jobs that runs tempest this isn\u0027t an issue since most of them install tempest as part of devstack installation. If you install tempest as part of devstack installation there is a workaround that makes sure that tox\u003c4 will be installed (globally) even if there\u0027s an existing installation[2]. Python-tempestconf jobs install tempest afterwards, so the workaround doesn\u0027t work there. Also, there is a point in which tox is installed(into dist-packages) while setting up devstack (part of some neutron plugin installation[3]). Ensure-tox then finds existing tox installation and the version isn\u0027t changed. Tempest also uses the global version of tox, not the local one, so the global one (in dist-packages) needs to be reinstalled\n\nWe can approach this similary as workaround made in devstack[2] and also keep ensure-tox task there. But I don\u0027t think it\u0027s really necessary\n\n[1]https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-tox/tasks/main.yaml#L22\n[2]https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-tox/tasks/main.yaml#L22\n[3]https://opendev.org/openstack/devstack/src/branch/master/lib/neutron_plugins/ovn_agent#L370","commit_id":"96ba08311b79a3b44c6e4631d338890a7c7970df"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"96ce8a4200ab7a56600c3dfe7e0ab5b4f21f66e8","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    # the role is inherited from openstack/devstack project"},{"line_number":4,"context_line":"    - run-devstack"},{"line_number":5,"context_line":"  tasks:"},{"line_number":6,"context_line":"    - name: Ensure tox (system-wide)"},{"line_number":7,"context_line":"      shell: |"},{"line_number":8,"context_line":"        python3 -m pip install \"tox{{ ensure_tox_version }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fce27843_88ea78ca","line":5,"in_reply_to":"bfdcb6eb_919024d9","updated":"2023-05-29 16:23:06.000000000","message":"it seems so although I don\u0027t know the exact reason why the ensure-tox role wasn\u0027t working for us :/","commit_id":"96ba08311b79a3b44c6e4631d338890a7c7970df"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"1bc123826fe8e2ae5c4a60488210c54ec098beff","unresolved":true,"context_lines":[{"line_number":2,"context_line":"  roles:"},{"line_number":3,"context_line":"    # the role is inherited from openstack/devstack project"},{"line_number":4,"context_line":"    - run-devstack"},{"line_number":5,"context_line":"  tasks:"},{"line_number":6,"context_line":"    - name: Ensure tox (system-wide)"},{"line_number":7,"context_line":"      shell: |"},{"line_number":8,"context_line":"        python3 -m pip install \"tox{{ ensure_tox_version }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7ecb4078_40c9fe60","line":5,"in_reply_to":"fce27843_88ea78ca","updated":"2023-06-06 10:21:20.000000000","message":"To be honest, I\u0027m concerned about moving away from a shared role that should be working for everyone and I\u0027d like much to have this fixed in a central place.\n\nMoving away from a common role without knowing the reason is going to be problematic in the long run.","commit_id":"96ba08311b79a3b44c6e4631d338890a7c7970df"}]}