)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"fd2f0b56619fe31e7e48cd3183f9339521939660","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prioritize external network named public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tempestconf will prioritize the external network named public"},{"line_number":10,"context_line":"when auto-discovering an external network for tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The public network is the network we end up using in most of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aaf3a654_1a8027e2","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":68},"updated":"2024-05-03 12:42:53.000000000","message":"wouldn\u0027t we good if we support passing network name instead of assuming\" \"public\" as an external network.","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"67685a670dbf9941170d367cebc18adf7edfa456","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prioritize external network named public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tempestconf will prioritize the external network named public"},{"line_number":10,"context_line":"when auto-discovering an external network for tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The public network is the network we end up using in most of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"33348c7a_fcd7c2ff","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":68},"in_reply_to":"48ea7439_d96867df","updated":"2024-05-06 07:59:07.000000000","message":"https://review.opendev.org/c/openinfra/python-tempestconf/+/918203/","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"e3630e21ea3ad1ba6ee26beae20a2f16985734bc","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prioritize external network named public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tempestconf will prioritize the external network named public"},{"line_number":10,"context_line":"when auto-discovering an external network for tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The public network is the network we end up using in most of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"290638aa_5b65d7c7","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":68},"in_reply_to":"48ea7439_d96867df","updated":"2024-05-06 08:01:01.000000000","message":"thanks Martin, ok to do it in followup and can also revert this autodiscovery unless and until other auto discoveries do similar assumption.","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2dde821e092097556a1b04589d78c71693b96ff","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prioritize external network named public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tempestconf will prioritize the external network named public"},{"line_number":10,"context_line":"when auto-discovering an external network for tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The public network is the network we end up using in most of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d2ef0b82_705da9fd","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":68},"in_reply_to":"aaf3a654_1a8027e2","updated":"2024-05-04 17:06:35.000000000","message":"a user may set --network-id arg https://opendev.org/openinfra/python-tempestconf/src/commit/46fb09a653bd89b2deae6c25836ba2234409439d/config_tempest/main.py#L318 , if they do, the autodiscovery is skipped. Usually users don\u0027t specify it, then tempestconf tries to autodiscover a network, till now, it just took the first external network it found, now it takes the \"public\" one which is exactly the one we want in at least 99% cases.\n\nHowever, you have a good point, we could convert the --network-id to e.g. just --network and let user specify either id or name of a network - that\u0027s how openstack clients do it too .. i\u0027ll do it another patch as it will require couple more changes, e.g. deprecation of --network-id","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ed7900e1f3aba7e0b8417a79e188bc851621f8c7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Prioritize external network named public"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"python-tempestconf will prioritize the external network named public"},{"line_number":10,"context_line":"when auto-discovering an external network for tempest."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The public network is the network we end up using in most of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"48ea7439_d96867df","line":9,"range":{"start_line":9,"start_character":62,"end_line":9,"end_character":68},"in_reply_to":"d2ef0b82_705da9fd","updated":"2024-05-06 07:51:02.000000000","message":"I think yatin has a good point and converting the --network-id to --network sounds good to me.","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"4a0a188cf4ebcb0c01aa6ebc0a2a3e45ada7a26a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e7466169_c49d8f5e","updated":"2024-05-03 11:46:35.000000000","message":"LGTM. I\u0027m waiting for the jobs to finish for +1. I added a few comments - just a thought.","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ed7900e1f3aba7e0b8417a79e188bc851621f8c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"caa81631_76ca90b4","updated":"2024-05-06 07:51:02.000000000","message":"LGTM, I think yatin has a good point.","commit_id":"e4d8dc124ca8abb0f2aea7fb9fdc228e72354d0a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e653d520c6352d057e1f6887aef52dc710af7298","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7fddf1b5_d5daf981","updated":"2024-05-04 17:06:41.000000000","message":"check experimental","commit_id":"e4d8dc124ca8abb0f2aea7fb9fdc228e72354d0a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"9f5556d48aba55eaea10f79533dc2a1e3aebf425","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3498cb1d_412c697c","updated":"2024-05-06 12:02:43.000000000","message":"merging as this is really needed already","commit_id":"e4d8dc124ca8abb0f2aea7fb9fdc228e72354d0a"}],"config_tempest/services/network.py":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"4a0a188cf4ebcb0c01aa6ebc0a2a3e45ada7a26a","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                             \u0027\u0027.format(self._public_network_id))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _discover_network(self):"},{"line_number":68,"context_line":"        LOG.info(\"No network supplied, trying auto discover for network\")"},{"line_number":69,"context_line":"        network_list \u003d self.client.list_networks()"},{"line_number":70,"context_line":"        ext_nets \u003d []"},{"line_number":71,"context_line":"        for network in network_list[\u0027networks\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a9ba678_4bf24222","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":2},"updated":"2024-05-03 11:46:35.000000000","message":"\"No network supplied, trying auto discover for network (prioritizing external networks with name public if none exists then taking the first available external network\")","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2dde821e092097556a1b04589d78c71693b96ff","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                             \u0027\u0027.format(self._public_network_id))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _discover_network(self):"},{"line_number":68,"context_line":"        LOG.info(\"No network supplied, trying auto discover for network\")"},{"line_number":69,"context_line":"        network_list \u003d self.client.list_networks()"},{"line_number":70,"context_line":"        ext_nets \u003d []"},{"line_number":71,"context_line":"        for network in network_list[\u0027networks\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"802985d7_3ca55771","line":68,"range":{"start_line":68,"start_character":0,"end_line":68,"end_character":2},"in_reply_to":"0a9ba678_4bf24222","updated":"2024-05-04 17:06:35.000000000","message":"Done","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"4a0a188cf4ebcb0c01aa6ebc0a2a3e45ada7a26a","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        ext_nets \u003d []"},{"line_number":71,"context_line":"        for network in network_list[\u0027networks\u0027]:"},{"line_number":72,"context_line":"            if network[\u0027router:external\u0027] and network[\u0027subnets\u0027]:"},{"line_number":73,"context_line":"                if network[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":74,"context_line":"                    continue"},{"line_number":75,"context_line":"                # usually the external network we use is called \u0027public\u0027"},{"line_number":76,"context_line":"                if network[\u0027name\u0027] \u003d\u003d \u0027public\u0027:"},{"line_number":77,"context_line":"                    LOG.info(\"Found the \u0027public\u0027 external network, setting \""}],"source_content_type":"text/x-python","patch_set":1,"id":"dc1faa08_b8d59688","line":74,"range":{"start_line":73,"start_character":16,"end_line":74,"end_character":28},"updated":"2024-05-03 11:46:35.000000000","message":"Just a nit. The if-statements here can be merged into the previous if-statement. It would make the code less nested but it\u0027s true that the if statement would be long.","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"ed7900e1f3aba7e0b8417a79e188bc851621f8c7","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        ext_nets \u003d []"},{"line_number":71,"context_line":"        for network in network_list[\u0027networks\u0027]:"},{"line_number":72,"context_line":"            if network[\u0027router:external\u0027] and network[\u0027subnets\u0027]:"},{"line_number":73,"context_line":"                if network[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":74,"context_line":"                    continue"},{"line_number":75,"context_line":"                # usually the external network we use is called \u0027public\u0027"},{"line_number":76,"context_line":"                if network[\u0027name\u0027] \u003d\u003d \u0027public\u0027:"},{"line_number":77,"context_line":"                    LOG.info(\"Found the \u0027public\u0027 external network, setting \""}],"source_content_type":"text/x-python","patch_set":1,"id":"e32c251c_4e69e097","line":74,"range":{"start_line":73,"start_character":16,"end_line":74,"end_character":28},"in_reply_to":"4cd424e7_7c03af77","updated":"2024-05-06 07:51:02.000000000","message":"Ok, makes sense 👍","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2dde821e092097556a1b04589d78c71693b96ff","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        ext_nets \u003d []"},{"line_number":71,"context_line":"        for network in network_list[\u0027networks\u0027]:"},{"line_number":72,"context_line":"            if network[\u0027router:external\u0027] and network[\u0027subnets\u0027]:"},{"line_number":73,"context_line":"                if network[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":74,"context_line":"                    continue"},{"line_number":75,"context_line":"                # usually the external network we use is called \u0027public\u0027"},{"line_number":76,"context_line":"                if network[\u0027name\u0027] \u003d\u003d \u0027public\u0027:"},{"line_number":77,"context_line":"                    LOG.info(\"Found the \u0027public\u0027 external network, setting \""}],"source_content_type":"text/x-python","patch_set":1,"id":"4cd424e7_7c03af77","line":74,"range":{"start_line":73,"start_character":16,"end_line":74,"end_character":28},"in_reply_to":"dc1faa08_b8d59688","updated":"2024-05-04 17:06:35.000000000","message":"I originally wanted to add this to the if on line 72, however, the line was too long and if I\u0027d split it , it would be less readable in my opinion","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"4a0a188cf4ebcb0c01aa6ebc0a2a3e45ada7a26a","unresolved":true,"context_lines":[{"line_number":72,"context_line":"            if network[\u0027router:external\u0027] and network[\u0027subnets\u0027]:"},{"line_number":73,"context_line":"                if network[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":74,"context_line":"                    continue"},{"line_number":75,"context_line":"                # usually the external network we use is called \u0027public\u0027"},{"line_number":76,"context_line":"                if network[\u0027name\u0027] \u003d\u003d \u0027public\u0027:"},{"line_number":77,"context_line":"                    LOG.info(\"Found the \u0027public\u0027 external network, setting \""},{"line_number":78,"context_line":"                             \"%s as the public network for tempest\","},{"line_number":79,"context_line":"                             network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d6b7a2f_81bc0061","line":76,"range":{"start_line":75,"start_character":16,"end_line":76,"end_character":47},"updated":"2024-05-03 11:46:35.000000000","message":"```\n# Prioritize network with name public or take first available network\nif network[\u0027name\u0027] \u003d\u003d \u0027public\u0027 or not self._public_network_id:\n```","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2dde821e092097556a1b04589d78c71693b96ff","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            if network[\u0027router:external\u0027] and network[\u0027subnets\u0027]:"},{"line_number":73,"context_line":"                if network[\u0027status\u0027] !\u003d \u0027ACTIVE\u0027:"},{"line_number":74,"context_line":"                    continue"},{"line_number":75,"context_line":"                # usually the external network we use is called \u0027public\u0027"},{"line_number":76,"context_line":"                if network[\u0027name\u0027] \u003d\u003d \u0027public\u0027:"},{"line_number":77,"context_line":"                    LOG.info(\"Found the \u0027public\u0027 external network, setting \""},{"line_number":78,"context_line":"                             \"%s as the public network for tempest\","},{"line_number":79,"context_line":"                             network[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ad79888_36dd3de3","line":76,"range":{"start_line":75,"start_character":16,"end_line":76,"end_character":47},"in_reply_to":"8d6b7a2f_81bc0061","updated":"2024-05-04 17:06:35.000000000","message":"Done","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"4a0a188cf4ebcb0c01aa6ebc0a2a3e45ada7a26a","unresolved":true,"context_lines":[{"line_number":87,"context_line":"                      \"Please note that any test that relies on external \""},{"line_number":88,"context_line":"                      \"connectivity would most likely fail.\")"},{"line_number":89,"context_line":"            return"},{"line_number":90,"context_line":"        # in case no found external network is called \u0027public\u0027, let\u0027s use"},{"line_number":91,"context_line":"        # the first one"},{"line_number":92,"context_line":"        LOG.info(\"Found these external networks: %s\", str(ext_nets))"},{"line_number":93,"context_line":"        LOG.info(\"Setting %s as the public network for tempest\","},{"line_number":94,"context_line":"                 ext_nets[0][\u0027id\u0027])"},{"line_number":95,"context_line":"        self._public_network_id \u003d ext_nets[0][\u0027id\u0027]"},{"line_number":96,"context_line":"        self._public_network_name \u003d ext_nets[0][\u0027name\u0027]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @staticmethod"},{"line_number":99,"context_line":"    def get_service_type():"}],"source_content_type":"text/x-python","patch_set":1,"id":"22652ae7_6b58dfd2","line":96,"range":{"start_line":90,"start_character":7,"end_line":96,"end_character":55},"updated":"2024-05-03 11:46:35.000000000","message":"This would not be needed and the variable ext_nets as well.","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e2dde821e092097556a1b04589d78c71693b96ff","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                      \"Please note that any test that relies on external \""},{"line_number":88,"context_line":"                      \"connectivity would most likely fail.\")"},{"line_number":89,"context_line":"            return"},{"line_number":90,"context_line":"        # in case no found external network is called \u0027public\u0027, let\u0027s use"},{"line_number":91,"context_line":"        # the first one"},{"line_number":92,"context_line":"        LOG.info(\"Found these external networks: %s\", str(ext_nets))"},{"line_number":93,"context_line":"        LOG.info(\"Setting %s as the public network for tempest\","},{"line_number":94,"context_line":"                 ext_nets[0][\u0027id\u0027])"},{"line_number":95,"context_line":"        self._public_network_id \u003d ext_nets[0][\u0027id\u0027]"},{"line_number":96,"context_line":"        self._public_network_name \u003d ext_nets[0][\u0027name\u0027]"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    @staticmethod"},{"line_number":99,"context_line":"    def get_service_type():"}],"source_content_type":"text/x-python","patch_set":1,"id":"93a0bcfd_559de5de","line":96,"range":{"start_line":90,"start_character":7,"end_line":96,"end_character":55},"in_reply_to":"22652ae7_6b58dfd2","updated":"2024-05-04 17:06:35.000000000","message":"Done","commit_id":"38b03d26450c4b3c1aef56bb84fb10dd1c887f93"}]}