)]}'
{"refstack_client/refstack_client.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"d5511309ef9d8eb56ebafea99e2186cf5b481508","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            except KeyboardInterrupt:"},{"line_number":343,"context_line":"                return"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def _sign_pubkey(self):"},{"line_number":346,"context_line":"        try:"},{"line_number":347,"context_line":"            with open(self.args.priv_key) as priv_key_file:"},{"line_number":348,"context_line":"                private_key \u003d RSA.importKey(priv_key_file.read())"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_8a1b2c1b","line":345,"updated":"2015-07-21 05:48:02.000000000","message":"Docstring here.","commit_id":"503b13c77e897f35c21ecab58c92b9c3d560b63c"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"a9ae597d4a434b2f82466158b6fc55903e782406","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            except KeyboardInterrupt:"},{"line_number":343,"context_line":"                return"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def _sign_pubkey(self):"},{"line_number":346,"context_line":"        try:"},{"line_number":347,"context_line":"            with open(self.args.priv_key) as priv_key_file:"},{"line_number":348,"context_line":"                private_key \u003d RSA.importKey(priv_key_file.read())"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_14bf21ab","line":345,"in_reply_to":"3a50d1a3_8a1b2c1b","updated":"2015-08-17 10:49:13.000000000","message":"Done","commit_id":"503b13c77e897f35c21ecab58c92b9c3d560b63c"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"d5511309ef9d8eb56ebafea99e2186cf5b481508","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            with open(self.args.priv_key) as priv_key_file:"},{"line_number":348,"context_line":"                private_key \u003d RSA.importKey(priv_key_file.read())"},{"line_number":349,"context_line":"        except (IOError, ValueError) as e:"},{"line_number":350,"context_line":"            self.logger.info(\u0027Error during upload private key %s\u0027"},{"line_number":351,"context_line":"                             \u0027\u0027 % self.args.priv_key)"},{"line_number":352,"context_line":"            self.logger.exception(e)"},{"line_number":353,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_aabaa808","line":350,"updated":"2015-07-21 05:48:02.000000000","message":"Should probably make this self.logger.error since the logging level is currently set to logging.ERROR, and it seems to be an error message. Also, saying \u0027upload\u0027 in the message seems misleading. Perhaps \"Error opening private key %s\"? or \"Error reading...\" Something to that extent.","commit_id":"503b13c77e897f35c21ecab58c92b9c3d560b63c"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"a9ae597d4a434b2f82466158b6fc55903e782406","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            with open(self.args.priv_key) as priv_key_file:"},{"line_number":348,"context_line":"                private_key \u003d RSA.importKey(priv_key_file.read())"},{"line_number":349,"context_line":"        except (IOError, ValueError) as e:"},{"line_number":350,"context_line":"            self.logger.info(\u0027Error during upload private key %s\u0027"},{"line_number":351,"context_line":"                             \u0027\u0027 % self.args.priv_key)"},{"line_number":352,"context_line":"            self.logger.exception(e)"},{"line_number":353,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_b4dc2d19","line":350,"in_reply_to":"3a50d1a3_aabaa808","updated":"2015-08-17 10:49:13.000000000","message":"Done","commit_id":"503b13c77e897f35c21ecab58c92b9c3d560b63c"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"d5511309ef9d8eb56ebafea99e2186cf5b481508","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                             type\u003dstr,"},{"line_number":424,"context_line":"                             required\u003dFalse,"},{"line_number":425,"context_line":"                             dest\u003d\u0027priv_key\u0027,"},{"line_number":426,"context_line":"                             default\u003d\u0027~/.ssh/id-rsa\u0027,"},{"line_number":427,"context_line":"                             help\u003d\u0027Path to private RSA key. \u0027"},{"line_number":428,"context_line":"                                  \u0027OpenSSH RSA keys format supported\u0027)"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_2f5eaa76","line":426,"updated":"2015-07-21 05:48:02.000000000","message":"Should the default be id_rsa instead of id-rsa?","commit_id":"503b13c77e897f35c21ecab58c92b9c3d560b63c"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"a9ae597d4a434b2f82466158b6fc55903e782406","unresolved":false,"context_lines":[{"line_number":423,"context_line":"                             type\u003dstr,"},{"line_number":424,"context_line":"                             required\u003dFalse,"},{"line_number":425,"context_line":"                             dest\u003d\u0027priv_key\u0027,"},{"line_number":426,"context_line":"                             default\u003d\u0027~/.ssh/id-rsa\u0027,"},{"line_number":427,"context_line":"                             help\u003d\u0027Path to private RSA key. \u0027"},{"line_number":428,"context_line":"                                  \u0027OpenSSH RSA keys format supported\u0027)"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_ba3fb1d5","line":426,"in_reply_to":"3a50d1a3_2f5eaa76","updated":"2015-08-17 10:49:13.000000000","message":"Done","commit_id":"503b13c77e897f35c21ecab58c92b9c3d560b63c"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"d6809d4468ccd986351c2c42aa4ff3ff35d262c6","unresolved":false,"context_lines":[{"line_number":357,"context_line":"            with open(pubkey_filename) as pub_key_file:"},{"line_number":358,"context_line":"                pub_key \u003d pub_key_file.read()"},{"line_number":359,"context_line":"        except IOError:"},{"line_number":360,"context_line":"            self.logger.info(\u0027Public key file %s not found. \u0027"},{"line_number":361,"context_line":"                             \u0027Public key is generated from private one.\u0027"},{"line_number":362,"context_line":"                             \u0027\u0027 % pubkey_filename)"},{"line_number":363,"context_line":"            pub_key \u003d private_key.publickey().exportKey(\u0027OpenSSH\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_8f0374b8","line":360,"updated":"2015-08-17 19:00:22.000000000","message":"Since the __init__ for RefstackClient sets the loggingLevel to logging.ERROR when there are no verbose arguments, this INFO statement will never be exposed. Can either add:\n\nself.logger.setLevel(logging.INFO)\n\nto the top of this function, or perhaps we should consider making the default logging level logging.INFO. Was never really a fan of the silent test running be default. If we do want to change the default logging level, then you can leave this function as is, and I can submit a patch to make the changes, and perhaps add a \u0027--silent\u0027 argument to compensate.","commit_id":"6c2aa0ddbf70b8798fe4d219b12b2aa26283b308"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"d6809d4468ccd986351c2c42aa4ff3ff35d262c6","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    pubkey_args \u003d argparse.ArgumentParser(add_help\u003dFalse)"},{"line_number":423,"context_line":"    pubkey_args.add_argument(\u0027-i\u0027, \u0027--sign\u0027,"},{"line_number":424,"context_line":"                             type\u003dstr,"},{"line_number":425,"context_line":"                             required\u003dFalse,"},{"line_number":426,"context_line":"                             dest\u003d\u0027priv_key\u0027,"},{"line_number":427,"context_line":"                             help\u003d\u0027Path to private RSA key. \u0027"},{"line_number":428,"context_line":"                                  \u0027OpenSSH RSA keys format supported\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa1b9901_6fa060f5","line":425,"updated":"2015-08-17 19:00:22.000000000","message":"Since there is no longer a default, let\u0027s set required\u003dTrue.","commit_id":"6c2aa0ddbf70b8798fe4d219b12b2aa26283b308"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"708c6db52f2a313e973ab3bcb2fbad84e18a3c11","unresolved":false,"context_lines":[{"line_number":387,"context_line":"    )"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"    parser.add_argument(\u0027-v\u0027, \u0027--verbose\u0027,"},{"line_number":390,"context_line":"                        action\u003d\u0027count\u0027,"},{"line_number":391,"context_line":"                        help\u003d\u0027Show verbose output.\u0027)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    subparsers \u003d parser.add_subparsers(help\u003d\u0027Available subcommands.\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa1b9901_8db01c45","line":390,"updated":"2015-08-18 22:52:09.000000000","message":"Just noticed while using refstack-client that making this change would make it so \u0027./refstack-client test -vv\u0027 would not work with an error message like: \n\n\u0027refstack-client: error: unrecognized arguments: -vv\u0027\n\nWe would then have to put the -vv before the subcommand to change verbosity. Is this what we want? If so, the Readme needs to be updated to shift all occurrences of \u0027-vv\u0027.","commit_id":"79be77469807fb3aed266e595636590c3d2b0e63"}]}