)]}'
{"README.rst":[{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"b5852b1701c2e3d933bb76da0313b5f82f145b51","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   **Note:**"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   a. Adding the `-v` option will show the summary output."},{"line_number":69,"context_line":"   b. Adding the `-v` option will show the Tempest test result output."},{"line_number":70,"context_line":"   c. Adding the `--upload` option will have your test results be uploaded to the"},{"line_number":71,"context_line":"      default RefStack API server or the server specified by `--url`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_4788d1e7","line":68,"updated":"2015-10-14 05:10:03.000000000","message":"Should item \"a\". be deleted?  With the current code the summary output would be shown regardless whether there is a  -v option or not.","commit_id":"b0d34ff0553cdc91bed147a54bbdde66fe6ff573"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"2312542202ac7729f7f31417e7b59cd61b922dfc","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   **Note:**"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"   a. Adding the `-v` option will show the summary output."},{"line_number":69,"context_line":"   b. Adding the `-v` option will show the Tempest test result output."},{"line_number":70,"context_line":"   c. Adding the `--upload` option will have your test results be uploaded to the"},{"line_number":71,"context_line":"      default RefStack API server or the server specified by `--url`."}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a2ca52d_0d82f794","line":68,"in_reply_to":"5a2ca52d_4788d1e7","updated":"2015-10-14 08:34:34.000000000","message":"Yes, correct it.","commit_id":"b0d34ff0553cdc91bed147a54bbdde66fe6ff573"}],"refstack_client/refstack_client.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"86f95e704e2db094e22e46a8c6ed9b3efbe5fd61","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.args \u003d args"},{"line_number":76,"context_line":"        self.tempest_dir \u003d \u0027.tempest\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        \u0027\u0027\u0027set default log level to INFO.\u0027\u0027\u0027"},{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent is True:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.ERROR)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_95c057e2","line":78,"updated":"2015-10-12 23:03:36.000000000","message":"Use normal comment syntax here instead of docstring syntax:\n\n# Set default log level to INFO.","commit_id":"074d1604e9e9138ac8291140c1bbd351178ec586"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"86f95e704e2db094e22e46a8c6ed9b3efbe5fd61","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        \u0027\u0027\u0027set default log level to INFO.\u0027\u0027\u0027"},{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent is True:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.ERROR)"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            if self.args.verbose \u003d\u003d 1:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_15ad2731","line":80,"updated":"2015-10-12 23:03:36.000000000","message":"nit: Can drop the \"is True\" portion.","commit_id":"074d1604e9e9138ac8291140c1bbd351178ec586"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"86f95e704e2db094e22e46a8c6ed9b3efbe5fd61","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        \u0027\u0027\u0027set default log level to INFO.\u0027\u0027\u0027"},{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent is True:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.ERROR)"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            if self.args.verbose \u003d\u003d 1:"},{"line_number":84,"context_line":"                self.logger.setLevel(logging.INFO)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_90994522","line":81,"updated":"2015-10-12 23:03:36.000000000","message":"I think silent mode should be logging.WARNING. This seems to align with other openstack python clients.","commit_id":"074d1604e9e9138ac8291140c1bbd351178ec586"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"86f95e704e2db094e22e46a8c6ed9b3efbe5fd61","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent is True:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.ERROR)"},{"line_number":82,"context_line":"        else:"},{"line_number":83,"context_line":"            if self.args.verbose \u003d\u003d 1:"},{"line_number":84,"context_line":"                self.logger.setLevel(logging.INFO)"},{"line_number":85,"context_line":"            elif self.args.verbose \u003e 1:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_903b859c","line":82,"updated":"2015-10-12 23:03:36.000000000","message":"Actually, seems that since that we only have one level of verbosity now, the if statements can be simplified:\n\n  if self.args.silent:\n      self.logger.setLevel(logging.WARNING)\n  elif self.args.verbose \u003e 0:\n      self.logger.setLevel(logging.DEBUG)\n  else:\n      self.logger.setLevel(logging.INFO)","commit_id":"074d1604e9e9138ac8291140c1bbd351178ec586"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"86f95e704e2db094e22e46a8c6ed9b3efbe5fd61","unresolved":false,"context_lines":[{"line_number":460,"context_line":"    # Arguments that go with all subcommands."},{"line_number":461,"context_line":"    shared_args \u003d argparse.ArgumentParser(add_help\u003dFalse)"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    shared_args.add_argument(\u0027-s\u0027, \u0027--silent\u0027,"},{"line_number":464,"context_line":"                             action\u003d\u0027store_true\u0027,"},{"line_number":465,"context_line":"                             help\u003d\u0027Not show verbose output.\u0027)"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_75301b08","line":463,"updated":"2015-10-12 23:03:36.000000000","message":"Can we use: https://docs.python.org/2/howto/argparse.html#conflicting-options ?","commit_id":"074d1604e9e9138ac8291140c1bbd351178ec586"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"86f95e704e2db094e22e46a8c6ed9b3efbe5fd61","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    shared_args.add_argument(\u0027-s\u0027, \u0027--silent\u0027,"},{"line_number":464,"context_line":"                             action\u003d\u0027store_true\u0027,"},{"line_number":465,"context_line":"                             help\u003d\u0027Not show verbose output.\u0027)"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    shared_args.add_argument(\u0027-v\u0027, \u0027--verbose\u0027,"},{"line_number":468,"context_line":"                             action\u003d\u0027count\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_f0d0b9f9","line":465,"updated":"2015-10-12 23:03:36.000000000","message":"Suggest changing help string to:\n\n\u0027Suppress output except warnings and errors.\u0027","commit_id":"074d1604e9e9138ac8291140c1bbd351178ec586"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"b5852b1701c2e3d933bb76da0313b5f82f145b51","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.WARNING)"},{"line_number":82,"context_line":"        elif self.args.verbose \u003e 0:"},{"line_number":83,"context_line":"            self.logger.setLevel(logging.DEBUG)"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            self.logger.setLevel(logging.INFO)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_67638d1b","line":82,"updated":"2015-10-14 05:10:03.000000000","message":"Please also update the verbose checking in line 320  ( 1 --\u003e  0):\n\n        # If there were two verbose flags, show tempest results.\n        if self.args.verbose \u003e 1:    \n            stderr \u003d None","commit_id":"b0d34ff0553cdc91bed147a54bbdde66fe6ff573"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"2312542202ac7729f7f31417e7b59cd61b922dfc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.WARNING)"},{"line_number":82,"context_line":"        elif self.args.verbose \u003e 0:"},{"line_number":83,"context_line":"            self.logger.setLevel(logging.DEBUG)"},{"line_number":84,"context_line":"        else:"},{"line_number":85,"context_line":"            self.logger.setLevel(logging.INFO)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_a1250cac","line":82,"in_reply_to":"5a2ca52d_67638d1b","updated":"2015-10-14 08:34:34.000000000","message":"Correct, done.","commit_id":"b0d34ff0553cdc91bed147a54bbdde66fe6ff573"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"8e0cc6bf112132b0257e9b36a423a81eec61a37e","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.tempest_dir \u003d \u0027.tempest\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # set default log level to INFO."},{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.WARNING)"},{"line_number":82,"context_line":"        elif self.args.verbose \u003e 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_b5b8bce6","line":79,"updated":"2015-10-15 05:43:23.000000000","message":"just remove this line since it is covered in the else, then it should be good to go.","commit_id":"cd347cdb6f0181a5edea73df3553592becb03f48"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"c6c473075cc9e00d0742816e1f7ed1ddf40cae62","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.tempest_dir \u003d \u0027.tempest\u0027"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # set default log level to INFO."},{"line_number":79,"context_line":"        self.logger.setLevel(logging.INFO)"},{"line_number":80,"context_line":"        if self.args.silent:"},{"line_number":81,"context_line":"            self.logger.setLevel(logging.WARNING)"},{"line_number":82,"context_line":"        elif self.args.verbose \u003e 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_10ddfe0d","line":79,"in_reply_to":"5a2ca52d_b5b8bce6","updated":"2015-10-15 06:50:29.000000000","message":"Correct, done.","commit_id":"cd347cdb6f0181a5edea73df3553592becb03f48"}]}
