)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"8f1bc2c8e1896236aebdd2c2a46d9b812fc5c495","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add guard checks in _get_cpid_from_keystone."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1402949"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8e4bea2b5ab0e60d92fc07a5f0cfa60a7f84732d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a29b11f_0d070919","line":9,"updated":"2015-10-21 05:47:10.000000000","message":"This should be 1502940.","commit_id":"6cbb8a773794165938e22c62355e43382004b5c1"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"1b4099b760deedc15f846ef7dd2be412bbb92ac3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add guard checks in _get_cpid_from_keystone."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #1402949"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8e4bea2b5ab0e60d92fc07a5f0cfa60a7f84732d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a29b11f_3f0d40e8","line":9,"in_reply_to":"3a29b11f_0d070919","updated":"2015-10-21 06:30:28.000000000","message":"Yes, done.","commit_id":"6cbb8a773794165938e22c62355e43382004b5c1"}],"refstack_client/refstack_client.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"f7e3968d209752dff73881a1f76613f0087ea22d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                            len(service[\u0027endpoints\u0027]) \u003e 0:"},{"line_number":194,"context_line":"                            return service[\u0027endpoints\u0027][0][\u0027id\u0027]"},{"line_number":195,"context_line":"                        else:"},{"line_number":196,"context_line":"                            self.logger.error(\"endpoints not found in service\")"},{"line_number":197,"context_line":"                            exit(1)"},{"line_number":198,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":199,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_1a062486","line":196,"updated":"2015-10-22 03:23:34.000000000","message":"Suggest to make this error more clear:\n\n\"Unable to retrieve CPID. Identity service endpoint not found in Keystone v2 catalog.\"","commit_id":"feaf62279161e97b32c4aea66dfd9bb067af8753"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"d59ac1a5c6c82fd20ab2b65f089764dd302cc659","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                            len(service[\u0027endpoints\u0027]) \u003e 0:"},{"line_number":194,"context_line":"                            return service[\u0027endpoints\u0027][0][\u0027id\u0027]"},{"line_number":195,"context_line":"                        else:"},{"line_number":196,"context_line":"                            self.logger.error(\"endpoints not found in service\")"},{"line_number":197,"context_line":"                            exit(1)"},{"line_number":198,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":199,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_ef4365ad","line":196,"in_reply_to":"3a29b11f_1a062486","updated":"2015-10-22 06:17:26.000000000","message":"Yes, sure.","commit_id":"feaf62279161e97b32c4aea66dfd9bb067af8753"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"d59ac1a5c6c82fd20ab2b65f089764dd302cc659","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                            len(service[\u0027endpoints\u0027]) \u003e 0:"},{"line_number":194,"context_line":"                            return service[\u0027endpoints\u0027][0][\u0027id\u0027]"},{"line_number":195,"context_line":"                        else:"},{"line_number":196,"context_line":"                            self.logger.error(\"endpoints not found in service\")"},{"line_number":197,"context_line":"                            exit(1)"},{"line_number":198,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":199,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_3253006d","line":196,"in_reply_to":"3a29b11f_1a062486","updated":"2015-10-22 06:17:26.000000000","message":"Yes.","commit_id":"feaf62279161e97b32c4aea66dfd9bb067af8753"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"813bfb4d0de9a8d93bd67b9981b8e51481e26a89","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                            len(service[\u0027endpoints\u0027]) \u003e 0:"},{"line_number":194,"context_line":"                            return service[\u0027endpoints\u0027][0][\u0027id\u0027]"},{"line_number":195,"context_line":"                        else:"},{"line_number":196,"context_line":"                            self.logger.error(\"endpoints not found in service\")"},{"line_number":197,"context_line":"                            exit(1)"},{"line_number":198,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":199,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_accd7b32","line":196,"in_reply_to":"3a29b11f_1a062486","updated":"2015-10-22 04:38:21.000000000","message":"nitpicking:\n\"Unable to retrieve CPID. Identity service endpoint was not found in Keystone v2 catalog.\"","commit_id":"feaf62279161e97b32c4aea66dfd9bb067af8753"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"f7e3968d209752dff73881a1f76613f0087ea22d","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                        \u0027id\u0027 in service and service[\u0027id\u0027] is not None:"},{"line_number":213,"context_line":"                            return service[\u0027id\u0027]"},{"line_number":214,"context_line":"                    else:"},{"line_number":215,"context_line":"                        self.logger.error(\"id is not found in service\")"},{"line_number":216,"context_line":"                        exit(1)"},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                raise ValueError(\u0027Auth_version %s is unsupported\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_daad0c85","line":215,"updated":"2015-10-22 03:23:34.000000000","message":"Suggest to make this error more clear:\n\n\"Unable to retrieve CPID. Identity service ID was not found in Keystone v3 catalog.\"","commit_id":"feaf62279161e97b32c4aea66dfd9bb067af8753"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"d59ac1a5c6c82fd20ab2b65f089764dd302cc659","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                        \u0027id\u0027 in service and service[\u0027id\u0027] is not None:"},{"line_number":213,"context_line":"                            return service[\u0027id\u0027]"},{"line_number":214,"context_line":"                    else:"},{"line_number":215,"context_line":"                        self.logger.error(\"id is not found in service\")"},{"line_number":216,"context_line":"                        exit(1)"},{"line_number":217,"context_line":"            else:"},{"line_number":218,"context_line":"                raise ValueError(\u0027Auth_version %s is unsupported\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_6f0e758d","line":215,"in_reply_to":"3a29b11f_daad0c85","updated":"2015-10-22 06:17:26.000000000","message":"Done.","commit_id":"feaf62279161e97b32c4aea66dfd9bb067af8753"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"6e03d2fab872aae818c5e5a4c102995f14cb242e","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                              \"Identity service endpoint was \""},{"line_number":198,"context_line":"                                              \"not found in Keystone \""},{"line_number":199,"context_line":"                                              \"v2 catalog.\")"},{"line_number":200,"context_line":"                            exit(1)"},{"line_number":201,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":202,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"},{"line_number":203,"context_line":"                if conf_file.has_option(\u0027identity\u0027, \u0027domain_name\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_2e54301f","line":200,"updated":"2015-11-11 08:31:59.000000000","message":"Please replace exit(1) with raise some exception. ValueError or KeyError or something else. exit(1) is too ungracefull here","commit_id":"daae4b662c309625633b7f04736fe581bbbcbb20"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"fe7c31c650d3c1de91d0d1e326a042e24f9ab7d1","unresolved":false,"context_lines":[{"line_number":197,"context_line":"                                              \"Identity service endpoint was \""},{"line_number":198,"context_line":"                                              \"not found in Keystone \""},{"line_number":199,"context_line":"                                              \"v2 catalog.\")"},{"line_number":200,"context_line":"                            exit(1)"},{"line_number":201,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":202,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"},{"line_number":203,"context_line":"                if conf_file.has_option(\u0027identity\u0027, \u0027domain_name\u0027):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_c74f8769","line":200,"in_reply_to":"da85f559_2e54301f","updated":"2015-11-11 11:00:49.000000000","message":"Yes, agree.","commit_id":"daae4b662c309625633b7f04736fe581bbbcbb20"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"6e03d2fab872aae818c5e5a4c102995f14cb242e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                        self.logger.error(\"Unable to retrieve CPID. \""},{"line_number":219,"context_line":"                                          \"Identity service ID was not \""},{"line_number":220,"context_line":"                                          \"found in Keystone v3 catalog.\")"},{"line_number":221,"context_line":"                        exit(1)"},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                raise ValueError(\u0027Auth_version %s is unsupported\u0027"},{"line_number":224,"context_line":"                                 \u0027\u0027 % auth_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_6e5eb845","line":221,"updated":"2015-11-11 08:31:59.000000000","message":"ditto","commit_id":"daae4b662c309625633b7f04736fe581bbbcbb20"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"fe7c31c650d3c1de91d0d1e326a042e24f9ab7d1","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                        self.logger.error(\"Unable to retrieve CPID. \""},{"line_number":219,"context_line":"                                          \"Identity service ID was not \""},{"line_number":220,"context_line":"                                          \"found in Keystone v3 catalog.\")"},{"line_number":221,"context_line":"                        exit(1)"},{"line_number":222,"context_line":"            else:"},{"line_number":223,"context_line":"                raise ValueError(\u0027Auth_version %s is unsupported\u0027"},{"line_number":224,"context_line":"                                 \u0027\u0027 % auth_version)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_074a6f55","line":221,"in_reply_to":"da85f559_6e5eb845","updated":"2015-11-11 11:00:49.000000000","message":"Yes.","commit_id":"daae4b662c309625633b7f04736fe581bbbcbb20"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"72a2fe891279d90ec3cd85942ed22525d484429b","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                              \"v2 catalog.\")"},{"line_number":200,"context_line":"                            raise ValueError(\u0027Identity service endpoint was \u0027"},{"line_number":201,"context_line":"                                             \u0027not found in Keystone v2 \u0027"},{"line_number":202,"context_line":"                                             \u0027catalog.\u0027)"},{"line_number":203,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":204,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"},{"line_number":205,"context_line":"                if conf_file.has_option(\u0027identity\u0027, \u0027domain_name\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_bda374b1","line":202,"updated":"2015-11-11 10:25:31.000000000","message":"Strings looks the same. It will be better to do something like this\nmsg \u003d \"Unable to retrieve CPID. Identity service endpoint was not found in Keystone v2 catalog.\"\nself.logger.error(msg)\nraise RuntimeError(msg)\n\nI looked trough this document https://docs.python.org/2/library/exceptions.html#bltin-exceptions and found that RuntimeError here looks better than ValueError.","commit_id":"2899e86a204e2b2b677015aa87448eeee52304b4"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"5566eb95668331b47b71d5418fc73ba33d9ce878","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                              \"v2 catalog.\")"},{"line_number":200,"context_line":"                            raise ValueError(\u0027Identity service endpoint was \u0027"},{"line_number":201,"context_line":"                                             \u0027not found in Keystone v2 \u0027"},{"line_number":202,"context_line":"                                             \u0027catalog.\u0027)"},{"line_number":203,"context_line":"            elif auth_version \u003d\u003d \u0027v3\u0027:"},{"line_number":204,"context_line":"                args[\u0027auth_url\u0027] \u003d conf_file.get(\u0027identity\u0027, \u0027uri_v3\u0027)"},{"line_number":205,"context_line":"                if conf_file.has_option(\u0027identity\u0027, \u0027domain_name\u0027):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_c3da164b","line":202,"in_reply_to":"da85f559_bda374b1","updated":"2015-11-11 11:48:13.000000000","message":"Correct, quickly go through the doc, it seems RuntimeError more reasonable. Informative review, thank you Sergey.","commit_id":"2899e86a204e2b2b677015aa87448eeee52304b4"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"72a2fe891279d90ec3cd85942ed22525d484429b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                          \"Identity service ID was not \""},{"line_number":222,"context_line":"                                          \"found in Keystone v3 catalog.\")"},{"line_number":223,"context_line":"                        raise ValueError(\u0027Identity service ID was not found \u0027"},{"line_number":224,"context_line":"                                         \u0027in Keystone v3 catalog.\u0027)"},{"line_number":225,"context_line":"            else:"},{"line_number":226,"context_line":"                raise ValueError(\u0027Auth_version %s is unsupported\u0027"},{"line_number":227,"context_line":"                                 \u0027\u0027 % auth_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_dda8b88f","line":224,"updated":"2015-11-11 10:25:31.000000000","message":"ditto","commit_id":"2899e86a204e2b2b677015aa87448eeee52304b4"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"5566eb95668331b47b71d5418fc73ba33d9ce878","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                                          \"Identity service ID was not \""},{"line_number":222,"context_line":"                                          \"found in Keystone v3 catalog.\")"},{"line_number":223,"context_line":"                        raise ValueError(\u0027Identity service ID was not found \u0027"},{"line_number":224,"context_line":"                                         \u0027in Keystone v3 catalog.\u0027)"},{"line_number":225,"context_line":"            else:"},{"line_number":226,"context_line":"                raise ValueError(\u0027Auth_version %s is unsupported\u0027"},{"line_number":227,"context_line":"                                 \u0027\u0027 % auth_version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_03d57e1a","line":224,"in_reply_to":"da85f559_dda8b88f","updated":"2015-11-11 11:48:13.000000000","message":"Done.","commit_id":"2899e86a204e2b2b677015aa87448eeee52304b4"}]}