)]}'
{"refstack_client/refstack_client.py":[{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"5719c27011df442546cb412194ebaab7d23d10e8","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                    \u0027using %s endpoint (%s)\u0027 % (auth_version,"},{"line_number":237,"context_line":"                                    args[\u0027auth_url\u0027]))"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            return self._generate_cpid_from_endpoint(args[\u0027auth_url\u0027])"},{"line_number":240,"context_line":"        except ConfigParser.Error as e:"},{"line_number":241,"context_line":"            # Most likely a missing section or option in the config file."},{"line_number":242,"context_line":"            self.logger.error(\"Invalid Config File: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_dec87157","line":239,"range":{"start_line":239,"start_character":24,"end_line":239,"end_character":52},"updated":"2015-12-21 21:32:13.000000000","message":"My suggestion is: lets use URL hash as a source of CPID. \n\nBut also keep old code to retrieve Keystone service ID and add some code for storing it in test metadata in next patch.","commit_id":"af8e6c294725af4020df28bc7580cdae1afd5ab4"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"0fe23d0e808f6fda5ec69922bb7ddbf44e357705","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                    \u0027using %s endpoint (%s)\u0027 % (auth_version,"},{"line_number":237,"context_line":"                                    args[\u0027auth_url\u0027]))"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            return self._generate_cpid_from_endpoint(args[\u0027auth_url\u0027])"},{"line_number":240,"context_line":"        except ConfigParser.Error as e:"},{"line_number":241,"context_line":"            # Most likely a missing section or option in the config file."},{"line_number":242,"context_line":"            self.logger.error(\"Invalid Config File: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_8fb007df","line":239,"range":{"start_line":239,"start_character":24,"end_line":239,"end_character":52},"in_reply_to":"3a7e1126_dec87157","updated":"2016-01-03 20:14:24.000000000","message":"May I suggest the following:\n\n* We should keep this code as-is for this patch because it is implementing the https://review.openstack.org/#/c/255607/ spec which we all agreed on.\n\n* We should work on a new spec \u0026 patch for storing the CPID retrieved from Keystone and define how this information stored in the meta table should be used.","commit_id":"af8e6c294725af4020df28bc7580cdae1afd5ab4"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"1bc851ce34dad2822a28073a31a3077c2a3c9a9d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                    \u0027using %s endpoint (%s)\u0027 % (auth_version,"},{"line_number":237,"context_line":"                                    args[\u0027auth_url\u0027]))"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"            return self._generate_cpid_from_endpoint(args[\u0027auth_url\u0027])"},{"line_number":240,"context_line":"        except ConfigParser.Error as e:"},{"line_number":241,"context_line":"            # Most likely a missing section or option in the config file."},{"line_number":242,"context_line":"            self.logger.error(\"Invalid Config File: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_971eb961","line":239,"range":{"start_line":239,"start_character":24,"end_line":239,"end_character":52},"in_reply_to":"fa69d971_8fb007df","updated":"2016-01-04 20:04:17.000000000","message":"Sure, we should certainly address this in a subsequent patch. Will also address the conversion of keystone-client code to raw api requests in a subsequent patch.","commit_id":"af8e6c294725af4020df28bc7580cdae1afd5ab4"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"5719c27011df442546cb412194ebaab7d23d10e8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"           generate a CPID.\u0027\u0027\u0027"},{"line_number":248,"context_line":"        self.logger.info(\u0027Creating hash from endpoint to use as CPID.\u0027)"},{"line_number":249,"context_line":"        url_parts \u003d parse.urlparse(endpoint)"},{"line_number":250,"context_line":"        if \u0027http\u0027 not in url_parts.scheme:"},{"line_number":251,"context_line":"            raise ValueError(\u0027Invalid Keystone endpoint format. Make sure \u0027"},{"line_number":252,"context_line":"                             \u0027the endpoint (%s) includes the URL scheme \u0027"},{"line_number":253,"context_line":"                             \u0027(i.e. http/https).\u0027 % endpoint)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7e1126_12258f07","line":250,"range":{"start_line":250,"start_character":11,"end_line":250,"end_character":40},"updated":"2015-12-21 21:32:13.000000000","message":"We can be a little bit precise here:\n\nurl_parts.scheme in \u0027http\u0027, \u0027https\u0027","commit_id":"af8e6c294725af4020df28bc7580cdae1afd5ab4"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"1bc851ce34dad2822a28073a31a3077c2a3c9a9d","unresolved":false,"context_lines":[{"line_number":247,"context_line":"           generate a CPID.\u0027\u0027\u0027"},{"line_number":248,"context_line":"        self.logger.info(\u0027Creating hash from endpoint to use as CPID.\u0027)"},{"line_number":249,"context_line":"        url_parts \u003d parse.urlparse(endpoint)"},{"line_number":250,"context_line":"        if \u0027http\u0027 not in url_parts.scheme:"},{"line_number":251,"context_line":"            raise ValueError(\u0027Invalid Keystone endpoint format. Make sure \u0027"},{"line_number":252,"context_line":"                             \u0027the endpoint (%s) includes the URL scheme \u0027"},{"line_number":253,"context_line":"                             \u0027(i.e. http/https).\u0027 % endpoint)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_5727e1b5","line":250,"range":{"start_line":250,"start_character":11,"end_line":250,"end_character":40},"in_reply_to":"3a7e1126_12258f07","updated":"2016-01-04 20:04:17.000000000","message":"Done","commit_id":"af8e6c294725af4020df28bc7580cdae1afd5ab4"}]}