)]}'
{"refstack_client/refstack_client.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"7f21703a7c738f9932afa90e9731d3c13c93de28","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        \u0027tenant_id\u0027: tenant_id, \u0027tenant_name\u0027: tenant_name"},{"line_number":185,"context_line":"                        }"},{"line_number":186,"context_line":"            else:"},{"line_number":187,"context_line":"                self.logger.error(\u0027User credentials cannot be found.\u0027"},{"line_number":188,"context_line":"                                  \u0027 User credential should be defined\u0027"},{"line_number":189,"context_line":"                                  \u0027 in the accounts file as described in\u0027"},{"line_number":190,"context_line":"                                  \u0027 the Tempest configuration guide (\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_5bc2ffe9","line":187,"range":{"start_line":187,"start_character":28,"end_line":187,"end_character":33},"updated":"2016-03-03 19:43:51.000000000","message":"I think it would be preferable for this to be a warning, but still allow credentials in tempest.conf to be used instead of exiting.","commit_id":"645419db1443fe338ceb88b625dd9ac70497e710"},{"author":{"_account_id":11361,"name":"Simeon Monov","email":"sdmonov@us.ibm.com","username":"sdmonov"},"change_message_id":"220498aa8f74dd72bd0edad6422f23209d4675b1","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                        \u0027tenant_id\u0027: tenant_id, \u0027tenant_name\u0027: tenant_name"},{"line_number":185,"context_line":"                        }"},{"line_number":186,"context_line":"            else:"},{"line_number":187,"context_line":"                self.logger.error(\u0027User credentials cannot be found.\u0027"},{"line_number":188,"context_line":"                                  \u0027 User credential should be defined\u0027"},{"line_number":189,"context_line":"                                  \u0027 in the accounts file as described in\u0027"},{"line_number":190,"context_line":"                                  \u0027 the Tempest configuration guide (\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_03d5a9e6","line":187,"range":{"start_line":187,"start_character":28,"end_line":187,"end_character":33},"in_reply_to":"7af24918_5bc2ffe9","updated":"2016-03-03 20:29:02.000000000","message":"Added a check if identity section is used will show a warning and continue using the credentials from it. If no accounts file was specified nor credentials in identity section specified then show an error and exit","commit_id":"645419db1443fe338ceb88b625dd9ac70497e710"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"71c8e8452789d87b5c61b28f7bf80ba00d34b2e1","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                        \u0027username\u0027: username, \u0027password\u0027: password,"},{"line_number":184,"context_line":"                        \u0027tenant_id\u0027: tenant_id, \u0027tenant_name\u0027: tenant_name"},{"line_number":185,"context_line":"                        }"},{"line_number":186,"context_line":"            elif conf_file.has_option(\u0027identity\u0027, \u0027username\u0027):"},{"line_number":187,"context_line":"                self.logger.warn(\u0027Using identity section of tempest config \u0027"},{"line_number":188,"context_line":"                                 \u0027file to specify user credentials is \u0027"},{"line_number":189,"context_line":"                                 \u0027deprecated and won\\\u0027t be supported soon. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_cfa634ad","line":186,"updated":"2016-03-04 05:02:54.000000000","message":"do we really need this \u0027elif\u0027, we use account file or we fall\nback to deprecated ones, the warning message did helps indeed.","commit_id":"b066bd68a8faad6a12e13f248507d146a9d066e4"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"71c8e8452789d87b5c61b28f7bf80ba00d34b2e1","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                        \u0027domain_name\u0027: domain_name,"},{"line_number":206,"context_line":"                        \u0027username\u0027: username, \u0027password\u0027: password,"},{"line_number":207,"context_line":"                        \u0027tenant_id\u0027: tenant_id, \u0027tenant_name\u0027: tenant_name}"},{"line_number":208,"context_line":"            else:"},{"line_number":209,"context_line":"                self.logger.error(\u0027User credentials cannot be found. \u0027"},{"line_number":210,"context_line":"                                  \u0027User credentials should be defined in the \u0027"},{"line_number":211,"context_line":"                                  \u0027accounts file as described in the Tempest \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_6fe9e0b6","line":208,"updated":"2016-03-04 05:02:54.000000000","message":"again, the same, the log error message could be moved to the \nexception handle section I suggest.","commit_id":"b066bd68a8faad6a12e13f248507d146a9d066e4"}]}