)]}'
{"refstack_client/list_parser.py":[{"author":{"_account_id":26088,"name":"Linda Wang","email":"wangwulin@huawei.com","username":"wangwulin"},"change_message_id":"566e2acd454d2036cff1fc68f37f842d683bb752","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        of full test IDs for the current Tempest environment. Test ID"},{"line_number":47,"context_line":"        mappings are then formed for these tests."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if os.path.exists(os.path.join(self.tempest_dir, \u0027.stestr.conf\u0027)):"},{"line_number":50,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":51,"context_line":"                   \u0027stestr\u0027, \u0027list\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":54,"context_line":"                   \u0027testr\u0027, \u0027list-tests\u0027)"},{"line_number":55,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE,"},{"line_number":56,"context_line":"                                   cwd\u003dself.tempest_dir)"},{"line_number":57,"context_line":"        (stdout, stderr) \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_b56a2017","line":54,"range":{"start_line":49,"start_character":0,"end_line":54,"end_character":41},"updated":"2018-04-24 02:09:43.000000000","message":"Another patch (https://review.openstack.org/#/c/561777/) is dealing with the same issue, but I would prefer your solution, thanks:)","commit_id":"c31972a6a0e8fdbff7797dfa39cf50d24086678e"},{"author":{"_account_id":26088,"name":"Linda Wang","email":"wangwulin@huawei.com","username":"wangwulin"},"change_message_id":"ce81f2f7fb0f2b6455e0c10cc96ab3c035a224e6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        of full test IDs for the current Tempest environment. Test ID"},{"line_number":47,"context_line":"        mappings are then formed for these tests."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if os.path.exists(os.path.join(self.tempest_dir, \u0027.stestr.conf\u0027)):"},{"line_number":50,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":51,"context_line":"                   \u0027stestr\u0027, \u0027list\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":54,"context_line":"                   \u0027testr\u0027, \u0027list-tests\u0027)"},{"line_number":55,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE,"},{"line_number":56,"context_line":"                                   cwd\u003dself.tempest_dir)"},{"line_number":57,"context_line":"        (stdout, stderr) \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_18c1c1e5","line":54,"range":{"start_line":49,"start_character":0,"end_line":54,"end_character":41},"updated":"2018-04-24 03:45:10.000000000","message":"I tested your patch locally, it failed when running this command \"/src/tempest/tools/with_venv.sh stestr list\":\nstestr.repository.abstract.RepositoryNotFound: No repository found in /src/tempest. Create one by running \"stestr init\".\n\nBecause we only import list_parser package to get normalized test list, see: https://github.com/opnfv/functest/blob/master/functest/opnfv_tests/openstack/refstack/refstack.py#L39-L41\n\nThat is why I add \"stestr init\" in my patch:https://review.openstack.org/#/c/561777/4/refstack_client/list_parser.py","commit_id":"06de9a69185dd448595572dec8f1e21674b07a14"},{"author":{"_account_id":26088,"name":"Linda Wang","email":"wangwulin@huawei.com","username":"wangwulin"},"change_message_id":"2d1347d2cd97a348e3e95b0154233f71671bcc08","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        of full test IDs for the current Tempest environment. Test ID"},{"line_number":47,"context_line":"        mappings are then formed for these tests."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if os.path.exists(os.path.join(self.tempest_dir, \u0027.stestr.conf\u0027)):"},{"line_number":50,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":51,"context_line":"                   \u0027stestr\u0027, \u0027list\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":54,"context_line":"                   \u0027testr\u0027, \u0027list-tests\u0027)"},{"line_number":55,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE,"},{"line_number":56,"context_line":"                                   cwd\u003dself.tempest_dir)"},{"line_number":57,"context_line":"        (stdout, stderr) \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_341b5773","line":54,"range":{"start_line":49,"start_character":0,"end_line":54,"end_character":41},"in_reply_to":"9f6a8fd7_184f8193","updated":"2018-04-25 02:45:27.000000000","message":".stestr repository in /src/tempest is required, which could be created via \"stestr init\"","commit_id":"06de9a69185dd448595572dec8f1e21674b07a14"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"a85414e2c0ae500c1d01a9ea1d28304ac327bdc1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        of full test IDs for the current Tempest environment. Test ID"},{"line_number":47,"context_line":"        mappings are then formed for these tests."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if os.path.exists(os.path.join(self.tempest_dir, \u0027.stestr.conf\u0027)):"},{"line_number":50,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":51,"context_line":"                   \u0027stestr\u0027, \u0027list\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":54,"context_line":"                   \u0027testr\u0027, \u0027list-tests\u0027)"},{"line_number":55,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE,"},{"line_number":56,"context_line":"                                   cwd\u003dself.tempest_dir)"},{"line_number":57,"context_line":"        (stdout, stderr) \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_184f8193","line":54,"range":{"start_line":49,"start_character":0,"end_line":54,"end_character":41},"in_reply_to":"9f6a8fd7_18c1c1e5","updated":"2018-04-24 03:50:36.000000000","message":"I will have someone to test this","commit_id":"06de9a69185dd448595572dec8f1e21674b07a14"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"322364037e61b8bd6a12c1d12d6d8e2ff8474c46","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        of full test IDs for the current Tempest environment. Test ID"},{"line_number":47,"context_line":"        mappings are then formed for these tests."},{"line_number":48,"context_line":"        \"\"\""},{"line_number":49,"context_line":"        if os.path.exists(os.path.join(self.tempest_dir, \u0027.stestr.conf\u0027)):"},{"line_number":50,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":51,"context_line":"                   \u0027stestr\u0027, \u0027list\u0027)"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            cmd \u003d (os.path.join(self.tempest_dir, \u0027tools/with_venv.sh\u0027),"},{"line_number":54,"context_line":"                   \u0027testr\u0027, \u0027list-tests\u0027)"},{"line_number":55,"context_line":"        process \u003d subprocess.Popen(cmd, stdout\u003dsubprocess.PIPE,"},{"line_number":56,"context_line":"                                   cwd\u003dself.tempest_dir)"},{"line_number":57,"context_line":"        (stdout, stderr) \u003d process.communicate()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_56a20eb0","line":54,"range":{"start_line":49,"start_character":0,"end_line":54,"end_character":41},"in_reply_to":"9f6a8fd7_341b5773","updated":"2018-05-09 09:09:22.000000000","message":"I\u0027m not quite sure where this method is called in the refstack client usual workflow, but I would say it should be fine to run a init to initialize the repo if it is not there yet.\n\nOne thing worth noting is that the same \"init\" workflow existed with testr as well, so I wonder if refstack users today have to testr init before they can use the refstack client.","commit_id":"06de9a69185dd448595572dec8f1e21674b07a14"}],"refstack_client/refstack_client.py":[{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"885b6065b71c6f41dedabe9a9e29e5c19f4d5bba","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                              \u0027found. Assuming subunit results will be stored \u0027"},{"line_number":146,"context_line":"                              \u0027in file 0.\u0027)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            # Testr saves the first test stream to $sub_dir/0 when"},{"line_number":149,"context_line":"            # there is a newly generated $sub_dir directory."},{"line_number":150,"context_line":"            subunit_file \u003d \"0\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return os.path.join(tempest_dir, sub_dir, subunit_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_e35d4715","line":149,"range":{"start_line":148,"start_character":12,"end_line":149,"end_character":60},"updated":"2018-04-23 21:41:09.000000000","message":"NIT: Shorten comment to \"First test stream is saved into $sub_dir/0\"","commit_id":"c31972a6a0e8fdbff7797dfa39cf50d24086678e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"4f5fd939252fc45545166c48f2fc211e63746c6d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                              \u0027found. Assuming subunit results will be stored \u0027"},{"line_number":146,"context_line":"                              \u0027in file 0.\u0027)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"            # Testr saves the first test stream to $sub_dir/0 when"},{"line_number":149,"context_line":"            # there is a newly generated $sub_dir directory."},{"line_number":150,"context_line":"            subunit_file \u003d \"0\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        return os.path.join(tempest_dir, sub_dir, subunit_file)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_554704bd","line":149,"range":{"start_line":148,"start_character":12,"end_line":149,"end_character":60},"in_reply_to":"9f6a8fd7_e35d4715","updated":"2018-04-24 02:04:49.000000000","message":"Done","commit_id":"c31972a6a0e8fdbff7797dfa39cf50d24086678e"},{"author":{"_account_id":17716,"name":"Luz Cazares","email":"luz.cazares@intel.com","username":"luzcazares"},"change_message_id":"885b6065b71c6f41dedabe9a9e29e5c19f4d5bba","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                  sign_with\u003dself.args.priv_key)"},{"line_number":509,"context_line":"        else:"},{"line_number":510,"context_line":"            msg1 \u003d (\"tempest run command did not generate a results file \""},{"line_number":511,"context_line":"                    \"under the Refstack .tempest/.testrepository \""},{"line_number":512,"context_line":"                    \"directory. Review command and try again.\")"},{"line_number":513,"context_line":"            msg2 \u003d (\"Problem executing tempest run command. Results file \""},{"line_number":514,"context_line":"                    \"not generated hence no file to upload. Review \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_e36787b6","line":511,"range":{"start_line":511,"start_character":40,"end_line":511,"end_character":65},"updated":"2018-04-23 21:41:09.000000000","message":"change fixed directory with \"os.path.dirname(results_file)\"","commit_id":"c31972a6a0e8fdbff7797dfa39cf50d24086678e"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"4f5fd939252fc45545166c48f2fc211e63746c6d","unresolved":false,"context_lines":[{"line_number":508,"context_line":"                                  sign_with\u003dself.args.priv_key)"},{"line_number":509,"context_line":"        else:"},{"line_number":510,"context_line":"            msg1 \u003d (\"tempest run command did not generate a results file \""},{"line_number":511,"context_line":"                    \"under the Refstack .tempest/.testrepository \""},{"line_number":512,"context_line":"                    \"directory. Review command and try again.\")"},{"line_number":513,"context_line":"            msg2 \u003d (\"Problem executing tempest run command. Results file \""},{"line_number":514,"context_line":"                    \"not generated hence no file to upload. Review \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_754248ad","line":511,"range":{"start_line":511,"start_character":40,"end_line":511,"end_character":65},"in_reply_to":"9f6a8fd7_e36787b6","updated":"2018-04-24 02:04:49.000000000","message":"Done","commit_id":"c31972a6a0e8fdbff7797dfa39cf50d24086678e"}]}
