)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Drop python2, python3.6 and 3.7 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refstack-client is dropping support of python2 and also all python3 versions above python3.8"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":"-requirements.txt - added license on python-subunit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"08e5f1f5_7596e4a9","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":92},"updated":"2022-11-22 09:58:57.000000000","message":"the line is too long, this should be already on the next line","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Drop python2, python3.6 and 3.7 support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Refstack-client is dropping support of python2 and also all python3 versions above python3.8"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":"-requirements.txt - added license on python-subunit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"faafe739_ef810335","line":9,"range":{"start_line":9,"start_character":68,"end_line":9,"end_character":92},"in_reply_to":"08e5f1f5_7596e4a9","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":"-requirements.txt - added license on python-subunit"},{"line_number":13,"context_line":"-setup.cfg - removed python2 and python3 versions above python3.8"},{"line_number":14,"context_line":"           - added python3.10"},{"line_number":15,"context_line":"-setup_env - removed all python2 mentions"},{"line_number":16,"context_line":"\t   - python3 min version set to 3.8.0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc8344e9_a2bcf270","line":13,"range":{"start_line":13,"start_character":50,"end_line":13,"end_character":55},"updated":"2022-11-22 09:58:57.000000000","message":"below?","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Changes:"},{"line_number":12,"context_line":"-requirements.txt - added license on python-subunit"},{"line_number":13,"context_line":"-setup.cfg - removed python2 and python3 versions above python3.8"},{"line_number":14,"context_line":"           - added python3.10"},{"line_number":15,"context_line":"-setup_env - removed all python2 mentions"},{"line_number":16,"context_line":"\t   - python3 min version set to 3.8.0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"12afcedb_103e0961","line":13,"range":{"start_line":13,"start_character":50,"end_line":13,"end_character":55},"in_reply_to":"dc8344e9_a2bcf270","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":true,"context_lines":[{"line_number":13,"context_line":"-setup.cfg - removed python2 and python3 versions above python3.8"},{"line_number":14,"context_line":"           - added python3.10"},{"line_number":15,"context_line":"-setup_env - removed all python2 mentions"},{"line_number":16,"context_line":"\t   - python3 min version set to 3.8.0"},{"line_number":17,"context_line":"-tox.ini - removed py27 from envlist, added py38"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I6500ed950cb9bc07d87370940b4752e686712c14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bc35b59e_bc4bac7c","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":1},"updated":"2022-11-22 09:58:57.000000000","message":"tab, please use spaces instead","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":13,"context_line":"-setup.cfg - removed python2 and python3 versions above python3.8"},{"line_number":14,"context_line":"           - added python3.10"},{"line_number":15,"context_line":"-setup_env - removed all python2 mentions"},{"line_number":16,"context_line":"\t   - python3 min version set to 3.8.0"},{"line_number":17,"context_line":"-tox.ini - removed py27 from envlist, added py38"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I6500ed950cb9bc07d87370940b4752e686712c14"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7fa87fe9_417c9643","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":1},"in_reply_to":"bc35b59e_bc4bac7c","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9646511d_c50a6bfe","updated":"2022-11-03 11:35:33.000000000","message":"The patch looks like it is on a good way! It just needs a little cleanup. \n\nI think that the two main thinks that need to be fixed are:\n1) I have noticed that the setup_env script fails when I run \"./setup_env -p 3.10.0\".\n2) The script encounters an error during the creation of virtual environment on Ubuntu 20.04LTS (see code comments)","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4d038fc6_9d1cf9d6","updated":"2022-11-22 12:42:24.000000000","message":"The code worked as expected for me! I just added two comments.","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b24450c6_5fd66bf1","updated":"2022-11-22 09:58:57.000000000","message":"several small things I noticed which could be still improved","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2d27fa97_ad096952","updated":"2022-11-24 11:20:51.000000000","message":"Looks good to me. However I\u0027ve encountered a few issues with python 3.10.0+. \n\nThere\u0027s a leftover reference to python2.7 here [1].\n\n[1] https://opendev.org/openinfra/refstack-client/src/branch/master/README.rst","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"21020b1593d2b54a6552b9b9f1c638837bd0dd0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8f9af8e7_dc45e43b","updated":"2022-11-24 08:02:29.000000000","message":"lgtm, I\u0027ll wait with +w for Lukas\u0027 review ","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c268dc9c54756a88155e285edaa35d8369d68496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1a441adf_9ee4bd99","in_reply_to":"2d27fa97_ad096952","updated":"2022-11-29 18:08:02.000000000","message":"Done","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c268dc9c54756a88155e285edaa35d8369d68496","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"74bfc31a_2d7c2d1c","updated":"2022-11-29 18:08:02.000000000","message":"Nice fix. I\u0027m not sure about this but I think that the locally installed virtualenv needs to be added to PYTHONPATH and then it should be done!","commit_id":"85908437f8e19523d8d2a4efd9e37695481eba97"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0a99b3a1_a522c5bc","updated":"2023-01-29 16:54:59.000000000","message":"recheck to see whether the errors are consistent","commit_id":"78cc053988dfb566afdf013b0b29ddb8fd5e6176"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2aa0a736d41da1a5aad14f78b53c061139c91c4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"893a14af_80e57503","updated":"2023-02-07 14:12:26.000000000","message":"lgtm,plus the -l feature works, the option not to download, build and install local python can save around 3 minutes ","commit_id":"54c74fb8e3fbf3b56d1319de8a7c3400048c231d"}],"README.rst":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   e. -s option makes ``refstack-client`` use ``python-tempestconf`` from the"},{"line_number":39,"context_line":"   given source (path) - used when running f.e. in Zuul."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Usage"},{"line_number":42,"context_line":"#####"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"9dace980_1d4e3a22","line":40,"updated":"2022-12-13 17:25:47.000000000","message":"add the description of the new l option here as well","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   e. -s option makes ``refstack-client`` use ``python-tempestconf`` from the"},{"line_number":39,"context_line":"   given source (path) - used when running f.e. in Zuul."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Usage"},{"line_number":42,"context_line":"#####"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"26e20321_74dc4b7d","line":40,"in_reply_to":"9dace980_1d4e3a22","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"}],"setup_env":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":201,"context_line":"fi"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"# Determine python which will run virtualenv.py script"},{"line_number":204,"context_line":"if [ -n \"$(command -v python3)\" ]; then"},{"line_number":205,"context_line":"    python\u003d\u0027python3\u0027"},{"line_number":206,"context_line":"else"},{"line_number":207,"context_line":"    python\u003d\u0027python\u0027"},{"line_number":208,"context_line":"fi"},{"line_number":209,"context_line":"$python virtualenv.py ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":210,"context_line":"$python virtualenv.py ${TEMPEST_DIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":211,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1b685098_020913de","side":"PARENT","line":208,"range":{"start_line":204,"start_character":0,"end_line":208,"end_character":2},"updated":"2022-11-03 11:35:33.000000000","message":"I\u0027m wondering whether we really want to delete this condition here.","commit_id":"23d9f5d7dfb80c42f8154ff8dd1708f570595abc"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"fi"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"# Determine python which will run virtualenv.py script"},{"line_number":204,"context_line":"if [ -n \"$(command -v python3)\" ]; then"},{"line_number":205,"context_line":"    python\u003d\u0027python3\u0027"},{"line_number":206,"context_line":"else"},{"line_number":207,"context_line":"    python\u003d\u0027python\u0027"},{"line_number":208,"context_line":"fi"},{"line_number":209,"context_line":"$python virtualenv.py ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":210,"context_line":"$python virtualenv.py ${TEMPEST_DIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":211,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5694f0d0_a8ce0f6b","side":"PARENT","line":208,"range":{"start_line":204,"start_character":0,"end_line":208,"end_character":2},"in_reply_to":"1b685098_020913de","updated":"2022-11-22 09:58:57.000000000","message":"Done","commit_id":"23d9f5d7dfb80c42f8154ff8dd1708f570595abc"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":221,"context_line":"# Note: Since there are no requirements in tempest-additional-requirements.txt by default,"},{"line_number":222,"context_line":"# this line is commented out to prevent errors from being returned. Uncomment this line if"},{"line_number":223,"context_line":"# there are requirements in tempest-additonal-requirements.txt."},{"line_number":224,"context_line":"# ${TEMPEST_DIR}/.venv/bin/pip install -c ${UPPER_CONSTRAINTS_FILE} -r ${WORKDIR}/tempest-additional-requirements.txt"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"247f3788_32c2521c","side":"PARENT","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":117},"updated":"2022-11-03 11:35:33.000000000","message":"Just a nit:). We can keep the new line at the end of the file.","commit_id":"23d9f5d7dfb80c42f8154ff8dd1708f570595abc"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":221,"context_line":"# Note: Since there are no requirements in tempest-additional-requirements.txt by default,"},{"line_number":222,"context_line":"# this line is commented out to prevent errors from being returned. Uncomment this line if"},{"line_number":223,"context_line":"# there are requirements in tempest-additonal-requirements.txt."},{"line_number":224,"context_line":"# ${TEMPEST_DIR}/.venv/bin/pip install -c ${UPPER_CONSTRAINTS_FILE} -r ${WORKDIR}/tempest-additional-requirements.txt"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0894f25d_102193ca","side":"PARENT","line":224,"range":{"start_line":224,"start_character":0,"end_line":224,"end_character":117},"in_reply_to":"247f3788_32c2521c","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"23d9f5d7dfb80c42f8154ff8dd1708f570595abc"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        p)"},{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            else"},{"line_number":48,"context_line":"\t\tif [ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]; then"},{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"2472a4ab_1fafecb6","line":48,"range":{"start_line":47,"start_character":12,"end_line":48,"end_character":5},"updated":"2022-11-03 11:35:33.000000000","message":"I would use \u0027elif\u0027 here instead of \"else\" + \"if\"","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            else"},{"line_number":48,"context_line":"\t\tif [ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]; then"},{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ef775c90_df161780","line":48,"range":{"start_line":48,"start_character":31,"end_line":48,"end_character":44},"updated":"2022-11-03 11:35:33.000000000","message":"```${OPTARG:2:3}```\nThis will not work when I run \"./setup_env -p 3.10.0\".\n\n--------------------\n\n```\n[ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]\n```\nThis will fail. It could be replaced by something like this: \n```\n[[ ${OPTARG:0:1} \u003d\u003d \"3\" ]] \u0026\u0026 [[ ${OPTARG:2:3} -ge \"8\" ]]\n```\nNote that this will still fail in case -p 3.10.0 is used. We have to find some better solution:). \n----------------------\n\nFor example, we could try something like replacing \".\" with \" \" and then looking at the first and second word. \n\nYou can use \"tr\" for replacing characters and \"awk\" to get second/first word. \n```\necho \"3.10.0\" | tr \".\" \" \"  # \"3.10.0\" \u003d\u003e \"3 10 0\" \n```\n\nThis is just and idea maybe there is more effective way how to do it.","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        p)"},{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            else"},{"line_number":48,"context_line":"\t\tif [ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]; then"},{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3379af17_80af9f65","line":48,"range":{"start_line":47,"start_character":12,"end_line":48,"end_character":5},"in_reply_to":"2472a4ab_1fafecb6","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            else"},{"line_number":48,"context_line":"\t\tif [ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]; then"},{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fa43560e_2b17c440","line":48,"range":{"start_line":48,"start_character":31,"end_line":48,"end_character":44},"in_reply_to":"ef775c90_df161780","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            else"},{"line_number":48,"context_line":"\t\tif [ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]; then"},{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "},{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"fba6cb78_dff192b4","line":49,"range":{"start_line":49,"start_character":6,"end_line":49,"end_character":39},"updated":"2022-11-03 11:35:33.000000000","message":"Just to keep the comments consistent. I would add a white space between the \"#\" and \"minimal\": \n\n\"# minimal version of python -\u003e 3.8\"","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            else"},{"line_number":48,"context_line":"\t\tif [ ${OPTARG:0:1} \u003d\u003d \"3\" \u0026\u0026 ${OPTARG:2:3} \u003e\u003d \"8\" ]; then"},{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "},{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"d773dd05_4d33c96a","line":49,"range":{"start_line":49,"start_character":6,"end_line":49,"end_character":39},"in_reply_to":"fba6cb78_dff192b4","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "},{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"},{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"b25459da_00a85c91","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":50},"updated":"2022-11-03 11:35:33.000000000","message":"This comment can be removed:). It is possible to read the same thing in the echo message below the comment. But if you want to keep it I would add the space between # and \"not\".","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":49,"context_line":"\t\t    #minimal version of python -\u003e 3.8"},{"line_number":50,"context_line":"\t\t    PY_VERSION\u003d${OPTARG}"},{"line_number":51,"context_line":"\t\telse "},{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"},{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"27e6937b_92f78a4e","line":52,"range":{"start_line":52,"start_character":6,"end_line":52,"end_character":50},"in_reply_to":"b25459da_00a85c91","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":51,"context_line":"\t\telse "},{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"},{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"},{"line_number":56,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":57,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5f65367d_5cad77e6","line":54,"range":{"start_line":54,"start_character":1,"end_line":54,"end_character":2},"updated":"2022-11-03 11:35:33.000000000","message":"Tabs vs spaces thing:) :D. \n\nI would remove the tabs here to keep it consistent throughout the script.","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":51,"context_line":"\t\telse "},{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"},{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"},{"line_number":56,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":57,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"460e181e_3239a3d6","line":54,"range":{"start_line":54,"start_character":1,"end_line":54,"end_character":2},"in_reply_to":"5f65367d_5cad77e6","updated":"2022-11-22 12:42:24.000000000","message":"Not resolved yet. However Martin pointed this out in another comment therefore I\u0027m marking this as resolved.","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"},{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"},{"line_number":56,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":57,"context_line":"            fi"},{"line_number":58,"context_line":"            ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"e39f4107_894b1564","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":7},"updated":"2022-11-03 11:35:33.000000000","message":"This is a small thing :). It is a good practice not to leave white characters at the end of a line.","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":52,"context_line":"\t\t    #not supported version of python - show help"},{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"},{"line_number":56,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":57,"context_line":"            fi"},{"line_number":58,"context_line":"            ;;"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"a2570ca0_8eca621f","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":7},"in_reply_to":"e39f4107_894b1564","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"},{"line_number":56,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":57,"context_line":"            fi"},{"line_number":58,"context_line":"            ;;"},{"line_number":59,"context_line":"        t)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"584b662f_7d7a8604","line":56,"range":{"start_line":56,"start_character":2,"end_line":56,"end_character":22},"updated":"2022-11-03 11:35:33.000000000","message":"This can be removed.","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":53,"context_line":"\t\t    echo \"\\nVersion of python-$OPTARG no longer supported.\""},{"line_number":54,"context_line":"\t\t    usage"},{"line_number":55,"context_line":"\t\tfi\t\t\t"},{"line_number":56,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":57,"context_line":"            fi"},{"line_number":58,"context_line":"            ;;"},{"line_number":59,"context_line":"        t)"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ce7d6717_3f447871","line":56,"range":{"start_line":56,"start_character":2,"end_line":56,"end_character":22},"in_reply_to":"584b662f_7d7a8604","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":193,"context_line":"    rm -rf ${WORKDIR}/.venv"},{"line_number":194,"context_line":"fi"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"python\u003d\u0027python3\u0027"},{"line_number":197,"context_line":"$python -m venv ${WORKDIR}/.venv "},{"line_number":198,"context_line":"$python -m venv ${TEMPEST_DIR}/.venv"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."},{"line_number":201,"context_line":"cd ${TEMPESTCONF_DIR}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"eb50c260_69283a61","line":198,"range":{"start_line":196,"start_character":0,"end_line":198,"end_character":36},"updated":"2022-11-03 11:35:33.000000000","message":"This will fail on ubuntu20.04 (./setup_env -p 3.9.0). We need to discuss whether we want to use the builtin venv. \n\nThe error message:\n\n```\nThe virtual environment was not created successfully because ensurepip is not\navailable.  On Debian/Ubuntu systems, you need to install the python3-venv\npackage using the following command.\n\n    apt install python3.8-venv\n\nYou may need to use sudo with that command.  After installing the python3-venv\npackage, recreate your virtual environment.\n\nFailing command: [\u0027/home/ubuntu/refstack-client/.tempest/.venv/bin/python3\u0027, \u0027-Im\u0027, \u0027ensurepip\u0027, \u0027--upgrade\u0027, \u0027--default-pip\u0027]\n```","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    rm -rf ${WORKDIR}/.venv"},{"line_number":194,"context_line":"fi"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"python\u003d\u0027python3\u0027"},{"line_number":197,"context_line":"$python -m venv ${WORKDIR}/.venv "},{"line_number":198,"context_line":"$python -m venv ${TEMPEST_DIR}/.venv"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."},{"line_number":201,"context_line":"cd ${TEMPESTCONF_DIR}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bc8917c5_882c4284","line":198,"range":{"start_line":196,"start_character":0,"end_line":198,"end_character":36},"in_reply_to":"eb50c260_69283a61","updated":"2022-11-22 12:42:24.000000000","message":"Done. \n./setup_env -p 3.9.0 now works","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        p)"},{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            elif [[ ${OPTARG} \u003d~ ^3.([8-9]|[1-9][0-9]).[0-9]+$ ]]; then"},{"line_number":48,"context_line":"\t\t# minimal version of python -\u003e 3.8.0"},{"line_number":49,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":50,"context_line":"\t    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"26247c84_39f766dd","line":47,"range":{"start_line":47,"start_character":17,"end_line":47,"end_character":65},"updated":"2022-11-22 12:42:24.000000000","message":"Good idea using regex here!\n\nThis is probably a nit. The regex will accept, for example, also 3.10.002 which will probably cause failure later in the script. Maybe we can use more specific regex?\n\n```\n^3.([8-9]|[1-9][0-9]).([0-9]|[1-9][0-9])$\n```","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        p)"},{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            elif [[ ${OPTARG} \u003d~ ^3.([8-9]|[1-9][0-9]).[0-9]+$ ]]; then"},{"line_number":48,"context_line":"\t\t# minimal version of python -\u003e 3.8.0"},{"line_number":49,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":50,"context_line":"\t    else"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"559e268c_ba6a23a6","line":47,"range":{"start_line":47,"start_character":17,"end_line":47,"end_character":65},"in_reply_to":"26247c84_39f766dd","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":true,"context_lines":[{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            elif [[ ${OPTARG} \u003d~ ^3.([8-9]|[1-9][0-9]).[0-9]+$ ]]; then"},{"line_number":48,"context_line":"\t\t# minimal version of python -\u003e 3.8.0"},{"line_number":49,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":50,"context_line":"\t    else"},{"line_number":51,"context_line":"\t\techo \"Version of python-{$OPTARG} no longer supported.\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"e4800df3_62c4dbb9","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":1},"updated":"2022-11-22 09:58:57.000000000","message":"tabs, please use spaces instead","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            if [ ${OPTARG} \u003d\u003d \u00273\u0027 ]; then"},{"line_number":46,"context_line":"                PY_VERSION\u003d${PY_VERSION}"},{"line_number":47,"context_line":"            elif [[ ${OPTARG} \u003d~ ^3.([8-9]|[1-9][0-9]).[0-9]+$ ]]; then"},{"line_number":48,"context_line":"\t\t# minimal version of python -\u003e 3.8.0"},{"line_number":49,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":50,"context_line":"\t    else"},{"line_number":51,"context_line":"\t\techo \"Version of python-{$OPTARG} no longer supported.\""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bb156f0e_7ca4c2de","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":1},"in_reply_to":"e4800df3_62c4dbb9","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":true,"context_lines":[{"line_number":48,"context_line":"\t\t# minimal version of python -\u003e 3.8.0"},{"line_number":49,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":50,"context_line":"\t    else"},{"line_number":51,"context_line":"\t\techo \"Version of python-{$OPTARG} no longer supported.\""},{"line_number":52,"context_line":"\t\tusage"},{"line_number":53,"context_line":"            fi"},{"line_number":54,"context_line":"            ;;"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"6bc05d40_61cfb138","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":35},"updated":"2022-11-22 12:42:24.000000000","message":"{$OPTARG} -\u003e ${OPTARG}","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\t\t# minimal version of python -\u003e 3.8.0"},{"line_number":49,"context_line":"\t\tPY_VERSION\u003d${OPTARG}"},{"line_number":50,"context_line":"\t    else"},{"line_number":51,"context_line":"\t\techo \"Version of python-{$OPTARG} no longer supported.\""},{"line_number":52,"context_line":"\t\tusage"},{"line_number":53,"context_line":"            fi"},{"line_number":54,"context_line":"            ;;"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"fd5acd76_5c21b51f","line":51,"range":{"start_line":51,"start_character":26,"end_line":51,"end_character":35},"in_reply_to":"6bc05d40_61cfb138","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"3386f5e284b0ef71658c3d7329da8025bb9cad6b","unresolved":true,"context_lines":[{"line_number":216,"context_line":"# this line is commented out to prevent errors from being returned. Uncomment this line if"},{"line_number":217,"context_line":"# there are requirements in tempest-additonal-requirements.txt."},{"line_number":218,"context_line":"# ${TEMPEST_DIR}/.venv/bin/pip install -c ${UPPER_CONSTRAINTS_FILE} -r ${WORKDIR}/tempest-additional-requirements.txt"},{"line_number":219,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"6026325e_0f7017b0","line":219,"updated":"2022-11-22 09:58:57.000000000","message":"this is a redundant change","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":false,"context_lines":[{"line_number":216,"context_line":"# this line is commented out to prevent errors from being returned. Uncomment this line if"},{"line_number":217,"context_line":"# there are requirements in tempest-additonal-requirements.txt."},{"line_number":218,"context_line":"# ${TEMPEST_DIR}/.venv/bin/pip install -c ${UPPER_CONSTRAINTS_FILE} -r ${WORKDIR}/tempest-additional-requirements.txt"},{"line_number":219,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"eb0f01d2_ea84a415","line":219,"in_reply_to":"6026325e_0f7017b0","updated":"2022-11-24 11:20:51.000000000","message":"Done","commit_id":"f39072c621685ccccb1681185500cdfecdcc417b"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":true,"context_lines":[{"line_number":163,"context_line":"fi"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"# Build local python interpreter if needed"},{"line_number":166,"context_line":"sub_pystr\u003d\"python$(echo $PY_VERSION | cut -c 1-3)\""},{"line_number":167,"context_line":"python_version\u003d$($sub_pystr -V | cut -d \" \" -f 2)"},{"line_number":168,"context_line":"if [ $python_version \u003d\u003d $PY_VERSION ]; then"},{"line_number":169,"context_line":"    echo \"Python $PY_VERSION found!\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"a22e3b2c_8c98d184","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":50},"updated":"2022-11-24 11:20:51.000000000","message":"This will not work when the minor version of python has two digits. \n\nMaybe it can be replaced by something like this:\n\n```\npy_versions_array\u003d($(echo $PY_VERSION | tr \".\" \" \"))\npy_major_version\u003d${py_versions_array[0]}\npy_minor_version\u003d${py_versions_array[1]}\nsub_pystr\u003d\"python$py_major_version.$py_minor_version\"\n```","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c268dc9c54756a88155e285edaa35d8369d68496","unresolved":false,"context_lines":[{"line_number":163,"context_line":"fi"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"# Build local python interpreter if needed"},{"line_number":166,"context_line":"sub_pystr\u003d\"python$(echo $PY_VERSION | cut -c 1-3)\""},{"line_number":167,"context_line":"python_version\u003d$($sub_pystr -V | cut -d \" \" -f 2)"},{"line_number":168,"context_line":"if [ $python_version \u003d\u003d $PY_VERSION ]; then"},{"line_number":169,"context_line":"    echo \"Python $PY_VERSION found!\""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"b1895508_47d08ac2","line":166,"range":{"start_line":166,"start_character":0,"end_line":166,"end_character":50},"in_reply_to":"a22e3b2c_8c98d184","updated":"2022-11-29 18:08:02.000000000","message":"Done\n\nNice simple solution!","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":true,"context_lines":[{"line_number":184,"context_line":"    PYPATH\u003d\"${WORKDIR}/.localpython/bin/$sub_pystr\""},{"line_number":185,"context_line":"fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"# Setup virtual environments for refstack-client and tempest"},{"line_number":188,"context_line":"VENV_VERSION\u003d\u002716.7.9\u0027"},{"line_number":189,"context_line":"wget https://github.com/pypa/virtualenv/archive/${VENV_VERSION}.tar.gz"},{"line_number":190,"context_line":"tar xvfz ${VENV_VERSION}.tar.gz"},{"line_number":191,"context_line":"rm ${VENV_VERSION}.tar.gz"},{"line_number":192,"context_line":"cd virtualenv-${VENV_VERSION}"},{"line_number":193,"context_line":"if [ -d ${WORKDIR}/.venv ]; then"},{"line_number":194,"context_line":"    rm -rf ${WORKDIR}/.venv"},{"line_number":195,"context_line":"fi"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"# Determine python which will run virtualenv.py script"},{"line_number":198,"context_line":"if [ -n \"$(command -v python3)\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"403d737b_31267230","line":195,"range":{"start_line":187,"start_character":0,"end_line":195,"end_character":2},"updated":"2022-11-24 11:20:51.000000000","message":"Virtualenv installed by this script will not work with python3.10 (ubuntu 20.04 - but I guess it will not work on other systems as well). Virtualenv\u003d\u003d16.7.2 does not support officially python 3.8.0+ [1].\n\nI think that we can maybe replace this section by this (note: this code needs a bit of testing to make sure that it really works with the supported python versions):\n```\n# Determine python which will run virtualenv.py script\nif [ -n \"$(command -v python3)\" ]; then\n    python\u003d\u0027python3\u0027\nelse\n    python\u003d\u0027python\u0027\nfi\n\nmkdir ${WORKDIR}/.localvirtualenv\nVENV_VERSION\u003d\u002720.16.7\u0027\n$python -m pip install --target\u003d${WORKDIR}/.localvirtualenv virtualenv\u003d\u003d${VENV_VERSION}\nVIRTUALENV\u003d${WORKDIR}/.localvirtualenv/bin/virtualenv\n\n$VIRTUALENV ${WORKDIR}/.venv --python\u003d\"${PYPATH}\"\n$VIRTUALENV virtualenv.py ${TEMPEST_DIR}/.venv --python\u003d\"${PYPATH}\"\n```\n\n[1] https://github.com/pypa/virtualenv/blob/16.7.2/setup.cfg#L29","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c268dc9c54756a88155e285edaa35d8369d68496","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    PYPATH\u003d\"${WORKDIR}/.localpython/bin/$sub_pystr\""},{"line_number":185,"context_line":"fi"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"# Setup virtual environments for refstack-client and tempest"},{"line_number":188,"context_line":"VENV_VERSION\u003d\u002716.7.9\u0027"},{"line_number":189,"context_line":"wget https://github.com/pypa/virtualenv/archive/${VENV_VERSION}.tar.gz"},{"line_number":190,"context_line":"tar xvfz ${VENV_VERSION}.tar.gz"},{"line_number":191,"context_line":"rm ${VENV_VERSION}.tar.gz"},{"line_number":192,"context_line":"cd virtualenv-${VENV_VERSION}"},{"line_number":193,"context_line":"if [ -d ${WORKDIR}/.venv ]; then"},{"line_number":194,"context_line":"    rm -rf ${WORKDIR}/.venv"},{"line_number":195,"context_line":"fi"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"# Determine python which will run virtualenv.py script"},{"line_number":198,"context_line":"if [ -n \"$(command -v python3)\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"57422c56_b43e4e89","line":195,"range":{"start_line":187,"start_character":0,"end_line":195,"end_character":2},"in_reply_to":"403d737b_31267230","updated":"2022-11-29 18:08:02.000000000","message":"Done","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"3408f7336c8daa9cb6b9fe0dae23ff3723e301ca","unresolved":true,"context_lines":[{"line_number":203,"context_line":"$python virtualenv.py ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":204,"context_line":"$python virtualenv.py ${TEMPEST_DIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"cd .."},{"line_number":207,"context_line":"rm -rf virtualenv-${VENV_VERSION}"},{"line_number":208,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."},{"line_number":209,"context_line":"cd ${TEMPESTCONF_DIR}"},{"line_number":210,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"47bf234e_e4daedfd","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":33},"updated":"2022-11-24 11:20:51.000000000","message":"This can be removed if we go with the installation of virtualenv using pip.","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c268dc9c54756a88155e285edaa35d8369d68496","unresolved":false,"context_lines":[{"line_number":203,"context_line":"$python virtualenv.py ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":204,"context_line":"$python virtualenv.py ${TEMPEST_DIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"cd .."},{"line_number":207,"context_line":"rm -rf virtualenv-${VENV_VERSION}"},{"line_number":208,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."},{"line_number":209,"context_line":"cd ${TEMPESTCONF_DIR}"},{"line_number":210,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"593de08f_9700af37","line":207,"range":{"start_line":206,"start_character":0,"end_line":207,"end_character":33},"in_reply_to":"47bf234e_e4daedfd","updated":"2022-11-29 18:08:02.000000000","message":"Done","commit_id":"51f381961d8b004f60a9f739596a8d667a7c055a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"c268dc9c54756a88155e285edaa35d8369d68496","unresolved":true,"context_lines":[{"line_number":194,"context_line":"mkdir ${WORKDIR}/.localvirtualenv"},{"line_number":195,"context_line":"VENV_VERSION\u003d\u002720.16.7\u0027"},{"line_number":196,"context_line":"$python -m pip install --target\u003d${WORKDIR}/.localvirtualenv virtualenv\u003d\u003d${VENV_VERSION}"},{"line_number":197,"context_line":"virtualenv\u003d\u003d${VENV_VERSION}"},{"line_number":198,"context_line":"VIRTUALENV\u003d${WORKDIR}/.localvirtualenv/bin/virtualenv"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"$VIRTUALENV ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1dc1f26e_d282e51a","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":27},"updated":"2022-11-29 18:08:02.000000000","message":"This can be removed and should be replaced with: \n\n```\nexport PYTHONPATH\u003d$(realpath .localvirtualenv):$PYTHONPATH\n```","commit_id":"85908437f8e19523d8d2a4efd9e37695481eba97"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":194,"context_line":"mkdir ${WORKDIR}/.localvirtualenv"},{"line_number":195,"context_line":"VENV_VERSION\u003d\u002720.16.7\u0027"},{"line_number":196,"context_line":"$python -m pip install --target\u003d${WORKDIR}/.localvirtualenv virtualenv\u003d\u003d${VENV_VERSION}"},{"line_number":197,"context_line":"virtualenv\u003d\u003d${VENV_VERSION}"},{"line_number":198,"context_line":"VIRTUALENV\u003d${WORKDIR}/.localvirtualenv/bin/virtualenv"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"$VIRTUALENV ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"0b4a71ab_3af494df","line":197,"range":{"start_line":197,"start_character":0,"end_line":197,"end_character":27},"in_reply_to":"1dc1f26e_d282e51a","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"85908437f8e19523d8d2a4efd9e37695481eba97"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    echo \"  -q  Run quietly. If .tempest folder exists, refstack-client is considered as installed\""},{"line_number":22,"context_line":"    echo \"  -s  Use python-tempestconf from the given source (path), used when running f.e. in Zuul\""},{"line_number":23,"context_line":"    echo \"  -t  Tempest test runner tag. You can specify tag here\""},{"line_number":24,"context_line":"    echo \"  -l  Use local python interpreter .The version of interpreter depends on -p argument,\""},{"line_number":25,"context_line":"    echo \"      default is 3.8.10. If the specified or default interpreter doesn\u0027t exists,\""},{"line_number":26,"context_line":"    echo \"      script will install it.\""},{"line_number":27,"context_line":"    echo \"      ${CHECKOUT_POINT}\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"670c0b15_fcfbb895","line":24,"range":{"start_line":24,"start_character":44,"end_line":24,"end_character":46},"updated":"2022-12-13 17:25:47.000000000","message":"nit: the dot is on the wrong side","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    echo \"  -q  Run quietly. If .tempest folder exists, refstack-client is considered as installed\""},{"line_number":22,"context_line":"    echo \"  -s  Use python-tempestconf from the given source (path), used when running f.e. in Zuul\""},{"line_number":23,"context_line":"    echo \"  -t  Tempest test runner tag. You can specify tag here\""},{"line_number":24,"context_line":"    echo \"  -l  Use local python interpreter .The version of interpreter depends on -p argument,\""},{"line_number":25,"context_line":"    echo \"      default is 3.8.10. If the specified or default interpreter doesn\u0027t exists,\""},{"line_number":26,"context_line":"    echo \"      script will install it.\""},{"line_number":27,"context_line":"    echo \"      ${CHECKOUT_POINT}\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"770e43db_39a67cad","line":24,"range":{"start_line":24,"start_character":44,"end_line":24,"end_character":46},"in_reply_to":"670c0b15_fcfbb895","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    echo \"  -s  Use python-tempestconf from the given source (path), used when running f.e. in Zuul\""},{"line_number":23,"context_line":"    echo \"  -t  Tempest test runner tag. You can specify tag here\""},{"line_number":24,"context_line":"    echo \"  -l  Use local python interpreter .The version of interpreter depends on -p argument,\""},{"line_number":25,"context_line":"    echo \"      default is 3.8.10. If the specified or default interpreter doesn\u0027t exists,\""},{"line_number":26,"context_line":"    echo \"      script will install it.\""},{"line_number":27,"context_line":"    echo \"      ${CHECKOUT_POINT}\""},{"line_number":28,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"1fb946e3_a0f5baec","line":25,"range":{"start_line":25,"start_character":83,"end_line":25,"end_character":89},"updated":"2022-12-13 17:25:47.000000000","message":"exist","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":22,"context_line":"    echo \"  -s  Use python-tempestconf from the given source (path), used when running f.e. in Zuul\""},{"line_number":23,"context_line":"    echo \"  -t  Tempest test runner tag. You can specify tag here\""},{"line_number":24,"context_line":"    echo \"  -l  Use local python interpreter .The version of interpreter depends on -p argument,\""},{"line_number":25,"context_line":"    echo \"      default is 3.8.10. If the specified or default interpreter doesn\u0027t exists,\""},{"line_number":26,"context_line":"    echo \"      script will install it.\""},{"line_number":27,"context_line":"    echo \"      ${CHECKOUT_POINT}\""},{"line_number":28,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"0d653bc7_737db997","line":25,"range":{"start_line":25,"start_character":75,"end_line":25,"end_character":89},"updated":"2022-12-13 17:25:47.000000000","message":"this isn\u0027t entirely true, if the environment has the python version specified by -p, however, we don\u0027t want to use local version (-l is not specified \u003d\u003e LOCAL_INTERPRETER \u003d False) we build/install the specified python anyway.","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    echo \"  -s  Use python-tempestconf from the given source (path), used when running f.e. in Zuul\""},{"line_number":23,"context_line":"    echo \"  -t  Tempest test runner tag. You can specify tag here\""},{"line_number":24,"context_line":"    echo \"  -l  Use local python interpreter .The version of interpreter depends on -p argument,\""},{"line_number":25,"context_line":"    echo \"      default is 3.8.10. If the specified or default interpreter doesn\u0027t exists,\""},{"line_number":26,"context_line":"    echo \"      script will install it.\""},{"line_number":27,"context_line":"    echo \"      ${CHECKOUT_POINT}\""},{"line_number":28,"context_line":"    exit 1"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"8f973ed8_2d0b672b","line":25,"range":{"start_line":25,"start_character":83,"end_line":25,"end_character":89},"in_reply_to":"1fb946e3_a0f5baec","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        h)  #show help"},{"line_number":68,"context_line":"            usage"},{"line_number":69,"context_line":"            ;;"},{"line_number":70,"context_line":"        l)  # use local python interpret"},{"line_number":71,"context_line":"            LOCAL_INTERPRET\u003dtrue"},{"line_number":72,"context_line":"            ;;"},{"line_number":73,"context_line":"        \\?) #unrecognized option - show help"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"22a6b5e4_967113ce","line":70,"range":{"start_line":70,"start_character":31,"end_line":70,"end_character":40},"updated":"2022-12-13 17:25:47.000000000","message":"interpreter","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        h)  #show help"},{"line_number":68,"context_line":"            usage"},{"line_number":69,"context_line":"            ;;"},{"line_number":70,"context_line":"        l)  # use local python interpret"},{"line_number":71,"context_line":"            LOCAL_INTERPRET\u003dtrue"},{"line_number":72,"context_line":"            ;;"},{"line_number":73,"context_line":"        \\?) #unrecognized option - show help"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"b4cde55a_81ea5006","line":70,"range":{"start_line":70,"start_character":31,"end_line":70,"end_character":40},"in_reply_to":"22a6b5e4_967113ce","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            usage"},{"line_number":69,"context_line":"            ;;"},{"line_number":70,"context_line":"        l)  # use local python interpret"},{"line_number":71,"context_line":"            LOCAL_INTERPRET\u003dtrue"},{"line_number":72,"context_line":"            ;;"},{"line_number":73,"context_line":"        \\?) #unrecognized option - show help"},{"line_number":74,"context_line":"            echo -e \\\\n\"Option -$OPTARG not allowed.\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"0e9d95f4_1702871a","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":27},"updated":"2022-12-13 17:25:47.000000000","message":"LOCAL_INTERPRETER","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            usage"},{"line_number":69,"context_line":"            ;;"},{"line_number":70,"context_line":"        l)  # use local python interpret"},{"line_number":71,"context_line":"            LOCAL_INTERPRET\u003dtrue"},{"line_number":72,"context_line":"            ;;"},{"line_number":73,"context_line":"        \\?) #unrecognized option - show help"},{"line_number":74,"context_line":"            echo -e \\\\n\"Option -$OPTARG not allowed.\""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5586b0ad_4fc23446","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":27},"in_reply_to":"0e9d95f4_1702871a","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":171,"context_line":"# Build local python interpreter if needed"},{"line_number":172,"context_line":"sub_pystr\u003d\"python$(echo $PY_VERSION | grep -o \u00273.[0-9]\\+\u0027)\""},{"line_number":173,"context_line":"python_version\u003d$($sub_pystr -V | cut -d \" \" -f 2)"},{"line_number":174,"context_line":"if [ $python_version \u003d\u003d $PY_VERSION ] \u0026\u0026 [ ${LOCAL_INTERPRET} ]; then"},{"line_number":175,"context_line":"    echo \"Python $PY_VERSION found!\""},{"line_number":176,"context_line":"    PYPATH\u003d\"$sub_pystr\""},{"line_number":177,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"c6a580c1_2d4bea95","line":174,"range":{"start_line":174,"start_character":45,"end_line":174,"end_character":60},"updated":"2022-12-13 17:25:47.000000000","message":"LOCAL_INTERPRETER","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"2c2928771ba886c906185bb08115ba6dc72dd202","unresolved":false,"context_lines":[{"line_number":171,"context_line":"# Build local python interpreter if needed"},{"line_number":172,"context_line":"sub_pystr\u003d\"python$(echo $PY_VERSION | grep -o \u00273.[0-9]\\+\u0027)\""},{"line_number":173,"context_line":"python_version\u003d$($sub_pystr -V | cut -d \" \" -f 2)"},{"line_number":174,"context_line":"if [ $python_version \u003d\u003d $PY_VERSION ] \u0026\u0026 [ ${LOCAL_INTERPRET} ]; then"},{"line_number":175,"context_line":"    echo \"Python $PY_VERSION found!\""},{"line_number":176,"context_line":"    PYPATH\u003d\"$sub_pystr\""},{"line_number":177,"context_line":"else"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"c61bcca7_fd6694bb","line":174,"range":{"start_line":174,"start_character":45,"end_line":174,"end_character":60},"in_reply_to":"c6a580c1_2d4bea95","updated":"2023-01-29 16:54:59.000000000","message":"Done","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"885b8d32a434ed5263b190e907510ba1d59739d8","unresolved":true,"context_lines":[{"line_number":176,"context_line":"    PYPATH\u003d\"$sub_pystr\""},{"line_number":177,"context_line":"else"},{"line_number":178,"context_line":"    echo \"Python $PY_VERSION not found. Building python ${PY_VERSION}...\""},{"line_number":179,"context_line":"    mkdir ${WORKDIR}/.localpython"},{"line_number":180,"context_line":"    mkdir ${WORKDIR}/.python_src"},{"line_number":181,"context_line":"    cd ${WORKDIR}/.python_src"},{"line_number":182,"context_line":"    wget http://www.python.org/ftp/python/${PY_VERSION}/Python-${PY_VERSION}.tgz"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"62696e2f_94fa67ed","line":179,"range":{"start_line":179,"start_character":22,"end_line":179,"end_character":33},"updated":"2022-12-13 17:25:47.000000000","message":"we get to this else branch when LOCAL_INTERPRETER is false, although, we keep using \"local\" word here anyway - this makes me think the LOCAL_INTERPRETER isn\u0027t the best name or it should be, maybe, inverted \u003d\u003e having local, LOCAL_INTERPRETER mean that local version of python will be used - local from refstack-client\u0027s point of view which is the python installed under ${WORKDIR}/.localpython\n\n-l/LOCAL_INTEPRETER should be false by default - in this case the global version of python (if matched with the version specified in -p) is used - by global i mean python installed in the environment/VM/server etc.\n\nif -l is specified on the command line LOCAL_INTERPRETER is set to True which will force the installation of python version (specified by -p) into the ${WORKDIR}/.localpython\n\nNot installing python and reusing the one already present in the environment is faster, therefore it should be the default way.","commit_id":"f1367469583c8f0bea94ebd50448b2485b2ae448"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fa1bbf0a4f3679422c3ae9a09e1dfe57c219639","unresolved":true,"context_lines":[{"line_number":191,"context_line":"    PYPATH\u003d\"${WORKDIR}/.localpython/bin/$sub_pystr\""},{"line_number":192,"context_line":"fi"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"# Determine python which will run virtualenv.py script"},{"line_number":195,"context_line":"if [ -n \"$(command -v python3)\" ]; then"},{"line_number":196,"context_line":"    python\u003d\u0027python3\u0027"},{"line_number":197,"context_line":"else"},{"line_number":198,"context_line":"    python\u003d\u0027python\u0027"},{"line_number":199,"context_line":"fi"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"mkdir ${WORKDIR}/.localvirtualenv"},{"line_number":202,"context_line":"VENV_VERSION\u003d\u002720.16.7\u0027"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"a0a4750c_77fadf11","line":199,"range":{"start_line":194,"start_character":0,"end_line":199,"end_character":2},"updated":"2023-01-29 23:52:00.000000000","message":"why we still keep this as from now we will support only python3? I think we had this discussion but I don\u0027t remember the outcome of that discussion.","commit_id":"78cc053988dfb566afdf013b0b29ddb8fd5e6176"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"8fa1bbf0a4f3679422c3ae9a09e1dfe57c219639","unresolved":true,"context_lines":[{"line_number":204,"context_line":"export PYTHONPATH\u003d$(realpath .localvirtualenv):$PYTHONPATH"},{"line_number":205,"context_line":"VIRTUALENV\u003d${WORKDIR}/.localvirtualenv/bin/virtualenv"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"$PYPATH $VIRTUALENV ${WORKDIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":208,"context_line":"$PYPATH $VIRTUALENV ${TEMPEST_DIR}/.venv --python\u003d\"${PYPATH}\""},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"${WORKDIR}/.venv/bin/python -m pip install -c ${UPPER_CONSTRAINTS_FILE} -e ."},{"line_number":211,"context_line":"cd ${TEMPESTCONF_DIR}"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"159a045d_ae9fd340","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":61},"updated":"2023-01-29 23:52:00.000000000","message":"what if we edit these 2 like suggested in this post - https://stackoverflow.com/questions/63491221/modulenotfounderror-no-module-named-virtualenv-seed-embed-via-app-data-when-i \n\n$PYPATH -m venv ${WORKDIR}/.venv\n$PYPATH -m venv ${TEMPEST_DIR}/.venv\n\n^^ if we ran those commands, we could get rid of installing virtualenv, (lines 201-205), right? (again I have a feeling we had this discussion already, although I don\u0027t remember how we closed that)","commit_id":"78cc053988dfb566afdf013b0b29ddb8fd5e6176"}],"tox.ini":[{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"5a1ee88087b5164eb8e24d35803dcc3d86273e75","unresolved":true,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d pep8,py3,py38"},{"line_number":3,"context_line":"minversion \u003d 3.8.0"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9cf8bda3_900f29fc","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":18},"updated":"2022-11-03 11:35:33.000000000","message":"Why do we need to increase the minversion? Just curious:)","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d179d2243ac9b6783ca7a7423ceaeaeafa9a9a34","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d pep8,py3,py38"},{"line_number":3,"context_line":"minversion \u003d 3.8.0"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"}],"source_content_type":"text/x-properties","patch_set":1,"id":"829b9ddf_eed6f113","line":3,"range":{"start_line":3,"start_character":15,"end_line":3,"end_character":18},"in_reply_to":"9cf8bda3_900f29fc","updated":"2022-11-22 12:42:24.000000000","message":"Done","commit_id":"c147981a944166f870550ee4ee39e8357ba49c72"}]}