)]}'
{"refstack/api/controllers/user.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"026d79956fb8dc86d044ba92c64b98b28d6083a5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class PublicKeysController(validation.BaseRestControllerWithValidation):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    \"\"\"Controller provides user information in OpenID 2.0 IdP.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    __validator__ \u003d validators.PubkeyValidator"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_56059b77","line":30,"updated":"2015-07-22 06:06:07.000000000","message":"This class docstring seems to be a copy paste of the one below in ProfileController.","commit_id":"60c5aa2046b8aa153b2b8b584806363603bb4288"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"11974f236ae6d44233b994dd4523d0e084b20c46","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if len(parts) \u003d\u003d 2:"},{"line_number":50,"context_line":"            parts.append(\u0027\u0027)"},{"line_number":51,"context_line":"        pubkey[\u0027format\u0027], pubkey[\u0027key\u0027], pubkey[\u0027comment\u0027] \u003d parts"},{"line_number":52,"context_line":"        pubkey_id \u003d db.store_pubkey(pubkey)"},{"line_number":53,"context_line":"        return pubkey_id"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    @secure(api_utils.is_authenticated)"}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_202349a9","line":52,"updated":"2015-08-14 05:49:57.000000000","message":"Would be good to pass a descriptive error message to the user if a DBDuplicateEntry is raised. Right now, the user will just get an Internal Server Error response. Perhaps return a 400 Bad Request response saying that the public key is already in use?","commit_id":"217cadd60854cf4701388f9e50e8d3d7841ec337"}],"refstack/common/validators.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"026d79956fb8dc86d044ba92c64b98b28d6083a5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            },"},{"line_number":107,"context_line":"            \u0027duration_seconds\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":108,"context_line":"            \u0027results\u0027: {"},{"line_number":109,"context_line":"                \"type\": \"array\","},{"line_number":110,"context_line":"                \"items\": [{"},{"line_number":111,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":112,"context_line":"                    \u0027properties\u0027: {"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_8f91c9f3","line":109,"updated":"2015-07-22 06:06:07.000000000","message":"nit: might as well make these single quotes for consistency.","commit_id":"60c5aa2046b8aa153b2b8b584806363603bb4288"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"026d79956fb8dc86d044ba92c64b98b28d6083a5","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            \u0027duration_seconds\u0027: {\u0027type\u0027: \u0027integer\u0027},"},{"line_number":108,"context_line":"            \u0027results\u0027: {"},{"line_number":109,"context_line":"                \"type\": \"array\","},{"line_number":110,"context_line":"                \"items\": [{"},{"line_number":111,"context_line":"                    \u0027type\u0027: \u0027object\u0027,"},{"line_number":112,"context_line":"                    \u0027properties\u0027: {"},{"line_number":113,"context_line":"                        \u0027name\u0027: {\u0027type\u0027: \u0027string\u0027},"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_af8e05ce","line":110,"updated":"2015-07-22 06:06:07.000000000","message":"same","commit_id":"60c5aa2046b8aa153b2b8b584806363603bb4288"}],"refstack/db/sqlalchemy/api.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"11974f236ae6d44233b994dd4523d0e084b20c46","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        if not pubkeys_collision:"},{"line_number":195,"context_line":"            pubkey.save(session)"},{"line_number":196,"context_line":"        else:"},{"line_number":197,"context_line":"            raise DBDuplicateEntry(columns\u003d[\u0027pubkeys.pubkey\u0027],"},{"line_number":198,"context_line":"                                   value\u003dpubkey.pubkey)"},{"line_number":199,"context_line":"    return pubkey.id"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_a52a0b8f","line":197,"updated":"2015-08-14 05:49:57.000000000","message":"Was testing this and ran into the problem where I two different users could not use the same public key. Should we allow different user accounts to have the same public key, and just restrict it so that the same user can\u0027t upload the same public key twice?","commit_id":"217cadd60854cf4701388f9e50e8d3d7841ec337"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"f3cd0cc7ea80a06f393f5247c3b6950259a21af2","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        if not pubkeys_collision:"},{"line_number":195,"context_line":"            pubkey.save(session)"},{"line_number":196,"context_line":"        else:"},{"line_number":197,"context_line":"            raise DBDuplicateEntry(columns\u003d[\u0027pubkeys.pubkey\u0027],"},{"line_number":198,"context_line":"                                   value\u003dpubkey.pubkey)"},{"line_number":199,"context_line":"    return pubkey.id"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"1a4dcd0f_402f75a7","line":197,"in_reply_to":"1a4dcd0f_a52a0b8f","updated":"2015-08-14 06:26:10.000000000","message":"Haha, nvm. I realize the need for non-duplicate pubkeys while reviewing other patches and thinking about it some more.","commit_id":"217cadd60854cf4701388f9e50e8d3d7841ec337"}]}