)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"dce18482179cb652672636754eb61550ac3232eb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Van Eck \u003cpvaneck@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-18 10:27:13 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refstack pop up window should remain open before user close click,"},{"line_number":8,"context_line":"fix it with alert instead of close, with some unit tests."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I91a56602e69e795f3d1e94dba89d50253ada0da6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_2fe1242a","line":7,"updated":"2015-09-18 18:54:14.000000000","message":"s/close click/clicks close/\n\nAnd this does not meet the structural guidelines for commit messages. See http://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"87e325249d6568f97ea11f551738aff5e12f916a"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"94685ee9deafe7d71556d10e9c622b2433486737","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Van Eck \u003cpvaneck@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-18 10:27:13 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refstack pop up window should remain open before user close click,"},{"line_number":8,"context_line":"fix it with alert instead of close, with some unit tests."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I91a56602e69e795f3d1e94dba89d50253ada0da6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_1408d727","line":7,"in_reply_to":"ba15a1d1_2fe1242a","updated":"2015-09-22 03:14:01.000000000","message":"Thank you Matthew, I\u0027ll read the doc then change it.","commit_id":"87e325249d6568f97ea11f551738aff5e12f916a"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"0d5e0b0463605767682e7089dc1e4d86fcb869ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refstack pop up window should remain open before user close click,"},{"line_number":8,"context_line":"fix it with alert instead of close, with some unit tests."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I91a56602e69e795f3d1e94dba89d50253ada0da6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_077d20e7","line":9,"updated":"2015-09-18 23:21:25.000000000","message":"Add:\n   Closes-Bug: #1492360\n\nso that reviewers can get more info","commit_id":"87e325249d6568f97ea11f551738aff5e12f916a"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"94685ee9deafe7d71556d10e9c622b2433486737","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refstack pop up window should remain open before user close click,"},{"line_number":8,"context_line":"fix it with alert instead of close, with some unit tests."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I91a56602e69e795f3d1e94dba89d50253ada0da6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_340ddb37","line":9,"in_reply_to":"ba15a1d1_077d20e7","updated":"2015-09-22 03:14:01.000000000","message":"Correct, thank you Paul.","commit_id":"87e325249d6568f97ea11f551738aff5e12f916a"}],"refstack-ui/app/shared/alerts/alertModalFactory.js":[{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"84770727d8f27220db92da0335b3f9a885092f49","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                $modalInstance.close();"},{"line_number":36,"context_line":"            };"},{"line_number":37,"context_line":"            $interval(function(){"},{"line_number":38,"context_line":"                $modalInstance.alert();"},{"line_number":39,"context_line":"            }, 3000, 1);"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"    ]"}],"source_content_type":"text/javascript","patch_set":1,"id":"ba15a1d1_67be6eaf","line":38,"updated":"2015-09-18 14:58:18.000000000","message":"If you don\u0027t want to close popup after time you can just remove this section","commit_id":"7888ef3434472379dc69e48362a2cb598d2c8eeb"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"71a3a9cf01a319e7819d0e2fac3d8df9204a696e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                $modalInstance.close();"},{"line_number":36,"context_line":"            };"},{"line_number":37,"context_line":"            $interval(function(){"},{"line_number":38,"context_line":"                $modalInstance.alert();"},{"line_number":39,"context_line":"            }, 3000, 1);"},{"line_number":40,"context_line":"        }"},{"line_number":41,"context_line":"    ]"}],"source_content_type":"text/javascript","patch_set":1,"id":"ba15a1d1_db7c9c22","line":38,"in_reply_to":"ba15a1d1_67be6eaf","updated":"2015-09-22 03:13:48.000000000","message":"Yes, correct, removed.","commit_id":"7888ef3434472379dc69e48362a2cb598d2c8eeb"},{"author":{"_account_id":6287,"name":"David Lenwell","email":"dlenwell@gmail.com","username":"dlenwell"},"change_message_id":"17782976fb1d78fffa69844ae3edd69f6b3eb751","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"refstackApp.controller(\u0027raiseAlertModalController\u0027,"},{"line_number":30,"context_line":"    [\u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027data\u0027,"},{"line_number":31,"context_line":"        function ($scope, $modalInstance, data) {"},{"line_number":32,"context_line":"            \u0027use strict\u0027;"},{"line_number":33,"context_line":"            $scope.data \u003d data;"}],"source_content_type":"text/javascript","patch_set":9,"id":"ba15a1d1_d4776600","line":30,"updated":"2015-09-22 18:22:25.000000000","message":"I know this was already missing it .. but this should have jdoc string with some inline documentation that explains clearly what this code is used for.","commit_id":"c1c1be30cb035cfb6f8e6c9b5c682035fd575e92"},{"author":{"_account_id":6287,"name":"David Lenwell","email":"dlenwell@gmail.com","username":"dlenwell"},"change_message_id":"53ac9b7aea0e6e1f97660d40f021757253f79f88","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"refstackApp.controller(\u0027raiseAlertModalController\u0027,"},{"line_number":30,"context_line":"    [\u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027data\u0027,"},{"line_number":31,"context_line":"        function ($scope, $modalInstance, data) {"},{"line_number":32,"context_line":"            \u0027use strict\u0027;"},{"line_number":33,"context_line":"            $scope.data \u003d data;"}],"source_content_type":"text/javascript","patch_set":9,"id":"ba15a1d1_8d7535cc","line":30,"in_reply_to":"ba15a1d1_4beac910","updated":"2015-09-23 17:02:51.000000000","message":"@david.. you\u0027ve missed my point .. inline documentation does not mean to document here as a comment.. it means to add a comment to the code with some description of its intended purpose.. IN THE CODE.. So take that string you just put here in a comment and add it to this file in your commit in a comment.. \n\nmore about javadoc: https://students.cs.byu.edu/~cs240ta/fall2012/tutorials/javadoctutorial.html","commit_id":"c1c1be30cb035cfb6f8e6c9b5c682035fd575e92"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"c6f71672b5420c43f04bd579666909d1a862df3c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"refstackApp.controller(\u0027raiseAlertModalController\u0027,"},{"line_number":30,"context_line":"    [\u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027data\u0027,"},{"line_number":31,"context_line":"        function ($scope, $modalInstance, data) {"},{"line_number":32,"context_line":"            \u0027use strict\u0027;"},{"line_number":33,"context_line":"            $scope.data \u003d data;"}],"source_content_type":"text/javascript","patch_set":9,"id":"ba15a1d1_1fadb99a","line":30,"in_reply_to":"ba15a1d1_8d7535cc","updated":"2015-09-24 02:06:51.000000000","message":"Yes, I\u0027ll read the doc carefully and add comments as your guidance.","commit_id":"c1c1be30cb035cfb6f8e6c9b5c682035fd575e92"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"616a2854927560a1202e3865fdcf13d14054f88f","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"refstackApp.controller(\u0027raiseAlertModalController\u0027,"},{"line_number":30,"context_line":"    [\u0027$scope\u0027, \u0027$modalInstance\u0027, \u0027data\u0027,"},{"line_number":31,"context_line":"        function ($scope, $modalInstance, data) {"},{"line_number":32,"context_line":"            \u0027use strict\u0027;"},{"line_number":33,"context_line":"            $scope.data \u003d data;"}],"source_content_type":"text/javascript","patch_set":9,"id":"ba15a1d1_4beac910","line":30,"in_reply_to":"ba15a1d1_d4776600","updated":"2015-09-23 01:03:12.000000000","message":"Yes. Originally the pop up window will wait 3 seconds then close, the change is remove the interval, wait for users to close, the added code is stub for unitary. Another modified file is unitary test, the code is relatively self-explanatory.","commit_id":"c1c1be30cb035cfb6f8e6c9b5c682035fd575e92"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"0d91cf3f4d2cd5d94e0c6ed72cbd71e0603badf2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027use strict\u0027;"},{"line_number":33,"context_line":"            $scope.data \u003d data;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"            //remove interval, wait for users click to close the pop up window."},{"line_number":36,"context_line":"            $scope.close \u003d function() {"},{"line_number":37,"context_line":"                $modalInstance.close();"},{"line_number":38,"context_line":"            };"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a1a9d01_65e5cc07","line":35,"updated":"2015-09-25 14:34:27.000000000","message":"Just:\n\"wait for users click to close the pop up window.\"","commit_id":"12ab0e38bc2e9e317520f4cf7d9fe6a8ce0f2e70"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"53b612c4c8c5515cbf26798e0091759f08a3e832","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            \u0027use strict\u0027;"},{"line_number":33,"context_line":"            $scope.data \u003d data;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"            //remove interval, wait for users click to close the pop up window."},{"line_number":36,"context_line":"            $scope.close \u003d function() {"},{"line_number":37,"context_line":"                $modalInstance.close();"},{"line_number":38,"context_line":"            };"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a1a9d01_ab0cef94","line":35,"in_reply_to":"9a1a9d01_65e5cc07","updated":"2015-09-28 02:36:22.000000000","message":"Ok, remove it.","commit_id":"12ab0e38bc2e9e317520f4cf7d9fe6a8ce0f2e70"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"0d91cf3f4d2cd5d94e0c6ed72cbd71e0603badf2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                $modalInstance.close();"},{"line_number":38,"context_line":"            };"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            //stub method for unitary test."},{"line_number":41,"context_line":"            $scope.getData \u003d function() {"},{"line_number":42,"context_line":"                return JSON.stringify($scope.data);"},{"line_number":43,"context_line":"            };"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a1a9d01_65c86c56","line":40,"updated":"2015-09-25 14:34:27.000000000","message":"Is method is not needed.","commit_id":"12ab0e38bc2e9e317520f4cf7d9fe6a8ce0f2e70"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"53b612c4c8c5515cbf26798e0091759f08a3e832","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                $modalInstance.close();"},{"line_number":38,"context_line":"            };"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"            //stub method for unitary test."},{"line_number":41,"context_line":"            $scope.getData \u003d function() {"},{"line_number":42,"context_line":"                return JSON.stringify($scope.data);"},{"line_number":43,"context_line":"            };"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a1a9d01_6b27b712","line":40,"in_reply_to":"9a1a9d01_65c86c56","updated":"2015-09-28 02:36:22.000000000","message":"remove it.","commit_id":"12ab0e38bc2e9e317520f4cf7d9fe6a8ce0f2e70"}],"refstack-ui/tests/unit/ControllerSpec.js":[{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"0d91cf3f4d2cd5d94e0c6ed72cbd71e0603badf2","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            });"},{"line_number":607,"context_line":"        }));"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        it(\u0027should have the same data\u0027,"},{"line_number":610,"context_line":"            function () {"},{"line_number":611,"context_line":"                scope.data \u003d data;"},{"line_number":612,"context_line":"                var expectedString \u003d JSON.stringify(data);"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a1a9d01_25ab5476","line":609,"updated":"2015-09-25 14:34:27.000000000","message":"This test tests nothing. \"should close\" test is enough.","commit_id":"12ab0e38bc2e9e317520f4cf7d9fe6a8ce0f2e70"},{"author":{"_account_id":17700,"name":"David Liu","email":"david.liu@cn.ibm.com","username":"lzbj"},"change_message_id":"53b612c4c8c5515cbf26798e0091759f08a3e832","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            });"},{"line_number":607,"context_line":"        }));"},{"line_number":608,"context_line":""},{"line_number":609,"context_line":"        it(\u0027should have the same data\u0027,"},{"line_number":610,"context_line":"            function () {"},{"line_number":611,"context_line":"                scope.data \u003d data;"},{"line_number":612,"context_line":"                var expectedString \u003d JSON.stringify(data);"}],"source_content_type":"text/javascript","patch_set":10,"id":"9a1a9d01_2b21bffb","line":609,"in_reply_to":"9a1a9d01_25ab5476","updated":"2015-09-28 02:36:22.000000000","message":"Yes, remove it.","commit_id":"12ab0e38bc2e9e317520f4cf7d9fe6a8ce0f2e70"}]}