)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"bfe52673ff83887886275cce9090a629f74fff55","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce \u0027group\u0027 table and table for link user with groups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie04de344a97b468acf2831bae9da0cac39b2a14a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_4d0456bf","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":52},"updated":"2016-01-21 18:16:39.000000000","message":"Could we also mention implementing spec https://review.openstack.org/#/c/269893/  ? Thanks!","commit_id":"a2815b4fb0e900cee1786d73d6cfd8b405706c5b"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"d125c8001f2a90acad076292d07a84e469c6dba7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Introduce \u0027group\u0027 table and table for link user with groups."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ie04de344a97b468acf2831bae9da0cac39b2a14a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a68dd71_c0356d46","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":52},"in_reply_to":"9a68dd71_4d0456bf","updated":"2016-01-21 18:41:39.000000000","message":"sure","commit_id":"a2815b4fb0e900cee1786d73d6cfd8b405706c5b"}],"refstack/db/api.py":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"ffca035727d821bf0342c494556b39ab086370f2","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def store_group(group_info):"},{"line_number":186,"context_line":"    \"\"\"Add or update specified group.\"\"\""},{"line_number":187,"context_line":"    return IMPL.store_group(group_info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_73467550","line":187,"range":{"start_line":187,"start_character":11,"end_line":187,"end_character":27},"updated":"2016-01-24 19:40:32.000000000","message":"The implementation for this along with get_group, and get_user_group_ids seemed to have not been included in the latest patch set.","commit_id":"2974430aceee7d4eb0356637dc1baf2a9a4fba56"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"7446d64472f5d99df7a2a75b2d511a5fcaaf10da","unresolved":false,"context_lines":[{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def store_group(group_info):"},{"line_number":186,"context_line":"    \"\"\"Add or update specified group.\"\"\""},{"line_number":187,"context_line":"    return IMPL.store_group(group_info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_73b43534","line":187,"range":{"start_line":187,"start_character":11,"end_line":187,"end_character":27},"in_reply_to":"9a68dd71_73467550","updated":"2016-01-24 19:43:48.000000000","message":"ops. I forgot to remove it here.","commit_id":"2974430aceee7d4eb0356637dc1baf2a9a4fba56"}],"refstack/db/sqlalchemy/api.py":[{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"bfe52673ff83887886275cce9090a629f74fff55","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    with session.begin():"},{"line_number":353,"context_line":"        item.user_openid \u003d user_openid"},{"line_number":354,"context_line":"        item.group_id \u003d group_id"},{"line_number":355,"context_line":"        item.save(session\u003dsession)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def remove_user_from_group(user_openid, group_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_2d9fa2b5","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":8},"updated":"2016-01-21 18:16:39.000000000","message":"Should the created_by_user_openid also be updated in this method?","commit_id":"a2815b4fb0e900cee1786d73d6cfd8b405706c5b"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"d125c8001f2a90acad076292d07a84e469c6dba7","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    with session.begin():"},{"line_number":353,"context_line":"        item.user_openid \u003d user_openid"},{"line_number":354,"context_line":"        item.group_id \u003d group_id"},{"line_number":355,"context_line":"        item.save(session\u003dsession)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def remove_user_from_group(user_openid, group_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_80f9b582","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":8},"in_reply_to":"9a68dd71_2d9fa2b5","updated":"2016-01-21 18:41:39.000000000","message":"I think no :)\nthis method and this code (DB impl layer) doesn\u0027t know about context - it is the responsibility of BL.\nso such properties should be set outside of DB implementation - in our case it will be api controllers.","commit_id":"a2815b4fb0e900cee1786d73d6cfd8b405706c5b"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"a4590fe8f378ff9320c7fe4301556ab62b72c322","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    with session.begin():"},{"line_number":353,"context_line":"        item.user_openid \u003d user_openid"},{"line_number":354,"context_line":"        item.group_id \u003d group_id"},{"line_number":355,"context_line":"        item.save(session\u003dsession)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def remove_user_from_group(user_openid, group_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_03e938e6","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":8},"in_reply_to":"9a68dd71_5da38d4f","updated":"2016-01-22 06:20:56.000000000","message":"Yes, You are right. I\u0027ll add third parameter to this function.","commit_id":"a2815b4fb0e900cee1786d73d6cfd8b405706c5b"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"71b60a41675cfa825280a862f8c86847a25d01a5","unresolved":false,"context_lines":[{"line_number":352,"context_line":"    with session.begin():"},{"line_number":353,"context_line":"        item.user_openid \u003d user_openid"},{"line_number":354,"context_line":"        item.group_id \u003d group_id"},{"line_number":355,"context_line":"        item.save(session\u003dsession)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def remove_user_from_group(user_openid, group_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_5da38d4f","line":355,"range":{"start_line":355,"start_character":0,"end_line":355,"end_character":8},"in_reply_to":"9a68dd71_80f9b582","updated":"2016-01-22 05:37:37.000000000","message":"It is the responsibility of the BL to identify the value of the user_openid.  However,I think at this level we should still have a method to set the value in the created_by_user column.\n\nExample:\n\nadd_user_to_group(user_openid, group_id, created_by_user)\nor\nset_created_by_user(user_openid, group_id, created_by_user)\nor\nset_created_by_user(user_to_group_id, created_by_user)","commit_id":"a2815b4fb0e900cee1786d73d6cfd8b405706c5b"}]}