)]}'
{"refstack/api/controllers/user.py":[{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"b695f8e863e886962df759e30d9868bdae38c112","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_e18c4b81","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"updated":"2016-02-22 18:01:46.000000000","message":"We had discussed this in #refstack on Feb 19, 2016.  This name may be ambiguous. For someone not reading the code, do they know that is_admin is a flag for foundation_admin user checking?\n\nFor RefStack, does \"admin\" refer to supper users of the RefStack project?  Or \"admin\" means a user role that can perform CRUD operations in a certain scope?  For example, admin in a foundation group can perform CRUD for all organization entities.  Admin in a vendor group can perform CRUD on the vendor.  In the future, admin in a product group can perform CRUD on the product.\n\nSuggestion to either clearly document the intention of this flag or use a more intuitive name.","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"a12bc5292234ced2aad05abc50a1f0550e450a11","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_94b45b35","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"in_reply_to":"bae84128_178cf47d","updated":"2016-02-23 19:19:16.000000000","message":"Yea, the main point is that this admin is a foundation admin.  If we are going to rename, it should be something like is_foundation_admin.","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"43cee24547b3df9387ababc919f6926091dd2c07","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_178cf47d","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"in_reply_to":"bae84128_2b1f22b8","updated":"2016-02-23 07:29:38.000000000","message":"but \u0027super\u0027 is not much better that \u0027admin\u0027 because it doesn\u0027t mean \u0027foundation\u0027 (for which we are discussing as I understand)","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"},{"author":{"_account_id":9312,"name":"Alexandre Levine","email":"alexandrelevine@gmail.com","username":"alevine"},"change_message_id":"7f61c340a6cdfe5bf93f952113bd962856c0fa50","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_413829d3","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"in_reply_to":"bae84128_2b4ecdc0","updated":"2016-02-24 12:39:55.000000000","message":"Guys, it should be is_admin exactly because it is the one and only admin which has full access. There is no other \"admin\" with complete rights. If there was I\u0027d agree that we need to differentiate admin, foundation_admin and vendor_admin. But it\u0027s not so. We have only admin (i.e. foundation admin) and per-vendor admins.\nSo in order to have no ambiguity for us or any other code reader in the future, and in order to simplify code, I suggest we stick with \"admin\" and hence \"is_admin\".","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"},{"author":{"_account_id":8434,"name":"Rochelle Grober","email":"rochelle.grober@huawei.com","username":"rockyg"},"change_message_id":"76dba9c68bf01929d0993c49424c6c8ad70c7ca6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_9309b534","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"in_reply_to":"bae84128_413829d3","updated":"2016-02-26 02:18:01.000000000","message":"OK.  Just adding a little clarification.  is_admin is fine here because this is within the scope of the software, not the full server.  Ops folks control the machine and its services and utilities, the \"infrastructure\" if you will, but this flag is for admin within the refstack code.  That means the is_admin has been set within the scope of the code and not the machine (or vm or container) it runs on.  Does this make sense?  The check operation ensures that the flag is for admin users within Refstack, not the machine it is running on.","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"},{"author":{"_account_id":9377,"name":"Sergey Slipushenko","email":"slipushenko@gmail.com","username":"sslypushenko"},"change_message_id":"4303e5b5c07dc68cbf4f2bd26c214fb775f50417","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2b4ecdc0","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"in_reply_to":"bae84128_94b45b35","updated":"2016-02-23 21:00:16.000000000","message":"For me \u0027is_foundation_admin\u0027 sounds like the best option. If there is no any obstacles to use this naming - it will be good to use it. If there is any - I could live with \u0027is_admin\u0027 naming, just because we don\u0027t have any other type of admins for the time being. But no \u0027super\u0027, please)","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"d4ccaa57696e7452b3990bc15af16d0286d62bea","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \"openid\": user.openid,"},{"line_number":84,"context_line":"            \"email\": user.email,"},{"line_number":85,"context_line":"            \"fullname\": user.fullname,"},{"line_number":86,"context_line":"            \"is_admin\": api_utils.check_user_is_foundation_admin()"},{"line_number":87,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2b1f22b8","line":86,"range":{"start_line":86,"start_character":13,"end_line":86,"end_character":20},"in_reply_to":"bae84128_e18c4b81","updated":"2016-02-23 00:43:22.000000000","message":"Don\u0027t really mind the \"is_admin\" key name, but if we want it to merely denote that the user has superuser privileges, perhaps \u0027is_super\u0027 or even just \u0027super\u0027 would work better for you, Catherine?","commit_id":"745576fc53943d614d5874a7ecdf2ba5440e9eb3"}]}