)]}'
{"refstack/db/sqlalchemy/api.py":[{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"13f4c97d3da840f6bb90f7801596d3f6523d6b8c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    product \u003d models.Product()"},{"line_number":435,"context_line":"    product.type \u003d product_info[\u0027type\u0027]"},{"line_number":436,"context_line":"    product.product_type \u003d product_info[\u0027product_type\u0027]"},{"line_number":437,"context_line":"    product.product_id \u003d product_info[\u0027product_id\u0027]"},{"line_number":438,"context_line":"    product.name \u003d product_info[\u0027name\u0027]"},{"line_number":439,"context_line":"    product.description \u003d product_info.get(\u0027description\u0027)"},{"line_number":440,"context_line":"    product.organization_id \u003d product_info[\u0027organization_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_f9796e83","line":437,"range":{"start_line":437,"start_character":4,"end_line":437,"end_character":51},"updated":"2016-02-29 18:26:02.000000000","message":"Since product_id is set as nullable\u003dFalse in https://github.com/openstack/refstack/blob/master/refstack/db/sqlalchemy/models.py . And, the user is not required to provide this field because it is used to set a secondary ID such as hash of a cloud URI.  Should a default number be set here?","commit_id":"02af5a27d6c21f58b25608cc712d9c820886ee69"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"ef87c6038727829c7cccfceb0dbebab88bd6ef35","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    product \u003d models.Product()"},{"line_number":435,"context_line":"    product.type \u003d product_info[\u0027type\u0027]"},{"line_number":436,"context_line":"    product.product_type \u003d product_info[\u0027product_type\u0027]"},{"line_number":437,"context_line":"    product.product_id \u003d product_info[\u0027product_id\u0027]"},{"line_number":438,"context_line":"    product.name \u003d product_info[\u0027name\u0027]"},{"line_number":439,"context_line":"    product.description \u003d product_info.get(\u0027description\u0027)"},{"line_number":440,"context_line":"    product.organization_id \u003d product_info[\u0027organization_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_105a172a","line":437,"range":{"start_line":437,"start_character":4,"end_line":437,"end_character":51},"in_reply_to":"9aed3d3a_40297e36","updated":"2016-03-01 22:09:51.000000000","message":"Ok.  Since the default value can be set at the controller and not at the DB level.  Perhaps, it is better to update this value to be nullable in the future.","commit_id":"02af5a27d6c21f58b25608cc712d9c820886ee69"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"eded4f8078922728c12bc2b61635119463d24876","unresolved":false,"context_lines":[{"line_number":434,"context_line":"    product \u003d models.Product()"},{"line_number":435,"context_line":"    product.type \u003d product_info[\u0027type\u0027]"},{"line_number":436,"context_line":"    product.product_type \u003d product_info[\u0027product_type\u0027]"},{"line_number":437,"context_line":"    product.product_id \u003d product_info[\u0027product_id\u0027]"},{"line_number":438,"context_line":"    product.name \u003d product_info[\u0027name\u0027]"},{"line_number":439,"context_line":"    product.description \u003d product_info.get(\u0027description\u0027)"},{"line_number":440,"context_line":"    product.organization_id \u003d product_info[\u0027organization_id\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_40297e36","line":437,"range":{"start_line":437,"start_character":4,"end_line":437,"end_character":51},"in_reply_to":"9aed3d3a_f9796e83","updated":"2016-02-29 18:54:13.000000000","message":"I think that is better to define default value at business logic layer (in controller for us). Database layer doesn\u0027t know too much to define this field.","commit_id":"02af5a27d6c21f58b25608cc712d9c820886ee69"}]}