)]}'
{"refstack/api/controllers/products.py":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"4c2efbf2e4c09ed2676e3af78c04fa4251a317c5","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                result \u003d dict()"},{"line_number":162,"context_line":"                if \u0027organization_id\u0027 in filters:"},{"line_number":163,"context_line":"                    org_id \u003d filters[\u0027organization_id\u0027]"},{"line_number":164,"context_line":"                    if not api_utils.check_user_is_vendor_admin(org_id):"},{"line_number":165,"context_line":"                        filters[\u0027public\u0027] \u003d True"},{"line_number":166,"context_line":"                else:"},{"line_number":167,"context_line":"                    filters[\u0027public\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_3e5234de","line":164,"updated":"2016-11-22 09:38:21.000000000","message":"organization_id works here not as a filter. it works here as a permission.\nThis request will return wider list instead of filtering results.\n\nBut this is not needed here. Such behavior already implemented in \u0027get_products_by_user\u0027. This method will return all products that current user can see (filter by organization already implemented there)","commit_id":"1a0cbdd848965f0e8839658d4ed370c154c61b1b"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"11ad2a4f53fa1db5458f8067584214f8efe8bf0b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                result \u003d dict()"},{"line_number":162,"context_line":"                if \u0027organization_id\u0027 in filters:"},{"line_number":163,"context_line":"                    org_id \u003d filters[\u0027organization_id\u0027]"},{"line_number":164,"context_line":"                    if not api_utils.check_user_is_vendor_admin(org_id):"},{"line_number":165,"context_line":"                        filters[\u0027public\u0027] \u003d True"},{"line_number":166,"context_line":"                else:"},{"line_number":167,"context_line":"                    filters[\u0027public\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_e4c25184","line":164,"in_reply_to":"7a77a97e_3e5234de","updated":"2016-11-28 22:45:41.000000000","message":"Yea, you are right. Good catch. Removed all this.","commit_id":"1a0cbdd848965f0e8839658d4ed370c154c61b1b"}],"refstack/db/sqlalchemy/api.py":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"4c2efbf2e4c09ed2676e3af78c04fa4251a317c5","unresolved":false,"context_lines":[{"line_number":603,"context_line":""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"def get_products(allowed_keys\u003dNone, filters\u003dNone):"},{"line_number":606,"context_line":"    \"\"\"Get all products.\"\"\""},{"line_number":607,"context_line":"    if filters is None:"},{"line_number":608,"context_line":"        filters \u003d {}"},{"line_number":609,"context_line":"    session \u003d get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_a3af0b7c","line":606,"range":{"start_line":606,"start_character":11,"end_line":606,"end_character":14},"updated":"2016-11-22 09:38:21.000000000","message":"not \u0027all\u0027 now","commit_id":"1a0cbdd848965f0e8839658d4ed370c154c61b1b"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"4c2efbf2e4c09ed2676e3af78c04fa4251a317c5","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        filters \u003d {}"},{"line_number":609,"context_line":"    session \u003d get_session()"},{"line_number":610,"context_line":"    query \u003d session.query(models.Product)"},{"line_number":611,"context_line":"    if \u0027public\u0027 in filters:"},{"line_number":612,"context_line":"        query \u003d query.filter_by(public\u003dfilters[\u0027public\u0027])"},{"line_number":613,"context_line":"    if \u0027organization_id\u0027 in filters:"},{"line_number":614,"context_line":"        query \u003d query.filter_by(organization_id\u003dfilters[\u0027organization_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_434637c0","line":611,"range":{"start_line":611,"start_character":4,"end_line":611,"end_character":26},"updated":"2016-11-22 09:38:21.000000000","message":"what about -\n\nif filters.get(\u0027public\u0027) is not None:","commit_id":"1a0cbdd848965f0e8839658d4ed370c154c61b1b"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"4c2efbf2e4c09ed2676e3af78c04fa4251a317c5","unresolved":false,"context_lines":[{"line_number":612,"context_line":"        query \u003d query.filter_by(public\u003dfilters[\u0027public\u0027])"},{"line_number":613,"context_line":"    if \u0027organization_id\u0027 in filters:"},{"line_number":614,"context_line":"        query \u003d query.filter_by(organization_id\u003dfilters[\u0027organization_id\u0027])"},{"line_number":615,"context_line":"    items \u003d query.order_by(models.Product.created_at.desc()).all()"},{"line_number":616,"context_line":"    return _to_dict(items, allowed_keys\u003dallowed_keys)"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_23c4db3e","line":615,"updated":"2016-11-22 09:38:21.000000000","message":"maybe here should be an exception for unknown filters?","commit_id":"1a0cbdd848965f0e8839658d4ed370c154c61b1b"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"4c2efbf2e4c09ed2676e3af78c04fa4251a317c5","unresolved":false,"context_lines":[{"line_number":634,"context_line":"    if \u0027organization_id\u0027 in filters:"},{"line_number":635,"context_line":"        query \u003d query.filter(models.Product.organization_id \u003d\u003d"},{"line_number":636,"context_line":"                             filters[\u0027organization_id\u0027])"},{"line_number":637,"context_line":"    items \u003d query.order_by(models.Organization.created_at.desc()).all()"},{"line_number":638,"context_line":"    items \u003d [item[0] for item in items]"},{"line_number":639,"context_line":"    return _to_dict(items, allowed_keys\u003dallowed_keys)"},{"line_number":640,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_63b5f3ce","line":637,"updated":"2016-11-22 09:38:21.000000000","message":"maybe here should be an exception for unknown filters?","commit_id":"1a0cbdd848965f0e8839658d4ed370c154c61b1b"}]}