)]}'
{"refstack-ui/app/components/vendors/vendorController.js":[{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"dbc6cb5b5b9f97b99cdf907739d901979a7d6e66","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        function saveChanges() {"},{"line_number":295,"context_line":"            ctrl.showError \u003d false;"},{"line_number":296,"context_line":"            ctrl.showSuccess \u003d false;"},{"line_number":297,"context_line":"            var old_name \u003d ctrl.vendor.name;"},{"line_number":298,"context_line":"            var url \u003d [refstackApiUrl, \u0027/vendors/\u0027, ctrl.vendor.id].join(\u0027\u0027);"},{"line_number":299,"context_line":"            var properties \u003d propertiesToJson();"},{"line_number":300,"context_line":"            var content \u003d {\u0027name\u0027: ctrl.vendor.name,"}],"source_content_type":"text/javascript","patch_set":2,"id":"3a71b18c_cf5b2586","line":297,"range":{"start_line":297,"start_character":16,"end_line":297,"end_character":24},"updated":"2016-12-02 19:36:33.000000000","message":"This needs to be instantiated out of this function as by the time you get into this function ctrl.vendor.name has probably already changed.","commit_id":"7cf28d6bf287e78953ca4796daaf3f4bfedbb0a3"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"0a64d45d6bc7dcc131bcacf954a959697e989129","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        function saveChanges() {"},{"line_number":295,"context_line":"            ctrl.showError \u003d false;"},{"line_number":296,"context_line":"            ctrl.showSuccess \u003d false;"},{"line_number":297,"context_line":"            var old_name \u003d ctrl.vendor.name;"},{"line_number":298,"context_line":"            var url \u003d [refstackApiUrl, \u0027/vendors/\u0027, ctrl.vendor.id].join(\u0027\u0027);"},{"line_number":299,"context_line":"            var properties \u003d propertiesToJson();"},{"line_number":300,"context_line":"            var content \u003d {\u0027name\u0027: ctrl.vendor.name,"}],"source_content_type":"text/javascript","patch_set":2,"id":"3a71b18c_ca3f90d4","line":297,"range":{"start_line":297,"start_character":16,"end_line":297,"end_character":24},"in_reply_to":"3a71b18c_cf5b2586","updated":"2016-12-02 21:33:20.000000000","message":"Oops! You are right!  Thanks at lot!","commit_id":"7cf28d6bf287e78953ca4796daaf3f4bfedbb0a3"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"dbc6cb5b5b9f97b99cdf907739d901979a7d6e66","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            var content \u003d {\u0027name\u0027: ctrl.vendor.name,"},{"line_number":301,"context_line":"                           \u0027description\u0027: ctrl.vendor.description,"},{"line_number":302,"context_line":"                           \u0027properties\u0027: properties};"},{"line_number":303,"context_line":"            if (old_name \u003d\u003d ctrl.vendor.name) {"},{"line_number":304,"context_line":"                delete content.name;"},{"line_number":305,"context_line":"            }"},{"line_number":306,"context_line":"            $http.put(url, content).success(function() {"}],"source_content_type":"text/javascript","patch_set":2,"id":"3a71b18c_cfb7a584","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":47},"updated":"2016-12-02 19:36:33.000000000","message":"maybe remove the name key from the content dict above, then just add it if the old name does not equal the new name (instead of deleting it).","commit_id":"7cf28d6bf287e78953ca4796daaf3f4bfedbb0a3"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"0a64d45d6bc7dcc131bcacf954a959697e989129","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            var content \u003d {\u0027name\u0027: ctrl.vendor.name,"},{"line_number":301,"context_line":"                           \u0027description\u0027: ctrl.vendor.description,"},{"line_number":302,"context_line":"                           \u0027properties\u0027: properties};"},{"line_number":303,"context_line":"            if (old_name \u003d\u003d ctrl.vendor.name) {"},{"line_number":304,"context_line":"                delete content.name;"},{"line_number":305,"context_line":"            }"},{"line_number":306,"context_line":"            $http.put(url, content).success(function() {"}],"source_content_type":"text/javascript","patch_set":2,"id":"3a71b18c_ca16b054","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":47},"in_reply_to":"3a71b18c_cfb7a584","updated":"2016-12-02 21:33:20.000000000","message":"Thanks for your suggestion! I have made the change in the next patch.","commit_id":"7cf28d6bf287e78953ca4796daaf3f4bfedbb0a3"}],"refstack/api/controllers/vendors.py":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"f985ec2a371bc9cce93cbcc85ad21a6bc0404b96","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    not is_foundation_admin):"},{"line_number":128,"context_line":"                pecan.abort("},{"line_number":129,"context_line":"                    403, \u0027Name change for an official vendor is not allowed.\u0027)"},{"line_number":130,"context_line":"            else:"},{"line_number":131,"context_line":"                vendor_info[\u0027name\u0027] \u003d kw[\u0027name\u0027]"},{"line_number":132,"context_line":"        if \u0027description\u0027 in kw:"},{"line_number":133,"context_line":"            vendor_info[\u0027description\u0027] \u003d kw[\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_7457cbc9","line":130,"range":{"start_line":130,"start_character":12,"end_line":130,"end_character":17},"updated":"2016-12-06 18:37:54.000000000","message":"nit: \n\u0027else\u0027 is not needed.\nupper \u0027if\u0027 block will raise an exception in case of error and flow will not execute next commands","commit_id":"76876b880aa6f17149acd9b3cf68387e63ff934e"},{"author":{"_account_id":10526,"name":"Catherine Diep","email":"cdiep@us.ibm.com","username":"cdiep"},"change_message_id":"270aef0f928fa8f9b1cb6b57ba99aef44d5a6443","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    not is_foundation_admin):"},{"line_number":128,"context_line":"                pecan.abort("},{"line_number":129,"context_line":"                    403, \u0027Name change for an official vendor is not allowed.\u0027)"},{"line_number":130,"context_line":"            else:"},{"line_number":131,"context_line":"                vendor_info[\u0027name\u0027] \u003d kw[\u0027name\u0027]"},{"line_number":132,"context_line":"        if \u0027description\u0027 in kw:"},{"line_number":133,"context_line":"            vendor_info[\u0027description\u0027] \u003d kw[\u0027description\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_107a2088","line":130,"range":{"start_line":130,"start_character":12,"end_line":130,"end_character":17},"in_reply_to":"3a71b18c_7457cbc9","updated":"2016-12-06 19:23:05.000000000","message":"Done.  Thanks!","commit_id":"76876b880aa6f17149acd9b3cf68387e63ff934e"}]}