)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"957afdffe4867b7c8068f572daa0f9941b9473e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"82fc5a9c_4a42265a","updated":"2025-08-12 21:28:03.000000000","message":"One tiny thing I left a comment about, + the unneeded `import os`, otherwise this looks good, thank you a lot.\n\nI tried it out as I actually never used client authentication with Prometheus. Seems like the code in observabilityclient for set_client_cert https://opendev.org/openstack/python-observabilityclient/src/branch/master/observabilityclient/prometheus_client.py#L72 is wrong (I\u0027m not sure where that function came from and if it was ever tested, I\u0027m not the author).\n\nAccording to https://docs.python-requests.org/en/latest/api/#requests.Session.cert , there is no `key` parameter, only `cert`, which expects a `(cert, key)` pair. I\u0027ll submit a fix for the observabilityclient, but this looks good on the Aetos side.","commit_id":"708732a88f1c68e179348665d5873f039b692031"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1683b32664b70a07acafdf9531d4394d591d44a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fae9b56a_2ff5d2c8","updated":"2025-08-13 02:08:31.000000000","message":"recheck node failure","commit_id":"86c4ec1bc756ee8992ccc08d5b54bea0d9861369"}],"aetos/tests/unit/test_base_controller.py":[{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"957afdffe4867b7c8068f572daa0f9941b9473e7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            mock_client.assert_called_once_with(\u0027localhost:9090\u0027)"},{"line_number":55,"context_line":"            mock_client.return_value.set_ca_cert.assert_called_once_with("},{"line_number":56,"context_line":"                \u0027cafile\u0027)"},{"line_number":57,"context_line":"            mock_client.return_value.set_client_cert.assert_not_called()"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_create_prometheus_client_with_tls_default_ca(self):"},{"line_number":60,"context_line":"        \"\"\"Test prometheus client creation with TLS with default CA\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"aed409a2_f915a39b","line":57,"updated":"2025-08-12 21:28:03.000000000","message":"We don\u0027t open the file, so we don\u0027t need it to exist. Good find +1","commit_id":"708732a88f1c68e179348665d5873f039b692031"},{"author":{"_account_id":34975,"name":"Jaromír Wysoglad","email":"jwysogla@redhat.com","username":"jwysogla"},"change_message_id":"957afdffe4867b7c8068f572daa0f9941b9473e7","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    def test_create_prometheus_client_without_tls_with_cert_and_key(self):"},{"line_number":101,"context_line":"        \"\"\"Test prometheus client creation without TLS with cert/key file\"\"\""},{"line_number":102,"context_line":"        self.conf.set_override(\u0027cert_file\u0027, \u0027certfile\u0027, group\u003d\u0027prometheus\u0027)"},{"line_number":103,"context_line":"        self.conf.set_override(\u0027cert_file\u0027, \u0027keyfile\u0027, group\u003d\u0027prometheus\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        with mock.patch("},{"line_number":106,"context_line":"            \u0027observabilityclient.prometheus_client.PrometheusAPIClient\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"dda0bff3_a6cb9118","line":103,"updated":"2025-08-12 21:28:03.000000000","message":"```suggestion\n        self.conf.set_override(\u0027key_file\u0027, \u0027keyfile\u0027, group\u003d\u0027prometheus\u0027)\n```","commit_id":"708732a88f1c68e179348665d5873f039b692031"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a1e43eaeddcb8e4c9201478043c65d6f9c31abc0","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def test_create_prometheus_client_without_tls_with_cert_and_key(self):"},{"line_number":101,"context_line":"        \"\"\"Test prometheus client creation without TLS with cert/key file\"\"\""},{"line_number":102,"context_line":"        self.conf.set_override(\u0027cert_file\u0027, \u0027certfile\u0027, group\u003d\u0027prometheus\u0027)"},{"line_number":103,"context_line":"        self.conf.set_override(\u0027cert_file\u0027, \u0027keyfile\u0027, group\u003d\u0027prometheus\u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        with mock.patch("},{"line_number":106,"context_line":"            \u0027observabilityclient.prometheus_client.PrometheusAPIClient\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"183520f2_b4f02c76","line":103,"in_reply_to":"dda0bff3_a6cb9118","updated":"2025-08-13 01:05:38.000000000","message":"Done","commit_id":"708732a88f1c68e179348665d5873f039b692031"}]}