)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38496,"name":"Andressa Cabistani","display_name":"Andressa","email":"acabistani@gmail.com","username":"andressadotpy","status":"I\u0027m a Software Engineer at Red Hat and I love Open Source and connect with people! Feel free to DM through IRC, I\u0027ll be delighted to chat"},"change_message_id":"9ac41f1680549ad87e7988d07fe46806240894fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"363e8e53_88ba65d4","updated":"2026-07-07 14:36:27.000000000","message":"Hey, that\u0027s my first review here for this initiative. First of all thank you for all the effort! I plan on continuing to help with reviews the most I can, it\u0027s something I\u0027m very interested about.\n\nI tested this skill with 2 different prompts:\n\nPrompt 1:\n\u003e I want to design a skill for reviewing Swift replication patches (ssync, rsync). Help me design it - what Swift-specific knowledge does it need? What evals should cover? Should it check probe tests for replication scenarios?\n\nPrompt 2:\n\u003e Create a skill that helps review patches migrating Swift from eventlet to stdlib threading. The skill needs to check for eventlet.spawn replacements, non-blocking I/O patterns, and threading safety. Design the workflow and knowledge structure.\n\nSome interesting findings:\n\n- The skill-designer workflow skips all interactive checkpoints despite documentation stating it should pause for user input.\n\nFor both prompts skill-designer jumped directly from exploration to implementation, without asking \"should I proceed?\" after exploration or \"should I implement\" after design brief presentation.\n\nAnother thing I noticed is that it didn\u0027t explore my local skills for similar ones, and in both cases I had some local skills that would be helpful to write the new ones.\n\n- `Use assets/skill-brief-template.md when a structured artifact helps` makes it template usage optional so for both prompts that were template sections missing or for the first prompt, for example, using custom markdown structure instead of using template.\n\nBoth created skills demonstrate deep technical accuracy (ssync protocol, threading patterns), practical code examples and proper structure. I believe this one can get even better, that\u0027s why I\u0027m voting -1.","commit_id":"4fa51d5db0b5291e871315a236acff602c9f51be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"fe3432e1ddef4af1866c06678f810032cc89babc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8dcc2549_a1068ac8","in_reply_to":"363e8e53_88ba65d4","updated":"2026-07-07 15:15:08.000000000","message":"i belvie that is fixed in https://review.opendev.org/c/openstack/agentic-workflows/+/985902/2\n\ni probaly shoudl combine the two. reviews into one\n\nthis sued to be later in the serise but i brought it earlier\norgianlly i had the skill stub sill as the fist aptch and the designer in the later one and realise that really the skill stub should not be user facing.\n\nso i guess the current form does nto fully work as intended until later in the serisee.\n\nthis serise need to eb reworked in anycase so ill set -1 for nwo","commit_id":"4fa51d5db0b5291e871315a236acff602c9f51be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e7ca00423bf1c628fedbdba1063b2a8e940715dd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe3b0a05_cd3de8a2","in_reply_to":"8dcc2549_a1068ac8","updated":"2026-07-07 15:23:44.000000000","message":"and yes its intentioal that it shoudl shoudl not explore your local skills\nthe designer is intended for building skills in this repositry since we cannot assume that you have any other skills installed or that you are usign any specific tool we cant really depend on other skills in the envionemt if we want these to be freestanding.","commit_id":"4fa51d5db0b5291e871315a236acff602c9f51be"}],"AGENTS.md":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7b478fe317f5aefeef28b44b385b2589104e3bb9","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- Personas and shared rules live under `knowledge/personas/` and"},{"line_number":20,"context_line":"  `knowledge/rules/`."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"## Design Gotchas"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- Do not duplicate deterministic checks already enforced by linters, CI, or"},{"line_number":25,"context_line":"  validation scripts."}],"source_content_type":"text/x-markdown","patch_set":2,"id":"a00d4b18_6ecadcd7","line":22,"updated":"2026-04-21 07:16:29.000000000","message":"any reason why you just rephrase the whole \u0027Design Principles\u0027 section instead of slightling modifying the bullet list ? That\u0027s hard to review the differences.","commit_id":"4fa51d5db0b5291e871315a236acff602c9f51be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"35bcc0e145fa52e028b1d626c2d287d6501ae3f8","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- Personas and shared rules live under `knowledge/personas/` and"},{"line_number":20,"context_line":"  `knowledge/rules/`."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"## Design Gotchas"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"- Do not duplicate deterministic checks already enforced by linters, CI, or"},{"line_number":25,"context_line":"  validation scripts."}],"source_content_type":"text/x-markdown","patch_set":2,"id":"801c1fdd_ff93390a","line":22,"in_reply_to":"a00d4b18_6ecadcd7","updated":"2026-07-07 15:21:42.000000000","message":"honestly because i was in a rush to prepare this before the ptg and while i do think we might be better deleting all the content in the repo and starting form scratch i tried to preseve some fo the orginal contnet but didnt have time to  really do it cleanly.\n\nfor example  personas  files and rules proably shoudl not exist in this repo\nbut i didnt feel comfortabel jsut removeing all refence to them in this change\nbut i dont think that shoudl have been merged in the proir reviews without dicussion either.","commit_id":"4fa51d5db0b5291e871315a236acff602c9f51be"}],"knowledge/reference/repo-structure.md":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"316d9c48a32e6a1bfef700eaa9543d799e204af2","unresolved":true,"context_lines":[{"line_number":19,"context_line":"### `.claude-plugin/`"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Claude Code plugin and marketplace metadata. Use this to expose the same"},{"line_number":22,"context_line":"canonical assets through Claude Code\u0027s native plugin flow."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"### `knowledge/`"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-markdown","patch_set":2,"id":"c9f2d520_cc7e1d1c","line":22,"updated":"2026-04-21 07:18:52.000000000","message":"same concern than the other patch, if we go this route then we need to provide knobs as well for Cursor and Ambient Code Platform (and possibly other tools)","commit_id":"4fa51d5db0b5291e871315a236acff602c9f51be"}]}