)]}'
{"anchor/certificate_ops.py":[{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"fd547d03c8045d2d5910eadc1665353161b86120","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # TODO(hyakuhei): Consider adding dd some validation checks"},{"line_number":69,"context_line":"    # (though the config validator should have already done this)"},{"line_number":70,"context_line":"    function_name \u003d validator_step[0]"},{"line_number":71,"context_line":"    params \u003d validator_step[1]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # make sure the requested validator exists"},{"line_number":74,"context_line":"    if not hasattr(validators, function_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_6763f31a","line":71,"updated":"2015-03-04 19:49:57.000000000","message":"rather than deleting, I had swapped \u0027if type(tup) is not tuple:\u0027 for \u0027if type(tup) is not list:\u0027\n\nThat allows the test where you pass it a random object, not a config file, to pass. But may break other stuff.","commit_id":"21437504f1a687c3183294db397359787f92b11e"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"21131b0f3967d700b28774f3495f5c57800cb09b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    # TODO(hyakuhei): Consider adding dd some validation checks"},{"line_number":69,"context_line":"    # (though the config validator should have already done this)"},{"line_number":70,"context_line":"    function_name \u003d validator_step[0]"},{"line_number":71,"context_line":"    params \u003d validator_step[1]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # make sure the requested validator exists"},{"line_number":74,"context_line":"    if not hasattr(validators, function_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_098969eb","line":71,"in_reply_to":"9a80dd14_6763f31a","updated":"2015-03-04 19:55:19.000000000","message":"good idea!","commit_id":"21437504f1a687c3183294db397359787f92b11e"}],"config.json":[{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"fd547d03c8045d2d5910eadc1665353161b86120","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          \"common_name\","},{"line_number":49,"context_line":"          {"},{"line_number":50,"context_line":"            \"allowed_domains\": ["},{"line_number":51,"context_line":"              \".hp.com\""},{"line_number":52,"context_line":"            ]"},{"line_number":53,"context_line":"          }"},{"line_number":54,"context_line":"        ],"}],"source_content_type":"application/json","patch_set":2,"id":"9a80dd14_c7881fea","line":51,"updated":"2015-03-04 19:49:57.000000000","message":"Why change back to HP? I thought we were trying to de-brand this in the upstream?","commit_id":"21437504f1a687c3183294db397359787f92b11e"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"21131b0f3967d700b28774f3495f5c57800cb09b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"          \"common_name\","},{"line_number":49,"context_line":"          {"},{"line_number":50,"context_line":"            \"allowed_domains\": ["},{"line_number":51,"context_line":"              \".hp.com\""},{"line_number":52,"context_line":"            ]"},{"line_number":53,"context_line":"          }"},{"line_number":54,"context_line":"        ],"}],"source_content_type":"application/json","patch_set":2,"id":"9a80dd14_c99af113","line":51,"in_reply_to":"9a80dd14_c7881fea","updated":"2015-03-04 19:55:19.000000000","message":"I agree that I don\u0027t particularly want the branding.\n\nThe reason I did this was because I needed something in allowed_domains that would get checked against a CSR appropriately. Really this was more for the allowed_network checks that come after.\n\nI\u0027m not sure how to guarentee the network that \u0027example.com\u0027 will resolve to.","commit_id":"21437504f1a687c3183294db397359787f92b11e"}]}