)]}'
{"anchor/app.py":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"993b5f9d15bc213034b19eeae540f24233ee3d64","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            raise ConfigValidationException(\"Validator set \u003c%s\u003e is missing \""},{"line_number":54,"context_line":"                                            \"validation steps\", name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        for step in validators_list[\"steps\"]:"},{"line_number":57,"context_line":"            if len(step) \u003d\u003d 0:"},{"line_number":58,"context_line":"                raise ConfigValidationException(\"Validator set \u003c%s\u003e contains \""},{"line_number":59,"context_line":"                                                \"a step with no validator \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_98a6610f","line":56,"updated":"2015-03-05 10:48:50.000000000","message":"Should we assert that where we once had a Tuple we now have a list composed like this:\n[ \u003cstring\u003e, \u003cdictionary\u003e ] ?","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"}],"anchor/certificate_ops.py":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"993b5f9d15bc213034b19eeae540f24233ee3d64","unresolved":false,"context_lines":[{"line_number":67,"context_line":"       :param args: additional arguments to pass to the validator function"},{"line_number":68,"context_line":"       :return: True on success, else False"},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    function_name \u003d validator_step[0]"},{"line_number":71,"context_line":"    params \u003d validator_step[1]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # make sure the requested validator exists"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_b8396543","line":70,"updated":"2015-03-05 10:48:50.000000000","message":"This will break if the config.json file has a bad set of validators. That\u0027s ok if our validate config functions are up to scratch","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"12e3242b6fa41da0d00792e974ff574ff5c04bd2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"       :param args: additional arguments to pass to the validator function"},{"line_number":68,"context_line":"       :return: True on success, else False"},{"line_number":69,"context_line":"    \"\"\""},{"line_number":70,"context_line":"    function_name \u003d validator_step[0]"},{"line_number":71,"context_line":"    params \u003d validator_step[1]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    # make sure the requested validator exists"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_382bb595","line":70,"in_reply_to":"9a80dd14_b8396543","updated":"2015-03-05 10:55:57.000000000","message":"true, but validating the validators are sane should be done before we ever get this far.","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"993b5f9d15bc213034b19eeae540f24233ee3d64","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    # NOTE(tkelsey): im not so sure we want to pass all this lot through"},{"line_number":106,"context_line":"    # to the validator, seems like far more than we should need. Also, the"},{"line_number":107,"context_line":"    # config block breaks when passed through as key word args."},{"line_number":108,"context_line":"    #"},{"line_number":109,"context_line":"    args \u003d {\u0027auth_result\u0027: auth_result,"},{"line_number":110,"context_line":"            \u0027csr\u0027: csr,"},{"line_number":111,"context_line":"            # \u0027conf\u0027: jsonloader.conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_d8c45994","line":108,"updated":"2015-03-05 10:48:50.000000000","message":"Some validators may want to know about the REST request etc. I\u0027d rather pass more information than have to refactor and add more later ? - is there a performance impact doing that?","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"1d2c19dc92b3014885292490ef968c7d31373701","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    # NOTE(tkelsey): im not so sure we want to pass all this lot through"},{"line_number":106,"context_line":"    # to the validator, seems like far more than we should need. Also, the"},{"line_number":107,"context_line":"    # config block breaks when passed through as key word args."},{"line_number":108,"context_line":"    #"},{"line_number":109,"context_line":"    args \u003d {\u0027auth_result\u0027: auth_result,"},{"line_number":110,"context_line":"            \u0027csr\u0027: csr,"},{"line_number":111,"context_line":"            # \u0027conf\u0027: jsonloader.conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c35c6ef0","line":108,"in_reply_to":"9a80dd14_0364c6e3","updated":"2015-03-05 11:01:33.000000000","message":"That could make for some horrible bugs I agree, but auth_result is a great example of something that is currently required by validators. (It contains the AD groups a user belongs to)","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"12e3242b6fa41da0d00792e974ff574ff5c04bd2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    # NOTE(tkelsey): im not so sure we want to pass all this lot through"},{"line_number":106,"context_line":"    # to the validator, seems like far more than we should need. Also, the"},{"line_number":107,"context_line":"    # config block breaks when passed through as key word args."},{"line_number":108,"context_line":"    #"},{"line_number":109,"context_line":"    args \u003d {\u0027auth_result\u0027: auth_result,"},{"line_number":110,"context_line":"            \u0027csr\u0027: csr,"},{"line_number":111,"context_line":"            # \u0027conf\u0027: jsonloader.conf,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_0364c6e3","line":108,"in_reply_to":"9a80dd14_d8c45994","updated":"2015-03-05 10:55:57.000000000","message":"I guess, also performance really isn\u0027t a consideration here (though i don\u0027t think there is much of an impact really). The thing I don\u0027t like here is how potentially fragile this is, for example, what happens when I shadow auth_result or similar with a param from my validator arg set.","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"993b5f9d15bc213034b19eeae540f24233ee3d64","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    #"},{"line_number":109,"context_line":"    args \u003d {\u0027auth_result\u0027: auth_result,"},{"line_number":110,"context_line":"            \u0027csr\u0027: csr,"},{"line_number":111,"context_line":"            # \u0027conf\u0027: jsonloader.conf,"},{"line_number":112,"context_line":"            \u0027request\u0027: request}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # It is ok if the config doesn\u0027t have any validators listed"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_f86d9d9a","line":111,"updated":"2015-03-05 10:48:50.000000000","message":"Hmm, so we should either delete this or talk about it more, I don\u0027t want to merge in commented out lines of code...","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"12e3242b6fa41da0d00792e974ff574ff5c04bd2","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    #"},{"line_number":109,"context_line":"    args \u003d {\u0027auth_result\u0027: auth_result,"},{"line_number":110,"context_line":"            \u0027csr\u0027: csr,"},{"line_number":111,"context_line":"            # \u0027conf\u0027: jsonloader.conf,"},{"line_number":112,"context_line":"            \u0027request\u0027: request}"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    # It is ok if the config doesn\u0027t have any validators listed"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a80dd14_c3a9cee0","line":111,"in_reply_to":"9a80dd14_f86d9d9a","updated":"2015-03-05 10:55:57.000000000","message":"Actually, I think this may be a mistake on my part. Im looking more into it","commit_id":"8c26630d3d37e6bf95568aa0b2328f1beb0e0388"}]}
