)]}'
{"tests/validators/test_callable_validators.py":[{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"eb1405a85342e4ea3dcee351b4a1bbc1ff59b4c0","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                [\u0027dummy_value\u0027, \u0027dummy_value\u0027],"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"        csr_mock \u003d mock.MagicMock(**csr_config)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.assertRaises("},{"line_number":80,"context_line":"            validators.ValidationError,"},{"line_number":81,"context_line":"            validators.common_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_8bd36838","line":78,"updated":"2015-03-30 17:07:10.000000000","message":"Suggest checking that this raises the exception you expect, to make sure you are failing on the test that you intend to, rather than another exception. For example, change to something like:\n\nself.assertRaisesRegexp(\n  validators.ValidationError,\n  \"Too many CNs in the request\",\n  validators.common_name,\n  csr\u003dcsr_mock,\n  allowed_domains\u003d[ ],\n  allowed_networks\u003d[ ],\n)\n\nHowever on re-reading the function that this is attempting to exercise (I assume this test should fail if it has more than one CN?) I am not convinced the logic in the function is correct – it only verifys the number of CN’s if alternate names  are present. I don’t know if its possible to have multiple CN’s in a CSR without alt names..","commit_id":"9adcf784556833f2ac3754ed6c401a384c0db6f0"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"efc446fcbfe6ba8421b9de0a3182db08d93c9296","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                [\u0027dummy_value\u0027, \u0027dummy_value\u0027],"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"        csr_mock \u003d mock.MagicMock(**csr_config)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.assertRaises("},{"line_number":80,"context_line":"            validators.ValidationError,"},{"line_number":81,"context_line":"            validators.common_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_275911ff","line":78,"in_reply_to":"da9b358b_053f2dd7","updated":"2015-03-31 10:10:52.000000000","message":"Doug, I agree we should verify the exceptions as you say, I\u0027ll look into it.\n\nRob, yeah we will need to take a look at these validators once we do that refactor.","commit_id":"9adcf784556833f2ac3754ed6c401a384c0db6f0"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"2ba2f85f4ec94004d460fc9420a22702d9c06d40","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                [\u0027dummy_value\u0027, \u0027dummy_value\u0027],"},{"line_number":76,"context_line":"        }"},{"line_number":77,"context_line":"        csr_mock \u003d mock.MagicMock(**csr_config)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.assertRaises("},{"line_number":80,"context_line":"            validators.ValidationError,"},{"line_number":81,"context_line":"            validators.common_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9b358b_053f2dd7","line":78,"in_reply_to":"da9b358b_8bd36838","updated":"2015-03-31 07:42:15.000000000","message":"Regarding the exception we expect, I\u0027m not sure what you mean? We\u0027re already catching a specific (this didn\u0027t validate) exception. \n\nIt\u0027s not easy to create a CSR like that, but you could do so with an ASN.1 builder and use openssl to create the signing digest. At the moment Anchor works by signing the actual CSR. Architecturally we want to move to extracting fields we want and signing those in a new certificate, some of these checks can go away then.","commit_id":"9adcf784556833f2ac3754ed6c401a384c0db6f0"}]}
