)]}'
{"anchor/validators.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"25117e3d010824c4f202347c4cb08b33e442339c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def check_domains(domain, allowed_domains):"},{"line_number":34,"context_line":"    if len(allowed_domains):"},{"line_number":35,"context_line":"        if not any(domain.endswith(suffix) for suffix in allowed_domains):"},{"line_number":36,"context_line":"            # no domain matched"},{"line_number":37,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_da3ee0b7","line":34,"updated":"2015-04-07 12:15:24.000000000","message":"why not use:\n\n    if allowed_domains:\n         ...\n\nmore pythonic this way","commit_id":"4940a5a0a4dc5c8eb168e1431b2d188c678297e4"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"a797eeaa02d7b54a791fe12d983b7ba29e6d5ddc","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def check_domains(domain, allowed_domains):"},{"line_number":34,"context_line":"    if len(allowed_domains):"},{"line_number":35,"context_line":"        if not any(domain.endswith(suffix) for suffix in allowed_domains):"},{"line_number":36,"context_line":"            # no domain matched"},{"line_number":37,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa53dc9_4e6d7203","line":34,"in_reply_to":"9aa53dc9_da3ee0b7","updated":"2015-04-07 12:41:28.000000000","message":"Done","commit_id":"4940a5a0a4dc5c8eb168e1431b2d188c678297e4"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"f2924620c9c11e005bda580d9f64e03ead28deef","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return False"},{"line_number":38,"context_line":"    else:"},{"line_number":39,"context_line":"        # no valid domains were provided, so we can\u0027t make any assertions"},{"line_number":40,"context_line":"        logger.warning(\"No valid domains were given, skipping\")"},{"line_number":41,"context_line":"    return True"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_7055b04e","line":40,"updated":"2015-04-07 13:34:06.000000000","message":"Can this be more elaborate?\n\n\"No domains were configured for validation. Anchor will issue certificates for any domain, this is not a recommended configuration for production environments\" ?\n\nMaybe?","commit_id":"c5af5cfa294c6f90d881f8a82c6b41a6287466c6"}]}