)]}'
{"anchor/certificate_ops.py":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"497930c2666fbbcfaa33820082da873f98c50dbf","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    except Exception as e:"},{"line_number":118,"context_line":"        # TODO(tkelsey): harden this up, we may want to squelch errors"},{"line_number":119,"context_line":"        logger.error(\"Error running validator \u003c%s\u003e - %s\", vname, e)"},{"line_number":120,"context_line":"        pecan.abort(500, \"Internal Validation Error: {} running validator \""},{"line_number":121,"context_line":"                         \"\u0027{}\u0027 in set \u0027{}\u0027\".format(str(e), vname, name))"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_f37d67e8","line":119,"updated":"2015-04-27 16:56:51.000000000","message":"The Exception could also be from the jsonloader barfing up, not just the validator\u0027s flagging issues...","commit_id":"3eb4b673880bc9718efc8b15b71be3ecb544780e"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"ff5ee4e4263fabe5ba3dfa90bc4127b3ffb6c6c7","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    except Exception as e:"},{"line_number":118,"context_line":"        # TODO(tkelsey): harden this up, we may want to squelch errors"},{"line_number":119,"context_line":"        logger.error(\"Error running validator \u003c%s\u003e - %s\", vname, e)"},{"line_number":120,"context_line":"        pecan.abort(500, \"Internal Validation Error: {} running validator \""},{"line_number":121,"context_line":"                         \"\u0027{}\u0027 in set \u0027{}\u0027\".format(str(e), vname, name))"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ad32947_f367a723","line":119,"in_reply_to":"7ad32947_f37d67e8","updated":"2015-04-27 16:59:54.000000000","message":"while that is technically possible, we do validate the config in jsonloader during start up, so it should be clean at this point","commit_id":"3eb4b673880bc9718efc8b15b71be3ecb544780e"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"03fb59847b87b5f0bd5069f4f6a7816d066883ab","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    try:"},{"line_number":110,"context_line":"        for name, vset in jsonloader.conf.validators.iteritems():"},{"line_number":111,"context_line":"            logger.debug(\"validate_csr: checking with set {}\".format(name))"},{"line_number":112,"context_line":"            for vname, validator in vset.iteritems():"},{"line_number":113,"context_line":"                valid \u003d _run_validator(vname, validator, args)"},{"line_number":114,"context_line":"                if not valid:"},{"line_number":115,"context_line":"                    break  # early out at the first error"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_46353bf5","line":112,"updated":"2015-05-01 11:17:20.000000000","message":"You could reduce this to:\n\n    valid \u003d all(_run_validator(vname, validator, args) for vname, validator in vset.iteritems())","commit_id":"89d178dd3221caaf754324852cbe2e286488ee14"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"bef1025ba55d310fd180802df7f41f94158ef05a","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    except Exception as e:"},{"line_number":118,"context_line":"        # TODO(tkelsey): harden this up, we may want to squelch errors"},{"line_number":119,"context_line":"        logger.error(\"Error running validator \u003c%s\u003e - %s\", vname, e)"},{"line_number":120,"context_line":"        pecan.abort(500, \"Internal Validation Error: {} running validator \""},{"line_number":121,"context_line":"                         \"\u0027{}\u0027 in set \u0027{}\u0027\".format(str(e), vname, name))"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_183e4728","line":119,"updated":"2015-05-29 02:11:12.000000000","message":"Can we make this logger.exception() instead? It will print out the whole stacktrace with lines and everything. This is useful in case the whole error is \"method \u0027get\u0027 not found in NoneType\"","commit_id":"ded1656ecb60dfc0a8b760c28c6d37222cd042a7"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"00505fd7cc0f6783cfee03e7a9f9077e1db1786f","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    except Exception as e:"},{"line_number":118,"context_line":"        # TODO(tkelsey): harden this up, we may want to squelch errors"},{"line_number":119,"context_line":"        logger.error(\"Error running validator \u003c%s\u003e - %s\", vname, e)"},{"line_number":120,"context_line":"        pecan.abort(500, \"Internal Validation Error: {} running validator \""},{"line_number":121,"context_line":"                         \"\u0027{}\u0027 in set \u0027{}\u0027\".format(str(e), vname, name))"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_e648282f","line":119,"in_reply_to":"7a016987_183e4728","updated":"2015-06-01 10:50:56.000000000","message":"good point, thanks","commit_id":"ded1656ecb60dfc0a8b760c28c6d37222cd042a7"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"bef1025ba55d310fd180802df7f41f94158ef05a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # TODO(tkelsey): harden this up, we may want to squelch errors"},{"line_number":119,"context_line":"        logger.error(\"Error running validator \u003c%s\u003e - %s\", vname, e)"},{"line_number":120,"context_line":"        pecan.abort(500, \"Internal Validation Error: {} running validator \""},{"line_number":121,"context_line":"                         \"\u0027{}\u0027 in set \u0027{}\u0027\".format(str(e), vname, name))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # something failed, return a 400 to the client"},{"line_number":124,"context_line":"    if not valid:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_f8e24b9f","line":121,"updated":"2015-05-29 02:11:12.000000000","message":"I don\u0027t think the user should see the any detailed error really. The name of the failing validator is probably fine, but what if an Exception includes some clues about private keys when serializing something?\n\nEC2 keys authentication had a similar kind of problem before: https://bugs.launchpad.net/nova/+bug/868360 / cve 2011-4076","commit_id":"ded1656ecb60dfc0a8b760c28c6d37222cd042a7"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"00505fd7cc0f6783cfee03e7a9f9077e1db1786f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        # TODO(tkelsey): harden this up, we may want to squelch errors"},{"line_number":119,"context_line":"        logger.error(\"Error running validator \u003c%s\u003e - %s\", vname, e)"},{"line_number":120,"context_line":"        pecan.abort(500, \"Internal Validation Error: {} running validator \""},{"line_number":121,"context_line":"                         \"\u0027{}\u0027 in set \u0027{}\u0027\".format(str(e), vname, name))"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # something failed, return a 400 to the client"},{"line_number":124,"context_line":"    if not valid:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_2642c00f","line":121,"in_reply_to":"7a016987_f8e24b9f","updated":"2015-06-01 10:50:56.000000000","message":"yeah, I did think about that when creating the change, hence my TODO. I will change the behaviour since we are in agreement. Thanks Stan","commit_id":"ded1656ecb60dfc0a8b760c28c6d37222cd042a7"}]}