)]}'
{"anchor/validators.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"d8891cc58cdec689108f600cac8646bdad687fa1","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            raise ValidationError(\"Domain \u0027%s\u0027 not allowed \""},{"line_number":185,"context_line":"                                  \"(CN blacklisted)\" % cn)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    for _, name in iter_alternative_names(csr, [\u0027DNS\u0027],"},{"line_number":188,"context_line":"                                          fail_other_types\u003dFalse):"},{"line_number":189,"context_line":"        if check_domains(name, blacklist_domains):"},{"line_number":190,"context_line":"            raise ValidationError(\"Domain \u0027%s\u0027 not allowed \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_af7c95b5","line":187,"updated":"2015-06-04 10:24:41.000000000","message":"Shouldn\u0027t this include IP as well? If not how would you blacklist an IP address?","commit_id":"c2dd4d6958ab256723eb24d55b2fc6be0ac7c540"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"dab3543dc8e81451cd75617b2c3f6c40fe1f3f89","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            raise ValidationError(\"Domain \u0027%s\u0027 not allowed \""},{"line_number":185,"context_line":"                                  \"(CN blacklisted)\" % cn)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    for _, name in iter_alternative_names(csr, [\u0027DNS\u0027],"},{"line_number":188,"context_line":"                                          fail_other_types\u003dFalse):"},{"line_number":189,"context_line":"        if check_domains(name, blacklist_domains):"},{"line_number":190,"context_line":"            raise ValidationError(\"Domain \u0027%s\u0027 not allowed \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5afe65bd_81808dc1","line":187,"in_reply_to":"5afe65bd_af7c95b5","updated":"2015-06-04 11:39:26.000000000","message":"Doug\u0027s use case was for blocking *.com. IP may be useful... we\u0027ll have to check it based on ipaddr range rather than name though. I think it should be a separate validator really. But in that case, this needs to be renamed to blacklist_names, or something....\n\nI\u0027ll change the name for now.","commit_id":"c2dd4d6958ab256723eb24d55b2fc6be0ac7c540"}],"tests/validators/test_callable_validators.py":[{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"bb5c6ec14d4f28c2f283b037c4cf896329d068ff","unresolved":false,"context_lines":[{"line_number":705,"context_line":"        csr_mock \u003d mock.MagicMock()"},{"line_number":706,"context_line":"        csr_mock.get_extensions.return_value \u003d [ext1_mock, ext2_mock]"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":"        with self.assertRaises(validators.ValidationError):"},{"line_number":709,"context_line":"            validators.blacklist_names("},{"line_number":710,"context_line":"                csr\u003dcsr_mock,"},{"line_number":711,"context_line":"                domains\u003d[\u0027.bad\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_afce4181","line":708,"updated":"2015-06-22 12:29:50.000000000","message":"This looks like it just checks that a ValidationError was raised, not the specific case you were testing for. Applies to the two tests above too.","commit_id":"1444e5b10b2a437c3fad6c0e3a97e2ab98c870da"}]}
