)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"3b315547f27b3108d73de82f3be0757914ab94e4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Anchor instance. For example multiple teams can configure separate"},{"line_number":16,"context_line":"source ips allowed to apply for separate hostnames."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes bug: 1463748"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id5f811c6d46bc47ddcc1f751ef8e4e7ffd1254fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3afb71cf_3040c833","line":18,"updated":"2015-06-10 11:00:51.000000000","message":"nit: s/Closes Bug/Closes-Bug/","commit_id":"a2272f3ef0ecc550113d5a1cc4a89b3ffceef711"}],"anchor/certificate_ops.py":[{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"3b315547f27b3108d73de82f3be0757914ab94e4","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    # It is ok if the config doesn\u0027t have any validators listed"},{"line_number":106,"context_line":"    if len(jsonloader.conf.validators) \u003d\u003d 0:"},{"line_number":107,"context_line":"        logger.debug(\"validate_csr: no validator sets - accepting all\")"},{"line_number":108,"context_line":"        return"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3afb71cf_901f7c5a","line":107,"updated":"2015-06-10 11:00:51.000000000","message":"This should be a warning, we don\u0027t expect this to a be a valid use case for Anchor.","commit_id":"a2272f3ef0ecc550113d5a1cc4a89b3ffceef711"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"a853713b0cfb71f31f7d5223b33b4565c37503cd","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    try:"},{"line_number":111,"context_line":"        for name, vset in jsonloader.conf.validators.iteritems():"},{"line_number":112,"context_line":"            logger.debug(\"validate_csr: checking with set {}\".format(name))"},{"line_number":113,"context_line":"            valid \u003d True"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            for vname, validator in vset.iteritems():"},{"line_number":116,"context_line":"                valid \u003d _run_validator(vname, validator, args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_39008201","line":113,"updated":"2015-06-11 10:50:46.000000000","message":"If vset is empty we should also have a warning?","commit_id":"37fa6f6d0dc60186f383317fa86f9147aed2eff4"},{"author":{"_account_id":11650,"name":"Tom Cammann","email":"tom.cammann@hpe.com","username":"cammann"},"change_message_id":"8fa50d25c1bcf10f24f66ece3491b88d8df43ad8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    try:"},{"line_number":111,"context_line":"        for name, vset in jsonloader.conf.validators.iteritems():"},{"line_number":112,"context_line":"            logger.debug(\"validate_csr: checking with set {}\".format(name))"},{"line_number":113,"context_line":"            valid \u003d True"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            for vname, validator in vset.iteritems():"},{"line_number":116,"context_line":"                valid \u003d _run_validator(vname, validator, args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af86dd1_efdc3f48","line":113,"in_reply_to":"1af86dd1_ac5b022e","updated":"2015-06-12 11:12:46.000000000","message":"Yeah that is a better plan. Move the warnings to the validation of the config, keep this function to a single responsibility which is running the validators.","commit_id":"37fa6f6d0dc60186f383317fa86f9147aed2eff4"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"33f057f8fcc2bf6c574b31e76f909b19c5890476","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    try:"},{"line_number":111,"context_line":"        for name, vset in jsonloader.conf.validators.iteritems():"},{"line_number":112,"context_line":"            logger.debug(\"validate_csr: checking with set {}\".format(name))"},{"line_number":113,"context_line":"            valid \u003d True"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            for vname, validator in vset.iteritems():"},{"line_number":116,"context_line":"                valid \u003d _run_validator(vname, validator, args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_b893f44e","line":113,"in_reply_to":"1af86dd1_efdc3f48","updated":"2015-06-22 09:35:09.000000000","message":"+1","commit_id":"37fa6f6d0dc60186f383317fa86f9147aed2eff4"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"7a2bb979a68b821eca5337b385f0ab332670bd22","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    try:"},{"line_number":111,"context_line":"        for name, vset in jsonloader.conf.validators.iteritems():"},{"line_number":112,"context_line":"            logger.debug(\"validate_csr: checking with set {}\".format(name))"},{"line_number":113,"context_line":"            valid \u003d True"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"            for vname, validator in vset.iteritems():"},{"line_number":116,"context_line":"                valid \u003d _run_validator(vname, validator, args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af86dd1_ac5b022e","line":113,"in_reply_to":"3afb71cf_39008201","updated":"2015-06-12 01:54:42.000000000","message":"I wonder if it actually belongs here. We already have a config validation step - should it go there instead? It makes sense to warn the user on startup (maybe even error then?), but if they do want to run this way then spamming the log is not helpful. What do you think?","commit_id":"37fa6f6d0dc60186f383317fa86f9147aed2eff4"}]}