)]}'
{"anchor/X509/certificate.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"d218465bb2ece7b5c7c4cf62b692aa2657c298f0","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def as_pem(self):"},{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if ret \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_4645ed14","line":110,"updated":"2015-07-01 09:04:44.000000000","message":"please use ffi gc stuff, eg\nbio \u003d self._ffi.gc(bio, self._lib.BIO_free)\ninstead of explicit \"self._lib.BIO_free(bio)\" destructor, its more robust.","commit_id":"d131d881705f0873eb161e33b6381369f0987425"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"469a2ce6437473852ee439011d3655f805316700","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def as_pem(self):"},{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_7b53aa39","line":110,"updated":"2015-07-02 11:15:58.000000000","message":"Shouldn\u0027t BIO_s_secmem be used and/or set to read only?","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"7bf86c5f4f0a6bf38b54c17f49d79a358993b414","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def as_pem(self):"},{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_e6d13d24","line":110,"in_reply_to":"ba3cc151_46434913","updated":"2015-07-02 23:50:27.000000000","message":"You are quite right, I miss-thought this was secret handling.","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5753b8fc292d71ac613680245452407163bdab05","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def as_pem(self):"},{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_d40c03ee","line":110,"in_reply_to":"ba3cc151_7b53aa39","updated":"2015-07-02 11:38:20.000000000","message":"good idea, we are unfortunately limited to those methods that are exposed by pyca/cryptography, I dont think  BIO_s_secmem has been exposed yet (though I could be wrong)","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"63bfd96a237e29de59f51db790c27fb825f23c3d","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def as_pem(self):"},{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_46434913","line":110,"in_reply_to":"ba3cc151_d40c03ee","updated":"2015-07-02 23:47:37.000000000","message":"Is there a reason to use secmem here? Typically it\u0027s a separate heap for private data like keys. Here, we\u0027re saving a public certificate. (maybe confidential, but \"public\" in ssl security sense)\n\nIt\u0027s not set readonly, since we need to write to it.","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"469a2ce6437473852ee439011d3655f805316700","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if ret \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_de574458","line":111,"updated":"2015-07-02 11:15:58.000000000","message":"Why free it youself?  Can\u0027t we just BIO_free(mem) / BIO_CLOSE flag ?","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"63bfd96a237e29de59f51db790c27fb825f23c3d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if ret \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_662f6d3f","line":111,"in_reply_to":"ba3cc151_34652fb4","updated":"2015-07-02 23:47:37.000000000","message":"What Tim said regarding BIO_free(). As for the buffer itself, BIO_CLOSE is the default for memory bio (bss_mem.c/mem_new() sets shutdown\u003d1)","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":979,"name":"Dave Walker","email":"email@daviey.com","username":"davewalker"},"change_message_id":"7bf86c5f4f0a6bf38b54c17f49d79a358993b414","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if ret \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_a6c7b562","line":111,"in_reply_to":"ba3cc151_662f6d3f","updated":"2015-07-02 23:50:27.000000000","message":"Ah, Good catch","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"5753b8fc292d71ac613680245452407163bdab05","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \"\"\"Serialise this X509 certificate object as PEM string.\"\"\""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        raw_bio \u003d self._lib.BIO_new(self._lib.BIO_s_mem())"},{"line_number":111,"context_line":"        bio \u003d self._ffi.gc(raw_bio, self._lib.BIO_free)"},{"line_number":112,"context_line":"        ret \u003d self._lib.PEM_write_bio_X509(bio, self._certObj)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        if ret \u003d\u003d 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba3cc151_34652fb4","line":111,"in_reply_to":"ba3cc151_de574458","updated":"2015-07-02 11:38:20.000000000","message":"this isn\u0027t actually freeing anything, it sets up the FFI mechanisms to call the correct function (self._lib.BIO_free) when Python garbage collects the bio object. This is better than explicitly freeing the BIO object ourselves as we can never leak it in the event of an exception being thrown, for example.","commit_id":"4e3ba4eee27ae41ead3816174e82b48fe00db7f7"}]}
